From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64FD743E92; Wed, 17 Apr 2024 15:46:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E815B402AE; Wed, 17 Apr 2024 15:46:17 +0200 (CEST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mails.dpdk.org (Postfix) with ESMTP id CB2DE4003C for ; Wed, 17 Apr 2024 15:46:14 +0200 (CEST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56e1bbdb362so6313621a12.1 for ; Wed, 17 Apr 2024 06:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1713361574; x=1713966374; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/RxDa6KeluSOM0bI0PWaCKPJtnMna3G0DUxQsDDS2Lc=; b=cbH6lbD6laHKjo5zgNpxgXF9z3btR9itznaDg4xbyGyCdVZMliOvjbHSYpWoSddCpz 5eNMGArkCXBrVvKsLTDn/0NP9PKv30Dh7nBKox9ncwLmdAsV/9B2piCnx2QfifNaAG5V X2nF8i4HznZBIBm++A7qWRuHFAZIh7t6oz2RQjGDc67gWAEP37aZZ+NZzB6W5b4L2r+r dZgw5rLePEXXirP5WvxfNGBTmn1mOmui08rV9126IApCiCBCFRzksohgQ2RUA4HHrDzX Ir+QglPGLAlyFMD3mXjK0kZ+BayFCH9/2y4R+2majr7suveVuN9SC4EUjQghb+H2pbqn elcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713361574; x=1713966374; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RxDa6KeluSOM0bI0PWaCKPJtnMna3G0DUxQsDDS2Lc=; b=ji/ktNToeuJEc48F8WahpSG741B1ysk2cMOz5YjG6xBr351fnhY5pboGRRtOpE/wJ3 3xYC6Ts5sys6i69q5vOOqeXAXqhRCD45eCcGmpWTnjwBu3Sid6Ly2lRYiadhCNcjHVj8 Wmk5rpdc3MuXm2HVGWRi8DO17CvoR5GfUCEQyLhdfveOqcySHM7UfZEQTHxakkaJrlIt OXJleslqcT98g9dybleKzbOH7t0Oq1R04s7QMnzGX0rNUdVKfB7iNkykg8a3ZXFCq9TQ W+eMkOAF05gl2T/MaIOTP1V4kHNY2X7esLP0bXtp4IGSSvG0wD2/Fi/CIKfo+S8FXcrS yVTQ== X-Forwarded-Encrypted: i=1; AJvYcCWZJ79cXzx5KMbI/IQ25VT1s8ozWjox/gZsG7GR4nsWebr1L03vc4//K6xs5xrhYcIBbRoUM4tuKM/3NzM= X-Gm-Message-State: AOJu0YzX1zFBwW5sUz4fmpPyDr87GncKaRG6F2mgpC39vYiFjifkBUYH sFX+c5hwxCzpk57FBRFSTJK/QIE7IyssXMlPeenPSH6vfRCLveILiwIwBK7EvUZs3kO0/VIgO3N ajCvJYUeEj0Lm9Bhm7KWR2HbUggJa4qRVZsuLtw== X-Google-Smtp-Source: AGHT+IHTUOcX0f1BL4yBmZaMA19m4A7SaS3h4LpAqkWWWX9jWx/JlkzaA9CqMrJl8qhap3oh+vDe6W1uN5j/J0NrP+k= X-Received: by 2002:a17:906:a05a:b0:a55:5620:6734 with SMTP id bg26-20020a170906a05a00b00a5556206734mr1351832ejb.65.1713361574605; Wed, 17 Apr 2024 06:46:14 -0700 (PDT) MIME-Version: 1.0 References: <20240404153106.19047-1-npratte@iol.unh.edu> <20240416181840.11539-1-npratte@iol.unh.edu> In-Reply-To: <20240416181840.11539-1-npratte@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 17 Apr 2024 15:46:03 +0200 Message-ID: Subject: Re: [PATCH v3] dts: Change hugepage runtime config to 2MB Exclusively To: Nicholas Pratte Cc: paul.szczepanek@arm.com, wathsala.vithanage@arm.com, bruce.richardson@intel.com, yoan.picchi@foss.arm.com, mb@smartsharesystems.com, jspewock@iol.unh.edu, Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Don't forget to run the ../devtools/dts-check-format.sh script, it found one issue: framework/testbed_model/os_session.py:351: [D] D417 Missing argument descriptions in the docstring [pydocstyle] On Tue, Apr 16, 2024 at 8:18=E2=80=AFPM Nicholas Pratte wrote: > > The previous implementation configures and allocates hugepage sizes > based on a system default. This can lead to two problems: overallocation = of > hugepages (which may crash the remote host), and configuration of hugepag= e > sizes that are not recommended during runtime. This new implementation > allows only 2MB hugepage allocation during runtime; any other unique > hugepage size must be configured by the end-user for initializing DTS. > > If the amount of 2MB hugepages requested exceeds the amount of 2MB > hugepages already configured on the system, then the system will remount > hugepages to cover the difference. If the amount of hugepages requested i= s > either less than or equal to the amount already configured on the system, > then nothing is done. > > Bugzilla ID: 1370 > Signed-off-by: Nicholas Pratte > Reviewed-by: Jeremy Spewock > --- > doc/guides/tools/dts.rst | 7 +++++- > dts/conf.yaml | 4 ++-- > dts/framework/config/__init__.py | 4 ++-- > dts/framework/config/conf_yaml_schema.json | 6 ++--- > dts/framework/config/types.py | 2 +- > dts/framework/testbed_model/linux_session.py | 24 +++++++++++--------- > dts/framework/testbed_model/node.py | 8 ++++++- > dts/framework/testbed_model/os_session.py | 4 +++- > 8 files changed, 37 insertions(+), 22 deletions(-) > > diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst > index 47b218b2c6..1103db0faa 100644 > --- a/doc/guides/tools/dts.rst > +++ b/doc/guides/tools/dts.rst > @@ -131,7 +131,12 @@ There are two areas that need to be set up on a Syst= em Under Test: > > You may specify the optional hugepage configuration in the DTS conf= ig file. > If you do, DTS will take care of configuring hugepages, > - overwriting your current SUT hugepage configuration. > + overwriting your current SUT hugepage configuration. Configuration = of hugepages via DTS > + allows only for configuration of 2MB hugepages. I'd like to see a quick explanation of why we only do 2MB hugepages, like you mentioned in the commit message. > Thus, if your needs require hugepage > + sizes not equal to 2MB, then you these configurations must be done = outside of the DTS typo - you is extra. And I think this should be configuration singular - this configuration must be done. > + framework; moreover, if you do not desire the use of 2MB hugepages,= and instead perfer prefer > + other sizes (e.g 1GB), then we assume that hugepages have been manu= ally configued before configured > + runtime. Looks like the two sentences (separated by semicolon) are saying the same t= hing. > > * System under test configuration >