From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B442C4289A; Tue, 4 Apr 2023 13:51:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 413E340EF0; Tue, 4 Apr 2023 13:51:50 +0200 (CEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id 5136340A7E for ; Tue, 4 Apr 2023 13:51:48 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id eh3so129384252edb.11 for ; Tue, 04 Apr 2023 04:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20210112.gappssmtp.com; s=20210112; t=1680609108; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/wBOSAifFNdB1nUukCahe8E7vyzLp72Q1MgLq9rNN98=; b=fqIrA3YGYqGQHU39nyGnHLn81HWf/s7j+aCsgLA/dwFyjrwP+k/s5ViOJ7W13/0z9U LDT+ij9S9FnOOwHukUFN20fAGsJXfsdf3Lww6TruRgNup7OP7N1ucK3/X5P6F4yYZQHU irMv5zvYiQbI/Ted46mhfU/L0bhOURJQyQB9BLup8A8Haels9GzBMMMpmEEzhUi2ez3u TvtCuavg7oqdsZN1TIxUnTjjVCgIrHUQB7pJx4I9WANv7TsbFFCJvBPp5jloQyMCMmhQ 1F5bYMFUP0KegZE/eWGBr0vS3nQj2I3Tp8WI7ha4wy5qi95SSEmn0RO2f5t2YubC9in7 EjuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680609108; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/wBOSAifFNdB1nUukCahe8E7vyzLp72Q1MgLq9rNN98=; b=UhMs1ut7LpxmQDgGcfVieIhZOGP5SUTyl0y82wA9rBPijz703gmBqdt70qnfNtfNVN /rASMelOwmBm4uSkg1CcL3D6YZG2XXrYXafUhuta4eEdfmd8Qitn/uqprhvXe1plr7/g z/r0blxh27wt2MxU3SDMoSbD1TUq6+lV32ugXITS25uywVF6OpDYRBfxYxzEznRAE5hy fbBtBQpCNte2M3FEQGVPKnjRXkE5DZzrLevRvtrhY+p0M3DcwwHyKxV541Hmh7i3L13v 4fHscmmygQVPtjY6LKmF4BSXaIlITbkYB7zHBrLF7YbMHKfsyXrS3pBJc3j8mkM9ViqU X0eg== X-Gm-Message-State: AAQBX9ejUcVD27fvKPKDyMoDTTjRiZKwwurEbBJWE61CK9R+hUFnx9Zn rBh7mx8sGrws+9nYuVWXKbtKvhuGFdjx9xf4uec6wg== X-Google-Smtp-Source: AKy350YYPb/FT43ClbpPTMVYpQ4YSZGzjIusUFMxKilqU/RCDclLp67Mqt+cL/rZwQzPyNZitUc8j39lNwoRP46Lnto= X-Received: by 2002:a17:907:7e8e:b0:93e:186f:ea0d with SMTP id qb14-20020a1709077e8e00b0093e186fea0dmr1039662ejc.15.1680609108107; Tue, 04 Apr 2023 04:51:48 -0700 (PDT) MIME-Version: 1.0 References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5831673.1BCLMh4Saa@thomas> <7872319.mogB4TqSGs@thomas> In-Reply-To: <7872319.mogB4TqSGs@thomas> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Tue, 4 Apr 2023 13:51:36 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] dts: fabric requirements To: Thomas Monjalon Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000e53fe205f8814c8e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000e53fe205f8814c8e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon wrote: > 03/04/2023 16:56, Juraj Linke=C5=A1: > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon > wrote: > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > Replace pexpect with Fabric. > > > > > > You should squash these lines with the move to Fabric. > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > --- > > > > dts/poetry.lock | 553 > +++++++++++++++++++++++++++++++++++++++------ > > > > > > Do we really need *all* these lines? > > > I see a lot of lines about Windows and MacOSX which are not supported > in > > > DTS. > > > It is so long that it looks impossible to review. > > > > > > > > This is a generated file and doesn't need to be reviewed. > > In general, I don't like storing generated files. > Me neither, but this one is specifically designed to be stored in a repository: https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-= version-control > > > I separated the > > dependencies part so that the code part is easier to review. If you > want, I > > can squash the two commits. > > What happens if we manually remove the useless lines? > > The lock file is there so that everyone installs exactly the same versions of dependencies. We can specify the versions of dependencies in pyproject.toml, but we won't control the versions of dependencies of dependencies this way. If we remove the changes to the lock file, then we won't be storing tested versions, everyone would be using slightly different versions and we may potentially need to address versioning issues in the future - best to prevent that with a lock file. --000000000000e53fe205f8814c8e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Apr 3, 2023 at 5:18=E2=80=AFP= M Thomas Monjalon <thomas@monjalo= n.net> wrote:
03/04/2023 16:56, Juraj Linke=C5=A1:
> On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon <thomas@monjalon.net> w= rote:
>
> > 03/04/2023 13:46, Juraj Linke=C5=A1:
> > > Replace pexpect with Fabric.
> >
> > You should squash these lines with the move to Fabric.
> >
> > > Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.t= ech>
> > > ---
> > >=C2=A0 dts/poetry.lock=C2=A0 =C2=A0 | 553 +++++++++++++++++++= ++++++++++++++++++++------
> >
> > Do we really need *all* these lines?
> > I see a lot of lines about Windows and MacOSX which are not suppo= rted in
> > DTS.
> > It is so long that it looks impossible to review.
> >
> >
> This is a generated file and doesn't need to be reviewed.

In general, I don't like storing generated files.
=
Me neither, but this one is specifically designed to be stor= ed in a repository:=20 https://python-poetry.org/docs/basic-usage/#com= mit-your-poetrylock-file-to-version-control
=C2=A0

> I separated the
> dependencies part so that the code part is easier to review. If you wa= nt, I
> can squash the two commits.

What happens if we manually remove the useless lines?


The lock file is there so that everyone installs exactly the same = versions of dependencies. We can specify the versions of dependencies in py= project.toml, but we won't control the versions of dependencies of depe= ndencies this way. If we remove the changes to the lock file, then we won&#= 39;t be storing tested versions, everyone would be using slightly different= versions and we may potentially need to address versioning issues in the f= uture - best to prevent that with a lock file.
=C2=A0 <= br>
--000000000000e53fe205f8814c8e--