From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A510A43F44; Mon, 29 Apr 2024 09:46:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 294DC402A3; Mon, 29 Apr 2024 09:46:09 +0200 (CEST) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mails.dpdk.org (Postfix) with ESMTP id D70824025C for ; Mon, 29 Apr 2024 09:46:07 +0200 (CEST) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a5544fd07easo536989166b.0 for ; Mon, 29 Apr 2024 00:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1714376766; x=1714981566; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8q+3PYVBvuvNWtNpXpvf1EJNEbUVfzjVYf84Hw9zG9Y=; b=rcLoG08cWGyYZo70YS24zyefr5k5MOJyaeHWNYYXnw+2C7iqX1lk6MPk6IKvTu57gg daNw66plYZyuPs573KwyBY6ob6rYutuZChodMyMx7RjiTc9/HzMsBF7u4UqGj6NRM6Mc 5GupOfuuvqB00Uq9iV/ChA8+tZHN41e2GIatvRYbyHF6cbzwJSgzy2TPCmp6QQ0Fmrep E53yYjuW8OcZHQpJprbEegNJokTOXxtVpuU74kQuUGCbh0QV6VYZlKdjH77NaOoyyjkc X42f5MQz/dbqzGybkkm2B2vqmSq+uoEF1Xljqxu6DqXYz0Ozmqz0rbvcoP0vzJNTn+iO qWSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714376766; x=1714981566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8q+3PYVBvuvNWtNpXpvf1EJNEbUVfzjVYf84Hw9zG9Y=; b=YVZY/ebZ9rslrlm2bYykteLTHvFmKF7dlPT8xEqoeKAOuPjB50Y/aPpgnsixbUShJr U/Wkdh0v8OGIMZkaFPdjtmqp8HpVlBXJennsdiiP3Cgn+Iv8XmZ36I5+GveSz0En/5ZV ht3SBtSVcbl+iaAX9dbaXcaDaWGyaETJbYOwAPCj/SDyVpu4XQednqZDpgbPe8IL85eI cMkJ7oyPqS+aTOWtHFR1FyaMQ67GPusT/jHKfzSd/Jv6ZKGt1vXImQ5YSqAnlUO+Zh5D xw7qGQbvOKWjcRfKud7R/IVU6sqyOmUlfa/aZ3DL1vMQu8VIDuJQWHhJfcewalObytYL N+SA== X-Forwarded-Encrypted: i=1; AJvYcCUb8hwwd6C17teQ3zFPZJHakKSd7VsMZx1LQjBzFtNcUFTC2TLC9JZdZc2Dq2dplsBh5UcFGuTOP+DtmuU= X-Gm-Message-State: AOJu0YyTR2pmKPYD3j90YAaXnLzBtQU82cnVSJT1dI7RMX0yKeQYCBjL jHWT0kivzXlosD0CYQLY3qdfiyGVPeGiYSqP02ZvccSt6/Wrf3Zh0/sG3TNiYi8RmAwZgLuy8mg dZtCT35I4tEcHxe5C0TIiGurPohjsV7IDxhOFhQ== X-Google-Smtp-Source: AGHT+IGVEHOwBIiGIvP3Pg7lXTNcufZhsXaFc3NxRNHPWNvQk3lV4EZQrG/FwtFP1PikbiGBwiMohMeW3A0jW8A4aU4= X-Received: by 2002:a17:906:b016:b0:a58:ee10:ad05 with SMTP id v22-20020a170906b01600b00a58ee10ad05mr2679744ejy.69.1714376766540; Mon, 29 Apr 2024 00:46:06 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-5-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 29 Apr 2024 09:45:55 +0200 Message-ID: Subject: Re: [PATCH 4/6] dts: use testpmd params for scatter test suite To: Jeremy Spewock Cc: Luca Vizzarro , dev@dpdk.org, Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 26, 2024 at 8:06=E2=80=AFPM Jeremy Spewock wrote: > > On Wed, Apr 10, 2024 at 9:19=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > > > On Wed, Apr 10, 2024 at 12:53=E2=80=AFPM Luca Vizzarro wrote: > > > > > > On 09/04/2024 20:12, Juraj Linke=C5=A1 wrote: > > > >> @@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: int) -> None: > > > >> """ > > > >> testpmd =3D self.sut_node.create_interactive_shell( > > > >> TestPmdShell, > > > >> - app_parameters=3DStrParams( > > > >> - "--mbcache=3D200 " > > > >> - f"--mbuf-size=3D{mbsize} " > > > >> - "--max-pkt-len=3D9000 " > > > >> - "--port-topology=3Dpaired " > > > >> - "--tx-offloads=3D0x00008000" > > > >> + app_parameters=3DTestPmdParameters( > > > >> + forward_mode=3DTestPmdForwardingModes.mac, > > > >> + mbcache=3D200, > > > >> + mbuf_size=3D[mbsize], > > > >> + max_pkt_len=3D9000, > > > >> + tx_offloads=3D0x00008000, > > > >> ), > > > >> privileged=3DTrue, > > > >> ) > > > >> - testpmd.set_forward_mode(TestPmdForwardingModes.mac) > > > > > > > > Jeremy, does this change the test? Instead of configuring the fw mo= de > > > > after starting testpmd, we're starting testpmd with fw mode > > > > configured. > > To my knowledge, as Luca mentions below, this does not functionally > change anything about the test, scatter should just need the MAC > forwarding mode to be set at some point before forwarding starts, it > doesn't technically matter when. One thing to note that this does > change, however, is that we lose the verification step that the method > within testpmd provides. I'm not sure off the top of my head if > testpmd just completely fails to start if the forwarding mode flag is > set and it fails to change modes or if it still starts and then just > goes back to default (io) which would make the test operate in an > invalid state without anyway of knowing. > > As another note however, I've never seen a mode change fail and I > don't know what could even make it fail, so this would be a rare thing > anyway, but still just something to consider. > Ok, thanks. This is fine then. If we see a problem with this when testpmd starts we can just raise a bug against testpmd (as it should either start with mac forwarding or error). > > > > > > > I am not Jeremy (please Jeremy still reply), but we discussed this on > > > Slack. Reading through the testpmd source code, setting arguments lik= e > > > forward-mode in the command line, is the exact equivalent of calling > > > `set forward mode` right after start-up. So it is equivalent in theor= y. > > > > > > > If not, we should remove the testpmd.set_forward_mode method, as it= 's > > > > not used anymore. > > > > > > Could there be test cases that change the forward mode multiple times= in > > > the same shell, though? As this could still be needed to cover this. > > > > Yes, but we don't have such a test now. It's good practice to remove > > unused code. We can still bring it back anytime, it'll be in git > > history.