From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEE9CA0508; Tue, 26 Apr 2022 16:30:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF454427F9; Tue, 26 Apr 2022 16:30:53 +0200 (CEST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id D52F8406A2 for ; Tue, 26 Apr 2022 16:30:52 +0200 (CEST) Received: by mail-io1-f41.google.com with SMTP id c125so20038919iof.9 for ; Tue, 26 Apr 2022 07:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4cOc8iZBlLf4CAVwRZprsrlQjeAkKWvO058mUm1nrWA=; b=UnGV/5k1ZdXXpHmuR6CLx+ekPBQTKEQmYDFoy02d/jY5CIicnQv/Zxuccx6VDrNyfw PTr2X2WiT9XLCCx0R5UnNVkVvLQnf54C+rp4QJEN/yaejCC7bIL7JW7T1gulUg+8kkPD n6ouF9gOKJehsMNp0VNApZEiXnUhIzbXsWYiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4cOc8iZBlLf4CAVwRZprsrlQjeAkKWvO058mUm1nrWA=; b=qjnkILjFuKg/xcNIk4J9zS0rV2FOAN9F83TKQqer1592w+eDX0qYk98GxVtop1P8os qY91vfgSYpCK05NMoYhu2z2Tus4FxHpLPkOJu2X0tT03goB49W2DFD6h8Eb43+sGUlIL 2oTsImr9Zk0fsLFqmy6Q1EDOqIQw0AqJnhO/eOzSl0C/Dn9HJ2rqwQ6p6y6km7psmPW9 xOa67ii/jGOHfvMRkpdvv40U0StcGkw/WY06/FIf6IgixJdchS2vvnO1J61EV+jrQlch flQOcMeSARbhgajzInVpOS57+WqcS8JAo2UXX5AAITluwLGVkiuxWdjjCbW32jX/yaDr zmBg== X-Gm-Message-State: AOAM5313vhCLCpkSGBXut1MQA5iiI5jrFLH3Bn06q5O0h+SnfdvAWN/N DxfCrZ+JOtvaoHDfeEpuJ6pKrUdli6IaQuQ40J0A8g== X-Google-Smtp-Source: ABdhPJzZQprYK6alTM1l2kDNCpG0i3Xw6f0iHsk9A/UdyvK/ULSN/osITPwZ+CSscqlCc0Uk98ZbGcAa10bDzJdVOP8= X-Received: by 2002:a05:6e02:1a62:b0:2cc:5634:763e with SMTP id w2-20020a056e021a6200b002cc5634763emr9054232ilv.68.1650983452111; Tue, 26 Apr 2022 07:30:52 -0700 (PDT) MIME-Version: 1.0 References: <20220129170313.489986-1-blo@iol.unh.edu> <20220129175514.746925-1-blo@iol.unh.edu> In-Reply-To: From: Brandon Lo Date: Tue, 26 Apr 2022 10:30:16 -0400 Message-ID: Subject: Re: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips validation To: Gowrishankar Muthukrishnan Cc: dev , "Zhang, Roy Fan" , "Power, Ciara" , Anoob Joseph Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gowrishankar, I apologize for the late response. I have not worked on the AES-CBC implementation, so you are free to go ahead. Please let me know if you run into any issues that I can help with. Thanks, Brandon On Thu, Apr 21, 2022 at 4:02 AM Gowrishankar Muthukrishnan wrote: > > Hi Brandon, > Following some cleanup patches I have posted against examples/fips, I would like to take enabling AES_CBC in fips validation. > Please let me know if you/anyone have already have WIP for the same, before I proceed. > > Thanks, > Gowrishankar > > > -----Original Message----- > > From: Brandon Lo > > Sent: Thursday, April 14, 2022 7:12 PM > > To: dev ; Zhang, Roy Fan ; > > Power, Ciara > > Subject: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips > > validation > > > > External Email > > > > ---------------------------------------------------------------------- > > Adding the dev mailing list back into this discussion. > > > > On Wed, Apr 13, 2022 at 9:13 AM Brandon Lo wrote: > > > > > > Hi guys, > > > > > > Lincoln and I would like to know if we can get this patch set looked > > > at and merged before submitting the rest of the algorithms. So far, > > > I've worked on implementing the HMAC and CMAC tests, but I keep > > > getting pulled away by some requests from the community. This patchset > > > does not seem to break backward compatibility, so merging it will only > > > lead to more coverage from the UNH lab. It may also be easier to > > > review since it isn't going to be one huge patchset that needs to be > > > looked at in the future. > > > > > > On Thu, Feb 17, 2022 at 7:47 AM Brandon Lo wrote: > > > > > > > > On Fri, Feb 11, 2022 at 9:16 AM Brandon Lo wrote: > > > > > I only have the AES-GCM algorithm implemented because the current > > > > > implementations of the other algorithms require some extra > > > > > information than what comes with the JSON format in the API. > > > > > For example, I couldn't find the JSON counterpart for things like > > > > > fips_validation_sha.c's "MD =" or "Seed =" as well as > > > > > fips_validation_ccm.c's extra test types like CCM-DVPT, CCM-VADT, > > etc. > > > > > just to name a few. > > > > > This could very well be due to my inexperience with the FIPS > > > > > validation, and I definitely plan to take another look at it again. > > > > > > > > > > My assumption is that the JSON version of FIPS validation files > > > > > isn't used as much as the old CAVP format, so I am more aiming > > > > > towards getting something working in the lab first and then > > > > > expanding on it later. > > > > > > > > Hi all, > > > > > > > > Could I get someone to look at this patch set? > > > > The UNH lab is ready to deploy FIPS testing on patches that affect > > > > the crypto portion of DPDK. > > > > > > > > Thanks, > > > > Brandon > > > > > > > > > > > > -- > > > > Brandon Lo > > > > UNH InterOperability Laboratory > > > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu > > > > https://urldefense.proofpoint.com/v2/url?u=http- > > 3A__www.iol.unh.edu& > > > > d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr- > > g7yUFhtOio8r2Rtm13Aqe4WVp_S > > > > > > _gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMs > > cV7HXyJ > > > > > > 95BftFMJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e= > > > > > > > > > > > > -- > > > Brandon Lo > > > UNH InterOperability Laboratory > > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu > > > https://urldefense.proofpoint.com/v2/url?u=http- > > 3A__www.iol.unh.edu&d= > > > DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr- > > g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHp > > > > > cu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMscV7H > > XyJ95BftF > > > MJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e= > > > > > > > > -- > > Brandon Lo > > UNH InterOperability Laboratory > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu > > https://urldefense.proofpoint.com/v2/url?u=http- > > 3A__www.iol.unh.edu&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr- > > g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmG > > LgWSAhIknbuvLgguNAXKjN0xCMscV7HXyJ95BftFMJJJ&s=GVCZy3E9sE9H23T > > SCEcLyQoT4zxNQ4pyameEW76PZno&e= -- Brandon Lo UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu www.iol.unh.edu