From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC880A0C48; Tue, 6 Jul 2021 18:10:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5765C4128B; Tue, 6 Jul 2021 18:10:15 +0200 (CEST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by mails.dpdk.org (Postfix) with ESMTP id 875DB4120E for ; Tue, 6 Jul 2021 18:10:13 +0200 (CEST) Received: by mail-il1-f174.google.com with SMTP id j12so10375851ils.5 for ; Tue, 06 Jul 2021 09:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tokY/7BhKQz+jv/g+sub5bhm52xc5DEDrgZMirvXDoM=; b=IdmnkXLc5ZB7wzQEA3XqZAc5pnbmT3VQGAY6RnnZToSmlurOlUsClzCeqRexdnpjsr uUYtUK3TbXDuZWQiMwI7BzLbHAw28G0PjM2osGKSFNwfEJsLKPgBDBLaX5l1Do1jnaJ3 kgrnnYOGJEiv69FzZifKhhWtyxIG9QpUQBauA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tokY/7BhKQz+jv/g+sub5bhm52xc5DEDrgZMirvXDoM=; b=J9GMqn+a8KJUcp+90OqPxozGSD3uGONVLYT3jK04uaFDy55HWRuBfHj3o8ddYP/w70 tOJkYMVsWDcyRR71BMUfzrI6mwUxH6zVzWTDkuSjfVYh2bqQebidPd1l/yk45ZYcSk6H j7midITT7ZWD54OslgPJE/T+ZzhQ+TN+UUuVEg1W8yuS8t5VUklFUOJdded1Udcy9NMJ aM8/xho+2qk09p/JXK/vq/JZzFJ6mX2aM/kFhcdNrJ3cArUYcA6d90onuCfQ85Mgtp9j ZbGbZZOgCRQNODvewYvrGxyB1TjqgFD+4XkB9vKgQjtf4FIGZxwok8dRbECsGjBF95vI O6+A== X-Gm-Message-State: AOAM533Ri61xO75snGwn+qn8rFf8IZ4NodEosR1w+b7cRrXbfCI8vTBM KeH/OlsCr0yOVzUNW9rNX9UlkFyl8aeFShcnrxM4AA== X-Google-Smtp-Source: ABdhPJz29XPK1FK1Eo33bkqUEDjfj3uP5rUl4K6D5kd9aZWaQmbMsokH9ORV4Hw05saaOhY4jNGx/dLm3Ca4uiZNpvU= X-Received: by 2002:a92:c6ca:: with SMTP id v10mr14271108ilm.78.1625587810528; Tue, 06 Jul 2021 09:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> In-Reply-To: From: Brandon Lo Date: Tue, 6 Jul 2021 12:09:34 -0400 Message-ID: To: "Gujjar, Abhinandan S" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "jerinj@marvell.com" , "dpdklab@iol.unh.edu" , "aconole@redhat.com" , "gakhil@marvell.com" , "Power, Ciara" , Ali Alnubani Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi all, I have rerun the failing unit test. It also recreated the report, so that category should be passing now. Currently, I am looking more into the ABI test that is failing on Arch, as well as the failures with DTS tests. I will keep this thread updated. Thanks, Brandon On Mon, Jul 5, 2021 at 2:30 AM Gujjar, Abhinandan S wrote: > > Hi Jerin/Akhil, > > Could you please review the patch? > > Regards > Abhinandan > > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Saturday, July 3, 2021 4:56 AM > > To: Gujjar, Abhinandan S ; dev@dpdk.org; > > jerinj@marvell.com; dpdklab@iol.unh.edu; aconole@redhat.com > > Cc: gakhil@marvell.com; Power, Ciara ; Ali Alnubani > > > > Subject: Re: [PATCH] test: fix crypto_op length for sessionless case > > > > On 7/2/2021 7:08 PM, Gujjar, Abhinandan S wrote: > > > Hi Aaron/dpdklab, > > > > > > This patch's CI seems to have lot of false positive! > > > Ferruh triggered the re-test sometime back. Now, it is reporting less. > > > Could you please check from your end? Thanks! > > > > > > > Only a malloc related unit test is still failing, which seems unrelated with the > > patch. I am triggering it one more time, third time lucky. > > > > Also after re-run, some tests passing now still shown as fail in the patchwork > > checks table. Isn't re-run sending the patchwork test status again? > > > > > Regards > > > Abhinandan > > > > > > > > >> -----Original Message----- > > >> From: Gujjar, Abhinandan S > > >> Sent: Wednesday, June 30, 2021 6:17 PM > > >> To: dev@dpdk.org; jerinj@marvell.com > > >> Cc: gakhil@marvell.com; Gujjar, Abhinandan S > > >> ; Power, Ciara > > >> Subject: [PATCH] test: fix crypto_op length for sessionless case > > >> > > >> Currently, private_data_offset for the sessionless is computed > > >> wrongly which includes extra bytes added because of using > > >> sizeof(struct > > >> rte_crypto_sym_xform) * 2) instead of (sizeof(union > > >> rte_event_crypto_metadata)). Due to this buffer overflow, the > > >> corruption was leading to test application crash while freeing the ops > > mempool. > > >> > > >> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") > > >> Reported-by: ciara.power@intel.com > > >> > > >> Signed-off-by: Abhinandan Gujjar > > >> --- > > >> app/test/test_event_crypto_adapter.c | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/app/test/test_event_crypto_adapter.c > > >> b/app/test/test_event_crypto_adapter.c > > >> index f689bc1f2..688ac0b2f 100644 > > >> --- a/app/test/test_event_crypto_adapter.c > > >> +++ b/app/test/test_event_crypto_adapter.c > > >> @@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less) > > >> first_xform = &cipher_xform; > > >> sym_op->xform = first_xform; > > >> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH + > > >> - (sizeof(struct rte_crypto_sym_xform) * 2); > > >> + (sizeof(union > > >> + rte_event_crypto_metadata)); > > >> op->private_data_offset = len; > > >> /* Fill in private data information */ > > >> rte_memcpy(&m_data.response_info, &response_info, @@ - > > >> 424,7 +424,7 @@ test_op_new_mode(uint8_t session_less) > > >> first_xform = &cipher_xform; > > >> sym_op->xform = first_xform; > > >> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH + > > >> - (sizeof(struct rte_crypto_sym_xform) * 2); > > >> + (sizeof(union > > >> + rte_event_crypto_metadata)); > > >> op->private_data_offset = len; > > >> /* Fill in private data information */ > > >> rte_memcpy(&m_data.response_info, &response_info, > > >> -- > > >> 2.25.1 > > > > -- Brandon Lo UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu www.iol.unh.edu