From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A18CFA0C51; Wed, 21 Jul 2021 17:11:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CFE24014E; Wed, 21 Jul 2021 17:11:48 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id D37464014D for ; Wed, 21 Jul 2021 17:11:46 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id g22so3747655lfu.0 for ; Wed, 21 Jul 2021 08:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xl1jv3Ykqf+cILTZgPH68yYP7wGBV4Bpjj0qd6mn9DQ=; b=aG3kKdCdpv++9yfKlzflLSOEEM4YIVNBgaHMIO0b48jGcN4sieK8JAhORw58pZHDv3 MZLxUE5uy8Wx3WfRgoWEfISHlUe5owey7sttGxDIZVldOpJl+Mh0C7OsT+hSLzQMnn5u gbGxCNYubEsBrfzZnPRwRd9HesAyGjrkp/m+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xl1jv3Ykqf+cILTZgPH68yYP7wGBV4Bpjj0qd6mn9DQ=; b=mI1ZV3f3MElvNdCcBcTUHMuxxYrle/FF9sJp6c/7vqmtHnO1IbZc7T3mM963pxV+hu i8qrz+n/uYtfyHYTbtwNWB17uxm5tT9is/PUvv5CxEbuwMkiPtjvUvvhbn534DdUrtUz bzZNrXJii/qftdz1Ue10LfxoelHC+o9dtckP1mb+v5dU8gZBCGITeE0mFqeSSwwunKVm qY6hUq7lIlthm7iOEQlN3mTZQs4H4GxeXfd3hFAapYiNsihNTEzLgyWVrKlpE0BeRHSm daRMYBZRwef0iBMBAVqaA45BfBRLwV8WVLQ0x62rcFUxBNlfP2RTX7KISXkHnzSFgIer S4Vg== X-Gm-Message-State: AOAM531UqbrZ99t4AAlZL5uKfTQ7ej5GVSd1stZ8bR3ALR/WbDtXswTG kqlZGkcv4Riam/sk0Xt0S9EF2UeFjZ6llnacQH0Fxg== X-Google-Smtp-Source: ABdhPJyxd3RwO0t+G3/X9v51OnqAoHZAjmFeEfRH9tfSrNlWfM3EufSwbFm5sRho0g2M+O3jdZXTOCFYCAm2VY+mAHY= X-Received: by 2002:a05:6512:322a:: with SMTP id f10mr15211727lfe.625.1626880306323; Wed, 21 Jul 2021 08:11:46 -0700 (PDT) MIME-Version: 1.0 References: <6005170.NIlMa9dU7d@thomas> In-Reply-To: <6005170.NIlMa9dU7d@thomas> From: Brandon Lo Date: Wed, 21 Jul 2021 11:11:10 -0400 Message-ID: To: Thomas Monjalon Cc: Akhil Goyal , dev , Ray Kinsella , Pavan Nikhilesh Bhagavatula , Anoob Joseph , Abhinandan Gujjar , Ankur Dwivedi , Jerin Jacob Kollanukkaran , Aaron Conole , dpdklab , Lincoln Lavoie , Shijith Thotton , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 21, 2021 at 5:44 AM Thomas Monjalon wrote: > > 20/07/2021 14:14, David Marchand: > > On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal wrote: > > > > > > Hi David, > > > > > > > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > > > > > 'net_octeontx'] > > > > > > +deps += ['crypto_octeontx'] > > > > > > > > > > This extra dependency resulted in disabling the event/octeontx driver > > > > > in FreeBSD, since crypto/octeontx only builds on Linux. > > > > > Removing hw support triggers a ABI failure for FreeBSD. > > > > > > > > > > > > > > > - This had been reported by UNH CI: > > > > > http://mails.dpdk.org/archives/test-report/2021-June/200637.html > > > > > It seems the result has been ignored but it should have at least > > > > > raised some discussion. > > > > > > > > > This was highlighted to CI ML > > > > http://patches.dpdk.org/project/dpdk/patch/0686a7c3fb3a22e37378a8545b > > > > c37bce04f4c391.1624481225.git.sthotton@marvell.com/ > > > > > > > > but I think I missed to take the follow up with Brandon and applied the patch > > > > as it did not look an issue to me as octeon drivers are not currently built on > > > > FreeBSD. > > > > Not sure why event driver is getting built there. > > > > > > > > > > > > > > - I asked UNH to stop testing FreeBSD abi for now, waiting to get the > > > > > main branch fixed. > > > > > > > > > > I don't have the time to look at this, please can you work on it? > > > > > > > > > > Several options: > > > > > * crypto/octeontx is made so that it compiles on FreeBSD, > > > > > * the abi check is extended to have exceptions per OS, > > > > > * the FreeBSD abi reference is regenerated at UNH not to have those > > > > > drivers in it (not sure it is doable), > > > > > > > > Thanks for the suggestions, we are working on it to resolve this as soon as > > > > possible. > > > > We may need to add exception in ABI checking so that it does not shout if a > > > > PMD > > > > is not compiled. > > > Can we have below change? Will it work to disable compilation of > > > event/octeontx2 for FreeBSD? I believe this was done by mistake earlier > > > as all other octeontx2 drivers are compiled off on platforms other than Linux. > > > > > > diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build > > > index 96ebb1f2e7..1ebc51f73f 100644 > > > --- a/drivers/event/octeontx2/meson.build > > > +++ b/drivers/event/octeontx2/meson.build > > > @@ -2,7 +2,7 @@ > > > # Copyright(C) 2019 Marvell International Ltd. > > > # > > > > > > -if not dpdk_conf.get('RTE_ARCH_64') > > > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > > > build = false > > > reason = 'only supported on 64-bit' > > > subdir_done() > > > > I did not suggest this possibility. > > That's the same as for other octeon drivers, such change has been > > deferred to 21.11. > > https://patches.dpdk.org/project/dpdk/list/?series=15885 > > > > > > > > Or of this does not work, then we would need to add exception in ABI checking. > > > Any suggestions how to do this? > > > > Sorry, no good idea from me. > > We would need to revert the change breaking the ABI test. > But I don't understand why it seems passing in recent CI runs? Hi Thomas, For the UNH lab, FreeBSD 13 ABI tests have been disabled due to a request made during the community CI meeting on July 15th. The recent CI ABI runs will show up as passes, but the older runs with FreeBSD 13 included will keep their recorded failures. Thanks, Brandon -- Brandon Lo UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu www.iol.unh.edu