From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id A0A3999AA for ; Mon, 31 Jul 2017 18:18:27 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id y67so31165614wrb.3 for ; Mon, 31 Jul 2017 09:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8ule1MDcgz9TfXrxkQnUi7wMOP8I2PbDTI70g7t4h6U=; b=hCiVbG3YrVB0rjoRkac8lgLhbg0NQ0HESOYQgMSi3+CE7K/KgiGc8ugS6VQ6Xpy4u2 urQzG5W3MqXf4YWevAbpQ2b7X0Z4zKo1jRVQGlz3BmPJXmvFqWUUCwI7zdk2iMHjefNM 7gRJ5WNvk9PdAK2ThsqZWUSPlW/beQZciW39m2X1Bog54H9624vGlX7zGrWc/7VY7uXv kDeYDobvz2KfcvhtY7asmHwqJk2j62SaZYxCGag+eptsK3yyNu6BR7tJSReZFr7wNt5X xws+EOmF6a6pWEykwGbH90i6zy2PgEEc3q0fdE5VEx7ntck4Q7ZPyLGQVs1s1QtDgJPM vAGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8ule1MDcgz9TfXrxkQnUi7wMOP8I2PbDTI70g7t4h6U=; b=NFwjMC1rmeMo14fiU9Sk7DbWOCoxDg01UkLajriUz6/AWaXkZ6XWGKNj3ZJWpGH/nX 9bjRmDDhW05ehT8x/sBgGwYB+20vJPVcRPNefNZGXEtzJAR3hNNb3JPoare4xw2ZzpxX Us9yv4KFFK9o334kOM4ZfiApYFnNbwWycOC5E8fvHXKRN4wPZAVjzEghUMiaME9dFsDe +Ei7FEzanti0oGRjE2+dt7up2NxJbSHZRrXswbhVMrBj16unqylccA/oC9QhhkJatUnH K907MDcNUuSHJi46a1no2YnvE7pSoil9ou/jFbVv45p7lvD1UMLQW7WGgEpmhvg7Xu3i z4VA== X-Gm-Message-State: AIVw110i/WlJVl4si8LB2wtei10VFb2T/WbfHGIG4LXHJcilewJf/0nJ Oe/G+ZyGlVNl0OtJF9SXpT95Vyhcbw== X-Received: by 10.223.174.209 with SMTP id y75mr11856292wrc.19.1501517907349; Mon, 31 Jul 2017 09:18:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.208.3 with HTTP; Mon, 31 Jul 2017 09:18:26 -0700 (PDT) In-Reply-To: <20170731152216.GA33288@bricha3-MOBL3.ger.corp.intel.com> References: <20170727204146.9574-1-asomers@gmail.com> <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> <20170731152216.GA33288@bricha3-MOBL3.ger.corp.intel.com> From: alan somers Date: Mon, 31 Jul 2017 10:18:26 -0600 Message-ID: To: Bruce Richardson Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 16:18:27 -0000 On Mon, Jul 31, 2017 at 9:22 AM, Bruce Richardson wrote: > On Mon, Jul 31, 2017 at 09:11:11AM -0600, alan somers wrote: >> On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson >> wrote: >> > On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: >> >> From: Alan Somers >> >> >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >> >> >> >> Signed-off-by: Alan Somers >> >> --- >> >> examples/performance-thread/l3fwd-thread/test.sh | 2 +- >> >> usertools/dpdk-setup.sh | 2 +- >> >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh >> >> index b7718b622..eb1fe2dc2 100755 >> >> --- a/examples/performance-thread/l3fwd-thread/test.sh >> >> +++ b/examples/performance-thread/l3fwd-thread/test.sh >> >> @@ -1,4 +1,4 @@ >> >> -#!/bin/bash >> >> +#!/usr/bin/env bash >> >> >> >> case "$1" in >> >> >> > This script doesn't look to be using any bash specific features to me, >> > so a better fix might be to change it to use /bin/sh rather than >> > requiring bash itself. [Needs testing, to check there isn't something >> > bash-specific hidden away, obviously] >> >> True. Unfortunately, I can't test it right now because I can't get >> DPDK to build on either Linux or FreeBSD, and I'm out of time to debug >> the build failures for now. Would you like me to resubmit the patch, >> altered to use /bin/sh, without testing? >> >> > > I'm not sure it's that important a change that we need to rush into > doing so. > > What difficulties are you having getting DPDK to build? Is it just > platform setup issues? On Linux, I fail for lack of numa.h. The docs say to install libnuma-devel, but that package doesn't exist on my distro (Ubuntu 16.04). On FreeBSD, I get this compile error /usr/home/alans/freebsd/head/sys/vm/vm_phys.h:120:2: error: use of undeclared identifier 'vm_cnt' vm_cnt.v_free_count += adj; On FreeBSD stable/11, I get a litany of errors, beginning with: n file included from contigmem.c:49: In file included from ./machine/bus.h:6: In file included from ./x86/bus.h:1038: In file included from ./machine/bus_dma.h:32: ./x86/bus_dma.h:43:1: error: static declaration of 'bus_dmamap_create' follows non-static declaration bus_dmamap_create(bus_dma_tag_t dmat, int flags, bus_dmamap_t *mapp) ^ /usr/home/alans/freebsd/stable_11/sys/sys/bus_dma.h:262:5: note: previous declaration is here int bus_dmamap_create(bus_dma_tag_t dmat, int flags, bus_dmamap_t *mapp); And on FreeBSD stable/10, I get a make error: make[6]: "/usr/home/alans/freebsd/stable_10/sys/conf/kern.mk" line 43: Malformed conditional (${MK_FORMAT_EXTENSIONS} == "no") -Alan