From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <asomers@gmail.com> Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 852AA994F for <dev@dpdk.org>; Mon, 31 Jul 2017 21:08:19 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id v105so152726958wrb.0 for <dev@dpdk.org>; Mon, 31 Jul 2017 12:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4163CWAutBFaSf+vXTiX26GI0BnxZzXMay5frOcUgCw=; b=l1hGIpj9iNXh7H40IdQ9L7qMu57mhnz56fB4HYsMVLyfRYoAZZ3bjanEPmMGmbToPW 6nRIl3z4N62p7qKG43dXKiKkZuhhyoNFOgdqe9u7w6x5ZtrLYlmgknIOh/UWa1oHfKTF OZMzKEIpACEnHk6E7EJH3Fk9z/O/m2d7GVEOUuGvs1vn6xz9BpNrLo/3rAfH9jWNG0yp JodRCUonIdvDYiSgkhFd2/j8mbNN/V17QQkqcd4W+Sq5iKXuHoAXNrywLUZpuzUICfMB Q1QRrzhaMh2tyiFveu61Z1aMx/AYKciBRb6ROf/4cLp76ZLvSOoLSqe3xh2+A9uCRKAm HZ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4163CWAutBFaSf+vXTiX26GI0BnxZzXMay5frOcUgCw=; b=LfV+DK1S0UZP7M7h1+846vUwdpnDyw/rUMh48H4zxU+TFspcXnoQRRgFsYpiQtFjni V1hBjO1Q+RV1NHLTHk6Y7SYlsjexNClzESFrCa+nI/Y9UCjnMiKOEvHaz95DnlU0Lz9K gwHgojk9Z4CzE9/dagKWQHAWQ6osiPGhv+5y8Y4s52753I4xm6VZklb7hsGEUfAKINuj awhlkxerx2lMsq+rC4A/NTwu8RZhiX+PCFMWxUQs0zPMLS6Z/F8fsDP0DnK7V6UalNga A5jEc8qkrGx/0YBGXIl2eNGDmERlzSDuAAfrN8CCF5FOxn6g6Dv1+8NK9F8IDdAuKf/E goBw== X-Gm-Message-State: AIVw1120wlT3Lmi32wHnUI7aSKY0UbAYGv2KIOq+Inv9dL8UPmXWlgxK KS278C874GTXTIjkEM/ogijlwtTXiQ== X-Received: by 10.223.136.78 with SMTP id e14mr12296924wre.84.1501528099240; Mon, 31 Jul 2017 12:08:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.208.3 with HTTP; Mon, 31 Jul 2017 12:08:18 -0700 (PDT) In-Reply-To: <F47EFC8D-C1B9-4AAF-907A-B5A52A13AAD5@intel.com> References: <20170727204146.9574-1-asomers@gmail.com> <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> <CAOtMX2gdV-Ry3U1PZEuAOHaC1DAU2-EDGWRu8g2xCsQvi7-ZqA@mail.gmail.com> <20170731152216.GA33288@bricha3-MOBL3.ger.corp.intel.com> <CAOtMX2g_qTFHEtzvpFPNfMu9R=avC3xd_7dZdcQs7AC6XV4bLA@mail.gmail.com> <F47EFC8D-C1B9-4AAF-907A-B5A52A13AAD5@intel.com> From: alan somers <asomers@gmail.com> Date: Mon, 31 Jul 2017 13:08:18 -0600 Message-ID: <CAOtMX2imx85nZBbcG6Y5cR1axXCtiJn36wONaavrbnP7nvcwBw@mail.gmail.com> To: "Wiles, Keith" <keith.wiles@intel.com> Cc: "Richardson, Bruce" <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 31 Jul 2017 19:08:19 -0000 On Mon, Jul 31, 2017 at 11:06 AM, Wiles, Keith <keith.wiles@intel.com> wrote: > >> On Jul 31, 2017, at 11:18 AM, alan somers <asomers@gmail.com> wrote: >> >> On Mon, Jul 31, 2017 at 9:22 AM, Bruce Richardson >> <bruce.richardson@intel.com> wrote: >>> On Mon, Jul 31, 2017 at 09:11:11AM -0600, alan somers wrote: >>>> On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson >>>> <bruce.richardson@intel.com> wrote: >>>>> On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: >>>>>> From: Alan Somers <asomers@gmail.com> >>>>>> >>>>>> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >>>>>> >>>>>> Signed-off-by: Alan Somers <asomers@gmail.com> >>>>>> --- >>>>>> examples/performance-thread/l3fwd-thread/test.sh | 2 +- >>>>>> usertools/dpdk-setup.sh | 2 +- >>>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh >>>>>> index b7718b622..eb1fe2dc2 100755 >>>>>> --- a/examples/performance-thread/l3fwd-thread/test.sh >>>>>> +++ b/examples/performance-thread/l3fwd-thread/test.sh >>>>>> @@ -1,4 +1,4 @@ >>>>>> -#!/bin/bash >>>>>> +#!/usr/bin/env bash >>>>>> >>>>>> case "$1" in >>>>>> >>>>> This script doesn't look to be using any bash specific features to me, >>>>> so a better fix might be to change it to use /bin/sh rather than >>>>> requiring bash itself. [Needs testing, to check there isn't something >>>>> bash-specific hidden away, obviously] >>>> >>>> True. Unfortunately, I can't test it right now because I can't get >>>> DPDK to build on either Linux or FreeBSD, and I'm out of time to debug >>>> the build failures for now. Would you like me to resubmit the patch, >>>> altered to use /bin/sh, without testing? >>>> >>>>> >>> I'm not sure it's that important a change that we need to rush into >>> doing so. >>> >>> What difficulties are you having getting DPDK to build? Is it just >>> platform setup issues? >> >> On Linux, I fail for lack of numa.h. The docs say to install >> libnuma-devel, but that package doesn't exist on my distro (Ubuntu >> 16.04). On FreeBSD, I get this compile error >> /usr/home/alans/freebsd/head/sys/vm/vm_phys.h:120:2: error: use of undeclared >> identifier 'vm_cnt' >> vm_cnt.v_free_count += adj; > > On my Ubuntu 17.04 the package is called libnuma-dev Thanks. That gets dpdk to build. But the performance-thread directory still doesn't. I could dig futher, but I'm really out of time for this task. That's why I suggest just changing the shebang to find bash from the PATH, rather than use a different shell entirely. -alan