From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA618A0C43; Thu, 21 Oct 2021 18:40:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A48AB40683; Thu, 21 Oct 2021 18:40:58 +0200 (CEST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id EB8A24003E for ; Thu, 21 Oct 2021 18:40:57 +0200 (CEST) Received: by mail-ed1-f44.google.com with SMTP id w14so3515285edv.11 for ; Thu, 21 Oct 2021 09:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6eJ6fzZEzgPjfSZop0DKQoNcbQq2vLpI+VpUA+KaIcg=; b=FblySnKRJ+EaR2sNKMeqXIfeYdv6WZ6wy7URiKGP85GFEriUBN7HZoPSsFpa4ipy6f icckkp9AUgtl879Z6kUQ63kjtaXI/7ytBvwpbmnfjj7k2B40XhYmNxjNa95/Jyd3DrRW 1dtWbRdwHVX3rig49dNsvrjSDxoY3kk1EIDdhxuGznORSvPo68K4+WN3ybKnqruw/UFO aeKw3WOJg5v+KIm0YQI2CClxarTkxOyFx7E0TNfzJ4nWMJ118ioIFUCkOI0GJlLX+Ept xUV1rcw99BqR3HJYSybRYafiXWCpPrqR/uPH7XhNTb8UU8KnqAMJ8RawEwrbHb/9eJOf VFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6eJ6fzZEzgPjfSZop0DKQoNcbQq2vLpI+VpUA+KaIcg=; b=q+l+YeBwxWAxwhW2iq0/n6+MBJ2P1dgvIb6Tx1Rue7g1YZQM46WWtsU0RuzmhoLWKb YDi72MEBXrfn6IYvOgcT1AGpblr8yCxlURXDklTWR48xQK7pOzItxkZVjmEVpgz/We7n UmxH13Q8nWa4Y/hJ3EVFOaIdFAc96BhNC0jvprG6LtcSqZ74rzqYG59XuZeifgqJDC8g IiM7aF+3uiUIqjga4Ud91aoOJiymki2ys6IA6KRIK3WBgRQLeVhxjefkBXLqj18QjqZm XmK1mEmzDYueDzM0w0u1perD4dkBk9DLoslph7dhShtTvfB8N+sYLmN430Y+2EJ5Ci4s EmVQ== X-Gm-Message-State: AOAM531F5/8a+Ge3TuVNSlwt0bCMHSyGH4L8xd9a4R+qRUrfUGUEwLFq jpUc5JcE9Y6Qnnybd21tx3QuB3z9oc2jndKOUR0= X-Google-Smtp-Source: ABdhPJzqtMppnH+doZvqulwvph8/4FWpwec1OB1rv/9kFBYNl05Y5TT5dZyGM0OZ+nyznVO9yjVt8IyRw+GKTGnkNBU= X-Received: by 2002:a05:6402:5216:: with SMTP id s22mr9317397edd.167.1634834457697; Thu, 21 Oct 2021 09:40:57 -0700 (PDT) MIME-Version: 1.0 References: <1634306769-20123-1-git-send-email-tudor.cornea@gmail.com> <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> <579fa9cd-07cd-fade-d4ec-6e742806c7ca@intel.com> In-Reply-To: <579fa9cd-07cd-fade-d4ec-6e742806c7ca@intel.com> From: Tudor Cornea Date: Thu, 21 Oct 2021 19:40:46 +0300 Message-ID: To: Ferruh Yigit Cc: "Zhang, Qi Z" , "Wang, Haiyue" , "Zhang, AlvinX" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Oct 2021 at 18:33, Ferruh Yigit wrote: > On 10/20/2021 7:13 PM, Tudor Cornea wrote: > > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > > seem to initialize anymore, while running testpmd. > > > > Configuring Port 0 (socket 0) > > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > > Fail to start port 0: Invalid argument > > Configuring Port 1 (socket 0) > > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > > Fail to start port 1: Invalid argument > > Please stop the ports first > > > > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > > we will not be able to initialize the ports correctly. > > > > The behavior seems to have changed since the following commit: > > > > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") > > > > Hi Tudor, > > We document this with explicit 'Fixes' tag, this also helps up to > manage backporting patches to LTS releases, so updating as: > > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in > DCF") > Cc: stable@dpdk.org > > Also we use 'fix' verb in the patch title almost as keyword, again > to help deciding which patch to backport, also to clarify impact of > the patch, so will update patch title as: > > net/ixgbe: fix port initialization if MTU config fails > > > For more details please check contribution guide: > https://doc.dpdk.org/guides/contributing/patches.html > > Thanks, > ferruh > > > We can make this particular use case work correctly if we don't > > return an error, which seems to be consistent with the overall > > kernel ixgbevf implementation. > > > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c#n2015 > > > > The code that this link references can change by time as code changes, > I will update it as following to bind it a specific version (v5.14): > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c?h=v5.14#n2015 > > > Signed-off-by: Tudor Cornea > > > > --- > > v2: > > * Change title > > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c > > It's already fixed as part of Ferruh's changes in next-net branch, > > so this part should be redundant, now > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > b/drivers/net/ixgbe/ixgbe_rxtx.c > > index b263dfe..a51450f 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -5673,11 +5673,9 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) > > * ixgbevf_rlpml_set_vf even if jumbo frames are not used. This > way, > > * VF packets received can work in all cases. > > */ > > - if (ixgbevf_rlpml_set_vf(hw, frame_size) != 0) { > > + if (ixgbevf_rlpml_set_vf(hw, frame_size) != 0) > > PMD_INIT_LOG(ERR, "Set max packet length to %d failed.", > > frame_size); > > - return -EINVAL; > > - } > > > > /* > > * Assume no header split and no VLAN strip support > > > > Hi Ferruh, Thanks a lot for the good observations and for pointing me in the right direction ! Tudor