From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C18A00C3; Mon, 17 Jan 2022 17:24:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99B5441C27; Mon, 17 Jan 2022 17:24:50 +0100 (CET) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id BA21E4122E for ; Mon, 17 Jan 2022 17:24:48 +0100 (CET) Received: by mail-ed1-f41.google.com with SMTP id g22so21348949edu.1 for ; Mon, 17 Jan 2022 08:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tL5zZV1kODp+VKrwiCgL0fKkbaHwp6TV3+bk4JDq7KI=; b=mUcHJcUAuh0itS+BokRgUZ0d+Lw08x6xSNCXM5dfdaU6jNqkVJDMoAXOVa6Xe409U7 xO/EVhHZWnZHZJGMcJ51OcFZA2g02UaoAfjvTf8F745Aw9jm00/RD4hBYg2aSd8NsEP8 Criia6I41tOXvKuR40PVwYTUrLZPVb0PH+GU4FkubtMEbOv4Po+rbMpSAbavEy1+ECZJ 1tMO2UHiB2001vxvisAxjF20S/WcmjO/BntUzzppof4nR0j4E28qR3J+pYLHIAXVsI84 OB2YqXjE6NjDbah66HuoUFMntIZ/DZY5mRUX8IpVERwStUsD48TJGJJH9TXRsyMn3hI5 atXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tL5zZV1kODp+VKrwiCgL0fKkbaHwp6TV3+bk4JDq7KI=; b=szc2x5eZYpKJzfjUqLVElX4Vvp0OrBb1q9B/0TfhIRMjJEHwM4v3oxAC58rjDFqvX/ 8grAitehDjbJLma/NUYg4x7A0rvbWyjxXiQayP7lll2KzpdT4U982/bOWjJeeao+T7Gb naloHYh1Pazifwjiziaxx0/t+f0BfRvwdNSmdwM9AabJaCR4t2PO10m5BB3jsK/mCCZR Ex5rmO8U3twGaP1IShfVsPjTz0P7ec1qaBlvrjAUh3Ex2bRo9Y/s26yAqQJVLD0g2qQI 7WM9vf8ZEvEtVibsUiw5wtfR38em9SX81S5qTHlEz953VDVF6KmMWQ+dc1Ses3OQPh/d fP0w== X-Gm-Message-State: AOAM530mzGgZ7fVHlZZkuKGmlvEfJRyZEWmVrRfY7XfRYWXVQrc5gvM4 nfwMWCk6Qa/pMKsUA4I6dBiY79HKRv1/pSuXDoagy4lE98Y= X-Google-Smtp-Source: ABdhPJzeYxbMTJyzn9LIk0J2B5wtmyuM4z+aXOKhsHnhrCjTpT42gbsLhtoDTdNmxQfMsONoZzi0p6SEgALCKsAcLMI= X-Received: by 2002:a17:906:ff47:: with SMTP id zo7mr18306587ejb.62.1642436688518; Mon, 17 Jan 2022 08:24:48 -0800 (PST) MIME-Version: 1.0 References: <1637781854-74761-1-git-send-email-tudor.cornea@gmail.com> <1642173499-59396-1-git-send-email-tudor.cornea@gmail.com> <20220114082415.69752802@hermes.local> <49900a8c-f9d1-f69f-04f8-b49a4aeebd5e@intel.com> In-Reply-To: <49900a8c-f9d1-f69f-04f8-b49a4aeebd5e@intel.com> From: Tudor Cornea Date: Mon, 17 Jan 2022 18:24:37 +0200 Message-ID: Subject: Re: [PATCH v5] kni: allow configuring the kni thread granularity To: Ferruh Yigit Cc: Stephen Hemminger , padraig.j.connolly@intel.com, Thomas Monjalon , helin.zhang@intel.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000062a12c05d5c9971f" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000062a12c05d5c9971f Content-Type: text/plain; charset="UTF-8" On Fri, 14 Jan 2022 at 18:44, Ferruh Yigit wrote: > On 1/14/2022 4:24 PM, Stephen Hemminger wrote: > > On Fri, 14 Jan 2022 17:18:19 +0200 > > Tudor Cornea wrote: > > > >> +module_param(min_scheduling_interval, long, 0644); > >> +MODULE_PARM_DESC(min_scheduling_interval, > >> +"\t\tKni thread min scheduling interval (default=100 microseconds):\n" > >> +"\t\t" > >> +); > >> + > >> +module_param(max_scheduling_interval, long, 0644); > >> +MODULE_PARM_DESC(max_scheduling_interval, > >> +"\t\tKni thread max scheduling interval (default=200 microseconds):\n" > >> +"\t\t" > >> +); > > > > Please don't add more bad module parameter strings. > > The KNI author did something no other kernel modules do with tabs > > and double spacing, stop this bogus stuff. > > > > The patch is good, let's not block it for the module parameter string, > all can be fixed with another patch. > > Can you please give a sample what is a common way of it, me or Tudor can > do the patch? > > I agree that the module parameter string is in non-standard format. I was planning to send a follow-up patch, which would correct the description for all of the KNI parameters (including the two new parameters that the current patch would add) in one shot. > > Is there any reason you have to use KNI at all. > > KNI is broken on many levels and is not fixable. > > What about virtio or tap? > > We've run some tests with tap interfaces and found the performance to not be good enough for our use. We're going to experiment with virtio_user in the future. I'm aware that there is a long term plan to deprecate the KNI. --00000000000062a12c05d5c9971f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Fri, 14 Jan 2022 at 18:44, Ferruh Yigi= t <ferruh.yigit@intel.com&= gt; wrote:
On 1/= 14/2022 4:24 PM, Stephen Hemminger wrote:
> On Fri, 14 Jan 2022 17:18:19 +0200
> Tudor Cornea <tudor.cornea@gmail.com> wrote:
>
>> +module_param(min_scheduling_interval, long, 0644);
>> +MODULE_PARM_DESC(min_scheduling_interval,
>> +"\t\tKni thread min scheduling interval (default=3D100 micro= seconds):\n"
>> +"\t\t"
>> +);
>> +
>> +module_param(max_scheduling_interval, long, 0644);
>> +MODULE_PARM_DESC(max_scheduling_interval,
>> +"\t\tKni thread max scheduling interval (default=3D200 micro= seconds):\n"
>> +"\t\t"
>> +);
>
> Please don't add more bad module parameter strings.
> The KNI author did something no other kernel modules do with tabs
> and double spacing, stop this bogus stuff.
>

The patch is good, let's not block it for the module parameter string,<= br> all can be fixed with another patch.

Can you please give a sample what is a common way of it, me or Tudor can do the patch?


I agree that the module parameter stri= ng is in non-standard format.=C2=A0=C2=A0
I was planning= to send a follow-up patch, which would correct the description for all of = the KNI parameters (including the two new parameters that the current patch= =C2=A0would add) in one shot.
=C2=A0
> Is there any reason you have to use KNI at all.
> KNI is broken on many levels and is not fixable.
> What about virtio or tap?


We've run some tests with tap inte= rfaces and found the performance to not be good enough for our=C2=A0use.
We're going to experiment with virtio_user in the future. I= 'm aware that there is a long term plan to deprecate the KNI.


=C2=A0
--00000000000062a12c05d5c9971f--