From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aber@semihalf.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 153D31288
 for <dev@dpdk.org>; Fri, 15 May 2015 15:37:09 +0200 (CEST)
Received: by wgnd10 with SMTP id d10so110847229wgn.2
 for <dev@dpdk.org>; Fri, 15 May 2015 06:37:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to
 :content-type;
 bh=nasKu8FwlfMHT18MxLCGSLP6GFGsdXbRZ5L1E1aQ4nI=;
 b=d40mW5NS5/tYKl8sdpb8sV7fLneY0CPzc2BBpKe+t/b/6YAlFlS9svzY0sEr+SZZM0
 MUq811dEfVaidkKeTEyRiux6q/6J8cTsfjpe0wpuUOlyao8nWIfFYCQH4xLdZ9HCXNQq
 UDGDwnymTCLg6a4UUe3eNZYqbdbUc3IHjmNmIkdA43ZT8+jGQETUxy/f+PR+sWhaXDeZ
 ycy6bN2pRl8fdESKvPHU6Jkj7XVFplwtur2TK6p9hYuORtffk2bJQNpamvsfyRxK66z3
 D544/9xiYSIL4zr3+lxq2Kc7qQQqnITt20RS9yQPvaIbk74yPa9vPc8o7rE5ehfnk9RM
 5R7w==
X-Gm-Message-State: ALoCoQno7XbTx1cxq4V0pgGXUyOZAMPHkflisHFuh8anG9XL/c+TwnNHPhiAh/0lvZ4ggYXpoBRS
X-Received: by 10.181.11.193 with SMTP id ek1mr33875876wid.15.1431697028899;
 Fri, 15 May 2015 06:37:08 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.27.229.202 with HTTP; Fri, 15 May 2015 06:36:48 -0700 (PDT)
From: Andriy Berestovskyy <aber@semihalf.com>
Date: Fri, 15 May 2015 15:36:48 +0200
Message-ID: <CAOysbxr30TQ+a7BDHSjd29=3W-Z7V9bYbxcSeyCMZYOLjH=-Ag@mail.gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
Subject: [dpdk-dev] bond: mode 4 promiscuous mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2015 13:37:09 -0000

Hey guys,
Can we in function bond_mode_8023ad_activate_slave() try to add to the
slave bond and LACP multicast MACs first? And then we would fall back
into promiscuous mode if the adding has failed.

In other words:

if (rte_eth_dev_mac_addr_add(slave_id, bond_mac) != 0
    || rte_eth_dev_mac_addr_add(slave_id, lacp_mac) != 0) {
    ...
    rte_eth_promiscuous_enable(slave_id)
}

Seems to work fine on my setup, but I might miss something.

Regards,
Andriy