From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f169.google.com (mail-yw0-f169.google.com [209.85.161.169]) by dpdk.org (Postfix) with ESMTP id 14CB16A1A for ; Mon, 9 May 2016 17:22:16 +0200 (CEST) Received: by mail-yw0-f169.google.com with SMTP id t10so289237610ywa.0 for ; Mon, 09 May 2016 08:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=do6R+haH1vyT4yKPUDUM1tLbTI8F1dJkoZCCKSkxymE=; b=SnJNqH8H6q6jn1fR2z+w2sYKcbXQlIvSYx3szKze5l/54TMBTc//tPi3/IU8981Mk5 Y9B78NmehPtNpLR17B3jMTct6Zn0AcAZYkmMTMeNZTJWHs1m0i0pNyVJ0Z+zfkB9H8M9 0KK2xk3cNdDDQf2w8gCOY1i50AeNMEWHly2AA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=do6R+haH1vyT4yKPUDUM1tLbTI8F1dJkoZCCKSkxymE=; b=gCg0PXPpyalYNuZDvXPbuZJr0c/iZZem3wV9bGCl2rripz3hI34A+93VXXajio7hjj 8eQ/QrezYg+ORk3T4OO6tyi2g+cvjEUAchDhtNB05pahLkasHDCWSW3zafomgkHzbJu5 RnjYv+zwMoj5jJ/nKEVnsTCs/3QyYO5YDe4Qfwj6E3TZuJZHWuQWWnPrimPwDPK9h48k Su/6dGk48FuJpxCZlkrCZxlPElrj10bCu2YniOCUQnNT4YYTEVQzIxnyov5YbqAWULYm kt3yEpmAVuX4OoTah6dQ6JwUQG2psvSa0WvyzVQZuCfj71O9jgSzrjRmGm3RjbrQ6vWL xtCQ== X-Gm-Message-State: AOPr4FVjoPXQXbbUF4f2ZLV5EsYrGQYCJxrOcej6usn9MT+pIJEXxOYDJDXNIhnAXpJ5/gCKfV9ZFZ/COTeEz1Qi MIME-Version: 1.0 X-Received: by 10.37.223.215 with SMTP id w206mr16479633ybg.149.1462807335520; Mon, 09 May 2016 08:22:15 -0700 (PDT) Received: by 10.37.223.2 with HTTP; Mon, 9 May 2016 08:22:15 -0700 (PDT) In-Reply-To: <20160509121118.GA8689@localhost.localdomain> References: <1462801702-30918-1-git-send-email-hemant.agrawal@nxp.com> <20160509090621.GA4631@localhost.localdomain> <20160509121118.GA8689@localhost.localdomain> Date: Mon, 9 May 2016 23:22:15 +0800 Message-ID: From: Jianbo Liu To: Jerin Jacob Cc: Hemant Agrawal , dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 15:22:16 -0000 On 9 May 2016 at 20:11, Jerin Jacob wrote: > On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: >> On 9 May 2016 at 17:06, Jerin Jacob wrote: >> > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: >> >> This patch introduces dpaa2 machine target to address difference >> >> in cpu parameter, number of core to 8 and no numa support >> >> w.r.t default armv8-a machine >> >> >> >> Signed-off-by: Hemant Agrawal >> >> --- >> >> config/defconfig_arm64-dpaa2-linuxapp-gcc | 44 +++++++++++++++++++++++ >> >> mk/machine/dpaa2/rte.vars.mk | 60 +++++++++++++++++++++++++++++++ >> >> mk/rte.module.mk | 5 +++ >> >> 3 files changed, 109 insertions(+) >> >> create mode 100644 config/defconfig_arm64-dpaa2-linuxapp-gcc >> >> create mode 100644 mk/machine/dpaa2/rte.vars.mk >> >> >> >> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc >> >> new file mode 100644 >> >> index 0000000..80bda26 >> >> --- /dev/null >> >> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc >> >> @@ -0,0 +1,44 @@ >> >> +# BSD LICENSE >> >> +# >> >> +# Copyright(c) 2016 Freescale Semiconductor, Inc. All rights reserved. >> >> +# >> >> +# Redistribution and use in source and binary forms, with or without >> >> +# modification, are permitted provided that the following conditions >> >> +# are met: >> >> +# >> >> +# * Redistributions of source code must retain the above copyright >> >> +# notice, this list of conditions and the following disclaimer. >> >> +# * Redistributions in binary form must reproduce the above copyright >> >> +# notice, this list of conditions and the following disclaimer in >> >> +# the documentation and/or other materials provided with the >> >> +# distribution. >> >> +# * Neither the name of Freescale Semiconductor nor the names of its >> >> +# contributors may be used to endorse or promote products derived >> >> +# from this software without specific prior written permission. >> >> +# >> >> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >> >> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> >> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >> >> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >> >> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >> >> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >> >> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >> >> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >> >> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >> >> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >> >> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> >> +# >> >> + >> >> +#include "defconfig_arm64-armv8a-linuxapp-gcc" >> >> + >> >> +# NXP (Freescale) - Soc Architecture with WRIOP and QBMAN support >> >> +CONFIG_RTE_MACHINE="dpaa2" >> >> +CONFIG_RTE_ARCH_ARM_TUNE="cortex-a57+fp+simd" >> >> + >> >> +# >> >> +# Compile Environment Abstraction Layer >> >> +# >> >> +CONFIG_RTE_MAX_LCORE=8 >> >> +CONFIG_RTE_MAX_NUMA_NODES=1 >> >> +CONFIG_RTE_EAL_IGB_UIO=n >> > >> > I think it makes sense to move this option to generic arm64 config >> > as upstream arm64 kernel does not have support for sysfs based PCI mmap >> > resource file,(/sys/bus/pci/devices/B:D:F/resource[_wc]X) need for >> > CONFIG_RTE_EAL_IGB_UIO to work) and use VFIO for all cases. >> > >> > Any objections? >> > >> Is there any conflict to keep both? > > I would like to avoid the case like below in dpdk.org ml. > http://dpdk.org/ml/archives/dev/2016-January/031313.html > So no conflict to enable both. I'd rather keep as it is for armv8a defconfig, becasue it's the base, any change may affect existing user.