From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com [209.85.161.174]) by dpdk.org (Postfix) with ESMTP id 184A9214A for ; Tue, 3 Jan 2017 08:40:26 +0100 (CET) Received: by mail-yw0-f174.google.com with SMTP id v81so180405468ywb.2 for ; Mon, 02 Jan 2017 23:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dlWm3P6EAWQGL44fKf5agD2k6as5W6uFtUri/kHIX1k=; b=X4tRPqe3y2qfy5vhonhSN/PWUaC0/rAhh/ZL2z4IF/PE9I/es/XhMTpsDUIkma5i7X 2kqJRbHVlDgtDr8/YOq+zcQB1agA4MDiWeXtWxWwMOq7sg/lUspv4CWh77ZuIjEL9oO+ H7O9zSPoQ3xWBGX22nbBT231WkAwHNE0GuH7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dlWm3P6EAWQGL44fKf5agD2k6as5W6uFtUri/kHIX1k=; b=kEATRrSS2nCAZB/FoxdZY79qePgm5Is6I0X89WIbKTijALI7q7/PllaPf2ALv2VqDZ Q+5Gykj/9FjGSt4kuVYNLF0EA1dWrnNtHauvG4GKDFLz7JF/7AbK1ypbYh1nq85mbPQu AqPTifFuSmOcilGuYrsc34UBlijHTd0F7WhYs8QKT0TausuiTnFCenS3YPF9iSok8G99 /sSNwvi7n5PVrF/kNZFrX7Y+meV2Bn7HqH43dHPLLFA9fa5Vhim8RdHM4B0JX0qNgnPu xsQA4PAXuIGVHuUrGbzC41QJeXdSZbQ/po9KFeN+hRKC1Jax/bwxI09MLAQqYdYiYwfp UIHQ== X-Gm-Message-State: AIkVDXI6rt0+jyExfcigxROIk1HYYLbPPAt2LFKEVd6FqPpFfyj7H6YkDYb5a690AfkmYr9p99Xn4qdE6ofFfjJa X-Received: by 10.129.175.26 with SMTP id n26mr58344624ywh.32.1483429225447; Mon, 02 Jan 2017 23:40:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.221.65 with HTTP; Mon, 2 Jan 2017 23:40:25 -0800 (PST) In-Reply-To: <1482832175-27199-8-git-send-email-jerin.jacob@caviumnetworks.com> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-8-git-send-email-jerin.jacob@caviumnetworks.com> From: Jianbo Liu Date: Tue, 3 Jan 2017 15:40:25 +0800 Message-ID: To: Jerin Jacob Cc: dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin , Santosh Shukla , stable@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2 07/29] eal/arm64: fix memory barrier definition for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 07:40:26 -0000 On 27 December 2016 at 17:49, Jerin Jacob wrote: > dsb instruction based barrier is used for non smp > version of memory barrier. > > Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8") > > CC: Jianbo Liu > CC: stable@dpdk.org > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > index d854aac..bc7de64 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > @@ -43,7 +43,8 @@ extern "C" { > > #include "generic/rte_atomic.h" > > -#define dmb(opt) do { asm volatile("dmb " #opt : : : "memory"); } while (0) > +#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); } > +#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); } > > /** > * General memory barrier. > @@ -54,7 +55,7 @@ extern "C" { > */ > static inline void rte_mb(void) > { > - dmb(ish); > + dsb(sy); > } > > /** > @@ -66,7 +67,7 @@ static inline void rte_mb(void) > */ > static inline void rte_wmb(void) > { > - dmb(ishst); > + dsb(st); > } > > /** > @@ -78,7 +79,7 @@ static inline void rte_wmb(void) > */ > static inline void rte_rmb(void) > { > - dmb(ishld); > + dsb(ld); > } > > #define rte_smp_mb() rte_mb() > -- > 2.5.5 > Acked-by: Jianbo Liu