From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianbo.liu@linaro.org>
Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com
 [209.85.161.171]) by dpdk.org (Postfix) with ESMTP id 93ECFAB03
 for <dev@dpdk.org>; Thu, 19 May 2016 15:48:09 +0200 (CEST)
Received: by mail-yw0-f171.google.com with SMTP id j74so78356688ywg.1
 for <dev@dpdk.org>; Thu, 19 May 2016 06:48:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=xFB/HDJ1+UxQ2ZpV+PWK1VMYLGYxLS3D8iIEyQ8Yglg=;
 b=hAmiq/pOPUA547/m9QUqc9MndHr6tpu9OtS56hXZlHxHaG3NZznVJgfadW9KRrPRp/
 nisPFb0lLcgtR1H6P3+dAL6y4Dkb0wC0sFN+Re0VJePbV/BedUMtSzbyG95816k9OVqp
 yjP5XYxjFZHKk8orALCihxR664Fir0EVJH5DI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=xFB/HDJ1+UxQ2ZpV+PWK1VMYLGYxLS3D8iIEyQ8Yglg=;
 b=dQLLcj8NC9xhugZFnzwgcfiLw4udQR+SVCnSM5oHwnBix3sJc3iwDQoX0fIwEHLUav
 /ssOBcKaiqZZKoxaPX+4CaRtnTCRVB66jlzO2MDh8epGm+Z6mjCYqg6XJ5zVjU5gd2Ho
 EN6hFUxycEZMBxoVJIJU2iD0TJZezGEX0oyrC18wddbYlwJFkgUMv1ivyJXX6g2c+ewe
 hq5S3hAjd6MO52EBN/wYeJv25sabp9XhRVUuzrPkn6gXQKvEtEqM5z7D3HVrCwPgcn5F
 s8UXGtb+GWBH2MwkQYrbhx/8Y8gAvcmh1u+u8+4kik5egc5xzPlqvAX165jWAVQQX43N
 B7tA==
X-Gm-Message-State: AOPr4FVMdMoVb8JyIE/zE/b8F8kTartwBJk+qJrhIdGVPgfbAdIzMrsmm4sFHlovN7q5+FDfiCXUQShq+27jI9lf
MIME-Version: 1.0
X-Received: by 10.13.233.130 with SMTP id s124mr7705177ywe.15.1463665688602;
 Thu, 19 May 2016 06:48:08 -0700 (PDT)
Received: by 10.37.223.133 with HTTP; Thu, 19 May 2016 06:48:08 -0700 (PDT)
In-Reply-To: <2364439.Jm7BSl6O9C@xps13>
References: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org>
 <2364439.Jm7BSl6O9C@xps13>
Date: Thu, 19 May 2016 21:48:08 +0800
Message-ID: <CAP4Qi380CmSRkb5g4WLFX3HaoeuphDxpyy2vjf6dEBz5dFJZcQ@mail.gmail.com>
From: Jianbo Liu <jianbo.liu@linaro.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH] arm64: change rte_memcpy to inline function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2016 13:48:09 -0000

On 13 May 2016 at 23:49, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2016-05-10 14:01, Jianbo Liu:
>> Other APP may call rte_memcpy by function pointer,
>> so change it to an inline function.
>
> Any example in mind?
>
It's for ODP-DPDK.
>> --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
>> +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
>> -#define rte_memcpy(d, s, n)  memcpy((d), (s), (n))
>> +static inline void *
>> +rte_memcpy(void *dst, const void *src, size_t n)
>> +{
>> +     return memcpy(dst, src, n);
>> +}
>
> It has no sense if other archs (arm32, ppc64, tile) are not updated.
>
But it also an inline function on x86.
Sorry for my late reply...