From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f172.google.com (mail-yw0-f172.google.com [209.85.161.172]) by dpdk.org (Postfix) with ESMTP id 5FD5A2C5D for ; Thu, 2 Jun 2016 11:04:14 +0200 (CEST) Received: by mail-yw0-f172.google.com with SMTP id x189so43926955ywe.3 for ; Thu, 02 Jun 2016 02:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=laL6fLPnmMdSeXP2/Sq++phvztuXOmOTDx+8U6QlwuI=; b=Gj3ufP7vjlf+60XHJrkOo9pv4ZTCy9AE25PGKlb6MyuRj8UP9seY4wAkfvogzf8UDS +5scQMUrvZWECNkWaw1eIROBD1JRTf7eaqACUtKSKvSRxAcuofSLgNNNIZA/s3PX0c8d Viobx5MllP01ellcgYxgouczqje5jNAUtRqoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=laL6fLPnmMdSeXP2/Sq++phvztuXOmOTDx+8U6QlwuI=; b=fKY4AdJCduBHkLvw5hqlO41QyWvew3ElddYbFror6fuk/OGhWTBDPgidY7yRuZL7eC jIrWdO1Pc4oE9GVMGLYhTOzvE9JJAWayzgOToDVlxDN1ct2PY9a15ZVb5wYA8NnwosL1 6r/7yh5TpJr2ovg1ZFhP0OoYSjgvM223Hd8q9CWVIzczJC6vMEkk8VtiZScomIYP+kEt o/r8ii8lVUofBzUiW+74mSIlOHMz2Fkfb+6azfVXR016NmvqFxkjYLOY5K3wm6CNFi9n bjQGd94LnsNGswI6HHc0/5CeDeG/Ljf9cYyahsPwfEENpQhaVBSP5iLnQrcKCzWtIE2o e/6A== X-Gm-Message-State: ALyK8tIiUfbbwEHcw7pcRqOwna4oZ/s/PsERleApEeDKf6c2m9EIhQr4trRgoYHWMIh+sRGWe0E1Bhr6k3CfHM0I MIME-Version: 1.0 X-Received: by 10.13.232.211 with SMTP id r202mr5173998ywe.163.1464858253794; Thu, 02 Jun 2016 02:04:13 -0700 (PDT) Received: by 10.37.212.146 with HTTP; Thu, 2 Jun 2016 02:04:13 -0700 (PDT) In-Reply-To: <20160601060028.GA3823@localhost.localdomain> References: <1464663966-8122-1-git-send-email-jianbo.liu@linaro.org> <574DE5D6.2040001@6wind.com> <20160601060028.GA3823@localhost.localdomain> Date: Thu, 2 Jun 2016 17:04:13 +0800 Message-ID: From: Jianbo Liu To: Jerin Jacob Cc: Olivier MATZ , dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2016 09:04:14 -0000 On 1 June 2016 at 14:00, Jerin Jacob wrote: > On Wed, Jun 01, 2016 at 11:29:47AM +0800, Jianbo Liu wrote: >> On 1 June 2016 at 03:28, Olivier MATZ wrote: >> > Hi Jianbo, >> > >> > On 05/31/2016 05:06 AM, Jianbo Liu wrote: >> >> Change the inline function to macro with parameters >> >> >> >> Signed-off-by: Jianbo Liu >> >> >> >> [...] [...] >> It's for performance consideration, and only on armv8a platform. > > Strictly it is not armv8 specific, IA also implemented this API with > _MM_HINT_NTA hint. I mean this patch is only for ixgbe vector PMD on armv8 platform. > > Do we really need non-temporal/transient version of prefetch for ixgbe? Strictly speaking, we don't have to since we don't know how APPs use the mbuf header. But, is it high possibility that the second part is used only once or short period because prefetching is done only when split_packet is not NULL? > If so, for x86 also it makes sense to keep it? Right? > > The primary use case for transient version would be use with pipe line > line mode where the same cpu wont consume the packet. > > /** > * Prefetch a cache line into all cache levels (non-temporal/transient > * version) > * > * The non-temporal prefetch is intended as a prefetch hint that > * processor will > * use the prefetched data only once or short period, unlike the > * rte_prefetch0() function which imply that prefetched data to use > * repeatedly. > * > * @param p > * Address to prefetch > */ > static inline void rte_prefetch_non_temporal(const volatile void *p); > >> >> > >> > By the way, I did not try to apply the patch, but it looks >> > it's on top of dpdk-next-net/rel_16_07, right? >> > >> Yes