From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f179.google.com (mail-yw0-f179.google.com [209.85.161.179]) by dpdk.org (Postfix) with ESMTP id 555551094 for ; Tue, 3 Jan 2017 08:48:33 +0100 (CET) Received: by mail-yw0-f179.google.com with SMTP id a10so282563002ywa.3 for ; Mon, 02 Jan 2017 23:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EvLeYk9zs/bEhWuk85MxOWsA96SVZ/sPUxX1XsTIwZE=; b=GWiaIWe+A/1NdW8sABncQgMcvc2tVBCU2x7VKfJr+ZhpsADz5p78ql4V1rbx46TMd3 epMFflDgZ9IAcImrhglwP2kCrsVbhvDrpiK3ygYwdwjvH3aEQJ+CPxB24T1DuWvsSQnk HfqCESssNzqMFg3mHbGZqAi7h6VHhUdPJNmfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EvLeYk9zs/bEhWuk85MxOWsA96SVZ/sPUxX1XsTIwZE=; b=cJDHz/l+TRrpe2X4/cUpeD66hAUhwvImBTO63aCmaGxhPuWW89cUoQ1uCemcg28w4j gjrbKTAeH/gEdHQoIqQvKxP6yWdapdI6vVLU+oiA0ms2XMPQlhdLDOMbbhS63wMGbqyE J8YLmItunfaRl6tqnp7fxsmJkBGMwEf/pqjXlfXSODuddeBeHfE1kCR1h7pyGLTcVzny lE0xbGdMHeL17o87CBRnTXaPNtCVXf1mPls6Torh6WVNqOxMaz9RoZ8xvNkZZwt+u6j2 GX7FE76/0ozfvPCRTQGLkXg3521ao9/e1cAEj4mJmUFah6/PwTpUCszWgiDHsk9K+lSO cuZA== X-Gm-Message-State: AIkVDXLTPd3HnI9K5ZNCiF2hWZuel3ekkAgc5DODAGnO97LfCD9DBW/zKozSIlS2pLAsbgbyQwdugPOqBf6sAfIo X-Received: by 10.13.201.197 with SMTP id l188mr63332217ywd.31.1483429712837; Mon, 02 Jan 2017 23:48:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.221.65 with HTTP; Mon, 2 Jan 2017 23:48:32 -0800 (PST) In-Reply-To: <1482832175-27199-10-git-send-email-jerin.jacob@caviumnetworks.com> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-10-git-send-email-jerin.jacob@caviumnetworks.com> From: Jianbo Liu Date: Tue, 3 Jan 2017 15:48:32 +0800 Message-ID: To: Jerin Jacob Cc: dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin , Santosh Shukla Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2 09/29] eal/arm64: define I/O device memory barriers for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 07:48:33 -0000 On 27 December 2016 at 17:49, Jerin Jacob wrote: > CC: Jianbo Liu > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > index 78ebea2..ef0efc7 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > @@ -88,6 +88,12 @@ static inline void rte_rmb(void) > > #define rte_smp_rmb() dmb(ishld) > > +#define rte_io_mb() rte_mb() > + > +#define rte_io_wmb() rte_wmb() > + > +#define rte_io_rmb() rte_rmb() > + I think it's better to use outer shareable dmb for io barrier, instead of dsb.