From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f44.google.com (mail-vk0-f44.google.com [209.85.213.44]) by dpdk.org (Postfix) with ESMTP id 42A48DE6 for ; Wed, 2 Dec 2015 07:14:10 +0100 (CET) Received: by vkay187 with SMTP id y187so18726011vka.3 for ; Tue, 01 Dec 2015 22:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TYb6XzX57AYDWRKYyFkS5RDg3AXmlBy58/kHKG2msVY=; b=YyLCEW47jAPYfwmsIVylDx0hAuyQFSnrrd8wBas6rjSlEXtEnbtxc2m2FKEvI2tbJb XnebgjUcaHumMeQEqQ5p/nIFZ6/qT6mprKtpwGfYSx3+6E9fX/pjMIBqOBaSXv5ViTju R+aE2fDr/g9CY4mol8v4PDunFE/9BNfII49cj9jD0rpLdEbHS0KWwlh7FzEIpf4iL3GD homLCxezP78wLRRxmD0GX0WRStPrenxv2QeMkTprHZ+uxHYWpQRpAGIOwuA/40BtHxiu 6KPXD4xvOxYln4NgrFLdo3mOlbjsmqiJlQ1+nlO8rXOVAN9/52h5Y5kclDXLVyMa7Ywm EIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=TYb6XzX57AYDWRKYyFkS5RDg3AXmlBy58/kHKG2msVY=; b=aKdE4+D5Uyj9fgLIP7N2T9z+R6en2CCmPR+7skKztKvrZ23m+o+AdlxqxMCz/vX9Zc LHG7OpJY5jpGIjSXmtCBu/GYRvZOXKR51vgCpZxXZ093/lRvJIs/x5bOtUI8u6jV0aDJ 4wl0lJOby1sTsoFihkmLj6wcveYLYdO5WSNV1R1eeZ8I6uVQHh98sNno9bPgY2WthY3Q 44Qcpzuqr/x6N7r6WQlGf7dj4NmVnNNhPi3ZKNbKUFt7J1DMZm9dc/TFzIiDmWR5gX5f 6CqsiJfbZy6QtmOLXA2YYjnCja1EfhP7Nn0yJRJPZzbMUR1GFL1C00xr9V43+KvuBWDl khyA== X-Gm-Message-State: ALoCoQmYjXoWadAShq7+8UeYQI3u0nkP5jTMn9KLPSYAC1wZyw/vm5seHKmuehaH38TrYE227TDS MIME-Version: 1.0 X-Received: by 10.31.50.85 with SMTP id y82mr807013vky.48.1449036849801; Tue, 01 Dec 2015 22:14:09 -0800 (PST) Received: by 10.31.95.215 with HTTP; Tue, 1 Dec 2015 22:14:09 -0800 (PST) In-Reply-To: <20151201154611.230b6137@pcviktorin.fit.vutbr.cz> References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <1448995276-9599-3-git-send-email-jianbo.liu@linaro.org> <20151201144343.GA4883@localhost.localdomain> <20151201154611.230b6137@pcviktorin.fit.vutbr.cz> Date: Wed, 2 Dec 2015 14:14:09 +0800 Message-ID: From: Jianbo Liu To: Jan Viktorin Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/4] eal/acl: enable acl for armv7-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 06:14:10 -0000 On 1 December 2015 at 22:46, Jan Viktorin wrote: > On Tue, 1 Dec 2015 20:13:49 +0530 > Jerin Jacob wrote: > >> > enum rte_acl_classify_alg alg = RTE_ACL_CLASSIFY_DEFAULT; >> > >> > -#ifdef RTE_ARCH_ARM64 >> > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) >> > alg = RTE_ACL_CLASSIFY_NEON; >> >> I believe SIMD is optional in armv7. If true, select alg as >> RTE_ACL_CLASSIFY_NEON only when cpufeature NEON enabled. > > Yes. Or, probably, we can be happy with > > #if defined(__ARM_NEON_FP) > ... > #endif > > as it is currently done in rte_memcpy_32.h. > > Regards > Jan Athough optional for armv7, I believe there is NEON in most of the popular armv7a chips. Anyway, I will add the checking... Thanks!