From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f169.google.com (mail-yb0-f169.google.com [209.85.213.169]) by dpdk.org (Postfix) with ESMTP id 46E672E8A for ; Wed, 5 Apr 2017 07:45:52 +0200 (CEST) Received: by mail-yb0-f169.google.com with SMTP id m133so707909ybb.1 for ; Tue, 04 Apr 2017 22:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=O0GUKNLvze8zFBzn+UQt8EMc9Tkz7nqh5/oENqVHBws=; b=VeyLqFxk4PCSDGphOS8E3yqvbtkE4O6pVmWIaEZW25CdY0cnqCz/Gt9hCOqYybKOhl 83d2nZf1o/hf/Qqiro74Y5/OPeKTFUqvlMnZCGFslwMFrNQh5jNybPUDZkHaHDQFMwsW LOL5iMAkJ/M6k5qcV6YJZ3OORNQYrzsnfbvXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=O0GUKNLvze8zFBzn+UQt8EMc9Tkz7nqh5/oENqVHBws=; b=oI0X2QRQc4O5usyYS2jip4i6CgyUcRh3B4p/YFbmRqEjXbwbwM2hL+EpsLvb1aO+ed KYyevD0kTP5UzoZc/bOtjTNrZ8o3wW3Z48MmZrUiTEU62PeNT5UqEUMxckBb7yOCgqLn oGzQ1GcELu9zDjKNekhfRLX3jqnpYPWprzwYajw7Ei0MMc4E6ZLR9JeozyAoG73mAGsd 8QU+csZdTXDpMzyvFX6LzA5IzQpa6T7iIJvN4/XwFqGYBFSSgrsQ1nt5Kd14E0zm3yzh BUffX3+NxcpJtllDRMs/5c4fVP9yFA/DaW+Ga2sqIjRRcJmHXQMD4iTF7yoMuClUFIG6 1EnA== X-Gm-Message-State: AFeK/H2KXI5jh2JkYX9NtqgiwQzvuLFuFKjoLp/+Wm/3Ngf2mw269wHfF2b4qXDixuyzt93uGROty4sv7KvxOEQy X-Received: by 10.37.177.31 with SMTP id g31mr11896203ybj.94.1491371151556; Tue, 04 Apr 2017 22:45:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.173.103 with HTTP; Tue, 4 Apr 2017 22:45:51 -0700 (PDT) In-Reply-To: <8195227.QCEXF4XZSi@xps13> References: <20170404015516.7784-1-qi.z.zhang@intel.com> <7f5ba680-9b10-dde5-fef2-5b245f928c93@intel.com> <8195227.QCEXF4XZSi@xps13> From: Jianbo Liu Date: Wed, 5 Apr 2017 13:45:51 +0800 Message-ID: To: Thomas Monjalon Cc: Qi Zhang , dev@dpdk.org, Ferruh Yigit , "Wu, Jingjing" , "Zhang, Helin" , Jerin Jacob , Chao Zhu Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 05:45:52 -0000 On 5 April 2017 at 04:22, Thomas Monjalon wrote: > 2017-04-04 10:30, Ferruh Yigit: >> On 4/4/2017 2:55 AM, Qi Zhang wrote: >> > The patch set create new APIs that help to change the mapping from hardware >> > defined packet type to software defined packet type for i40e NICs. >> > Keep these APIs private is because currently they are only meaningful for >> > devices that support dynamic PTYPE configuration, which may not be a general >> > device feature. > [...] >> > Qi Zhang (3): >> > net/i40e: enable per dev PTYPE mapping table >> > net/i40e: configurable PTYPE mapping >> > app/testpmd: add CL for ptype mapping configure >> >> Series applied to dpdk-next-net/master, thanks. > > It does not compile for ARM (not tested for POWER): > drivers/net/i40e/i40e_rxtx_vec_neon.c: In function '_recv_raw_pkts_vec': > 229:2: error: unknown type name 'uint32' > uint32 *ptype_tbl = rxq->vsi->adapter->ptype_tbl; > It must be uint32_t. > Given that > - it changes NEON and Altivec code > - it does not compile on ARM > - there is no Ack from NEON or Altivec maintainers (they were not Cc'ed) > I really doubt it has been tested. > That's why it won't be in RC1. > > If NEON and Altivec maintainers agree, we can give it a chance for RC2. > Other than the above error on ARM: Acked-by: Jianbo Liu > PS: please use --in-reply-to to let us check the discussion history.