From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f175.google.com (mail-yw0-f175.google.com [209.85.161.175]) by dpdk.org (Postfix) with ESMTP id 1DE1C2E83 for ; Thu, 11 May 2017 12:01:25 +0200 (CEST) Received: by mail-yw0-f175.google.com with SMTP id b68so10057444ywe.3 for ; Thu, 11 May 2017 03:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zE4PbWyAMPUE8Vd8SV3VBqBN4hmMpKN/TfC047uc2GU=; b=WvdqXUc1xvqQtziDDS6uOcTKZorH8OCH5D65EBia/gfhvfplb7cZexOdDQ327R/eM9 RQQlSJn4/g01WUS6KyY2VDyHWhAJEeE9U9CSzeb4KWhA8aN0/lX5LW70bg9v1+t3AGuU PG0+GwKRUTXOKKq9MoQJ5gfg6VVsoEIc85Qy4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zE4PbWyAMPUE8Vd8SV3VBqBN4hmMpKN/TfC047uc2GU=; b=BowrLXpyLWCwzJacHql4tdh731LmKJxVEiNAbstRlu9NX4N9pqJ1tfg8m9GOw9WHt6 0xdNkt5FeaB9lbEGR/gEfPYkmu9qKD/p0h9yvZ3P/e+hj/kaH7HdfUI5H8nDYa/YgVhA 6wOw2NGKN16L/ODRLo0w/sQ8uQHk0ZEF9qn+RxDeNRNdqh9oCtexWuoLDCCEC6EKq3+2 b0rJK1Trhp6i1QPJatNv7v3MvZM/bK1mrK9Ze8VikaT3kjfz5Pnk+ae57piybuQvsgvs urGoLrT6uQmOorJawU3Do3w/Iru3saiqpIYVxjX7csohWzx7Cx0Si/L7qK4EzihHrStw K7nA== X-Gm-Message-State: AODbwcBDoS1AR2bcvWyErIg2DW4E/lHiG6yJxB+IdpscOEmwubA7tGz+ 0OBbrj2uCI6J39LlLrItZNAu6D4SdChoAhiajQ== X-Received: by 10.129.173.74 with SMTP id l10mr8233255ywk.114.1494496885243; Thu, 11 May 2017 03:01:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Thu, 11 May 2017 03:01:24 -0700 (PDT) In-Reply-To: <1494496145.4256.9.camel@caviumnetworks.com> References: <1493709255-8887-1-git-send-email-jianbo.liu@linaro.org> <1494494708-20642-1-git-send-email-jianbo.liu@linaro.org> <1494494708-20642-6-git-send-email-jianbo.liu@linaro.org> <1494496145.4256.9.camel@caviumnetworks.com> From: Jianbo Liu Date: Thu, 11 May 2017 18:01:24 +0800 Message-ID: To: "Sekhar, Ashwin" Cc: "tomasz.kantecki@intel.com" , "Jacob, Jerin" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 10:01:26 -0000 On 11 May 2017 at 17:49, Sekhar, Ashwin wrote: > Hi Jianbo, > > Thanks for v3. Small compilation error. See inline comment. Otherwise > it looks fine. > > On Thu, 2017-05-11 at 17:25 +0800, Jianbo Liu wrote: >> Use ARM NEON intrinsics to accelerate l3 fowarding. >> >> Signed-off-by: Jianbo Liu >> --- > [...] > >> +/** >> + * Process one packet: >> + * Update source and destination MAC addresses in the ethernet >> header. >> + * Perform RFC1812 checks and updates for IPV4 packets. >> + */ >> +static inline void >> +process_packet(struct rte_mbuf *pkt, uint16_t *dst_port) >> +{ >> + struct ether_hdr *eth_hdr; >> + uint32x4_t te, ve; >> + >> + eth_hdr = rte_pktmbuf_mtod(pkt, struct ether_hdr *); >> + >> + te = vld1q_u32((uint32_t *)eth_hdr); >> + ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]); >> + >> + >> + rfc1812_process((struct ipv4_hdr *)(eth_hdr + 1), dst_port, >> + pkt->packet_type); >> + >> + ve = vcopyq_lane_u32(ve, 3, te, 3); > Compilation error here. This should be vcopyq_laneq_u32 (Extra q after > lane) No vcopyq_laneq_u32 in arm_neon.h of my environment. I thought it's a typo so I changed. my gcc version 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC). What about yours? >> + vst1q_u32((uint32_t *)eth_hdr, ve); >> +} >> + > [...]