* [PATCH] examples/flow_filtering: fix make clean
@ 2025-03-29 19:53 Tanzeel Ahmed
2025-03-31 8:45 ` Thomas Monjalon
2025-04-03 7:01 ` Shani Peretz
0 siblings, 2 replies; 4+ messages in thread
From: Tanzeel Ahmed @ 2025-03-29 19:53 UTC (permalink / raw)
To: orika; +Cc: dev, Tanzeel Ahmed
make clean is unable to delete build directory
because *.o files are not removed.
The other way to fix this would be to add all the
c files into SRCS-y.
Signed-off-by: Tanzeel Ahmed <tanzeelahmed713@gmail.com>
---
examples/flow_filtering/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/flow_filtering/Makefile b/examples/flow_filtering/Makefile
index 9998ed10b5..653e3319a2 100644
--- a/examples/flow_filtering/Makefile
+++ b/examples/flow_filtering/Makefile
@@ -50,5 +50,5 @@ build:
.PHONY: clean
clean:
- rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
+ rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared build/*.o
test -d build && rmdir -p build || true
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] examples/flow_filtering: fix make clean
2025-03-29 19:53 [PATCH] examples/flow_filtering: fix make clean Tanzeel Ahmed
@ 2025-03-31 8:45 ` Thomas Monjalon
2025-03-31 21:56 ` Tanzeel Ahmed
2025-04-03 7:01 ` Shani Peretz
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2025-03-31 8:45 UTC (permalink / raw)
To: Tanzeel Ahmed; +Cc: orika, dev, Shani Peretz
29/03/2025 20:53, Tanzeel Ahmed:
> make clean is unable to delete build directory
> because *.o files are not removed.
>
> The other way to fix this would be to add all the
> c files into SRCS-y.
How adding all C files into SRCS-y would help?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] examples/flow_filtering: fix make clean
2025-03-31 8:45 ` Thomas Monjalon
@ 2025-03-31 21:56 ` Tanzeel Ahmed
0 siblings, 0 replies; 4+ messages in thread
From: Tanzeel Ahmed @ 2025-03-31 21:56 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: orika, dev, Shani Peretz
On Mon, 31 Mar 2025 at 13:45, Thomas Monjalon:
>
> 29/03/2025 20:53, Tanzeel Ahmed:
> > make clean is unable to delete build directory
> > because *.o files are not removed.
Removing .o files is a simpler fix, as in the patch.
> > The other way to fix this would be to add all the
> > c files into SRCS-y.
>
> How adding all C files into SRCS-y would help?
We can bypass the obj files generation and use the current clean as it is
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] examples/flow_filtering: fix make clean
2025-03-29 19:53 [PATCH] examples/flow_filtering: fix make clean Tanzeel Ahmed
2025-03-31 8:45 ` Thomas Monjalon
@ 2025-04-03 7:01 ` Shani Peretz
1 sibling, 0 replies; 4+ messages in thread
From: Shani Peretz @ 2025-04-03 7:01 UTC (permalink / raw)
To: Tanzeel Ahmed, Ori Kam, Thomas Monjalon; +Cc: dev
> -----Original Message-----
> From: Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> Sent: Saturday, 29 March 2025 22:54
> To: Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> Subject: [PATCH] examples/flow_filtering: fix make clean
>
> External email: Use caution opening links or attachments
>
>
> make clean is unable to delete build directory because *.o files are not
> removed.
>
> The other way to fix this would be to add all the c files into SRCS-y.
>
> Signed-off-by: Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> ---
> examples/flow_filtering/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/flow_filtering/Makefile
> b/examples/flow_filtering/Makefile
> index 9998ed10b5..653e3319a2 100644
> --- a/examples/flow_filtering/Makefile
> +++ b/examples/flow_filtering/Makefile
> @@ -50,5 +50,5 @@ build:
>
> .PHONY: clean
> clean:
> - rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
> + rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
> + build/*.o
> test -d build && rmdir -p build || true
> --
> 2.25.1
I checked and looks good on my side
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-03 7:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-29 19:53 [PATCH] examples/flow_filtering: fix make clean Tanzeel Ahmed
2025-03-31 8:45 ` Thomas Monjalon
2025-03-31 21:56 ` Tanzeel Ahmed
2025-04-03 7:01 ` Shani Peretz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).