From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cm01fe.IST.Berkeley.EDU (cm01fe.IST.Berkeley.EDU [169.229.218.142]) by dpdk.org (Postfix) with ESMTP id 474A45A30 for ; Tue, 21 Apr 2015 06:58:22 +0200 (CEST) Received: from mail-pd0-f171.google.com ([209.85.192.171]) by cm01fe.ist.berkeley.edu with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.76) (auth plain:sangjin@berkeley.edu) (envelope-from ) id 1YkQGK-0004gA-3a for dev@dpdk.org; Mon, 20 Apr 2015 21:58:21 -0700 Received: by pdea3 with SMTP id a3so230223000pde.3 for ; Mon, 20 Apr 2015 21:58:19 -0700 (PDT) X-Received: by 10.67.22.72 with SMTP id hq8mr34915040pad.154.1429592299763; Mon, 20 Apr 2015 21:58:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sangjin Han Date: Tue, 21 Apr 2015 04:58:18 +0000 Message-ID: To: Greg Smith , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] QoS Question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2015 04:58:22 -0000 Hi, According to "21.2.4.6.6.2", it seems that the implementation is supposed to achieve max-min fairness. In your example, the effective cap of single active pipe should be 1Mbps, given the total demand of other 1999 pipes is less than 999Mbps. Sangjin On Mon, Apr 20, 2015 at 9:40 AM Greg Smith wrote: > Hi DPDK team, > > The docs on QoS (http://dpdk.org/doc/guides/prog_guide/qos_framework.html# > ) describe the traffic class (TC) as follows: > 1 - The TCs of the same pipe handled in strict priority order. > 2 - Upper limit enforced per TC at the pipe level. > 3 - Lower priority TCs able to reuse pipe bandwidth currently unused by > higher priority TCs. > 4 - When subport TC is oversubscribed (configuration time event), pipe TC > upper limit is capped to a dynamically adjusted value that is shared by all > the subport pipes. > > Can someone describe how and when the TC upper limit is "dynamically" > changed? > > For example, assume there's a 1Gb/s port and a single 1Gb/s subport and > 2000 pipes each of 1Mb/s (total pipes = 2Gb/s which is > the 1Gb/s subport > which I think means "oversubscribed" as used in the doc). Each Pipe has a > single TC. > In that case, would each pipe be shaped to an upper limit of 0.5 Mb/s? > What if there was no traffic on 1999 pipes, would the single active pipe > still be limited to 0.5 Mb/s? > What if the number of pipes changes without restarting the OS, how does > that change the behavior? > > BTW, great docs overall, thanks for writing those up. > > Thanks, > > Greg Smith > > > >