From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f173.google.com (mail-qk0-f173.google.com [209.85.220.173]) by dpdk.org (Postfix) with ESMTP id B467EC368 for ; Mon, 6 Apr 2015 21:01:40 +0200 (CEST) Received: by qkhg7 with SMTP id g7so30032828qkh.2 for ; Mon, 06 Apr 2015 12:01:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Pw53hUhBAopTSWeiyhakswN/j+tWHlFlexKCPANNOQc=; b=gM8vkliXeSzwDNGvGb/7BZv71J2FZQev6K1Izeqe2+98eDGgnZSnb5u5g69gntNGp4 pg0FKFVE429KYUVwWz+cV30hKEV/efmDLfAmiExita4i3Oahmf7G8+l9HnZu0wgR3u/j IgciebCfA9yJxWFZnIvsn8oIsRKQC7NeHI7IfMv68Lsu3qO8v8/ZNL5OpbG4+1dJtle2 3vvkkXW1AWus8nTqN2meo7dUKiCDvxcUmb31F3mMV1RlJ7M/yn4nbQMzZSvqyNJ8yOVt G7atIOJMbRIoF3NDtQS24/MLKgui9X5B6Rhi1E2MEcwvzZqTWmD49iTRa463vT+gjLrJ andw== X-Gm-Message-State: ALoCoQmuo199N+Ec8H2eyb12n+SmDvup5+hbkEgI5CPIUP2aKsLW7mDFpYb+H3k4gu6l/NJHVn/p MIME-Version: 1.0 X-Received: by 10.55.52.14 with SMTP id b14mr30938337qka.63.1428346900267; Mon, 06 Apr 2015 12:01:40 -0700 (PDT) Received: by 10.140.35.230 with HTTP; Mon, 6 Apr 2015 12:01:40 -0700 (PDT) In-Reply-To: <20150324135252.GA11053@hmsreliant.think-freely.org> References: <1426194348-4406-1-git-send-email-syuu@cloudius-systems.com> <1426908185-27940-1-git-send-email-syuu@cloudius-systems.com> <1426908185-27940-6-git-send-email-syuu@cloudius-systems.com> <20150324135252.GA11053@hmsreliant.think-freely.org> Date: Tue, 7 Apr 2015 04:01:40 +0900 Message-ID: From: Takuya ASADA To: Neil Horman Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCHv2 5/8] add OSv support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2015 19:01:41 -0000 On Tue, Mar 24, 2015 at 10:52 PM, Neil Horman wrote: > On Sat, Mar 21, 2015 at 12:23:02PM +0900, Takuya ASADA wrote: > > Adding OSv support. > > Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access > devices, allocate contiguous memory, etc. > > > > Signed-off-by: Takuya ASADA > > --- > > diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > b/lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h > > similarity index 100% > > copy from lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > > copy to lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > b/lib/librte_eal/osvapp/eal/rte_eal_version.map > > similarity index 92% > > copy from lib/librte_eal/bsdapp/eal/rte_eal_version.map > > copy to lib/librte_eal/osvapp/eal/rte_eal_version.map > > index 67b6a6c..ebb584a 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/osvapp/eal/rte_eal_version.map > > @@ -31,24 +31,26 @@ DPDK_2.0 { > > rte_eal_get_physmem_layout; > > rte_eal_get_physmem_size; > > rte_eal_has_hugepages; > > - rte_eal_hpet_init; > > rte_eal_init; > > rte_eal_iopl_init; > > rte_eal_lcore_role; > > rte_eal_mp_remote_launch; > > rte_eal_mp_wait_lcore; > > + rte_eal_parse_devargs_str; > > + rte_eal_pci_close_one; > > rte_eal_pci_dump; > > rte_eal_pci_probe; > > + rte_eal_pci_probe_one; > > rte_eal_pci_register; > > rte_eal_pci_unregister; > > rte_eal_process_type; > > rte_eal_remote_launch; > > rte_eal_tailq_lookup; > > rte_eal_tailq_register; > > + rte_eal_vdev_init; > > + rte_eal_vdev_uninit; > > rte_eal_wait_lcore; > > rte_exit; > > - rte_get_hpet_cycles; > > - rte_get_hpet_hz; > > rte_get_tsc_hz; > > rte_hexdump; > > rte_intr_callback_register; > > @@ -86,9 +88,6 @@ DPDK_2.0 { > > rte_thread_get_affinity; > > rte_thread_set_affinity; > > rte_vlog; > > - rte_xen_dom0_memory_attach; > > - rte_xen_dom0_memory_init; > > - test_mp_secondary; > > > I understand removing symbols that you don't support, but why are you > adding the > vdev, pci and parsing symbols? I don't see you using them anywhere in your > code... > This was because I copied rte_eal_version.map from linuxapp, but git format-patch generated diff from bsdapp. But osvapp don't have these symbols, so I dropped these lines. Please check v3 patchset which I just posted. > Neil > >