From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <matejvido@gmail.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id A06725A68
 for <dev@dpdk.org>; Fri, 20 Nov 2015 20:25:16 +0100 (CET)
Received: by wmvv187 with SMTP id v187so85900119wmv.1
 for <dev@dpdk.org>; Fri, 20 Nov 2015 11:25:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=yaySc0xX1Pu8Vn5ATxB0X0TB7EOXjz0pP0SG21Fb3FQ=;
 b=MFQw8odGi2P+WtyGaL4zn0GVZLsy7HBPr2B9xReXrdd6Mewe0NoQC82yy6dZufrmv6
 7Xu7YJuJTFdE5jE9aMKwdCvGncVZUnjpxcLcqlLgAayD7HEOmQDLpZhJFZ1eFGoy86ST
 ylcMU5BzZgu1aphHYsMH9Wk41GQ7LwhPxwINSOi6HLBN7BXnG+2fXcYApS5kZMNUNWjm
 AXQpp0DBH7wDhaMhqMe9dFOVA2427NEwj8/JHB5itftIOxD1dwDJovFZAWs7WNUcO9J+
 0AmcXXEgaDLegzOkvhwePqGJ+ceVEBPkPKKVaxpUxyIRZiXRrUvHhE/J8Bs1a/RAng6O
 4Tcw==
MIME-Version: 1.0
X-Received: by 10.28.55.200 with SMTP id e191mr4051077wma.83.1448047516457;
 Fri, 20 Nov 2015 11:25:16 -0800 (PST)
Received: by 10.194.95.198 with HTTP; Fri, 20 Nov 2015 11:25:16 -0800 (PST)
In-Reply-To: <2187677.AtrVqmgt0N@xps13>
References: <1442565172-5338-1-git-send-email-matejvido@gmail.com>
 <1447165098-6412-1-git-send-email-matejvido@gmail.com>
 <1447165098-6412-2-git-send-email-matejvido@gmail.com>
 <2187677.AtrVqmgt0N@xps13>
Date: Fri, 20 Nov 2015 20:25:16 +0100
Message-ID: <CAPb1KsTAKVPYYgoXmxcKFLuKOeeZeahNRA9CM7w2=qaqNWw8vw@mail.gmail.com>
From: Matej Vido <matejvido@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org, Viktor Pus <pus@cesnet.cz>
Subject: Re: [dpdk-dev] [PATCH v3 1/6] szedata2: add new poll mode driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 19:25:16 -0000

Hi,

2015-11-20 16:04 GMT+01:00 Thomas Monjalon <thomas.monjalon@6wind.com>:

> Hi,
>
> I'm doing some last checks before merging.
>
> The libsze2 depends on libcommlbr so it would be better to list it on
> https://www.liberouter.org/technologies/netcope/access-to-libsze2-library


Thank you for reminding, I will edit it.


>
>
> A patch is needed in mk/ to allow linking these dependencies from a
> non-standard directory: http://dpdk.org/dev/patchwork/patch/9023
>
> As only 64-bit versions of the libraries are provided, I guess we
> could mention it is currently supported only on x86-64.
>

I agree. Should I update the documentation and send a patch?


>
>
> 2015-11-10 15:18, Matej Vido:
> > +static void
> > +eth_stats_get(struct rte_eth_dev *dev,
> > +             struct rte_eth_stats *igb_stats)
> > +{
>
> igb_stats is a name inherited from old times. It is related to the first
> DPDK driver (igb).
> I will rename it to "stats".
>
> [...]
> > +       long int value;
> > +
> > +       value = strtol(mask_str, &endptr, 0);
> > +       if (*endptr != '\0' || value > UINT32_MAX || value < 0)
>
> This check would not compile in 32-bit environment (which is not
> supported).
>
> [...]
> > +static int
> > +rte_eth_from_szedata2(const char *name,
> > +               struct rxtx_szedata2 *szedata2,
> > +               const unsigned numa_node)
> > +{
> > +       struct pmd_internals *internals = NULL;
> > +       struct rte_eth_dev *eth_dev = NULL;
> > +       struct rte_eth_dev_data *data = NULL;
>
> This data variable is not used before the patch 4/6.
> I will move it.
>

Thanks for handling these changes.


Regards,
Matej