From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6595FA04B0; Thu, 13 Aug 2020 20:08:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 950871C10E; Thu, 13 Aug 2020 20:07:38 +0200 (CEST) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by dpdk.org (Postfix) with ESMTP id 5C0171C0D5 for ; Thu, 13 Aug 2020 20:07:37 +0200 (CEST) Received: by mail-ed1-f65.google.com with SMTP id cq28so4876021edb.10 for ; Thu, 13 Aug 2020 11:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=G8k0DEJbV5Zn1n+WgWMQkwlVICha6R+De0j14n8qiDk=; b=lV17FZCe4RbjjmXYFVDMxx59s0c0AhJZJrMv41nsLlxUDtcjFgLhVGHxXcdXJFnaCu pm7ydQ9kcd9j+bOPYNOotTp2Y43Ro48XD6z2dUWgjFWszOckvJ3jT7zXfU82BMbMp2kT TkDMoO9NJvY2uPj3TIlkMgY/Pph7EucFFwTJM9W9caA/6MZoo20jrfJ4CTC3A5shYUzH MHpxI9RX6ktBx0ujaskXoRsewP6XOZ9F2uFwYm8U7/PVMIW3iOz0vUIq+p8mS5jhHcK/ JCRbo/PWwUSYoq/Z960AJjtZGfVmuBDvyi5+d1vAgRzAG5GJgB1eraFhmD4wonWDtkmq sWdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=G8k0DEJbV5Zn1n+WgWMQkwlVICha6R+De0j14n8qiDk=; b=m0QZ5wJpMotmbE4Qgjr86TKNx8HA6RJ+OGfv9f8vBwcSCgAkPYTTk7Hm0hpfhWVhbI eVGMpcf8h6sg6O+qmlTYPMOSrQqj/eZ+RgebuBXvNWLz364GjN6AOSv/F3p12/+VUFgl EdUykLuEYIBlLTNP6WpKCj/EyZ+8+gVncB0c2q9fN1Uyhc6CsvbHIf9VNUpCzmaEioFz IpDPQCxddTKfHIkLcXdqmeEQUQPzhvJDdTCB/Np7YB+5CblDMazhlhUTIa5g0oqb0MQV 89poxTWeJFN5CP4WzdY8r378SOlOrT9BzDK9ufHMxrMfzZiLvLuKlocCi8ClmPW6kQe1 DPDA== X-Gm-Message-State: AOAM532cKS3Hg3g2Xa2fsK0RBUyupaDjtJJ7iD1ciqkwWWr8FEIEmS+S fWxL9FMCwdat+FmDev6xSrIBa6N7qpedJJx7MmRYRmwusrI= X-Google-Smtp-Source: ABdhPJwVuDufH0sfkZTiwzoi6Oo5E2QfytRtCRzLO3oPuCuqWkavSRsNAIFGg1oCsIxqX0LTxuIf+YfWqkvym6f5mic= X-Received: by 2002:aa7:c697:: with SMTP id n23mr5745002edq.50.1597342057040; Thu, 13 Aug 2020 11:07:37 -0700 (PDT) MIME-Version: 1.0 References: <20200812163729.4933-1-ar@semihalf.com> In-Reply-To: <20200812163729.4933-1-ar@semihalf.com> From: Marcin Wojtas Date: Thu, 13 Aug 2020 20:07:25 +0200 Message-ID: To: Artur Rojek Cc: Michal Krawczyk , Guy Tzalik , Igor Chauskin , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, =C5=9Br., 12 sie 2020 o 18:37 Artur Rojek napisa=C5=82(a)= : > > From: Michal Krawczyk > > This patch adds a missing LLQ-related check in the > ena_com_is_doorbell_needed() routine, which is relevant for the feature > supported by the next generation HW of the ENA. > > Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features") > CC: stable@dpdk.org > > Signed-off-by: Michal Krawczyk > [Extracted from a bigger patch] > Signed-off-by: Artur Rojek Reviewed-by: Marcin Wojtas > --- > drivers/net/ena/base/ena_eth_com.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/en= a_eth_com.h > index e37b642d4..3d66237b8 100644 > --- a/drivers/net/ena/base/ena_eth_com.h > +++ b/drivers/net/ena/base/ena_eth_com.h > @@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct = ena_com_io_sq *io_sq, > llq_info =3D &io_sq->llq_info; > num_descs =3D ena_tx_ctx->num_bufs; > > - if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx))) > + if (llq_info->disable_meta_caching || > + unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx))) > ++num_descs; > > if (num_descs > llq_info->descs_num_before_header) { > -- > 2.28.0 >