From: "Mauricio Vásquez" <mauricio.vasquezbernal@studenti.polito.it>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")
Date: Wed, 30 Mar 2016 11:13:14 +0200 [thread overview]
Message-ID: <CAPwdgqgwDSzwzKpR_Lin05_wnzqvV6QgLYGFGcuT7Bu0FeGoTg@mail.gmail.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E45123697820D8762@IRSMSX109.ger.corp.intel.com>
Hi Anatoly,
Thank you very much, I did not take into account that detail.
I have two additional concerns about it:
1. I think it is possible to have a race condition. The memzone is marked
as not freeable after it has been added to the ivshmem device, then it is
possible to free the memzone just after it has been added to the metadata
but before it is marked as not freeable.
Shouldn't the memzone be marked before adding the memzone to the ivshmem
device?
2. Are the #ifdefs necessary?, we already are in a file that will only
compiled when ivshmem is enabled.
Thanks,
Mauricio Vasquez,
On Wed, Mar 30, 2016 at 10:29 AM, Burakov, Anatoly <
anatoly.burakov@intel.com> wrote:
> Hi Mauricio,
>
>
>
> You’re not missing anything. It would be done this way, if the memzone
> parameter wasn’t const. But it is const, so we have to find the memzone in
> config to edit it.
>
>
>
> Thanks,
>
> Anatoly
>
>
>
> *From:* Mauricio Vásquez [mailto:mauricio.vasquezbernal@studenti.polito.it]
>
> *Sent:* Wednesday, March 30, 2016 9:22 AM
> *To:* dev@dpdk.org
> *Cc:* Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Burakov, Anatoly <
> anatoly.burakov@intel.com>
> *Subject:* Question about cd10c42eb5bc ("mem: fix ivshmem freeing")
>
>
>
> Dear All,
>
> I was looking at that patch, I can understand its functionality but not
> its implementation..
>
> Why to calculate idx?, Just doing "mz->ioremap_addr = mz->phys_addr" would
> not be sufficient? After all, the goal is to mark the memzone as used by
> ivshmem to forbid freeing it.
>
> Please corrected if I am missing something.
>
> Thank you,
>
> Mauricio Vasquez,
>
next prev parent reply other threads:[~2016-03-30 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 8:21 Mauricio Vásquez
2016-03-30 8:29 ` Burakov, Anatoly
2016-03-30 9:13 ` Mauricio Vásquez [this message]
2016-03-30 12:10 ` Burakov, Anatoly
2016-04-01 8:18 ` Mauricio Vásquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPwdgqgwDSzwzKpR_Lin05_wnzqvV6QgLYGFGcuT7Bu0FeGoTg@mail.gmail.com \
--to=mauricio.vasquezbernal@studenti.polito.it \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).