From: "Mauricio Vásquez" <mauricio.vasquezbernal@studenti.polito.it>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: [dpdk-dev] Ring PMD: why are stats counters atomic?
Date: Tue, 10 May 2016 11:13:08 +0200 [thread overview]
Message-ID: <CAPwdgqjR1eSt5ewcdm93WNT-ZX7ychWUSdSZvbU22Rapat3ybQ@mail.gmail.com> (raw)
Hello,
Per-queue stats counters are defined as rte_atomic64_t, in the tx/rx
functions, they are atomically increased if the rings have the multiple
consumers/producer flag enabled.
According to the design principles, the application should not invoke those
functions on the same queue on different cores, then I think that atomic
increasing is not necessary.
Is there something wrong with my reasoning?, If not, I am willing to send a
patch.
Thank you very much,
Mauricio V,
next reply other threads:[~2016-05-10 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:13 Mauricio Vásquez [this message]
2016-05-10 9:36 ` Bruce Richardson
2016-05-16 13:12 ` Mauricio Vásquez
2016-05-16 13:16 ` Bruce Richardson
2016-08-15 20:41 ` Mauricio Vásquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPwdgqjR1eSt5ewcdm93WNT-ZX7ychWUSdSZvbU22Rapat3ybQ@mail.gmail.com \
--to=mauricio.vasquezbernal@studenti.polito.it \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).