DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andriy Berestovskyy <aber@semihalf.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] ixgbe: account more Rx errors Issue
Date: Fri, 4 Sep 2015 18:58:40 +0200	[thread overview]
Message-ID: <CB900CE7-0595-48F1-B521-40B1E80AF73F@semihalf.com> (raw)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A508A73@IRSMSX109.ger.corp.intel.com>

Hi Maryam,
Please see below.

> XEC counts the Number of receive IPv4, TCP, UDP or SCTP XSUM errors

Please note than UDP checksum is optional for IPv4, but UDP packets with zero checksum hit XEC.

> And general crc errors counts Counts the number of receive packets with CRC errors.

Let me explain you with an example.

DPDK 2.0 behavior:
host A sends 10M IPv4 UDP packets (no checksum) to host B
host B stats: 9M ipackets + 1M ierrors (missed) = 10M

DPDK 2.1 behavior:
host A sends 10M IPv4 UDP packets (no checksum) to host B
host B stats: 9M ipackets + 11M in ierrors (1M missed + 10M XEC) = 20M?

> So our options are we can:
> 1. Add only one of these into the error stats.
> 2. We can introduce some cooking of stats in this scenario, so only add either or if they are equal or one is higher than the other.
> 3. Add them all which means you can have more errors than the number of received packets, but TBH this is going to be the case if your packets have multiple errors anyway.

4. ierrors should reflect NIC drops only.
XEC does not count drops, so IMO it should be removed from ierrors.

Please note that we still can access the XEC using rte_eth_xstats_get()


Regards,
Andriy

  reply	other threads:[~2015-09-04 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04  9:38 Andriy Berestovskyy
2015-09-04 12:44 ` Tahhan, Maryam
2015-09-04 16:58   ` Andriy Berestovskyy [this message]
2015-09-06 17:15     ` Tahhan, Maryam
2015-09-07  8:30       ` Olivier MATZ
2015-09-07 11:44         ` Tahhan, Maryam
2015-09-09 17:43           ` Kyle Larose
2015-09-14  9:50             ` Tahhan, Maryam
2015-10-22  8:21               ` Martin Weiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB900CE7-0595-48F1-B521-40B1E80AF73F@semihalf.com \
    --to=aber@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=maryam.tahhan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).