From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id AB99E1B727 for ; Mon, 17 Dec 2018 17:26:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 08:26:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,366,1539673200"; d="scan'208";a="111085229" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 17 Dec 2018 08:26:37 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 08:26:37 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.209]) by FMSMSX113.amr.corp.intel.com ([169.254.13.137]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 08:26:36 -0800 From: "Wiles, Keith" To: Luca Boccassi CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK Thread-Index: AQHUlWdO/reySZzRC0GuxdDtx7Cfp6WCdxiAgAEuvQA= Date: Mon, 17 Dec 2018 16:26:36 +0000 Message-ID: References: <20181216174604.91445-1-keith.wiles@intel.com> <1544998977.4766.10.camel@debian.org> In-Reply-To: <1544998977.4766.10.camel@debian.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.55] Content-Type: text/plain; charset="us-ascii" Content-ID: <0F77D5CD3D0012448555514C1C51C5E7@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 16:26:39 -0000 > On Dec 16, 2018, at 4:22 PM, Luca Boccassi wrote: >=20 > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote: >> --- /dev/null >> +++ b/lib/librte_dfs/meson.build >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2018 Intel Corporation >> + >> +version =3D 1 >=20 > You can leave the version out if it's 1, it's the default I understand that maybe the default, but it should not hurt anything and th= en the developer can update it as needed, right? >=20 >> --- /dev/null >> +++ b/lib/librte_dfs/Makefile >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2018 Intel Corporation >> + >> +include $(RTE_SDK)/mk/rte.vars.mk >> + >> +# library name >> +LIB =3D librte_dfs.a >> + >> +CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) -O3 >> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=3D64 >> +CFLAGS +=3D -D_GNU_SOURCE >> +CFLAGS +=3D -I$(RTE_SDK)/drivers/bus/pci >> +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev >> -lrte_utils >> +LDLIBS +=3D -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev >> +LDLIBS +=3D -lpthread >> +LDLIBS +=3D $(shell pkg-config --libs-only-l fuse3) >> +LDLIBS +=3D $(shell pkg-config --libs-only-l jansson) >=20 > Why --libs-only-l ? If the libraries are not installed in the canonical > path (eg: build-root-without-chroot) it will break as it won't use the > -L OK, will look at this one and see if I had a reason to use libs-only-l. >=20 > --=20 > Kind regards, > Luca Boccassi Regards, Keith