[dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query

[dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query

[Shahaf Shuler]

IBV_WQ_FLAGS_SCATTER_FCS is a WQ flag to be used to configure the CRC
strip on a queue upon creation.

Using IBV_RAW_PACKET_CAP_SCATTER_FCS instead to query to capability.
Even though this is RAW_QP capability, it is being used by rdma-core to
indicate for both RAW_QP and WQ.

Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
Cc: stable@dpdk.org

Reported-by: Alex Rosenbaum <alexr@mellanox.com>
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 544599b01..02082c107 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -895,9 +895,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
 		DEBUG("VLAN stripping is %ssupported",
 		      (config.hw_vlan_strip ? "" : "not "));
 
-		config.hw_fcs_strip =
-				!!(device_attr_ex.orig_attr.device_cap_flags &
-				IBV_WQ_FLAGS_SCATTER_FCS);
+		config.hw_fcs_strip = !!(device_attr_ex.raw_packet_caps &
+					 IBV_RAW_PACKET_CAP_SCATTER_FCS);
 		DEBUG("FCS stripping configuration is %ssupported",
 		      (config.hw_fcs_strip ? "" : "not "));
 
-- 
2.12.0

Re: [dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query

[Yongseok Koh]

> On Feb 1, 2018, at 10:53 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> IBV_WQ_FLAGS_SCATTER_FCS is a WQ flag to be used to configure the CRC
> strip on a queue upon creation.
> 
> Using IBV_RAW_PACKET_CAP_SCATTER_FCS instead to query to capability.
> Even though this is RAW_QP capability, it is being used by rdma-core to
> indicate for both RAW_QP and WQ.
> 
> Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
> Cc: stable@dpdk.org
> 
> Reported-by: Alex Rosenbaum <alexr@mellanox.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks