From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com [209.85.213.176]) by dpdk.org (Postfix) with ESMTP id E4B917DFB for ; Mon, 3 Nov 2014 17:52:54 +0100 (CET) Received: by mail-ig0-f176.google.com with SMTP id l13so5466375iga.9 for ; Mon, 03 Nov 2014 09:02:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/nXIj94hw2sj8XbKkWIs4ah2cHHIGS+9sib2SCUySzs=; b=F0mOD7qCVXkQm74ODnDzGje9ime7oXO/CODEKQmwti1Q5rqsCY6vtKWkEh0uc+iEu3 uY3uYycGiG+1PB7J/73XRA2HX1Nv2raqwi8kay4VimZ9bKImqgHkYps1SNMfgd6O0dcH nTikiuUaHtRiwzWBqspC5waLIq1NqfoEFeFxI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=/nXIj94hw2sj8XbKkWIs4ah2cHHIGS+9sib2SCUySzs=; b=QivwCOu94UIHyMXr2k83bSKXVKvlyqgOU3rPRSEnH7o9bk8H+3QhpiTtDOk1C9Bzrs 1VPAd0uAesgmL33ss1opungoKBtHfjA6n/Wa7+9ivxFW/sOuqcSFFpwrfZW4QZ5vUdZC nNULJN/VXeEPz6ZBwgFnDZ4fNb33zFyXe99zdcF/42SFgBh+KHLYm4685Q2M2AtqDr2+ k6rvaW5MMAOhDJak7NT0EnmfpTlLVy4D/gWRQS7807eriQkeJipqzCqxFabgdR5cgF+P AMszs7d/eLYyk5n6XcH/ao+NdKUFNK3nzngGGQwoVEBNqEQm5GM89LyquVpHTHXZbuIR Cn4A== X-Gm-Message-State: ALoCoQkT7FSAswnsnQEk7fBfrRYyQe2vA5zNffVuqSHsHtXfkLa7inxdECd7ibtfMFsSyGy+NtyN X-Received: by 10.107.164.71 with SMTP id n68mr49293340ioe.17.1415034129178; Mon, 03 Nov 2014 09:02:09 -0800 (PST) Received: from [172.31.1.110] (hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net. [47.55.100.128]) by mx.google.com with ESMTPSA id i184sm1931905ioi.33.2014.11.03.09.02.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 09:02:08 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Content-Type: text/plain; charset=utf-8 From: Aaron Campbell In-Reply-To: <53CFA637.1090706@neclab.eu> Date: Mon, 3 Nov 2014 13:02:08 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <53CD3E26.1060708@neclab.eu> <7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> <53CFA637.1090706@neclab.eu> To: Simon Kuenzer X-Mailer: Apple Mail (2.1990.1) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 16:52:55 -0000 Hi Simon, Thanks for the patch, this will be useful for us. I responded = separately to your original post with one suggestion. Our application currently assumes that DPDK will assign the first bit = set in the coremask to the master lcore. As far as I can tell, this is = hard-coded as of 1.7.1. But we would like the ability for our = application to specify any bit from the coremask to serve as the master = lcore. I don=E2=80=99t see any compatibility issues with this. Existing = applications should behave as before. Thomas, could this be accepted for the 1.8 release? Or will that only = happen if the BSD side can be patched as well? -Aaron > On Jul 23, 2014, at 9:10 AM, Simon Kuenzer = wrote: >=20 > Hi all, >=20 > the only issue I could imagine is that current DPDK applications are > utilizing the implicit assumption that the master lcore is always set = to > the first available lcore. I would consider this as a "bug" in the > application because it sets up its worker threads not "properly". >=20 > However, as far I could check it, the DPDK framework seems to cope = with > it correctly. > It would be nice if somebody else could confirm my statement. >=20 > Thanks, >=20 > Simon >=20 > On 23.07.2014 10:53, Hiroshi Shimamoto wrote: >> Hi, >>=20 >>> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to = specify master lcore id >>>=20 >>> Hi Hiroshi, >>>=20 >>> 2014-07-22 23:40, Hiroshi Shimamoto: >>>> does anyone have interest in this functionality? >>>>=20 >>>> I think this is important and useful. >>>> Since we should care about core assignment to get high performance >>>> and the master lcore thread is special in DPDK, we will want to >>>> assign the master to the target core. >>>> For example, with hyperthreading I'd like to make a pair of packet >>>> processing threads into one physical core and separate the master >>>> thread which does some management. >>>=20 >>> Thank you for showing your interest. >>> Does it mean you carefully reviewed this patch? In this case, I'd = appreciate >>> a note "Reviewed-by:". >>=20 >> Not yet deeply, wait a bit, we're testing this patch in our = application. >> Will report if it works fine. >>=20 >> By the way, we should add the same code into the BSD code, right? >>=20 >> thanks, >> Hiroshi >>=20 >>>=20 >>> Thanks >>> -- >>> Thomas >=20