From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 943C542C0E; Fri, 2 Jun 2023 08:20:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E9D3406B8; Fri, 2 Jun 2023 08:20:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 97DC140695 for ; Fri, 2 Jun 2023 08:20:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685686851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YTErD0SEH0Ht5pRqtGzC1wMSn9PNUJKDkUvj85neau0=; b=bMs6UrlzH9a1Lgv0OPg3vnFyzXBDCtHp7km/djqHj1sd8ooWiKLlDLVAk/UZgEfofZVDnm YNXY94xSt3B5y4xV292BdzHi2E3eTQrfyrE95ABZuFAB6+aiukA/fcw/SulsYdqmf6fpUD cf3NiSYxu9c2Ze/t05IPNcJO+MwwhZ0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-EJufQQwgNZOh_WvAUFVDkg-1; Fri, 02 Jun 2023 02:20:50 -0400 X-MC-Unique: EJufQQwgNZOh_WvAUFVDkg-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-50a16ab50e6so1172547a12.0 for ; Thu, 01 Jun 2023 23:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685686849; x=1688278849; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YTErD0SEH0Ht5pRqtGzC1wMSn9PNUJKDkUvj85neau0=; b=Yw5A9Gr/jm9zWk7Y6DSLEZLqwB6mFHUic0aDuITwRyW3peC04dLEcdyK+cNGe1nzjO PsAifJpbE7HG2LiYjWtFkijfr1yalbzL3gPHhwEzWDQiNPvYgTydYF2VdhTcQzwlVLVM mPJGH1cmIF11pclI5HltJ8CLYPsEB70mQs6XY+8uLlOuqh5aeZ1j/7Nan/QubchEnJ8l 7NW/uKr08e7psI/qfhJO3ZiLjnlEG4NFK7SIEfcOjlG0xExJvsE5uYzbBowvMizJksKl Q/iFLbMPnrD8+ZfBP319zejCXVp0aD8wL7gKsdFoNVMik7Wasnfmrp3z4uwVIGecZ01V yWJw== X-Gm-Message-State: AC+VfDwXHiNt+fy+yvhwZJ2b2lgJgzoK7l+Wl4IAy4hbDv+ZOVTscfMG BXo9RrWGrUp1nWKFe53F8SjddZ+MQfueoiI6k+36cW6v6zDZRLLxBYs+kfobTY7NFIR/aco3JJl Oylg= X-Received: by 2002:aa7:c543:0:b0:514:9e4d:c8b9 with SMTP id s3-20020aa7c543000000b005149e4dc8b9mr1480872edr.11.1685686848963; Thu, 01 Jun 2023 23:20:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5OWEYDRDME6AM4eY2jTTJrpFTb8m2urdXD1MIaeE0aImlbtY3MiUv4hN14FLT1SagBl5iuzw== X-Received: by 2002:aa7:c543:0:b0:514:9e4d:c8b9 with SMTP id s3-20020aa7c543000000b005149e4dc8b9mr1480865edr.11.1685686848637; Thu, 01 Jun 2023 23:20:48 -0700 (PDT) Received: from [10.39.192.143] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id bo28-20020a0564020b3c00b00514b1d2759bsm282558edb.42.2023.06.01.23.20.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2023 23:20:47 -0700 (PDT) From: Eelco Chaudron To: Maxime Coquelin Cc: chenbo.xia@intel.com, david.marchand@redhat.com, dev@dpdk.org Subject: Re: [PATCH v3 0/4] vhost: add device op to offload the interrupt kick Date: Fri, 02 Jun 2023 08:20:46 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: In-Reply-To: <9ac84bfd-94ea-095c-1c3b-942302963bc9@redhat.com> References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <9ac84bfd-94ea-095c-1c3b-942302963bc9@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1 Jun 2023, at 22:00, Maxime Coquelin wrote: > On 5/17/23 11:08, Eelco Chaudron wrote: >> This series adds an operation callback which gets called every time the >> library wants to call eventfd_write(). This eventfd_write() call could >> result in a system call, which could potentially block the PMD thread. >> >> The callback function can decide whether it's ok to handle the >> eventfd_write() now or have the newly introduced function, >> rte_vhost_notify_guest(), called at a later time. >> >> This can be used by 3rd party applications, like OVS, to avoid system >> calls being called as part of the PMD threads. >> >> v3: >> - Changed ABI compatibility code to no longer use a boolean >> to avoid having to disable specific GCC warnings. >> - Moved the fd check fix to a separate patch (patch 3/4). >> - Fixed some coding style issues. >> >> v2: - Used vhost_virtqueue->index to find index for operation. >> - Aligned function name to VDUSE RFC patchset. >> - Added error and offload statistics counter. >> - Mark new API as experimental. >> - Change the virtual queue spin lock to read/write spin lock. >> - Made shared counters atomic. >> - Add versioned rte_vhost_driver_callback_register() for >> ABI compliance. >> >> Eelco Chaudron (4): >> vhost: change vhost_virtqueue access lock to a read/write one >> vhost: make the guest_notifications statistic counter atomic >> vhost: fix invalid call FD handling >> vhost: add device op to offload the interrupt kick >> >> >> lib/eal/include/generic/rte_rwlock.h | 17 +++++ >> lib/vhost/meson.build | 2 + >> lib/vhost/rte_vhost.h | 23 ++++++- >> lib/vhost/socket.c | 63 +++++++++++++++++-- >> lib/vhost/version.map | 9 +++ >> lib/vhost/vhost.c | 92 +++++++++++++++++++++------- >> lib/vhost/vhost.h | 69 ++++++++++++++------- >> lib/vhost/vhost_user.c | 14 ++--- >> lib/vhost/virtio_net.c | 90 +++++++++++++-------------- >> 9 files changed, 278 insertions(+), 101 deletions(-) >> > > > Applied to dpdk-next-virtio/main. Thanks Maxime! //Eelco