From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4094A0C4B; Thu, 14 Oct 2021 18:02:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABA8B411FE; Thu, 14 Oct 2021 18:02:51 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0745F4112E for ; Thu, 14 Oct 2021 18:02:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="227606373" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="227606373" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 09:01:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="487491396" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2021 09:01:39 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 09:01:21 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 09:01:14 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 09:01:14 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 08:13:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PDd1rmBIC1VR31ZtMCYKQ0caacnMipCe2V1YxukPs/5U9Y3Ha3msLbKWgyuO6XM7YJXfYwDk8nkdguW69GGgIVnepLRr1RdQgLqSUBx8l+JDXVemxoRIWMdjdIlpfMUbOwUHnARECpUSJMin+e+g4mCPrQ6y8awnJ6J2Ld7YpdxaylHd53Bnl09Wx3R5MuJ+cWAX37UWqXxDl0LnKutwTA1l4Pea/sWJCNp02B+5MfD57Wg0dhcPagQ6UDslsjgi9qN7gAKOhIbjoagTk6HQcFxqS47QJnSHl7SFpg4VnL0BlUEi+2SmlKTVdympTiNSVAYP965ttFWxCQ5qcPWnwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZAsXkUSqBZ3Tetxqiaz/nLGOu4bg9T3GVt3GAeVOafA=; b=U2r5H1suAAXhp6n/lif0RlAX7xa9O+DCDWbmxjp8CEKpi/udMHwROzKbm+KO0rK3q3492aAfGBfcHjxMaHZLBBS5/1k088ea2RfEHHm70QoG8XYfiPldDo+hUYgAG6pOEsu3l/CSSMOy58d1HLAprk6cKziR1QA5ciuBYi5ckF0hHAdWNdvErkgX/QxtdpaZ+GWpmtByW3S8F7XSiZbD9jtynYvIZKsO8IUaZVTt5latIEfPE31cL7C8sAzgwZLsZoUlnQLVDbGSALY3MDJm6NN374PAKAliooeShQqBgNW6cr0nhp3/nbS7IKmEWWrh3QVYL5eFCBiwUGst3T10tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAsXkUSqBZ3Tetxqiaz/nLGOu4bg9T3GVt3GAeVOafA=; b=p37xSG4ooSux7fPPfgH48oFjyxGqgxjxbj18ptF3gynlxqv1CTWDxBbCp75ZLN4+JulavEwJDC0lvSSG/ZOziw6T+OSx2ltwtjIiTbli+/z46hKU+txPcd76qEeOkSBlU1usHsc44Ejwd/wbX5q/0mnW6OYyIIY2MCzG6iKpj3Q= Received: from CH0PR11MB5363.namprd11.prod.outlook.com (2603:10b6:610:ba::12) by CH2PR11MB4200.namprd11.prod.outlook.com (2603:10b6:610:3d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 15:13:42 +0000 Received: from CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128]) by CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128%8]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 15:13:42 +0000 From: "Liguzinski, WojciechX" To: Stephen Hemminger CC: "dev@dpdk.org" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Ajmera, Megha" Thread-Topic: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management Thread-Index: AQHXo7q+9IZf8lorTkynGWasXiVzYquY8c8AgDnC4RA= Date: Thu, 14 Oct 2021 15:13:41 +0000 Message-ID: References: <20210705080421.18736-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-2-wojciechx.liguzinski@intel.com> <20210907121452.3788c935@hermes.local> In-Reply-To: <20210907121452.3788c935@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 074a8a6f-6e5e-4604-022d-08d98f253577 x-ms-traffictypediagnostic: CH2PR11MB4200: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nJiq41dZLc+jIEFHOoImayC7QuLb0K+2rkdVqe3NHBMntLZUdQ0VXN7wDkL8Vzoccff2T0l4i45nJRGWsi7TltVr1TicksThuRGs/T5Oimu7KqLvLVSW3gFQdTia8TY6s5nyTLhtyEoyt4ntwfDyz5c8EfDNYK4AxHR+hbf0bg4OssS8TZ3rm+cUdwDPo+MDaJVjKylMlAS/z4T33QZ8Pdw2iTSZ1fF2R1uvCTIRQVfER3/dHOShJArmbsGVoc6CTUfcKhETmrWRKam96eAUyXJHVFG1ASSqwXLfpjgu1J+vUWRAaIm6TQBMP5Qsn+Pi0i51Ao2GVU7mygFKhccoa4WzaVd64mbXkFR1F3KfhGL6UE4+MrvJfPl/aXPa0UE1SW35BDYFckxiZu32+G8z5wbTpXhFK8OyO7M+dJ8jWl7vxJBKLi2y8UOFTmu+BP/i0tP/mlmt+V3YFZs1lHWItOOtHspivuEkcNjUb+vVWFdrWEZvlwDYGNEuKt9b1eTTcK7IyXfk41IcQJjDjcYiVqEiqHy1i9PHNt62d4dbg8y9j4Q1JmKRvDKSfoFLoTZRzOEAYYhJhWwgAOYUQtH3Wi0UX1IiZAL+yLGBJwTKBsejJw5a4nMUPtIrOJd5GthM4iiOoiQ9475bYiB846qi5J/Io978DarH3btcZE+65UHNPl8ktb4GdaVTrN7/nYx1EN1PmlTjGYYVt2Gy6ov9gQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5363.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(38070700005)(7696005)(71200400001)(64756008)(66446008)(76116006)(66946007)(53546011)(316002)(54906003)(52536014)(66476007)(8676002)(83380400001)(82960400001)(5660300002)(38100700002)(122000001)(9686003)(33656002)(55016002)(86362001)(2906002)(107886003)(4326008)(26005)(8936002)(6916009)(508600001)(186003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SvlgFMS1cychMoNyY7pv+ljFnHfNvJcXgf6GaueScwdQ6e7MIZ3I9/Lc+SZe?= =?us-ascii?Q?FBXTyOf3ToWcPVXAxuOMPLVtQQ2j/W0gwJ9seyUZdS+MzJd9IzDASHTQwlbu?= =?us-ascii?Q?LAmGCANIHZUi9O0HE1p+tVLq0q4mr+6hqoRzWgFubsLFsvOeYBf2OeJ++uvi?= =?us-ascii?Q?bbpoMyfgC5lFvgYLAMzemIs5XJUSkfFHamVSSivvkhpPbNZqVsyGY6OC37sx?= =?us-ascii?Q?gLnaBnc6e4EuvYOzZhRu+5ronhy9iwgLJlhzg5e+kDLoZgilrUisrx/dTsEb?= =?us-ascii?Q?N6CV8caTIwz9ZUEFzQuqNk6Xrt9n6M8APp4i3159hMcP+YCCL42LQh/VezBl?= =?us-ascii?Q?lTAZWyFdQO4Hwrk9dDsARHhE0B/vj2XnzzwBtrxS3CkQYKObv8dtFn+chZBm?= =?us-ascii?Q?mX7iOg6sIIWd7ivFySjeno24QuoytLSGsmZdw0UixxLlnDdkkYXd2eFZ9o8X?= =?us-ascii?Q?j0IzqjOsS/gu1+xsb+594cBO/dKwwhs8j9cUPZR7xpPXNeiX+sEdb4WORCnc?= =?us-ascii?Q?0oIUzecXugGVtnaLuk1Ejdoc2fDDdatY4aYNkbAViNz14u//cSGg0xzn84d6?= =?us-ascii?Q?O81qbTn4dwfFb00EN/f/FvkmTeitr32Lu6nkLkEp4TT+9U7JZv6D5rHenlBK?= =?us-ascii?Q?FjOSVm2nRy0H4zSMTcWI8IWFgXn5KvmFNbpX21FqM3OQMsPApaWkNnGzqOHB?= =?us-ascii?Q?JfZ1Xpq1XODfmDaGmzPmwKVN4b8n5arQXFBIJuOfiNljF4kTGX9RGHqmnHcF?= =?us-ascii?Q?gPBo4RWZLonc0edrWCeP1+jH7b93RbOkXX+GpzfX/LXBrm8kxtKmqOzhk1bI?= =?us-ascii?Q?i/B0YfqMp9xj/lxqMvn4pHxl2+vBIg+S145KboCtc85yJ8fl7JHzfXOooFMs?= =?us-ascii?Q?uszb3C+ClzRdp7SbdyPJGuiYfxhfiE0f2HABj0swjq9Nq06qz4RcN5lY9RzF?= =?us-ascii?Q?SN4ujsATrrhLhgT3TWrg5jDiZbKr/Lp47wGnZmoLhINhkYZ7BKNZFHgxjMHw?= =?us-ascii?Q?OomPRucRpicju616CquN4bJC2t2z4HOp0/LBEiRi7GdS+i+S3Cps4yhvJ90Q?= =?us-ascii?Q?ac4M2Ng4lVed77Jw9WCd6hDaur1t8uIs/9KtbyUTJEEiteufFpQAyXHwqjMm?= =?us-ascii?Q?whKcNZfIVYtrrI0uZPvwxBGv7iD1tgIUPg2qSUMr0lqyxGdMlvXg3ekpCuaA?= =?us-ascii?Q?SHrMEC6bpgq1cH4ghQpzWRNscVcywDXViNXVNPsW+jXeGqBdNeaqxyeBiryC?= =?us-ascii?Q?Lska0CHJewPWQSwao1nkJaLE8MKtEwUFkyvE9HmRA1cmuoYD5n6awuVmjIBF?= =?us-ascii?Q?Plqh/iipkGy2dP6mHMUFgSdT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5363.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 074a8a6f-6e5e-4604-022d-08d98f253577 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 15:13:41.5911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pnPymbWYs3yxsh5BsyejI/hgey/w73G4ZC/OOmY45RLdGtQoMCYMQ3gEmnQXNRcLvut+lfJ126NM7kLkXm/HtFhffOz/zVmE5+wsTaPUF1w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4200 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, I have applied as much your comments as it could be changed. Unfortunately, not all calculations could be change to improve performance. Thanks, Wojtek -----Original Message----- From: Stephen Hemminger =20 Sent: Tuesday, September 7, 2021 9:15 PM To: Liguzinski, WojciechX Cc: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu,= Cristian ; Ajmera, Megha Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion = management On Tue, 7 Sep 2021 07:33:24 +0000 "Liguzinski, WojciechX" wrote: > +/** > + * @brief make a decision to drop or enqueue a packet based on probabili= ty > + * criteria > + * > + * @param pie_cfg [in] config pointer to a PIE configuration=20 > +parameter structure > + * @param pie [in, out] data pointer to PIE runtime data > + * @param time [in] current time (measured in cpu cycles) */ static=20 > +inline void __rte_experimental _calc_drop_probability(const struct=20 > +rte_pie_config *pie_cfg, > + struct rte_pie *pie, uint64_t time) This code adds a lot of inline functions in the name of performance. But every inline like this means the internal ABI for the implmentation has= to be exposed. You would probably get a bigger performance bump from not using floating po= int in the internal math, than the minor performance optimization from havi= ng so many inlines.