From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E5A3A0C4E; Tue, 19 Oct 2021 10:26:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A75C410DF; Tue, 19 Oct 2021 10:26:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 523C240E6E for <dev@dpdk.org>; Tue, 19 Oct 2021 10:26:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="228726120" X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="228726120" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 01:26:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="443787864" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 19 Oct 2021 01:26:14 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 01:26:13 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 01:26:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 01:26:13 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 01:26:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hbioCNqNAOHU50Y54/+aOQZBGusq8a0IMR6WSXUQ5gaHUVCzgUCSSvIvrUKvOzMaSjWOpc2ytzNn+Y9WkCc/IS2FvXXYqeVwfRBNUW4em8qGaTkC/ZaBos84xjUTyiGtVvyltI1YItoz2iWcR3VRZzjsEPfpzZmyhbC4g/KCInXZea3OmqPAS7M3ZjmWmZfIzUVouc63fFRtUN67uLY2Ykq2DphfINB3KBKC5ip0YqlZvTMzPYqlF1RWCSWt5CUcaoafm3zTOUZYfDPaIoPLQbCWlWjA0nm5zykzevHoGS3mVPygjtdp/xtqA6nPdlCrQ9hU/hYRzBqx0swwys5uaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p2rlza8FyOCSmEVFkBwwXt+LpEpwg+Z+cq8Xc2DN46k=; b=XyMRNyianMJKxVAnWtc8F6md2gLAFMbnf416/xYMdSoYYjLyuZDOERz1QE1174n9q9D6cqUWZL0qmP606QIt/i/MyjTrNP3/wvF0ZCrNBzrDjcfidIVVvv9IaC5FZE9VnqKR3jof6+bBeW9oU/Oe2iePWatu4ovMeDv2ya1oYTQ4wOQRlnqbtiGMKPm8TeYGg8um3J7r3nkYjP1Q/tD+aO8/1apc4vNNm+xSlv6vIyOjggik3U1kJzlPgXfulQB7NxtTMPDGz1zTlEJTHIHikN/96HkCWr5DOz2kBTY0FOamBkDlgMfeojeIfCDPOjNyvFfipEMkx9LcZgp8Hyd2/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p2rlza8FyOCSmEVFkBwwXt+LpEpwg+Z+cq8Xc2DN46k=; b=dG/BKnpI18vU1VJFu3b7W5G7/IePN1EcmYevrIly7FErZYm0T4oVPM4yZq1tZbb9rIYUidtEM/ITzV3iz1gqwkilOOgNZx/MA7ABGqL5o9w76GihigOdvB+MBjCVjWr9MO33bMbEJBAIuEfbgimcw5hwSBoO0EhUANT2Djk6uHo= Received: from CH0PR11MB5363.namprd11.prod.outlook.com (2603:10b6:610:ba::12) by CH2PR11MB4424.namprd11.prod.outlook.com (2603:10b6:610:47::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 08:26:11 +0000 Received: from CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128]) by CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128%8]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 08:26:11 +0000 From: "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Singh, Jasvinder" <jasvinder.singh@intel.com> CC: "Ajmera, Megha" <megha.ajmera@intel.com> Thread-Topic: [PATCH v14 0/5] Add PIE support for HQoS library Thread-Index: AQHXwcyCQstQHsUP80mNjNngFd12N6vaAjlw Date: Tue, 19 Oct 2021 08:26:11 +0000 Message-ID: <CH0PR11MB5363BF94E3D2104F1ACFD14094BD9@CH0PR11MB5363.namprd11.prod.outlook.com> References: <20211014153346.2816600-1-wojciechx.liguzinski@intel.com> <20211015081620.2873739-1-wojciechx.liguzinski@intel.com> <DM8PR11MB5670DD93DFD67B1DC29E58A3EBB99@DM8PR11MB5670.namprd11.prod.outlook.com> In-Reply-To: <DM8PR11MB5670DD93DFD67B1DC29E58A3EBB99@DM8PR11MB5670.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e18ca5c-01b8-49e9-09b6-08d992da1bc8 x-ms-traffictypediagnostic: CH2PR11MB4424: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <CH2PR11MB4424A0FB16B2D3482230E7F994BD9@CH2PR11MB4424.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NWt8bs8QC9i+ofzkaKgUGO8c28gdDHcdq5w6SH5CtmU4HXo3MrRbRF8NTNgVBJoQqH5qQlf627fxa7d+3qadns2PyTOdQgWqKZsIVvOvo6QHQfZVgGAiE1U0jEK67ieJwoRj6/QTMe/VtxuPpIpLOeVhNT6IrS30l4bdn040Qkix0XShRuBQmcC4PY7IqT6skv9lQXK17dJR6iYob+18NWZxG1QlfSh5ayFWwjT7yaYylfoRDphIiAfyZvs2Ud4C6I6wmiKvO5nUrsDfic/dRg3tDJnEt1T6h4DH8eHasvlFpalOj1ociq0ItcK2rXJA4ugBZ1xVYeAg9T5qqqU9OSW2FTIqS0t0zc/fTMWRYImxcQPzfu4zcwzZPLODrVNDtsOvABCdWERaIl1Fs8EX2jTxEkXAQr9V0Y60wtl9fKPI4UO8uEwxY1eSjA/6I5liwYnZQ8JV6NZLGDpCyFKAvZdBgLrfeu4Ol1hJqO1KA/CAgra3J3RyRiZv+xxcfoZCqSCCxGko1BJig6Q3z9Rj7DOQW7ggG8rWQ6Bf3ebnXZToIMnt1z5cgP8FL+dsiF4HkpbGc+OLVhTB0cj14zOr4kHb3EyHfY43Qakh1GuFZsAs19Gi3VUENp3BrJst4nC2vFPaVVY+FdZSW4cEHkbYX+auPDPMX0RuDGPsh5l1PhU/pFGp7p4k1ICtbDjQZatZABLtsDam12uw0qtsU4/EjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5363.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(26005)(107886003)(316002)(9686003)(86362001)(8936002)(55016002)(6636002)(66446008)(66556008)(64756008)(66946007)(66476007)(110136005)(4326008)(52536014)(122000001)(508600001)(8676002)(53546011)(6506007)(82960400001)(71200400001)(38070700005)(5660300002)(38100700002)(33656002)(76116006)(186003)(83380400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i/H7jsTFRbkOpKMpq9ERx2YA4Zqjn62x85ADE8oM7TpPMoSY12JTCyKIsIzb?= =?us-ascii?Q?zzLTRDa7BOxvMgCB/+q/xLPzJ9EjL//pXiLRei3Ph5vP8iHYk+WAlnxbPIMf?= =?us-ascii?Q?V/LV6Y+5RPlMA3yh9f+LqYzhCOUJJQQBRjRZXKyDDaZ8PIk5SN1yOY+qdI7z?= =?us-ascii?Q?sJPc5KAbqax3yEM7T8Bq8m7WlVt8xrSLhlkY/mJ57JRBKYQOwCHGKCEGlIUR?= =?us-ascii?Q?/ldy4JdTlGRHHzSPAuZTsaoHQxbFAPnI36lNQbyFSLQLkHE8S3XsmXm/LzgA?= =?us-ascii?Q?7cBLRKAZ0u1Y1h0rArEd1cr9xIrk+UA04oy8pJvMH49dDQ783tpleUQ/2kUg?= =?us-ascii?Q?THMw62iYZT+kfjs2I5CUjP2wDgJwkd8gjOAYWshHogBv8Qn+oIiCbnOSjP3A?= =?us-ascii?Q?cYE/jP99lySntqeYBaAdwHh1VjtkfdkyGJtaj2Ttjwjhy7vLNHXVlN0KrzOc?= =?us-ascii?Q?5i9ZYAAHpKYzpwilQTw/n23ZZIWvhFtcxJmmYMCeLe1uW7PHEmkZ9g0whjWd?= =?us-ascii?Q?5ziMOe5TkIeswshKOl9NeC+z3NvuLbWI1WgdOuU+Jwd4m0idMziJ8tBrxsIO?= =?us-ascii?Q?PEPE03krAJ5NihXr06tG+lSRA/AfQIAb4Wywi2SG9NBnOYR95yRUS3pT187A?= =?us-ascii?Q?gZPqh1vbFKpgPi/UwlYxChFeQM6HqwQth+sekz68PaRZaa+y41UDB/D/9c/Y?= =?us-ascii?Q?vDWSilvzeOMIAqT84Rv714PMXQ8yeu6wbUBavWFpVql3qIa303mlDe6oIMgS?= =?us-ascii?Q?NWHPMKKs0hFH2HIbLnCBA4zRQ1vLBS+rKcZVYGcQmnIOJy9PEOd2OYciODQ2?= =?us-ascii?Q?BWx+/94BMYpLvYkPT3Akg5+xTrnPYCr8NJYwwWcfY8nhJorryWjbgKPXZZtn?= =?us-ascii?Q?N3R71udpgEHap8BzSFP+FfnF3z8NIGsGvjVQwutq5TyqBETtjeVmM8Ytze5l?= =?us-ascii?Q?N2WSPdtAIA6OE/yeANO/faJuuQ+t7rUyRhEsyCs+jzhduestSYjSaULGPMc4?= =?us-ascii?Q?y5ztRCE9JNrJ89JmUK6rRSxVHh48g6HeutoTkFouqPZ1+NhcUj4jhMQ4XI1w?= =?us-ascii?Q?l4ctygPvF0AUooCsbnrgAGXNfMQSRo0LUQn4bjau+uypVcT/bkxvgk3LE229?= =?us-ascii?Q?yDRjBuNLdiYaIwIKTkXfTRnvIQ99qd1X4/Arb5R/3CnQI9t4SKdXt/xjTWcm?= =?us-ascii?Q?ZhDTlUFuO/i5uq2bHpmzXAJnP2JwrT4LEoMqqvu9rbsu+Q5PI2kRBfJx4etH?= =?us-ascii?Q?hzUDsmQCLlFtNwf7e4KSgAGU00uiWy5V/GR+2pZbJ9g3tc2bxIWcuaDGQ3PU?= =?us-ascii?Q?oDpoTVh3K8imzgsMnjavdifH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5363.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e18ca5c-01b8-49e9-09b6-08d992da1bc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 08:26:11.4842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0kr3RZ8uzpSoUfhKekp5H3Atz3P17rFHSFK/PQ3HZ2nzc0JwxaTalWA96wxVl/l9zYDfWcP+LMUHKK8JgnNEs75Sz4RF6AZEkOnAMzRh048= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4424 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v14 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Cristian, Done. BR, Wojtek -----Original Message----- From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>=20 Sent: Friday, October 15, 2021 3:57 PM To: Liguzinski, WojciechX <wojciechx.liguzinski@intel.com>; dev@dpdk.org; S= ingh, Jasvinder <jasvinder.singh@intel.com> Cc: Ajmera, Megha <megha.ajmera@intel.com> Subject: RE: [PATCH v14 0/5] Add PIE support for HQoS library > -----Original Message----- > From: Liguzinski, WojciechX <wojciechx.liguzinski@intel.com> > Sent: Friday, October 15, 2021 9:16 AM > To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;=20 > Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Cc: Ajmera, Megha <megha.ajmera@intel.com> > Subject: [PATCH v14 0/5] Add PIE support for HQoS library >=20 > DPDK sched library is equipped with mechanism that secures it from the=20 > bufferbloat problem which is a situation when excess buffers in the=20 > network cause high latency and latency variation. Currently, it=20 > supports RED for active queue management (which is designed to control=20 > the queue length but it does not control latency directly and is now=20 > being obsoleted). Please remove the statement that RED is obsolete, as it is not true. Please= refer only to the benefits on the new algorithm without any generic negati= ve statements not supported by data versus other algorithms, thank you! However, more advanced queue management is required to > address this problem > and provide desirable quality of service to users. >=20 > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral > controller Enhanced) that can effectively and directly control queuing=20 > latency to address the bufferbloat problem. >=20 > The implementation of mentioned functionality includes modification of=20 > existing and adding a new set of data structures to the library,=20 > adding PIE related APIs. > This affects structures in public API/ABI. That is why deprecation=20 > notice is going to be prepared and sent. >=20 > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE >=20 > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 60 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/app_thread.c | 1 - > examples/qos_sched/cfg_file.c | 111 +- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 10 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 240 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 3 + > 20 files changed, 2161 insertions(+), 276 deletions(-) create mode=20 > 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c =20 > create mode 100644 lib/sched/rte_pie.h >=20 > -- > 2.25.1