From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 646A0A00C5; Wed, 16 Feb 2022 03:26:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA5B1410F7; Wed, 16 Feb 2022 03:26:49 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0026F4013F for ; Wed, 16 Feb 2022 03:26:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644978408; x=1676514408; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ulUsgQeyqfwyd6wtRS8W0scEUcwxr3CV5ezz2YNsw3I=; b=Lqvmm67oRckv9tOg9gf3TSQZ4hiQNFecJR7L8/N7968EhV9rT9xz6bT3 dzztmDT5pulYKQo5xVRB73xZ/WsxMZW13jFk/nSeWbvOijptOLOSmgZY4 ++auWDgZ7VHuGiCc4yXBV0kcufe+9zo5J/u7oMA3S8i2cMxfDoJggA0CZ LR+qaSTvG5LvIgaOjcHVpDPFVWZg8bqX8HuS7o2lco6z3baqaqMCwxpcc dIVzoql2o0w61ZAiQZO7WdnXD8cEQV/d6LzJ1zTJEtxYQUEIRIdxF6umR Swf7rtbIL81wXkn2jCrNia7u0pBQNiZY5qqpx6H1DLaJjiSEcZpoFv+ax Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10259"; a="336937745" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="336937745" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 18:26:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="773779765" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga006.fm.intel.com with ESMTP; 15 Feb 2022 18:26:47 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 18:26:46 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 18:26:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 18:26:46 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 18:26:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KRpAT60G3Y576ZdMtmiEtPl14NegFhgbXsOSnUTRqnxZaT5fbBYzLmXttsGbdPk2qgQ/Nko6HRFlOKvYmvMDf+er2qo67KxKmOOw6HsgOlHzySPNpAbrrA1miEc5ysuP3Oj0XFLmyfIiwmTO93+qIvgS6VyiqWazFYfG0vlCCQs1hDGXXcEU2D7+5HvySHSrGG82nxTaW9GmwAndJnwJUlBM/gXJONAQ9hjFvpMDim4jpFo/BUeBzUxSd1z+7Qri+ag9f2pOsSJAAqfW4od65eDjwesxFSsIjWXwgJrT9aPl+f/CaEuYbERrY8p533WTuvJCo9LTcDgxZu+kIDMW9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ulUsgQeyqfwyd6wtRS8W0scEUcwxr3CV5ezz2YNsw3I=; b=IY3k+PpqIZyxLe06Ri1H2CgMTe9RLH0gGFbz1RkR7QtXgcW6eL9hP0uziDE+ZV0aircj0vZ8/YeLGzENg6wWuIzw9caQc4Fp0NimnN4v96fXdGu/J4hm8N+KkeqcPKPnlvv7IuFoY+Bs5Fz7JHQpMfuMQ9Z7sYs8Y7Qa42ibeebYcXc1VPdjh91dlnoXlWBdctuW3Rnh7I6jcBy84ekEFd6X/OIqUa+FD/GM3Ii9A6TmhhR1JhGwNOItwN2DqWCrwaZE09L3CNQO1ytweOv1L42OdUceG1QQuqocYdsw3dLYuBI3SLr9oHuS0XptL1ihitiwlrutL5YCE0zUvf66eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CH0PR11MB5523.namprd11.prod.outlook.com (2603:10b6:610:d6::15) by DM5PR11MB2027.namprd11.prod.outlook.com (2603:10b6:3:a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb 2022 02:26:43 +0000 Received: from CH0PR11MB5523.namprd11.prod.outlook.com ([fe80::d13a:f88f:17e5:d264]) by CH0PR11MB5523.namprd11.prod.outlook.com ([fe80::d13a:f88f:17e5:d264%5]) with mapi id 15.20.4975.019; Wed, 16 Feb 2022 02:26:43 +0000 From: "Zhang, RobinX" To: Thomas Monjalon , "dev@dpdk.org" , "Zhang, Qi Z" , "Yigit, Ferruh" CC: "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , "Guo, Junfeng" , "Yang, SteveX" , David Marchand Subject: RE: [PATCH] app/testpmd: format dump information of module EEPROM Thread-Topic: [PATCH] app/testpmd: format dump information of module EEPROM Thread-Index: AQHYIlXrer3UYSjGokODy/q5IUuDf6yUmx6AgAAbwYCAALhYMA== Date: Wed, 16 Feb 2022 02:26:43 +0000 Message-ID: References: <20220215101853.919735-1-robinx.zhang@intel.com> <3208558.0oRPG1VZx4@thomas> In-Reply-To: <3208558.0oRPG1VZx4@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-Mentions: qi.z.zhang@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8963ba0-b055-413f-8c3d-08d9f0f3c5a3 x-ms-traffictypediagnostic: DM5PR11MB2027:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yp0B97E3+59T0wxwO+wJg6spFdOEsrhfTerQsvvXS53B1WgCxn12QVchPjyrNyGNOZ+FKfzuq5X4JyswmQyYEPX0JKgFo37lyUtrvx2NrnxPa+EzzZkDY3Jy4YQ4Uk3kAFjtC9v6Qx4qWmcfANJ/KvFe2MoGkHC0Kr/xeY/DbJh4q+T/BhuUy6vBix40Ek9+QNeMVYODzZFcG8FtNKNbKs2uZ0ybDQeRIlkHvajYyvrFVE7yRjEWsMfpmokq56+LO7ZOXI5D2t7R6GN7w7tzxEOtyrOMeVQK5IhSGDDUrgqeFiJH22d5LJNmXKDhlyqL7QrqKPPApqJ9Zq0+kBOsH1RZQdZljEDoJCFsRoMx5L074BIogU0Av0k8ounZaHfUxNDX9Z9veI/IJiHqm0ToqQc7Fghd7YJuJYTsZfaz4BCCqXgMs29gy1tp7ra8F/j7/wNJS3xAJZsxTsqLLSrsg6dl0tF7XDPTmQW+bK6UhAxRFdermnOkBZLjO0qnsRu+LfZDt2ZQywIvhV+a7BH/H6VyU16L2ivhzvFw7FQd8qYWU4nat0Yw5Xw7sUR9TDEGx5kh5E7w71sOk+eV0IK6WXBzEw07uOJRkn7TdUbaAsu97YiKMPNxqpD7a9ACd8teIY+ehZgRCdJOWsy+SEEkg0oKKpsfgrMqNUtwowPUA4vUeHgBlFVKXWgA0zTDXUEFDiBw1/ChZJLXS0DPXqdz271Ok3w5CmO2UOhU8HN3Z/A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5523.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(8676002)(66556008)(66946007)(66476007)(66446008)(64756008)(6506007)(7696005)(83380400001)(53546011)(86362001)(71200400001)(54906003)(110136005)(4326008)(76116006)(508600001)(55016003)(26005)(6636002)(9686003)(316002)(38100700002)(186003)(122000001)(33656002)(5660300002)(8936002)(2906002)(52536014)(82960400001)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kVcbrHkCIcH3KnFBacpCi3hI6yIFpcu33AchNB+vKUmOI3T6u0kaOqE99Tgg?= =?us-ascii?Q?U1LuZZCJTlmxfnJ+xsdPDuVZn6QsXbQzuTNw/kdSz6I6kM+eTGZLAEx/FySA?= =?us-ascii?Q?ccsGIAba1/WrOmYbNDTQ7QHsiBmOk3IwiTxDaJCADIDR+n3DK8tLYNsO4NTh?= =?us-ascii?Q?RwR+hlqhJNj7722/eZmn73hMns7PgHHu3lDRPzyVWk8PxrJFrywmtZdz0zkW?= =?us-ascii?Q?2pWzy8Yi++b1Z4mbC5gicx1Zo3AgGI7nYB51fUa+/ao+ujfAenTZY9cYMRzm?= =?us-ascii?Q?7V7OMHlhrl5kpsdbX3i22LgIP9ICedEO30HQwIwnQs0sfAH1rKY4i5sZW9tM?= =?us-ascii?Q?+OgMjSnkw4GyxnEwMtGnby3V9kQSV3qXhoN+Un0cd01mciAmG+uiQIV51J8I?= =?us-ascii?Q?dOQtePp9wBUJTDWDr1rXnNa0KxLP0xbbHg56YOngM6LTtxwsC3QqZueq6SJ7?= =?us-ascii?Q?R9hUssgBqzfRvWo9W3ERqW2AjjSxHV4nzJvhLorcIsvcgWG/wFUykzZPtoN/?= =?us-ascii?Q?c7xl0YecU/d2lE+1qmWzjVqBXikr4q9xUFccpRNl36O0xMbK2rCcB5tSFesr?= =?us-ascii?Q?G2V7qKPevVtC7g4NfQy3OfCHeCk3ZetGZmPmVqsSnexXtUuxXwLYfS94pQDV?= =?us-ascii?Q?8V7Iww7zDhDMZh0NCWJvcOmtSLyhKF/W2WRxxdjnOmVyy1srGz6+TWnHXOhS?= =?us-ascii?Q?nscp9BSKPGunNKwXklSifnSA9niMprxaR7fpgDdRUliaB6UWpHhazplaW7Mx?= =?us-ascii?Q?9yUqGfEnlUKXW/XqF5CHjF5sCxu1PFWKfX6OQ+Agh/NlNCAmgRoHof95BSpw?= =?us-ascii?Q?O/dahIqD4OrBeJf4h5MA0z2SUz3x3HxAuoqjKUVXPrSHXBlnfrogXh7JdCjs?= =?us-ascii?Q?2kRS/3Lxrmp8lyce7rZB2MutJyRwYgI4Ei50/Z8eK8Rz86mJp4rPH22NL2Dx?= =?us-ascii?Q?Hk+fLFf5h9GNQQiHJ20RFRPrZ6bqvZXNP9xf/XwHazDxR8Df8Pq+Z0UD0xqm?= =?us-ascii?Q?FqNGbU7Ew/r+/njqBdbkSkt9ThU7ekbBvo03EJAR/Q9pEkbocujnU9RIzvXo?= =?us-ascii?Q?TEIVS6NH6LxHYEdJ3DWxRiJJ/lPr8l5zWNLdtFCA/0HXg0F4fiQkemLnQy5m?= =?us-ascii?Q?h8Bbi8U26T35bvLqDk1uyxdiMeKR6RX377QN1pPcpddcJ/yeyiO38O2clwlg?= =?us-ascii?Q?bhLq4pgr94fedNoG8syZGZrWl18tBfyO0IhF7lhzFwz2nE01DzZawGkWzrhb?= =?us-ascii?Q?N1h4f+zn85aiQVDUts4zJahH7eHIEodZS8/82CvgT/DEAvsB6tAPahA2uceV?= =?us-ascii?Q?qypwJ9kLO2YXaynYShlS8KkETqcnLyz4Uo+aP8nswl99SDLTqVD7D6hJPd6M?= =?us-ascii?Q?sl7ZTSxcf1NFJgirPDVFs+gAsiAqhxAWWpO+/dM5cWReuQLGD0ackLu554ON?= =?us-ascii?Q?w0uwcNsgsL7QA0/gtiJ6OUoqmCoarpjPog9+5FZeEWhTa1hhP/BwwanmKfMy?= =?us-ascii?Q?LRAgqLB2XWh2Meamz9cHYb2s1tNIOlesbg/mdEyEzB5QRdttJiLEjNMZhFUD?= =?us-ascii?Q?PJqPNYy3VSZMdapBTWGzdFpbTPQedzWAtOuqljSNPHDrJyp0p9FAJ3ATX//h?= =?us-ascii?Q?bV1RwrhrlDOPOxJiW+Loj08=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5523.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8963ba0-b055-413f-8c3d-08d9f0f3c5a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 02:26:43.1764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yabLpb737vameClMySBY7hy0O3MAtCqC08MRDiY/3veo4szI8sbtTF9FNMK5XnE3z4CtwW6Kmi69wmeVmmjtmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2027 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, Thomas > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, February 15, 2022 11:08 PM > To: Zhang, RobinX ; dev@dpdk.org; Zhang, Qi Z > ; Yigit, Ferruh > Cc: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > Guo, Junfeng ; Yang, SteveX > ; David Marchand > Subject: Re: [PATCH] app/testpmd: format dump information of module > EEPROM >=20 > 15/02/2022 14:28, Ferruh Yigit: > > On 2/15/2022 10:18 AM, Robin Zhang wrote: > > > This patch add a format specific information of different module eepr= om. > > > The format support for SFP(Small Formfactor Pluggable)/SFP+ > > > /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on > > > SFF(Small Form Factor) Committee specifications > > > SFF-8079/SFF-8472/SFF-8024/SFF-8636. > > > > > > > Hi Robin, > > > > First of all, can you please clarify the motivation of this patch? Why > > we are adding this eeprom parsing, and who will be user of this patch? > > > > > > And, just to confirm, this parses the eeprom module based on SFF spec, > > right? So it doesn't specific or depends any vendor. > > > > But still, this is too much SFF specific code in the testpmd, and it > > is not small amount of code. I am not comfortable to get this into > > testpmd unless there is a good reason. >=20 > Please remember that testpmd is supposed to be the application for testin= g > ethdev API and drivers. > It doesn't make sense to add code if it does not directly help with the g= oal > above. The idea behind this is to monitor the quality of the link in the field dur= ing testpmd operations. It is supported in Linux driver with ethtool command "ethtool -m xxx", but = missing in DPDK. This feature is requested by customer 6WIND and we have been told this is h= ighly important in production. 6WIND also mentioned some other customers: NEC, EOLO and Open Systems. Similar request also received from customer CheckPoint. >=20 > > What do you think to have this as a sample application? >=20 > It can be in the directory app/ maybe. >=20 Base on the above background, I'm not sure if customer could accept this fe= ature as a sample application. @Zhang, Qi Z, could you kindly please share your comments on this? Thanks. >=20