From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70AF8A0560; Tue, 18 Oct 2022 15:12:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 174D340395; Tue, 18 Oct 2022 15:12:17 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 345E14021D; Tue, 18 Oct 2022 15:12:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666098735; x=1697634735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KANrJ6m03pJs6jW8D3YLruH32BnptGVLqyp6X97B9no=; b=dmIwLuUb/qkg1t3RIFbhe+AFo7ZFcClHdr7RjFga2x20ReiluoOFB6HD 5Xd8Wo+g4+1+8WZhVnPaNM4KV1FNMywMZjgu0899kJzyb0+BCkS/VggnH tqkuMwdKW1zVO4Ji8QtdRBl8nSxq4PEDD/ZAFXoWPQYCE3kr4HtuIBrFl cHln/mPBHxwarPjsdMVkgXG4x2VrBiPSgy7p6ifQfkz4t62m7/OzbUszm aevk0m+yP4biq7Blt2VxITeNQEE3XiI5V0cDeAxW8lMmNBjdRnIhbzD6q nYx5n33aBmn44AdPoEhYxdtBGltzViaeAudX6xwxZ2vU8KVvkp6CS75rk Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="332643446" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="332643446" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 06:12:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="697491564" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="697491564" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 18 Oct 2022 06:12:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 06:12:13 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 06:12:13 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 06:12:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 06:12:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GaOrYYzDH1+ghRCddrM0DGnxTXqDZl7onGkpoMOpRqC/K30peOA47RiVBtGCS0KtAtXk/sQtyYyopgZvX5nTEDpCJnDfcaQd4BCbKr5fGfjYM4Q+h1C6H4cpX51aKwNEC1TMtHpw/AGA7SuzJS4hmqDmma0UyWkeD8IBL0UuHgASIdyW0q3pv8VTWomnKkhkQq0jfK0xxfBMomkrazZ+WJlHK9p7paXidIfmfZyA3kqhrU5oIP7Lc05NiP6QcFJ/kCqnmbYscbpXxhDDu8G2vwQFmZW3JMqz8O3iFSciviJMqmA8ZhCi6P7h+KS17VhKHbSd3d7w+w0sjeWZCN8ahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dluy+nT+Pd1yHudjNsJLqUUnMc9Vm30+Te65Y+IjOdQ=; b=Es9RkkBhQxCSUUpLNAI8nXvjc9BNpg1yY9LyDQ1yIxKgpl8/LZEmAOZ+nZm0mIOy3jjupMdCfPRLR5PxqUdPdFOsX/pqqkbbOXuwVIA7b9V4N4KxI1Ey9BPUlh9ERbuDwl8njysRuuJqOSS4zzOKFYjzO9bM40ZBQofKtlTKFfQZvJbYU3QVPxF1uYlfOV+sIvHR253XucSNI76CwVd90b03Ts/sMlhxRbGlfsFjtpyJzoKQltEs+UCzNigYA9ybFcqG/nTatK1wgRiqHfop4Y/YgCMjThq4J7a/A+Z9yibjLRN086Jl5+D34LR4bjpio2jpz1sg52eBv1rVDjhXlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5724.namprd11.prod.outlook.com (2603:10b6:610:101::22) by PH7PR11MB5981.namprd11.prod.outlook.com (2603:10b6:510:1e0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct 2022 13:12:10 +0000 Received: from CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152]) by CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152%8]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 13:12:10 +0000 From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> To: "Ajmera, Megha" <megha.ajmera@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Singh, Jasvinder" <jasvinder.singh@intel.com> CC: "stable@dpdk.org" <stable@dpdk.org> Subject: RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config Thread-Topic: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config Thread-Index: AQHY2bZrVM3UkbCE+kqAnRCai1DYza4JMRwwgAqBTZCAAIAEMA== Date: Tue, 18 Oct 2022 13:12:10 +0000 Message-ID: <CH0PR11MB572406C980FD4F786385C8E3EB289@CH0PR11MB5724.namprd11.prod.outlook.com> References: <20221005172239.254327-1-megha.ajmera@intel.com> <20221006190038.431828-1-megha.ajmera@intel.com> <20221006190038.431828-3-megha.ajmera@intel.com> <CH0PR11MB572465FE3FE5A3447BAF23B9EB239@CH0PR11MB5724.namprd11.prod.outlook.com> <SA0PR11MB4670AB1BD19701A36630D82897289@SA0PR11MB4670.namprd11.prod.outlook.com> In-Reply-To: <SA0PR11MB4670AB1BD19701A36630D82897289@SA0PR11MB4670.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5724:EE_|PH7PR11MB5981:EE_ x-ms-office365-filtering-correlation-id: b78f379e-318c-4d4d-9ee7-08dab10a5da3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: deanWE19M1/8V71jRViSlr9H1MXFo40k+Rm2AopiBG7Hh1swiiOcXQGGSqUuk6jTa2c5wSw14WlUT8NMTskK+T2hki4kvmpUYh1m/eA2dWeyMggDGfSBZ+snbGv4KFwxtN+vY8gtFmu6WT7CPUjBY9edanogCoe9CqQ3W/YXpbGgiUWaMA3/VOjgnyioaJhOWSQ4M9XXJS9WyYRaQ3C2s9bGx+9jU8sIszYsRgJcQokubPM4rfjN7bPncBtb1amg+3J/ldhzH4qldojffeWEG4XxeI8+/cf5J8776eJU8rNEtOfMoKKjEqYQbQFn4b+iaGG7PD1/+5N66OT/uF885UnI2d3WaOTr3gv4+HhYa3xNTSBhfsgaaZ3BvQgWk2qZoySd4wxeI8Tu96X5sEW/qzquF49A79DZzz+d74pcbyNWhpnNjovixhnIIFstJhEON/25FOs8WJBkvsldI3olNQAyKGfrlEn1/vaQZGdnY71tay9xAVpjfMI83dLJO6s7kR+EvBeiwQRpVJHJH4ur2l4kP1SabE5MFgWmd8Gx4N01OFHifHiL+nCXfxBq8vHJaUFvJg6hZ7wxYSbj9vmQNJg04Ex9EX3LuiIjS4vXzGZkKrdEHSaHtMYIcD1LhWKYz+6Zze4hOH5IH4QvC7Dv453JbpTqaCcSMJj50vXlkDUs+07KViJ6dpX8nxpiQ1CDjxd9/i165GL2rpFZx3cBPcZzpSeQlbDWUXaZgScucopu++DMeA70gUSSoa9S+j48yetcx9cXH49mTSLYtJdJfQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5724.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(366004)(136003)(346002)(39860400002)(451199015)(316002)(110136005)(6636002)(4326008)(76116006)(66946007)(8676002)(450100002)(66556008)(66476007)(66446008)(64756008)(71200400001)(7696005)(5660300002)(52536014)(186003)(41300700001)(9686003)(2906002)(478600001)(53546011)(6506007)(8936002)(26005)(83380400001)(82960400001)(38070700005)(122000001)(86362001)(38100700002)(55016003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vwAfzvcVzhYQKspk+0RZYd56ktPRc1lNlcel8yCWA6p3st5+kGn1kZIuUXkC?= =?us-ascii?Q?IjU/68sM3WEa5UzWFwgfGmd4yf1e4S1fZQesiXD3DmR9zvMYkSyegNM2TbN4?= =?us-ascii?Q?rpxsiDyulB81aehdua03XJBwu4Xp52Tx2MfkK5TeqEotczqmO1A/O2OU5DD2?= =?us-ascii?Q?RGjlGklC9lv4eAuUCeXjs3Ez1hswLfx34hBZf5WVUySvuqmmZwGznQkCvISz?= =?us-ascii?Q?no48LCfUTYuVNdtlwg3GTDszPjX34czcnAFW7Jun2ur2d0VLC68bcseShLj7?= =?us-ascii?Q?0MmSMwdVaUP63q2fcTggnbt5paT8jikMXfTXyFkLJ+LoIQgQxwq5uYrgoG6k?= =?us-ascii?Q?hr4EPZeUYWtyuwBT2WsphopQqWoGoxzQjFn9FlrPOeW7v5iHJAnKS98Enx/5?= =?us-ascii?Q?DGbyEcDBQJSaKSS4K2qgrrU4FL6TDmiCRuG27FsaEUEQUzaM3cj7ePjrQ+4Y?= =?us-ascii?Q?nNC5xaWrq40qvrmimPuTOYz4OSkcYF+TROyMZp5UfgRE2RkEKxA+8y59Lm+Q?= =?us-ascii?Q?Xe8c9eZRYRcfkAYaw3E2aIx+zVuxLMAhGHVOMvzJ5zWURVQv3Z6E2Z5miUho?= =?us-ascii?Q?6KEfkV40cZCaf+mauyMUAvgKnr2eZSzHEt1Vin6tLg9H8nOpWL6Jolb6iW4U?= =?us-ascii?Q?KaXYDQFGH80zh7dccuTe728CDuDKoxBSO2vUc7EOdcjHM03NOHmAZVVTBMG6?= =?us-ascii?Q?+5zOjHych3PYvt3beU1k2s5fLKLIheFpbRHiUTsomoAHhn8G1qIoBTMhX7ti?= =?us-ascii?Q?SGoVR3qNRrHYNZc8MVheAYalOne9YzmxNcnet2uuXpNq9Dg4WWD8QBYUNHvK?= =?us-ascii?Q?W9Xffqz9eT3p/wnhOdgyKUGW9d1eIQsgmcj1f+zAfj/Sr2+53TITl5LBNiiK?= =?us-ascii?Q?Bz52b8/BbyRkvx4rQ5bmQmAYDJXRWuvNKgzSzf1+c50Vfu6Vqk+YdfCCWTFD?= =?us-ascii?Q?VYn1Ek3cXbiu8ZzDfwzJRjGn2yPFi2aciGdZ3Y7wAmRrZhEaYrml42fAyd7d?= =?us-ascii?Q?GqVR/2TrRvGEuv980ZL3sFDk8M/cDU0ViGjT8n62l708X5X+TAGRUM1s9O76?= =?us-ascii?Q?q81ZK7bFRyGsMvvJ0qBAdCN3AXksitzAc+VNPQPhDW/LP85JCgCCN7MGzgWb?= =?us-ascii?Q?Gp5QNzsOu/Am6NmXdlkKwwXkcg3ni1mkUufVVAkwc4rJF4Yxe2dOu/EoCUaT?= =?us-ascii?Q?+m69sr4k1PumDaYQpZNVTQpAaP81VRTk4qwkidB6+testCqH9YQ0pGD2yr8k?= =?us-ascii?Q?6jyXyHjY0Kmqy8jlk1sA2JZe653KAUa40dMS7kA6flYvXh44Un2tKTaPJ0yP?= =?us-ascii?Q?8tsSDcdKyBaLa7rhcZhATRddeyz0qaE49vmnqURf3nJGklbCeIhdf9O49lIX?= =?us-ascii?Q?Ln0yfkpr46aWhP3boZps7sO/iP1iWZXwu6DgrwNSb9/iN+YspS1i6aBXq487?= =?us-ascii?Q?JT0fcwzWyA0JMyo6qphseVWeDhr+GONepy1B1wpRtqdg54oc+BVd6Xp6ql6d?= =?us-ascii?Q?eVBqDk9zyN+Tq2+Z0wkW4LKkOpnSfcKRpUbyGCZhaJBwTALGiGzHI3VtHxck?= =?us-ascii?Q?hOWJSBW5ySSJ8xxpU3Rkdv9g7tzdsCu93QaXSPZTkgS6NU37RrSUCVrUgmt/?= =?us-ascii?Q?dg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5724.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b78f379e-318c-4d4d-9ee7-08dab10a5da3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 13:12:10.4983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: buuisMwbAMMUfRWaY3WMjVr7HfK9T3cj437eTRZVnEODzsKoDNqVlFp0FdbYLsjVgVq1oHxftJ9deTgGPhSygJVMU3+SlARmuYmsU1y80pY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5981 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha <megha.ajmera@intel.com> > Sent: Tuesday, October 18, 2022 6:40 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; dev@dpdk.org; > Singh, Jasvinder <jasvinder.singh@intel.com> > Cc: stable@dpdk.org > Subject: RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe > config >=20 > > > entry =3D rte_cfgfile_get_entry(cfg, sec_name, "tc 12 rate"); > > > if (entry) > > > - subport_profile[i].tc_rate[12] =3D (uint64_t)atoi(entry); > > > + subport_profile[i].tc_rate[12] =3D atol(entry); > > > } > > > > > > return 0; > > > -- > > > 2.25.1 > > > > Hi Megha, > > > > Maybe you can explain how removing this typecast can provide support fo= r > > 100+G rates? > > > > The atoi() function returns a 32-bit value, while the subport and pipe = rates > are > > 64-bit values; this typecast can at most remove a compiler warning ... >=20 > Hi Cristian, >=20 > We have now changed 'atoi' to 'atol' which will return 64-bit value so it= will > take care of 100G+ port speeds. However, I noticed that 'atol' will retur= n > signed-64-bit so typecast may still be needed to assign it to unsigned-64= -bit > variable. Will send updated patch today. >=20 > Regards, > Megha You need to use 'atoll', not 'atol'. And yes, typecast is still required.