From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20E48A00C2; Wed, 5 Oct 2022 21:20:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0BB240DFB; Wed, 5 Oct 2022 21:20:15 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 6BE3940DDC; Wed, 5 Oct 2022 21:20:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664997614; x=1696533614; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NQ6X5RAza7k8YZLA3NT+UWHZ1q/L4esJJHiJk9NOCio=; b=c3XpSFlanX++CYV7mPNIG2kwOrwdfE0FwMMKEyXlE6Zf21LGfEkejtEk exv2G5xt5V8NxpjJg2ruPVdR/4mSkAqTDKGVgaeRf1xkzEpQZiBnPpb7n sSuxLK1xlCZ1oYOdiV31G3t6/VVr0LX2B9ROTqLuEKoEmar/51q9E1WEL nS1zbpgkoiChaDJTgl8j9GgTXoYXIvWQYLC6cf0VNzfPYpvuSY2ZgwoWy 9t+zv4ejYOTsiKnVbrgdVTc7j85sXu/ZkS+x7ZKV8U/fpV6UtVcMp0qL6 ppZKkTjK1Wr63xLasGDwqi36HzE4kO4d1DK37rPxXrCzT3fx86Fk69w+e w==; X-IronPort-AV: E=McAfee;i="6500,9779,10491"; a="367380405" X-IronPort-AV: E=Sophos;i="5.95,161,1661842800"; d="scan'208";a="367380405" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 12:20:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10491"; a="693037438" X-IronPort-AV: E=Sophos;i="5.95,161,1661842800"; d="scan'208";a="693037438" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2022 12:20:05 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 5 Oct 2022 12:20:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 5 Oct 2022 12:20:01 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 5 Oct 2022 12:20:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A7alCBLPnK6LA99u7ySW/8wQLoIMB1zUNYQldSNkKyztcll4P4rzUCx78Oosb5FLYpGDTJ37GuV18J9d+hUZpipVWvy9YSNQatteKQnv03G0DEBHBKf9V7049BFNPeKEEmJzGmqxQJSqToHS0ZDJgWiE3ABbqZsOMAh/Wdh6yPNGNnGVhoUxRszEKiRxCNWD8xb75tGSAkg/wI6ciBmuXVS13B2YorovwKmkWqv2DD+TbfjuU42ubTiKJYDUgifgYjVHwAM7T0KegzBrK95NXRrF4+5Sp92WcQzYmNprULmqU8/UKDt6kTDERHlFYB8xzM5QU6FQ6g6mw0fXkqi+rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7heIWp15pyt0Sh+Pi7jbxvyLWa6VRxbO8nKEO/ETnaQ=; b=UWyBjBVbpWdi4RxlOyqryIuDe6Y7WXvrxrHVTAYR2epY5LwfWPcDWASCaSkhXV62lwUluUewAQaP8WOlVk3R37KZv/+OHpMDQylAKc7P8d43/1gkNL+9h6LeUgOHbH1OVuUJLZiF8/lTlFV/oKtg3SReJhu2NG7mipIFZ97ADcFH/JjhuIXhSwsksx3UKW7kJ6sdejLzt6yh9NUNEqFNnCLmweSGdVz9cKuPjI4uMo1GFfQtoc589NID8XMYO7eRUrQ+Joa1xZR5DPKfuoEKu8iZFclAK+fI0NFb5KQ5CXa7djboRAztAtLYaaihe4rKdf6gCjWDBKiGYfYpfCOz/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5724.namprd11.prod.outlook.com (2603:10b6:610:101::22) by SJ0PR11MB5152.namprd11.prod.outlook.com (2603:10b6:a03:2ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Wed, 5 Oct 2022 19:19:58 +0000 Received: from CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152]) by CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152%7]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 19:19:57 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "stable@dpdk.org" Subject: RE: [PATCH v2] sched: Fix subport profile id not set correctly. Thread-Topic: [PATCH v2] sched: Fix subport profile id not set correctly. Thread-Index: AQHY2N+HS7chc6Dpa060Li8SJ585K64ALC1g Date: Wed, 5 Oct 2022 19:19:57 +0000 Message-ID: References: <20221005172239.254327-1-megha.ajmera@intel.com> In-Reply-To: <20221005172239.254327-1-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5724:EE_|SJ0PR11MB5152:EE_ x-ms-office365-filtering-correlation-id: 28b2b4af-7d84-4f32-b58e-08daa7069768 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K5DHYIK53SBXHAlQ2Qx/rwmI5HhsF+7m7bQMQhkezLipUbaSYdMDvD4AQv9y+bSwUB/2AZ/XcBQ4dTy/0LRQ7TA3nvUemuOkwkrP2W08wJuAb9xPNlv+UPZGMXMmb6Lq78V+Sfi49jfYGuoRLwABudVuQuqjDf73aPHxvt30Jqdf8ucy6pewx+I1efV20dPrn6fAMNlqdofIMbfDcDRfro14+V2H08OghzGueHhDvQq4nu7dsxyW5J7zZAC8LQdiUGEEFPPEU1n1DeNoyNv0nfnsH+CWTNQysWLMPHEnw2sNK7dUf8Bw1yjhCPZLE8V4+107t5wv7RNGNr09Bbb5IRa7XYICweJ7ITVP0sp66V93R9Ra1n+tEIo0I8g3KCAzJMl8dYkBShByj0U6MMcKouX7LJYfbw0N0iNzjYqnM5QcC2cfR+/OUXMC1dWR6nFui+9Ni0d3goftFVVpoBRL86zLhhp4+icIOaiHuuuYIuQBWfIw3hgbnbG03dhPrFCRl4VJSUTRqQDaHsoJ4aVlzIIaaEKndiB5GGxB6i8eKDm6PMPw87o1Obwwj1GEPH+4/VxI/j3Sca28c21YivPvqV1udX6C0GcFdvNYxdPfl5BM2hfuypiAf8GFaNIFsAYtqaztBKqjYTF603ED8e3xdovL/LhIkQlZj55gwgF1vpcLFSXU1HZxPugjsRoh3ET8GnhtWTl2wgbuYmjAh31ou8hGnSL/E9+CSwfazhaaXNfaLZDxjhvMVQHXyYiDDgVALY1h2gPErPaNYJrn6s9qWA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5724.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(346002)(136003)(396003)(376002)(451199015)(55016003)(8676002)(186003)(9686003)(33656002)(26005)(8936002)(5660300002)(2906002)(52536014)(4326008)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(83380400001)(41300700001)(53546011)(6506007)(7696005)(450100002)(38100700002)(71200400001)(38070700005)(86362001)(110136005)(82960400001)(6636002)(316002)(122000001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D+FQ5Cyugly3ofQNu5BZKeEHbM8zmPFGFD1ynNQqdaWy9BrutLNgdKDuah02?= =?us-ascii?Q?PIHQaRASUndnrDm2Sfo2rFMXuaZhY7cAuGkeYotpqDguhOlhk5qYgx5DzSw5?= =?us-ascii?Q?Ka9hpVJuU0u1Z46qPl68uAz9CHj9u7mMHLxBKtPgk8Rj6GmFnLdFJuIOigCk?= =?us-ascii?Q?n4EI4di0SZMxDln4vYCMTkOaM4vC0sEnRAbHS/9uyV/OUIXa5XLX4x5hYB37?= =?us-ascii?Q?NdkxNA6+DeVPw/TOwsuPTV9GP63nOfyiK1oH0hEoDrAYgCvHfNGZpehFGSoN?= =?us-ascii?Q?ORjccYBNYDzsJ8T8BYd8UKCvd1Yde7+iEemriQBRGRO630DUn0blpM7fIqZF?= =?us-ascii?Q?X3F8gSiE4wUCQf1Uoy6K4QIuYIk2+oe6n/dev9LuUZ/OOcDnw9uDAXr/OZL3?= =?us-ascii?Q?7jcpeycMD6VkSMmubtWGIux3MRM2uN/5vgwhWUXAUodA/G+bzqIxSrZI+DQ8?= =?us-ascii?Q?ZQzUcv4brxVWWAdWXnyeQwTF/gCCQMB833fTX4HxhtHgf0yZQQr+V+TzLS/U?= =?us-ascii?Q?h4kYlix5gEZSaRK//jBSyhKHHFm7SA1iriGdUZmAhvxWwIVK3cuttHlY0m07?= =?us-ascii?Q?KHTp7UQWah8Um9TPw9GE/XOiIwBvxdoX0Dve8rwZnqIThqeJrTq6v4qMNg9+?= =?us-ascii?Q?k+m4qptuuLL1M07yGD0rZKIeEoHR/ZHfrLTYQnE2P0MyWmH/C4s3YTSk5SNw?= =?us-ascii?Q?cyz6wvOmRl11y2o5lOee6T9vL0cpOYvu++qNdAZjY0a4ejnZ7LsamcQlgqmh?= =?us-ascii?Q?mukFitV+yvh7oH+L+jl/SnU4Xvm50R5Kz+iwQaemNqUksdRSjCK4VVWhtG2z?= =?us-ascii?Q?gEbf9Pji19Bas7kkIplR2F61l4NHle77f18yGVrAp7MuSp3YqQH9VridYgDg?= =?us-ascii?Q?C6P1xuhJwQ8BiSmAislOey9g0wNRwchK8IMl1ZqH9wQPeQJP/4iw0jGX46GB?= =?us-ascii?Q?/j42k02QGCotwQlPc5bNvClR2Bw0lc/lSLapDE/NfDTOKfZUxGtVDI6Qntma?= =?us-ascii?Q?rYdBvpznWHsdL1SZZWz/doiFhX5iCSFb618DMKniXF0YbMglpmaBXkxPDIjK?= =?us-ascii?Q?5muSWby4hm7fGLO15GI2+t8mC1GNyIov+iMUfQM0ByCiuQgGP6/BWQwNf714?= =?us-ascii?Q?N/KJrAa5Eov4RkU7vGtywtulSkHzBgJYdgs1LwHglNfa2Zh8hLiweuXvcfZ3?= =?us-ascii?Q?Ig9m6NsHYRy1g2CPe5lAUtA2SuN2lkV7Bsc0iR61q2Ur9/rxvUcgW0H4mhfN?= =?us-ascii?Q?wu66/U49gxWmGtzyy+YOqOM0gysEc24KD8KdpYCSOkCq8Vo78WgTJF03iFix?= =?us-ascii?Q?9514KUvjPwhLRYDYiXoEZiyYraD/Ej8EQJUOwaicpJtsWXdlxnGI97UmLx7E?= =?us-ascii?Q?WgaIytV20nSswML0tWQG3xn1CHv6eQT+5xk4TG8Eh2oPS6GKoqvfvisXSLas?= =?us-ascii?Q?DKEGD9g+x95FeAIIlSBbidFrnaJXPr60lCmmj32A5BD/CTlNX3LSNhHADUpA?= =?us-ascii?Q?8blpe6MmXOYIjZiGU8Lcjgexx61DSCSLm3x//Yfsf7ao1sAABo3InEKN/uC/?= =?us-ascii?Q?vcLRlJkcINfLDkuEUWawKsxyy5FkguXmbk8VmNg+LciZPRGurbXvwZkFcF11?= =?us-ascii?Q?dQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5724.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28b2b4af-7d84-4f32-b58e-08daa7069768 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 19:19:57.7585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fWOZxAmSKxtZ+Y32HJaArCvkDF9L2E0qtrhmqC0Aziq2nq62Ok/l+C7VbF389bsbCWjBWbtJt0LJhlg8d8we0KgE3EuG8fL6dsypFfHcX/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5152 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Wednesday, October 5, 2022 6:23 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: stable@dpdk.org > Subject: [PATCH v2] sched: Fix subport profile id not set correctly. >=20 > In rte_sched_subport_config() API, subport_profile_id is not set correctl= y. >=20 > Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") > Cc: cristian.dumitrescu@intel.com >=20 > Signed-off-by: Megha Ajmera > --- > lib/sched/rte_sched.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index c5fa9e4582..c91697131d 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -1257,8 +1257,6 @@ rte_sched_subport_config(struct rte_sched_port > *port, >=20 > n_subports++; >=20 > - subport_profile_id =3D 0; > - > /* Port */ > port->subports[subport_id] =3D s; >=20 > -- > 2.25.1 Hi Megha, I noticed several patches from you that all fix small things, can you pleas= e put all of them into a series as opposed to isolated patches? This is to = avoid apply issues due to dependency order. No need for a cover letter in t= his case. Can you please also pay attention to the details in the patch title and des= cription: -title needs to have a lower case letter after "sched: " -title needs to start with a verb -title needs to be short and clear -description needs to make sense Thanks, Cristian