From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 537CCA0545; Tue, 11 Oct 2022 16:26:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3207942DE1; Tue, 11 Oct 2022 16:26:41 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7557D42B7D; Tue, 11 Oct 2022 16:26:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665498399; x=1697034399; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P0Mz5ofY3O4w20x+aG1iaYZGWPdBWBVnZ/vHzcKXlNo=; b=V+E1SVbMOdCSRq9pMmuMNVYvOx9WdMArz/mtxSqfwmntK+l58P93JC/G 7BTpg9ZEksjQaKw2RbBWq97Cyuhi0QobaByVUzRqthMsOvEaWTGJTs1nJ 50rmhweHv/+bl1E2E3dtSsY2aa2bfrxwQuPbdUwNF7f/YcUed8kgvZN5i Bh6bzO/FI3cRH6iSt43M7pqWhBl7YC+UYdPQcLkJtgZfVswohUj17f7hC tAOUiBqA1+SkRRaNy6PG7llOXWKtdo99GMVW6cwD8Z3909UZQSV/5p1tN TIb1Jpobxo+qutFipV7HgAJbP0ojX/tbEKYd61JcV72sk4bZLTPzKrhPE A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="368679928" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="368679928" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 07:26:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="621421046" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="621421046" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 11 Oct 2022 07:26:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 07:26:38 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 07:26:38 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 07:26:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DdZT7TxV/eCjnxC7w0SWkMAty8cHlkqQeo+47mBjlaaBWxy9RziNet9OLKd2svVi87K7rHbHUXHfp/n2RDRh5VAFwvm9rSu6jjqWktbpCzKtgv0xFAZNtgoV9oQPGPdzZJxyTG4UM2W5DFrtTHRiqfR+f62n3O8zYwZlY2qy3eI1vy6an0mPpy2i08yCDt5R8tO0XOFxV7mHxmYY158i9Z+/bzGsONrTKeXrYvXzZDbtGDIIV8LNTOyEN8l6fDn81OYL0k8mD1Gny1wjRM3F9eNCUseCMmo1He19rJb5iebYtKH3T9c3V6ZrDZSBNoQ2sqFLhcnA4exB0BUT2UWSUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4L/fd7xgcislK39GLTCJ0x1aQ3Xp/WpO2Q/pUH4c8JY=; b=fHD8dJIAGuyRvqo/dx3UgNpTfvIM54yaQGNYdYDOT55pyT732BO5AKSP0IUTJZyvQFPhb4xmjtsSmTBQDHkwagzc/U0XK3y4tVQI7oJntArIgjwRhveKwu+D3vGcAgLszh6kVVkGeSWXO2NM4QL8QK56p5hCTr6fWBDpuUIQVH4e2CDl4JbzLgmFOSgfmJZTGSoxzGSkNOQIRIM5awiEAKbrwBuVA/RVfFT2tuOuTunANmF64eZXYoVhJmQnXq8OAGd6PQgZg5EO9JnvYVbtDn3wtz42tkY6sJWbqJFVMjgfyE5HHtXLfq3rQKPap+M4zntbn0ZLFjrrfg45RbCpzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5724.namprd11.prod.outlook.com (2603:10b6:610:101::22) by PH8PR11MB6705.namprd11.prod.outlook.com (2603:10b6:510:1c4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct 2022 14:26:30 +0000 Received: from CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152]) by CH0PR11MB5724.namprd11.prod.outlook.com ([fe80::e9b2:d565:bd40:1152%7]) with mapi id 15.20.5709.021; Tue, 11 Oct 2022 14:26:30 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "stable@dpdk.org" Subject: RE: [PATCH 2/3] sched: removed unused subport field in hqos profile Thread-Topic: [PATCH 2/3] sched: removed unused subport field in hqos profile Thread-Index: AQHY2bZvZwyEAVK0zUSXbaUp6toluK4JRpKg Date: Tue, 11 Oct 2022 14:26:30 +0000 Message-ID: References: <20221005172239.254327-1-megha.ajmera@intel.com> <20221006190038.431828-1-megha.ajmera@intel.com> <20221006190038.431828-2-megha.ajmera@intel.com> In-Reply-To: <20221006190038.431828-2-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5724:EE_|PH8PR11MB6705:EE_ x-ms-office365-filtering-correlation-id: 74c7b91d-2c80-44f0-cf5e-08daab949751 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qG2P8kdk5Z59XnfTWG/VUqRgT5tkqdKabE22dFw3Jsy0zn2QyXNuycTh5gZUkuz/gNv8Ol2elHLG9XYgKUvgM0q6055hIgK3rUNAtmOb9YxeKrZIpWSMv2NLqxQlXonTo+BYb8zX5rnhYa7UAUW/KkgIQQnmTGhU2LFS1HmjL9lubB1wiYobODFfk9TT58qCfnUjMmFEfaGHqDlCcpqiSmij3vAcXxgXQlhUBUZVbSatHbTbKf46YX0FKdrw+KXmR0PWvgPkMHiV6hUXCyMZU/SEvOEpN9nPipJEfl1niM/CoFGsjv4nFVXUFmyhmCKYHHnbpc6/SGkNZqbZ87ft6wa5QlEYcb6znT2J+kCjcegojDMsJHfOm+2wqAASqMYx/1FS+5XK0b9F1+pQI10xEh9b7roa+PxTwFfm/QPFuteMeTVQAKiidOnL5yJy5Qba615YuUBXVyLmfcGDFiShW4734ifYK9KAuNJqRfftaLtAmm6KYULNhAiGzH57IWUET5J0Zr8+8kgKvR4cv0uUOCi2XJt0ustFZJI4fDpnh/AKHwSgw5csX7pWCTZkXyYY9iJwOKDMq1JNaQHp+IZrARgxGxc5vjBLuMbI001E0mIJasKf60vW2U+FLlxzDJpnyM+pERxEjAu9oTuKqAqrk/zDHf7yXQSvdAeH6a9vY2jZ6wL/lJejjPgN68jWp7o13tUbfbKIylZegpdviMgehIx0SZtj4VYpHdFyYvsE8SC+/2dCnplQGiNUlXAUx6RPGwcgaNdQhhl5NsXaMwiQPQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5724.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(376002)(396003)(39860400002)(136003)(451199015)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(5660300002)(52536014)(86362001)(41300700001)(186003)(478600001)(26005)(2906002)(71200400001)(6506007)(7696005)(9686003)(53546011)(83380400001)(450100002)(6636002)(33656002)(316002)(55016003)(76116006)(110136005)(8936002)(122000001)(82960400001)(38070700005)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M5Nf/vIRE/Wc7deZjN/LeFbRTJh1162FRtyGUtArhFy18qvK0zQdoWL6b8RJ?= =?us-ascii?Q?Yqk8IHrH/E2iSnGtdJgnw46EEqlpHSbh/eXoVzfkPQOWYEywtF700i9Hb/TZ?= =?us-ascii?Q?BEdUYGp1oMm30gSIX8eYg2Ah2aG2EEwlpUOGEYJnyi2FRD868Lxmjmg512Xj?= =?us-ascii?Q?byHjgpA1mr02imL7JUVe8tBwKT4S7ZCkfYAmyP8m8S09+vlNKIHaP+v4bAm/?= =?us-ascii?Q?UFjOsnmjBp9Db4kVjbaIoEsRPuliFC5QshWYDY6OO2Kw2R80th8cWYCKLPAY?= =?us-ascii?Q?EIlImVnLgJoIuNsw5zMSNwTOW5mcQJAJbShBD53S24m97IRCm/n+k2X7UCgr?= =?us-ascii?Q?4doWpJmWwfoo9DjBmxs23auUf8Wzzbf8TPWaEplpASTZ33qJekWdlpIvmTs8?= =?us-ascii?Q?ZFZ3/3FFEqDJ8oqns/eOeuZVIXlwcsQ9NDsjWQxUvOidQq94tJt9dmZ23iCc?= =?us-ascii?Q?EEuZ+T/ihdMjJr87RVKLsqi+D93SXSoD8qshEwUee6DnqAArfIOmmK0ySegP?= =?us-ascii?Q?vPA0tqItc27wv/tsd4kazLcat0hoYoUmD3wXbxuQp12tvL7FmHL9E3WNojzM?= =?us-ascii?Q?ve4VEDUD/3kPL2i8LDvZy6XZPsfc+GxSBTN6WlABKSuOOEGt7Toujx8BsQTM?= =?us-ascii?Q?ysLQA7dChXcOfXjSu3QP/k1MJUhKJuYMxqlyVujXxGvlZPhPJQUGtzbqHnOz?= =?us-ascii?Q?quzZRcwxToqblZffX07zCkWmnNU+cjFPMhnYkr+NDdae1sKWI2lnRoXPQAzA?= =?us-ascii?Q?o7KGwvizbtssHW7uQC1cisPIqliQFydzkfbbQZbinRsC0TK/z+gqoa+ospkg?= =?us-ascii?Q?qqRLuNt9TK6Lsk51czQ7GIJ/FxhbRvXivi6axPckNeUOp1r+/qhdZuPYPpRQ?= =?us-ascii?Q?LGMTGr4JBo1n6X/l1tdhq2ZPHJy7h3Wcs17eUZXKumPJeiuQ7Rf3oadx4b0h?= =?us-ascii?Q?2JgVP4YstimBj+viv6ZRs1ErK7fJ5bPydGmOQ+HpaeL7EQeGqHLTop4wStVA?= =?us-ascii?Q?wL7lsVLqYUDxtr19Z3JzSpMiMSaE6qpVeFn3FPRlbwMQWN6hnAq7Bf6+A2HP?= =?us-ascii?Q?yIpkyqMy61Lr4M5rUubvxZlFYC/9Iw2K3uc/vWPL+KaSFf0/aXuhi5mT5f/y?= =?us-ascii?Q?5qCciDx5bjDKWQMRkv+Kt4MrcE/AWf6sUgaflBM67vSa6clF1D/N3ob2Ctuo?= =?us-ascii?Q?RKVtDGzU67Z+8d9oROaUhp6geKf/FzeHaLk833FFuzsR7MH2uG2Bg0pj3q0M?= =?us-ascii?Q?GxvcUo8baYc0s5DPN+hFAkskr6/kaV05AQRmIVA2ql8NxQ4eDhuk/a7AQa7i?= =?us-ascii?Q?SUEeWSiUf81Y4auceiW97mfE1VdyQPXTRU1pJUv4Y6jtBmhZeh+Cou62h2JE?= =?us-ascii?Q?XAKNHmBHyLFVAIDNdLz4sqPBtt7MpIdVM1v9ImmGu9bau3PGEewzPGSswu2/?= =?us-ascii?Q?7KFGYGiHj7Sxqj1kLkPYEc1qgHgVcQoor5Z23ft1M7jk6toNwG7zmJVsUHZ3?= =?us-ascii?Q?gv9vFiSBri/621wKGUth8SvrE1OkY/o01ozbKHnHAwADQkUlUcUI9z80K4DJ?= =?us-ascii?Q?DePWd7efic9aUYfBrjlPnyg00J6mxmfwh2svTtsfPyuGzOuxohxa+VrXIxHm?= =?us-ascii?Q?jg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5724.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74c7b91d-2c80-44f0-cf5e-08daab949751 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 14:26:30.8108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l+IuQXfa3CbAMgSFPfg89wit4zJdMUcQXmWeu6ksZe7rIZHMbG99o+LeqxwzPWxr4appbPAiVkEEdcyWD/DppOnBzHN+4aNX2injx3YfuT8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6705 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Thursday, October 6, 2022 8:01 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: stable@dpdk.org > Subject: [PATCH 2/3] sched: removed unused subport field in hqos profile >=20 > Removed unused subport field from profile.cfg > Correctly using subport profile id in subport config load. >=20 > Fixes: 802d214dc880 ("examples/qos_sched: update subport rate > dynamically") > Cc: cristian.dumitrescu@intel.com >=20 > Signed-off-by: Megha Ajmera > --- > examples/qos_sched/cfg_file.c | 2 +- > examples/qos_sched/profile.cfg | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.= c > index 3d5d75fcf0..ca871d3287 100644 > --- a/examples/qos_sched/cfg_file.c > +++ b/examples/qos_sched/cfg_file.c > @@ -157,7 +157,7 @@ cfg_load_subport_profile(struct rte_cfgfile *cfg, >=20 > profiles =3D rte_cfgfile_num_sections(cfg, "subport profile", > sizeof("subport profile") - 1); > - subport_params[0].n_pipe_profiles =3D profiles; > + port_params.n_subport_profiles =3D profiles; >=20 > for (i =3D 0; i < profiles; i++) { > char sec_name[32]; > diff --git a/examples/qos_sched/profile.cfg > b/examples/qos_sched/profile.cfg > index c9ec187c93..e8de101b6c 100644 > --- a/examples/qos_sched/profile.cfg > +++ b/examples/qos_sched/profile.cfg > @@ -26,8 +26,6 @@ number of subports per port =3D 1 > number of pipes per subport =3D 4096 > queue sizes =3D 64 64 64 64 64 64 64 64 64 64 64 64 64 >=20 > -subport 0-8 =3D 0 ; These subports are configured with su= bport profile > 0 > - > [subport profile 0] > tb rate =3D 1250000000 ; Bytes per second > tb size =3D 1000000 ; Bytes > -- > 2.25.1 Hi Megha, Please fix: -the title: "sched: fix number of subport profiles". -add Cc: stable@dpdk.org, not Cc to me; you need to add me in the "To:" lin= e of the email Acked-by: Cristian Dumitrescu Regards, Cristian