From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54EB1A0093; Wed, 9 Nov 2022 00:48:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00B944014F; Wed, 9 Nov 2022 00:48:10 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C4A05400D7 for ; Wed, 9 Nov 2022 00:48:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667951289; x=1699487289; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jrgIvh8X/59LiW8dy1GpgCy8Uy408bfSnKbPc5slkYQ=; b=IXrd2PAdCNSh90X/lPGZcboowVUC/5JSiyKENqO7tblD9cU4+YZZs4H0 tcLeVDbGxozE5xjC034HHXjq2yUWAbOKBnuKjkn6IkK1klVxsPH6FzNZe d8ZKjHXE8nOmlOZLw2Tk+Gn6+F41ZA9HpnBFPZxcUAfngV9PZVfN35z/A 9NmkdlI2wKidjtmVpMjbe5ZD7tWbPGbE4Uafu961vUqdOX0x533yo1QB7 zf3KDdEIOOdxWLaITsdrrIFLaSGWk0R1Hqcpia7TktYbTcL/YsEY/NK/P myYteWVWDV6+Y5AJkz3eZ8wCYwlD2OZPz/ocFUazeBdVAk7vXc/7wFiqm A==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="311995837" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="311995837" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 15:48:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="587559121" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="587559121" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Nov 2022 15:48:02 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 15:48:02 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 15:48:02 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 15:48:02 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 8 Nov 2022 15:48:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXrf3f3wlS4oBwpD+fxmWbVv0j3D+Y/edU9/UsyQETJI4xSNmrCdAuneQNGxF2/gSxV5YUn5j1teprHJcaKc3Bs64onmGiPfVtcscJpFouxzWrGdH1jre0jAIzBJ8P9oQZGvtQzGmVF1UP/48ZpocRIJsM3BVHdIChe3N/9NkZtZ32MYwE+QljRdmuavmBiu1G27AW3FsaWUlo9vSK+zcv+/UcT4+BMLeTyMhJub9fIJ01uMecjwkqYl4cvIAPYqfHW7Roi9z4Qh8BSKqZLAzCkBcZUvhK34WDi8Mf+xw/+9uJdbV7t9cSP1UssX6c6WUp7C5DyxLu3kV8fvTOEk6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7MWR6JE6f3lvHnTPDmZtWU7auWbB7iYoSHPLs8isvY=; b=nSdAzGH7SY9h6CRTyYb9mHgYj+cz97k6wZCAhJI7uX7VLwZ17vEs3Qk3DYVNz/jzQ/WmmM8pfriP4WekHBr1bjGudV4YkLGQrzXlrsVDm9S7ucaKf4lOev7WtuBye5RYpH1mme3ZzfbKmacEo4i93iwiVUC2E6CQ9fDfdIfE3iRDy/DxLkYYRyUj9IWIotx679hOPjiSEmdm/gSeni+0y0XcO9xetUgVsJ/WoaqZdATXjE7s70o5OomHf4n+A25DBTReRFwQa8+ulpR8Q2GvHxfuAXXWiaW/WYL9EbEko6zUWxuJJuuQryZPOsjKSNpPtbVjakAAvibYMAfOi62ORA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH2PR11MB4455.namprd11.prod.outlook.com (2603:10b6:610:46::20) by DM4PR11MB5549.namprd11.prod.outlook.com (2603:10b6:5:388::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 23:47:54 +0000 Received: from CH2PR11MB4455.namprd11.prod.outlook.com ([fe80::c88e:ade:95ab:e2c4]) by CH2PR11MB4455.namprd11.prod.outlook.com ([fe80::c88e:ade:95ab:e2c4%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 23:47:54 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , "maxime.coquelin@redhat.com" , "trix@redhat.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Vargas, Hernan" Subject: RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Topic: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Index: AQHY3mR/OJU5Izo8vEyVyrRhEklaea4nNV6AgAGKGiCAAAWagIAAValwgAswTiCAAJgqAIAA9//w Date: Tue, 8 Nov 2022 23:47:54 +0000 Message-ID: References: <20221012175930.7560-1-nicolas.chautru@intel.com> <2823585.NACDBdzCOe@thomas> In-Reply-To: <2823585.NACDBdzCOe@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR11MB4455:EE_|DM4PR11MB5549:EE_ x-ms-office365-filtering-correlation-id: 175575ca-9e22-492b-9f50-08dac1e3a7fd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jUJCwlJxedviw3jrEQLlvnAwaNE9ZOomNhpymF4/TvKB/Yzc2ykN/+QDdpPxQbErUHQqjw/pvPfH3aH11PuSd3SWrnje2i/DPFOiYVRab/zYc2cS3uU2iL6AuFfGBqBvAUP6fv5IYzrfEJKgq6O/sVW7iaJ2x5S9chtjrIu4fy3rEQHKb2W0wUod48M0yNxn4pjm3yBZKYVBowdBYzjpZ2Hrl3fsDjv3t4x+7ctM1ntnliyuSkZsYSlhlcwlKSngk5gJJ8b4hmqe6WRYdJepTwGhFoVUkflezrPB7Ey5ZDxvwSROtv2rjeC6sMHU3ypATKOtzB6RoZaZkEollqvHOMh5k31BRkaJeP400ACTxnlT99oG6xGUrFRIwGyaSbok4Txt5fJsc1FdrtZTxMWQ9nimudXNhgfRmZHDYJGvMJzY4OmoA3kZm8YwhyOdIE87sB0itgoPdoWWT/pZs8V9TsCa12SvJzW4JAs1eOwaKIeaLHMRXgLMtdcfOkW72cwcgMkJHGfn6HT1gUGqJLIsvqiM54fYotlXqSLxtSmKhwsA6WUd7iPJNkIL6yKSbG+tYouVrNkNjH0cIWKk11jp2Y+jVq1v+o3nShM7493QZljEIIN0aR4Qhr0aBTZYVTrxpehByctUNk5yZjIC4LGivoqhxsNIiGZMWqrJO+cfQ0wPJse+5zojGe4n2DB8XUC1XSwXpcaMdN+p1r0DtEji4MAryA4n872pW8AUIANPEIWah//gYh6Jl2g/HmXBt9VRWK3t+Zutn7i3skIXarYMxadGFbHEopDKqCtVPyOw+Vq3s/wcrJyMHVYmBK8L9uwylpyop+01qHvhGC56a8q4Ng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR11MB4455.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199015)(86362001)(33656002)(52536014)(122000001)(26005)(5660300002)(2906002)(8936002)(186003)(38070700005)(6916009)(66476007)(83380400001)(38100700002)(9686003)(316002)(54906003)(66946007)(76116006)(4326008)(64756008)(66446008)(66556008)(8676002)(41300700001)(82960400001)(71200400001)(6506007)(478600001)(7696005)(55016003)(966005)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fFXYYIkwYVhzf11KKI2ifreB9Q58szKlahVDzcF3p0y4JhHRvGUuZQZ+QkZO?= =?us-ascii?Q?5JHgKV7xtS9+IHb48BSlqrCfcEIj1OgmWVIaeovO2gJYGfShsfzi3fGep/zc?= =?us-ascii?Q?/rSDhE1ITFxbnL9BFA24jahlIKcgF206GXyLCao6Kr+V7Syr/r48lq5Y6/2k?= =?us-ascii?Q?BPVLK1+B0xgZUMwdLMnmpK/1kadje8gadfb+ZKB7FoT2sip2mCcVImh9abic?= =?us-ascii?Q?3rsIXdc9oMipeXvqfeX13MC+h+9ZxrfZiNvZUUtpBRlQbjwyrNbz9l7Gj9dj?= =?us-ascii?Q?K9SirUBla3P0A4nU2gZBx6t+Ui9LguqGmf+65PGcuR7b76b/XF4wk7qYG+Bw?= =?us-ascii?Q?fu910zM1OLRu6jIzhegZ7PeaEo+Szkk4QT/XCXj762F9+d95Ar1mcp0hABVh?= =?us-ascii?Q?dxjjPTrbOEW+fnCBj6BD/3V/B00D3spATeQRSO6b++3GiOVfGx550Tcoqtr+?= =?us-ascii?Q?fJphxVCZ0LngggwqKCgGqKEfrLZxXDEErLHrMPljLz80g7ezJxg5YSJu+1cb?= =?us-ascii?Q?Wm3VuM8Th1IfhruoRz1DNzDUqoCQHT4S2jhcsBxbhn8F5TspJmHAeocwHisN?= =?us-ascii?Q?acahHvZ+RAmpOy9ddrdGf23q3tXi0yg+8Jwj4SRu963jp7pLF/KQAnKT1hus?= =?us-ascii?Q?FFKfuJPu3qdS+aPN/lb+Ulon+IwHO6MvdOmQgqTAGANnZwcGSflS/6knsAT9?= =?us-ascii?Q?VnyrU6H36ypWA17UCwhCuZM+fpCmrE8ne92hOBnpY8ALIWe8bnvO0s6EJkoY?= =?us-ascii?Q?0EciSSNwX0elTD5QRkNCNbahRkJKUzWgbemUXeZbsNy5TJM7KqQiWSRUVvu8?= =?us-ascii?Q?EYTeTuKraF8OaQPLaE39yEc2pUMpFcnpt4eDb1fErW9hx0uSaNkjyWl//Tp6?= =?us-ascii?Q?cG4u2uk7NNcyp077lwuN0TwrNa5sn9h+KAKpJiClaZt2cp9Z32X1Vsqr4DpG?= =?us-ascii?Q?8Z4yBKfAWS6yCL3fregkk3zuD05U0nFDrl/ANzv+qR3djxhimO0vjOkp2KGP?= =?us-ascii?Q?I/we1/LDLO5P2Q0M+YLJ6SceOczPXlBUVMsPq0D3KkZohX7TekCEaH0zFGm5?= =?us-ascii?Q?szQyS/QrdRGoH7dYh7B/HP2qtHZdhCA31ryU1yXDSduXnzwcwnJ+PaOnHNiW?= =?us-ascii?Q?xQddhowSylD0VnyhetvDNHeSx96AOLUBHN5pWeRStR0NzrTj2/1K8UIz7c+o?= =?us-ascii?Q?k7pi7pph/H75ZFE3JIt/oPGIfLMnj+rhvtvSqy+fBurVBKf4Yt014I9Z39dR?= =?us-ascii?Q?iNPMqtTs22c59b91nzNu+ytJDgf2TC1etuaXWfValDNeLQlh4R/F++UOVOR1?= =?us-ascii?Q?gBJiEWvjCKn9MUtvz8L+MFuNbcjRa9MhCr/2pZ8cj0XrccDSrRdzb1bEBtP0?= =?us-ascii?Q?QDE1uuY4EUuJ7h2q+W9vl2E3dCrAuQWqFIV/Rcu1P6OsNm2wbm9jlqvJkWyK?= =?us-ascii?Q?vmLASsvGtihobN8du2YE/+VCNJWB2k0lMUsN6tq+pixjget5tqRSMhygtFEX?= =?us-ascii?Q?XYtmEwxtYdvG1ZGl1mVXBocXGftC5MXmlzW1CzxZONbJUAOa/DSrIFO/2AhR?= =?us-ascii?Q?dkyF+Sqm+9wAG5FmawIGiQrTST+OiIyWMr9hzsUb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR11MB4455.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 175575ca-9e22-492b-9f50-08dac1e3a7fd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 23:47:54.6187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OeLgP0UDF/1QqevyHnnyQqzPpZj+/lUewqAWt3HA+bRYf+Wyjb5R5Qe1QcqURt2xzwliMewOF5dH8Pi37Q9V/JB8POjA1Muw5NoQYIczpzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5549 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas,=20 > -----Original Message----- > From: Thomas Monjalon > 08/11/2022 00:52, Chautru, Nicolas: > > Hi Thomas, > > Reminder : do you mind kindly clarifying/confirming below. Then we can > update the docs accordingly. Thanks. > > > > From: Chautru, Nicolas > > > From: Thomas Monjalon > > > > 31/10/2022 16:43, Chautru, Nicolas: > > > > > From: Thomas Monjalon > > > > > > 12/10/2022 19:59, Nicolas Chautru: > > > > > > > +Bind PF UIO driver(s) > > > > > > > +~~~~~~~~~~~~~~~~~~~~~ > > > > > > > + > > > > > > > +Install the DPDK igb_uio driver, bind it with the PF PCI > > > > > > > +device ID and use ``lspci`` to confirm the PF device is > > > > > > > +under use by ``igb_uio`` DPDK > > > > > > UIO driver. > > > > > > > > > > > > igb_uio is not recommended. > > > > > > Please focus on VFIO first. > > > > > > > > > > > > > +The igb_uio driver may be bound to the PF PCI device using > > > > > > > +one of two methods for ACC200: > > > > > > > + > > > > > > > + > > > > > > > +1. PCI functions (physical or virtual, depending on the use > > > > > > > +case) can be bound to the UIO driver by repeating this > > > > > > > +command for every > > > > function. > > > > > > > + > > > > > > > +.. code-block:: console > > > > > > > + > > > > > > > + cd insmod > > > > > > > + ./build/kmod/igb_uio.ko echo "8086 57c0" > > > > > > > > + /sys/bus/pci/drivers/igb_uio/new_id > > > > > > > + lspci -vd8086:57c0 > > > > > > > + > > > > > > > + > > > > > > > +2. Another way to bind PF with DPDK UIO driver is by using > > > > > > > +the ``dpdk-devbind.py`` tool > > > > > > > + > > > > > > > +.. code-block:: console > > > > > > > + > > > > > > > + cd > > > > > > > + ./usertools/dpdk-devbind.py -b igb_uio 0000:f7:00.0 > > > > > > > + > > > > > > > +where the PCI device ID (example: 0000:f7:00.0) is obtained > > > > > > > +using lspci -vd8086:57c0 > > > > > > > > > > > > This binding is not specific to the driver. > > > > > > It would be better to refer to the Linux guide instead of > > > > > > duplicating it again and again. > > > > > > > > > > > > > +In a similar way the PF may be bound with vfio-pci as any PC= Ie > device. > > > > > > > > > > > > You could mention igb_uio here. > > > > > > Is there any advantage in using igb_uio? > > > > > > > > > > > > > > > > Igb_uio is arguably easier to use to new user tend to start with > > > > > it or specific > > > > ecosystem. This is typically the entry point (no iommu, no flr > > > > below the bonnet, no vfio token...) hence good to have a bit of > > > > handholding with a couple of lines capturing how to easily run a > > > > few tests. I don't believe this is too redundant to have these few > > > > lines compared to the help in bring to the user not having to doubl= e guess > their steps. > > > > > More generally there are a number of module drivers combinations > > > > > that are > > > > supported based on different deployments. We don't document in too > > > > much details for the details since that is not too ACC specific > > > > and there is more documentation no pf_bb_config repo for using the > > > > PMD from > > > the VF.. > > > > > > > > > > Basically Thomas let us know more explicitly what you are > > > > > suggesting as > > > > documentation update. You just want more emphasis on vfio-pci flow > > > > (which is fair, some of it documented on pf_bb_config including > > > > the vfio token passing but we can reproduce here as well) or someth= ing > else? > > > > > > > > There are 2 things to change: > > > > 1/ igb_uio is going to be deprecated, so we must emphasize on VFIO > > > > > > Is there a date for deprecation? Do you mean to EOL the dpdk-kmods > > > repository itself; or something more specific for DPDK code like > > > removing RTE_PCI_KDRV_IGB_UIO; or last to just take out from > documentation? >=20 > There is no final decision yet, but the techboard wishes we focus more on= VFIO > which is in Linux upstream. > Out-of-tree module (like igb_uio) is not recommended. >=20 > > > It tends to be historical but uio has value notably for ease of use. >=20 > I don't think it is easy to use an out-of-tree module. > It needs to be compiled and installed. That is more up to the user. For some users/ecosystems it can be genuinely = significantly easier and also historical deployments still to be supported.= =20 Even if vfio-pci is the focus for most deployments.=20 But mentioning that since you are thinking about removing support, I see va= lue keeping support for a bit still >=20 > > > 2/ for doc > > > > maintenance, it is better to have common steps described in one pla= ce. > > > > If needed, you can change the common doc and refer to it. > > > > > > Do you mean to remove these sections and just add a pointer to > > > https://doc.dpdk.org/guides/linux_gsg/linux_drivers.html instead in > > > all these bbdev PMDS? >=20 > Yes > If the Linux guide is not convenient, I suggest to improve it. >=20 > > > Please kindly confirm. I see specific steps for binding in many > > > other PMDs docs in DPDK, a bit redundant but provides simple steps > > > specific to a PMD in one place. I don't mind either way. >=20 > The other PMD docs should point to a common doc. >=20 > Redundant docs make very hard to update. >=20 OK, did an update on this v1 for your review https://patches.dpdk.org/project/dpdk/patch/20221108234325.45589-2-nicolas.= chautru@intel.com/ the warning from checkpatch is a false alarm Thanks Nic