From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25DB941B89; Tue, 31 Jan 2023 07:56:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09B7040E28; Tue, 31 Jan 2023 07:56:42 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2063.outbound.protection.outlook.com [40.107.101.63]) by mails.dpdk.org (Postfix) with ESMTP id 992E640DFB for ; Tue, 31 Jan 2023 07:56:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql0kEItF0+FUOSmg7GZVsYdRsqDAmWmVPTouCt9Zr+UsbPhQ+DXnMOA1FjTEeP0BjnwN8O01GEAdbVyFxBri49g+LhwXcUbrWU580twvJbCNRP4yRx1pJPiHeD1B+gRh2KMe5kmqrBmmsr0uaJd0eofg6DEAOAP7/oz/D5WrkXmLqcnnP8vUQTiTtcmR3lSH5qOvzJomlxkk88dLd8vOLYFXHyCXPgFGtfouYmziDhs3D6Wz57gxR8zC5d6gMGKJx578vRkca7wwpP+rWNjtfyRcEMutzj/yxcwT4OX35XzaWIUB+Xh9MOxNvndke1PeZqN0AsyKhINPnW2ZqotYlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7y2p2aTbwyj2RMvXjZsNoSoJaBdgYN+Wv2bhUw3Z1eI=; b=FMv0f7K2CeoZ/YIo0A77400WOdjKYOmrYePPF0odJopB6Mjc5eIDiYCMb9r01js15eIrSysFi0BPwr6Koax25z6CAH10JTkPOVj/MrWiryXK8AAktHU2fvAlqZ8BGOnHfjmNTyi3OK2hcBaalXaHIcVwHQ/KoOsO4/wHj+MyzeAVhagx7oRyL1EzZldz8wLTZET0M8Uvx87dh2d+M/Rpbq2benRJQbv0l4TjT+IOLiP4Wd5N8tyoK7Z4DK1lX4UHRx5Qtruue8baKc5ArsJWlA/qlhglndy/pMxh/noSNLwQWt5brBT/QjbmIld9AYK3lc0asXX9LoC9IV5cvAZxmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7y2p2aTbwyj2RMvXjZsNoSoJaBdgYN+Wv2bhUw3Z1eI=; b=VxfbbijyG7s2AZ61FghBY8JUf1D+86oNFTdEy3z0F04fjfhbq+XqEjkl14wvTJapy+8LyoZjekALpOfwOzobkwVwaPAHvFGa6kZTF7dj+/nhijcDCeeRNpPIMQ97I0vkbdc23awF0P9Y7OSTfK8bntPWdKLyRisewLBOnuahOIZimenfTBLtQGlzyMywLmT6KLts36j5T3faiY0pyLTYtG5fYSJUKOd5wEZT2nCWklmkY4x18nd0lc8oWa5/x7KgGPBOqvz/CFi4/zdLcsutHcf9/JiYCb+MHH2liuvHdnolyj1TqQqU4JLVXN1ctf6GCAU0yLjJlJtVRHxilmhpAg== Received: from CH2PR12MB4248.namprd12.prod.outlook.com (2603:10b6:610:7a::23) by CY8PR12MB7291.namprd12.prod.outlook.com (2603:10b6:930:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 31 Jan 2023 06:56:38 +0000 Received: from CH2PR12MB4248.namprd12.prod.outlook.com ([fe80::f2a4:bf61:61d5:2950]) by CH2PR12MB4248.namprd12.prod.outlook.com ([fe80::f2a4:bf61:61d5:2950%8]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 06:56:37 +0000 From: "Leo Xu (Networking SW)" To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support Thread-Topic: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support Thread-Index: AQHZFEb+/f0tDans3ke7C5heWW27ga6kDWaAgBRLcyA= Date: Tue, 31 Jan 2023 06:56:37 +0000 Message-ID: References: <20221212085923.2314350-1-yongquanx@nvidia.com> <20221220074403.1015411-1-yongquanx@nvidia.com> <20221220074403.1015411-4-yongquanx@nvidia.com> <3467707.0WQXIW03uk@thomas> In-Reply-To: <3467707.0WQXIW03uk@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB4248:EE_|CY8PR12MB7291:EE_ x-ms-office365-filtering-correlation-id: a0a8da39-d127-4b44-a6cb-08db03584c88 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y4BqeNKzxBT9UOrYj3XG4AlA1CYxlAfaV9ENVsc5EF3QWffMV38XFH6yewn3p9dIphdn1yBBE6ZohoI/65mFiFrNG3ZCD/yPsFXO8yRRi2rUbomq38w0iaX9I8shk+GtrsFOjYBE3mGqagL1jP+ITNwzhpcJycESdKmtIpch5m4I6KbS5JJXik6/Ca2yz+Xm92nNKsFpIkgTJ74cPgWjUX6yVOqPbbSIDysRJ67WokpqXsgEV+YnsgzlvM3vVp7H2MsoZr44pbHkV0/A9AurzaRqJau7rWc4aMvwTZDv1raqm92ecmf93Ngz+WN5J70LzeU2xsaBcjd5HiDtVf0s4Ru+cv15GzGOWZUrefeO2a7J0awQ9WUuw8nl6X/3sbJoMuYf2U+cUrmACrNlEEP6KLDBVTpIQ31q81dC1XM/AkSZnJUgj5rDyXXeQCW5EL8Bkl/W2uL84alBpJd02R3Z1GIRRkPkO0Ck2B4NMaUykKRsQtsfod5oTVAi6wXURpkQB8wkah1UMWNSMpgE/LALntlCnlewnWFe66x1Jsq92Pg7bvgpXryuifXZNWt8mxJSiY7DmU6gP3HSIP2jfu2EDrULYB6MqpeXOmUN1+eC8xF8shKmlNR8dmv7FmCgho+1mYvCsfaa9Pm8Me7NNh0sJEkvfq3TAmqhQguJ1QmhQvkPuRaZVbTgOXQgblLw4YjNUvkCVj3RNBBM4Eec25OCgg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4248.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199018)(2906002)(33656002)(186003)(26005)(9686003)(54906003)(316002)(107886003)(478600001)(55016003)(38070700005)(86362001)(38100700002)(122000001)(66446008)(76116006)(6916009)(66476007)(66556008)(4326008)(64756008)(66946007)(8936002)(8676002)(41300700001)(71200400001)(7696005)(53546011)(6506007)(52536014)(5660300002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NVE6BbOIHTtdDaE6DV0Wp9fY1j9meveCWp+tEQDOVYXXH4VVade9yP+cyiUI?= =?us-ascii?Q?sBDXw3EjmygIG2iNMnCX5zb1Y1kOIcHi4ysKO9rLGZXq8jqcIri6eUYMoJKr?= =?us-ascii?Q?3W3OLjWIupHx5b/rN2VkNlOtuYK7EARq3BX1EElfWVDssfJ1dJfdFYEFQIdM?= =?us-ascii?Q?uBBp+ErirgSAF3GzyNpCHPC63t3K3w9Mz51vOuihFhw+c9fVBzftYK3OfAL6?= =?us-ascii?Q?KU8YgpvEgVueFgn56zg2j82NQIB/6lcjBStXHoDXpH4ETPEe3y0R6GJZN4BN?= =?us-ascii?Q?EW64fUMVIn4YcEsQJ2Gz422mDdYPtm+O5mqUcKu1xetqZubzG/D+qPWn9TcU?= =?us-ascii?Q?4xTMSMb7QfNex/NMOHRVHY6koW3SoSAakbCrIrOSQZhJEn6h19OO5NQxBxZj?= =?us-ascii?Q?K7Dg0c7zVSOLNTyaVbqOUrwDzCSQdYXEVJvB50OWJ/p3Bfb2YUy0SuHCU0+J?= =?us-ascii?Q?iPP/MwBC9Ml8ow1I/fqBZ5i21e7GXigSC86fcnNx3b7nARgIXKQunqg1du8M?= =?us-ascii?Q?cjrY/95OUUn/ZQ73fOzKkAIj7x31wp8Bh8aqs4MiYgVtRiUaClsPuDtF45bG?= =?us-ascii?Q?rbWlaLteMbZmVxPjioAh0rQsDJJPkw0ySnpx5KEcvpbqGqY/8kJcxpLYGxQq?= =?us-ascii?Q?i2BilBNCvguxyxDqVi9xKRTTMAdqDS46gnPqmYsksOo6ZgNK9axTv3dXMNM7?= =?us-ascii?Q?v8i8mJFKdcX1PEZJWJlG6WWrcso6DTj1GyJk3s3GyFD7mQY69ohWDHBXBEt3?= =?us-ascii?Q?WMKlZcsgHn7zcnj78o4Giz8cffD5TQojwd9dsyb345YavpJGeXw8jTtVT7Lc?= =?us-ascii?Q?S0zeMnXMqseNbBht6zNAgAfpBzprh7N2j41JxCB3bmggLEIbUPZ2Dc3tEt76?= =?us-ascii?Q?1XRNyKkHW5ZrTemuKk5EGVCkU4gx70xjrCKCSGvPPQt0l2YmaVA6IEXy31GZ?= =?us-ascii?Q?9bpXmDPNZA+R6FOX1m/6KsDfsGH9F7ueopLBraXUs7p4boyumIMH6P50/wIO?= =?us-ascii?Q?TmUObfWVnj89V66634X4Ec6gFceAyDm6ksY8SZmwA3V2XkzGeyW/a4s0o2nl?= =?us-ascii?Q?bGJIE7YrBSmJeKvPdzchFej62j2b/iOShEnPaS8JEAMav1cfNddwagCK8H+8?= =?us-ascii?Q?/oH4gFt6WMGzexuOG02s/a3Z1A4DJ59eVupdMVuanFyeVQdA4hcC/cDN+mV+?= =?us-ascii?Q?iew7VWEo52DwxdddxuC4M54htnW92vaLobYt5vweeaPOud1/I+efWMnUR6od?= =?us-ascii?Q?TTiJbhr+kyZNqenzJGq2ovLo0giHfnLqBvHVv5Zi0vtRocwVIStepEvBavhI?= =?us-ascii?Q?U4oBjhw1hI2m/b6NnUJL6Cf+FmBnyCLY1JF7qWmaGErdWJ0AGfF+yu4n5/mp?= =?us-ascii?Q?CgMahUAyzTPFBfHNdmm1XQS39FGiXjWWOVTdXmdXmAJBZWPNB9JWsmPybI08?= =?us-ascii?Q?J8B7LVt5mZptrr+obboNJeeR3JPVyTb4Oe40luvGMskXPzWQeWHqOwyBeyR5?= =?us-ascii?Q?hU6g7jUiRPmu2rPWqwPDt9Hnw/XHTyPE0imWR1lpFGjfpDZVEPQmhx7qfIp1?= =?us-ascii?Q?dMVR6r0fzXqkrQ0pREUR1cN8D6lPb0tAZA6+PlD9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4248.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0a8da39-d127-4b44-a6cb-08db03584c88 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 06:56:37.8534 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KUgb/+ALQj1Bdyv+YM+yaH7qCszcUVfNdP2/Jnx9n4RUMrw1R1AdzPELakvAZEuhJPUsPdL4pRRaYtKCsAYibQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7291 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, PSB > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, January 18, 2023 4:58 PM > To: Leo Xu (Networking SW) > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: Re: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence matc= h > support >=20 > External email: Use caution opening links or attachments >=20 >=20 > 20/12/2022 08:44, Leo Xu: > > This patch adds ICMPv6 ID and sequence match support for HWS. > > Since type and code of ICMPv6 echo is already specified by ITEM type: > > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST > > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY > > mlx5 pmd will set appropriate type and code automatically: > > Echo request: type(128), code(0) > > Echo reply: type(129), code(0) > > type and code provided by application will be ignored > > > > This patch also fixes these issues in ICMP definer. > > 1. Parsing inner ICMP item gets and overwrites the outer IP_PROTOCOL > > function, which will remove the outer L4 match incorrectly. Fix this > > by getting correct inner function. > > 2. Member order of mlx5_ifc_header_icmp_bits doesn't follow ICMP format= . > > Reorder them to make it more consistent. >=20 > Please don't fix stuff in the same patch as a new feature. > You should have one patch per fix. > The code for the new feature may be squashed in the other mlx5 patch for = the > feature. >=20 Thanks for that good catch.=20 Actually, those "fix stuff" related sentences should be removed. I leave it there by accident. Will remove them, in next patch