From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB347A3295 for ; Wed, 23 Oct 2019 13:44:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7632D1C10F; Wed, 23 Oct 2019 13:44:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 484271C0BF for ; Wed, 23 Oct 2019 13:44:05 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9NBgdls014884; Wed, 23 Oct 2019 04:44:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TbWf9nCs63c/eG0XMbyBZ94AfeaSD/IMV1x/O5CxWzo=; b=Y+bBkkNwqJku0oxpKyG9Uifrd/neOJFWjTCQjJbB32XkNNsyegHW+rcoXIM2jegtIVFY LD2gGhWQSOzqRFTB1yztgxiWRNbaA3wtn6jGmup/DboWtaRxx6l+aD11lcnAIpHUk9cv wrXWYDNsuT8H6NWhBiMR/NWLIv1qLSwyPqDzT5Gi8rrezdE4m9ngDcokrHjZw5l4V9OK CDFZC3rVaAGzWjx1lOgEKVz8770pOjab1bpmRi7V6YwxDA1hw5oTNa5gDLpMZEdOuP2J j6flLWUWmL9Z9Bc9pFqJAfehiP4xemsKuptsZoe8ErWlnSAlcudS0cuSMEv6Le/dnTk1 Qg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2vt9u5jk3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2019 04:44:01 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 23 Oct 2019 04:44:00 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.59) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 23 Oct 2019 04:44:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8kD7XIcDbx/1bXCVhRa89+jqe6KpAbd6zctrrEkLdUZVMWsHUKdZsmkiNf35LFu7wc0jlCOYPLn3EMOaW+aRlVg7P0MVYsdAcEpOxuwryh5f/7qivBGUgpHetA6yXDof3dmx5dbMPUs4Senw96wiHVmsmEYz/uw9PjfVXAuu1+bQ/8vIOYqzGaZu4kxtEvQXdUT3Y5trIxecmF/tf0uAVnlrhsq435Kgaol4R5v0Dsw5IADZYHE7A+/fGbJucUtDoJIcwNRghMEinGJLw11BdDBnumKBcVaknrS8uY7ZV3ZpDeMxwjP+E+OoqptljpxmNQWtvypZAmJPUjyw6ZCAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TbWf9nCs63c/eG0XMbyBZ94AfeaSD/IMV1x/O5CxWzo=; b=Reipl/HEyXLDn7UBFPcOX++JfTdOMeW/gKDY/hpUoGCA4VcztU5BNhU+s3IFM2qsUckTvQCWJZlWmuV9jXYuysWnlva40uEzilJNF+f4UQBDbHUbfs0bDx96oNX+d0rzQkZxL7dLTkfElYoR9DARcXDsGEjOWpxLWfsbszURMChlDhOzJPaqv8iv926YAF6apCtqQTW2PJ7Ted5DgHCy180KTQJNqcT3U2v6/dJeJykpjpro6zHVg7QmNODzp1Vmt82uUxb4VOF5VHCOudv9Jk72iAMJwctzjws5DIB9KY1GLg7WAV5Ue8il2gbp/70MlVYIp27jYh9ALAoZpVbOBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TbWf9nCs63c/eG0XMbyBZ94AfeaSD/IMV1x/O5CxWzo=; b=c6MFX2IjXU9YZ2K5cMPDJO2KFzEq4QCJxWwpBGKaCJgL4E/0Gtxnm25P8o7Lndf4rPpQX4WwVS3pkxAJ6me8kjCtuv3RjyKb4jpPz7uJ44vfqR2VxZoUErkVl7F0z538J4QMVPvbd8/p1f3KYKQjayT4ikU6MvQDtadDAT5u43c= Received: from CH2PR18MB3272.namprd18.prod.outlook.com (52.132.231.209) by CH2PR18MB3176.namprd18.prod.outlook.com (52.132.244.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Wed, 23 Oct 2019 11:43:58 +0000 Received: from CH2PR18MB3272.namprd18.prod.outlook.com ([fe80::e446:9487:82ba:de3c]) by CH2PR18MB3272.namprd18.prod.outlook.com ([fe80::e446:9487:82ba:de3c%6]) with mapi id 15.20.2387.021; Wed, 23 Oct 2019 11:43:58 +0000 From: Kiran Kumar Kokkilagadda To: Olivier Matz , Raslan Darawsheh CC: Ferruh Yigit , Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , "Andrew Rybchenko" , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v10] ethdev: add HIGIG2 key field to flow API Thread-Index: AQHViY/CSczl+knqS0ygtC5DwXGQhKdoGdyAgAAAzHA= Date: Wed, 23 Oct 2019 11:43:58 +0000 Message-ID: References: <20191021091617.11290-1-kirankumark@marvell.com> <20191022041648.4812-1-kirankumark@marvell.com> <8339b371-b0db-480c-426c-2f1cae244d3b@intel.com> <20191023113913.GK25286@glumotte.dev.6wind.com> In-Reply-To: <20191023113913.GK25286@glumotte.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [49.205.221.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ce6fcc9-ef9f-41fc-a94c-08d757ae4abe x-ms-traffictypediagnostic: CH2PR18MB3176: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:328; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(13464003)(199004)(189003)(25786009)(11346002)(446003)(3846002)(486006)(6116002)(476003)(14454004)(71200400001)(8676002)(71190400001)(81156014)(6436002)(478600001)(6246003)(9686003)(55016002)(6306002)(66066001)(4326008)(33656002)(966005)(229853002)(66946007)(66556008)(64756008)(66446008)(66476007)(76116006)(81166006)(256004)(14444005)(7736002)(86362001)(26005)(305945005)(74316002)(52536014)(5660300002)(316002)(76176011)(102836004)(110136005)(54906003)(53546011)(6506007)(186003)(19627235002)(2906002)(99286004)(7416002)(7696005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR18MB3176; H:CH2PR18MB3272.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c+fuX6meFC5PU0t1ASGz1EbTfnTWLRoMIq+lvCHsXnGh6dea212Vd4LNtt4BKq5Wgce/DKjZvbmQBa+7Fv0UzNlHMej2lTRYyDMGqK92m1Ufa1mqSW9hXLQGxoBJzJr9H0n4DZEawcIC9sPhqxCa5JjlbqTec/PszZdqgCXodIw8ckyyHWmyRGZeei1bCiThhl7hkc+5OXgA/bX6PAXHidsdT3TSDHjUStLieVpbzZwoxBhzvGnVMjmXS0144w15SoWMfl+YRwg7C/Ux2+xcEKzYioj3ZvfNXeceoEOBTTXI25lKYaLLazwRfAjKr2FO8bFEG8kReuVie+FYkraLo3ZE3FrR3/8DsRfiuL77s01KlunxEiB6iU8hA1+kwDVEFPytaw2qwFxTrOH3I5Fc1wk4wnGS7RqnhKM0rWNIvRd2sLHxrTyj+SsehsAF+uvIzUa6xUFNBYdbG2tE7uGT3py4wxHjuBfaNKDHLzIUS0M= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce6fcc9-ef9f-41fc-a94c-08d757ae4abe X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 11:43:58.3901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nVvSWeMiLi7as1fECsgN/iZldNie/O5TZxC7GLgP1PoJA5khtIUTF91xzyEOLpy0lxm+B932u1ITeW6yAW9mUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3176 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-23_03:2019-10-23,2019-10-23 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v10] ethdev: add HIGIG2 key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Olivier Matz > Sent: Wednesday, October 23, 2019 5:09 PM > To: Raslan Darawsheh > Cc: Ferruh Yigit ; Kiran Kumar Kokkilagadda > ; Adrien Mazarguil > ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > ; John McNamara > ; Marko Kovacevic ; > Thomas Monjalon ; Andrew Rybchenko > ; dev@dpdk.org; ajit.khaparde@broadcom.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v10] ethdev: add HIGIG2 key field to= flow > API >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi, >=20 >=20 >=20 > On Wed, Oct 23, 2019 at 10:50:52AM +0000, Raslan Darawsheh wrote: >=20 > > Hi, >=20 > > >=20 > > This patch broke the compilation of MLX5 PMD in debug mode: >=20 > > >=20 > > from /root/dpdk/x86_64-native-linux- > gcc/include/rte_ethdev_driver.h:18, >=20 > > from /root/dpdk/drivers/net/mlx5/mlx5_mp.c:11: >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:112:2: error: ty= pe of > bit-field 'opcode' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t opcode:3; >=20 > > ^ >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:113:2: error: ty= pe of > bit-field 'resv1' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t resv1:2; >=20 > > ^ >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:114:2: error: ty= pe of > bit-field 'src_t' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t src_t:1; >=20 > > ^ >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:115:2: error: ty= pe of > bit-field 'pfm' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t pfm:2; >=20 > > ^ >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:116:2: error: ty= pe of > bit-field 'resv2' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t resv2:5; >=20 > > ^ >=20 > > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:117:2: error: ty= pe of > bit-field 'hdr_ext_len' is a GCC extension [-Werror=3Dpedantic] >=20 > > uint16_t hdr_ext_len:3; >=20 > > >=20 > > and this is with gcc 4.8.5 >=20 >=20 >=20 > From https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__stackoverflow.com_questions_10906238_warning-2Dwhen-2Dusing- > 2Dbitfield-2Dwith-2Dunsigned- > 2Dchar&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DowEKckYY4FTmil1Z6oBUR > wkTThyuRbLAY9LdfiaT6HA&m=3DGZ- > 6cngPycaUlGJT20VEOf9oTcp5PMwk7j1JV1vAQfs&s=3DSCg5yVPS4zZa8GSn9bl_eUtI > vBmoDzi35PspWUttIUY&e=3D >=20 > it seems that it is allowed in c99, so I guess it's a gcc 4.8 bug. >=20 >=20 >=20 > Adding __extension__ above the struct solves the warnings, I suggest to >=20 > add it. /** * * higig2 ppt type1 header. */ RTE_STD_C11 struct rte_higig2_ppt_type1 { uint16_t classification; uint16_t resv; uint16_t vid; #if RTE_BYTE_ORDER =3D=3D RTE_LITTLE_ENDIAN uint16_t opcode:3; uint16_t resv1:2; uint16_t src_t:1; uint16_t pfm:2; uint16_t resv2:5; uint16_t hdr_ext_len:3; #elif RTE_BYTE_ORDER =3D=3D RTE_BIG_ENDIAN uint16_t pfm:2; uint16_t src_t:1; uint16_t resv1:2; uint16_t opcode:3; uint16_t hdr_ext_len:3; uint16_t resv2:5; #endif }; I have already added it. RTE_STD_C11 , this is a macro for __extension__.=20 /** C extension macro for environments lacking C11 features. */ #if !defined(__STDC_VERSION__) || __STDC_VERSION__ < 201112L #define RTE_STD_C11 __extension__ #else #define RTE_STD_C11 #endif >=20 >=20 >=20 >=20 >=20 > Olivier