From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DD64741CBC;
	Fri, 17 Feb 2023 08:32:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 74E5740EE1;
	Fri, 17 Feb 2023 08:32:46 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mails.dpdk.org (Postfix) with ESMTP id E5F0340A8B
 for <dev@dpdk.org>; Fri, 17 Feb 2023 08:32:42 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1676619163; x=1708155163;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=1xUx3Pu99lYOqvTfDm8p5ffH6nr5fFhTMoUQEC9FQwk=;
 b=PKHyiQFSTh1OC0mt3d48f/+D1MkUeMKraw0aZamfrpf0koUCZ9VytZ4P
 +2LEpwZyZDNG8eIPz5shrWOOqFnPfi2sIPuAZI3G2cLNLSbu5cqgChXix
 kaMHu244H6uPyCj83rF3D2SLy1UOeiCYXnRr0M8tbQZgpBPmk+U1oFWv0
 zSpNbkPT6OEYYCVKqt/YKagZrwtN2tUe8JhAfxZX7u2FZhf2ew5bGXMLY
 XI32hEBhqOOq/rLj0L1IFBVBpq7OpSZYav1zPOFYMnqgv8eMQlhyOi7jT
 hADj/QMKUpAatwviVtZbtXuq+K835yu3/ERw+GlX1bXjMCneD60J7UquY g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="418151990"
X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="418151990"
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 16 Feb 2023 23:32:37 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="647994867"
X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="647994867"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
 by orsmga006.jf.intel.com with ESMTP; 16 Feb 2023 23:32:33 -0800
Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.16; Thu, 16 Feb 2023 23:32:32 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.16 via Frontend Transport; Thu, 16 Feb 2023 23:32:32 -0800
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.16; Thu, 16 Feb 2023 23:32:32 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kWjMpob0irQ1bWuNOSfwplr2P3+CK9lsBgvrhmTPuS2wG0xIN6atJxInLRuHFVcW5DgD4jLdsW1vk9wMdi/Zn60FRKohhKFhAsFD+aaqk6wUdwis/Mn9ZI0ibgOG2m8pKGuG1pO/pqtDToTHmLL+oGkld9jFq4+mguzVx1ViGLccHDWht3YpMlfqysWwuhF91YbLOUI94+x0kQpPrq24ufMfRjVIig4Y38DqwcESK4gXSpJV5gFTXx9UIyEREboFlZ3FUSbkPqHy/73MHyfFlXWZV+bfjSlMdsgcA6qtZd36FBVxBybh4vJ3QxSQnm42KRn2stxyX2n71nw8cYb90w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZA10UVDpm1gd0vFDTJeyS7aLSMb9R8l1BfnKaKno5jc=;
 b=btVJAjA2jRGBT0lmpMci5UN7u6JqP/lw/d6ZPcL9V/dPKy0XqPyDMjnl4dRArvfi3kHUI+fZgrtet8b94BBlLWnRhZLkSAb0eG3MVHorDrSqtd9EmkLq639SOF8WNzFw7pG5sGx9E9QhLg6KTIaxjySNGQBtfmXd10WK2tFXAILaI5L+RwoZa0pE3bobqA0dtY57rQ2tkGLl9q1cLxqvWzEJeZNTjmyt1VFY2BTzkVGhH8OZX6nTZE44dR7j8Z4I3VvXWJv4QW08I2d50R48HgMQMa9rcJZhIfub5oOJXcgr/lbhNhcgva8AuNogFUQ3cJ4+U1iBivmMo3PBCVF61A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from CH3PR11MB7275.namprd11.prod.outlook.com (2603:10b6:610:14c::20)
 by CH3PR11MB8210.namprd11.prod.outlook.com (2603:10b6:610:163::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb
 2023 07:32:25 +0000
Received: from CH3PR11MB7275.namprd11.prod.outlook.com
 ([fe80::ef08:e74e:55c8:5aa0]) by CH3PR11MB7275.namprd11.prod.outlook.com
 ([fe80::ef08:e74e:55c8:5aa0%3]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023
 07:32:25 +0000
From: "Li, WeiyuanX" <weiyuanx.li@intel.com>
To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>,
 "orika@nvidia.com" <orika@nvidia.com>, "ferruh.yigit@amd.com"
 <ferruh.yigit@amd.com>, "chas3@att.com" <chas3@att.com>, "humin29@huawei.com"
 <humin29@huawei.com>, "linville@tuxdriver.com" <linville@tuxdriver.com>,
 "Loftus, Ciara" <ciara.loftus@intel.com>, "Zhang, Qi Z"
 <qi.z.zhang@intel.com>, "mw@semihalf.com" <mw@semihalf.com>,
 "mk@semihalf.com" <mk@semihalf.com>, "shaibran@amazon.com"
 <shaibran@amazon.com>, "evgenys@amazon.com" <evgenys@amazon.com>,
 "igorch@amazon.com" <igorch@amazon.com>, "chandu@amd.com" <chandu@amd.com>,
 "irusskikh@marvell.com" <irusskikh@marvell.com>, Shepard Siegel
 <shepard.siegel@atomicrules.com>, "Czeck, Ed" <ed.czeck@atomicrules.com>,
 "john.miller@atomicrules.com" <john.miller@atomicrules.com>,
 "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
 "somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>,
 "jerinj@marvell.com" <jerinj@marvell.com>, "mczekaj@marvell.com"
 <mczekaj@marvell.com>, "sthotton@marvell.com" <sthotton@marvell.com>,
 "srinivasan@marvell.com" <srinivasan@marvell.com>, "hkalra@marvell.com"
 <hkalra@marvell.com>, "rahul.lakkireddy@chelsio.com"
 <rahul.lakkireddy@chelsio.com>, "Daley, John" <johndale@cisco.com>,
 "hyonkim@cisco.com" <hyonkim@cisco.com>, "liudongdong3@huawei.com"
 <liudongdong3@huawei.com>, "yisen.zhuang@huawei.com"
 <yisen.zhuang@huawei.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, 
 "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>,
 "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, "Su, Simei"
 <simei.su@intel.com>, "Wu, Wenjun1" <wenjun1.wu@intel.com>, "Yang, Qiming"
 <qiming.yang@intel.com>, "Zhang, Yuying" <yuying.zhang@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, "Wang, Xiao W" <xiao.w.wang@intel.com>, "Wu, 
 Jingjing" <jingjing.wu@intel.com>, "Guo, Junfeng" <junfeng.guo@intel.com>,
 "Xu, Rosen" <rosen.xu@intel.com>, "ndabilpuram@marvell.com"
 <ndabilpuram@marvell.com>, "kirankumark@marvell.com"
 <kirankumark@marvell.com>, "skori@marvell.com" <skori@marvell.com>,
 "skoteshwar@marvell.com" <skoteshwar@marvell.com>, "lironh@marvell.com"
 <lironh@marvell.com>, "zr@semihalf.com" <zr@semihalf.com>,
 "radhac@marvell.com" <radhac@marvell.com>, "vburru@marvell.com"
 <vburru@marvell.com>, "sedara@marvell.com" <sedara@marvell.com>,
 "matan@nvidia.com" <matan@nvidia.com>, "viacheslavo@nvidia.com"
 <viacheslavo@nvidia.com>, "longli@microsoft.com" <longli@microsoft.com>,
 "spinler@cesnet.cz" <spinler@cesnet.cz>, "chaoyong.he@corigine.com"
 <chaoyong.he@corigine.com>, "niklas.soderlund@corigine.com"
 <niklas.soderlund@corigine.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "sachin.saxena@oss.nxp.com"
 <sachin.saxena@oss.nxp.com>, "g.singh@nxp.com" <g.singh@nxp.com>,
 "apeksha.gupta@nxp.com" <apeksha.gupta@nxp.com>, "sachin.saxena@nxp.com"
 <sachin.saxena@nxp.com>, "aboyer@pensando.io" <aboyer@pensando.io>,
 "rmody@marvell.com" <rmody@marvell.com>, "shshaikh@marvell.com"
 <shshaikh@marvell.com>, "dsinghrawat@marvell.com" <dsinghrawat@marvell.com>,
 "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
 "jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>,
 "jianwang@trustnetic.com" <jianwang@trustnetic.com>, "Behrens, Jochen"
 <jbehrens@vmware.com>, "maxime.coquelin@redhat.com"
 <maxime.coquelin@redhat.com>, "Xia, Chenbo" <chenbo.xia@intel.com>, "Webster, 
 Steven" <steven.webster@windriver.com>, "Peters, Matt"
 <matt.peters@windriver.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "mtetsuyah@gmail.com" <mtetsuyah@gmail.com>,
 "grive@u256.net" <grive@u256.net>, "Singh, Jasvinder"
 <jasvinder.singh@intel.com>, "Dumitrescu, Cristian"
 <cristian.dumitrescu@intel.com>, "jgrajcia@cisco.com" <jgrajcia@cisco.com>,
 "mb@smartsharesystems.com" <mb@smartsharesystems.com>
Subject: RE: [PATCH v11 2/6] ethdev: add trace points for ethdev (part one)
Thread-Topic: [PATCH v11 2/6] ethdev: add trace points for ethdev (part one)
Thread-Index: AQHZO+E3cMhzBY31Xk+Rj5YPWUwp/q7SxZZA
Date: Fri, 17 Feb 2023 07:32:24 +0000
Message-ID: <CH3PR11MB7275842C2B1B798EEB9EB9D1E4A19@CH3PR11MB7275.namprd11.prod.outlook.com>
References: <20230208132824.775985-1-adwivedi@marvell.com>
 <20230208171215.787063-1-adwivedi@marvell.com>
 <20230208171215.787063-3-adwivedi@marvell.com>
In-Reply-To: <20230208171215.787063-3-adwivedi@marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CH3PR11MB7275:EE_|CH3PR11MB8210:EE_
x-ms-office365-filtering-correlation-id: c14d6194-c943-4290-ba3f-08db10b91d2a
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: oK8LHcapT33eG0wOrPdLhGbWIsMqEZj6v6PbzYErymKRMItcBYjVmp1X/3OUqazgFDWukTz4MlMg8mbXstUNamd3SvD+idCZtJq4IbOeWJCuRnz+ChnuCHdyIobAU2F+rQ8Pz7fzgTa3ztMVFV3FNax8cVnBcqu7PA87RhWMRiSPBLIrkl5bzQv+4OZRbJupGz2pbrZc2age5A3jV1A7TF785P5ttgJ/HbYa3lYKt0kl3I9G/96Vq7Mxn6/RWBi71iI/oLdHQXca2Hnv9u5b0/hu7yaic+PMw0H/9IVSsp89s3ujwy+6x90CTHPqKNaLCpRyIqlhHVW2Mgr+YeJNjcjJIMTCZdZCmy8fg8QUeFsxkDiMKROwO4cELqHtQP3Xx57TgG2t13ZCDa4RaDu08IGXSCJ7E+jLaGngm7N6+wiQ4lt/THBQ2z3/ztPdC3q1GSt35DPH5Uj3SfvfGMckNqh4hvFOxXiz/avOQKJuddnpcpeC31loCWpNLWfueAVML/MhLnIqCRxWuH6Vfl5XHx/dqR/IQcrB0Y+DTjNgcRhTA6TepQTkRp5o7QhHo50tGLtNCNWW1bS8hWxr6Vd7twM6Wr47MPl1jI6JAKRvRAvkI6MDtWjsKYinSPjawE2HG7lVc0r1HX1M4s1H2R6RTir4PSFIyZnrMMZJH+1l+ajizxdvrt2Hojkm/V8kuX/+
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CH3PR11MB7275.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230025)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199018)(86362001)(82960400001)(38100700002)(186003)(83380400001)(33656002)(38070700005)(6506007)(53546011)(9686003)(26005)(122000001)(45080400002)(7696005)(478600001)(966005)(54906003)(66556008)(110136005)(64756008)(71200400001)(66446008)(66476007)(316002)(66946007)(8676002)(76116006)(4326008)(30864003)(41300700001)(5660300002)(52536014)(7366002)(7416002)(8936002)(7406005)(2906002)(55016003)(579004)(559001);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F+XDDXWJkJKKcUzBASSykCd25yYUCh388nK+layyUNuRRYgt64i4QPmHaKrx?=
 =?us-ascii?Q?j/nUjFcWrS8GqnqIQJR6tr5oL2EfE5DyRSfmuTIQsx2a+87ViOn6/kzwRvjN?=
 =?us-ascii?Q?acyVnymvn3e5MzOR3U51T4mx1Y19q5RhK+TNQFYFUe/QvJK5C4Qia4KU18rw?=
 =?us-ascii?Q?U4KgaMdbKy2+WoJLId3Lnabn6dvFZnxhb8YfWI9rbFrIT673W4cMoahIfViJ?=
 =?us-ascii?Q?8gTCCE2sUeGjomjoZpFMmKwQxq7YUDQ7JEznrr/oBQYZId42O7z/RsvevaqV?=
 =?us-ascii?Q?8y7XzB3S6uTXHTAYO3OTiOZRyDKC4kjK1QDRKByW1T/IeX+JBUiJx4dqCw+W?=
 =?us-ascii?Q?1roa+yJCwBaxxBM9LDRyCCjDZ5YekQKN2QriMJFXCLh5VTYKruoBUx4Vkp6w?=
 =?us-ascii?Q?OiHjYJp1UwIa5NLMrTdOa0iVoU1ZyNiklLhnXPeIZgZvA4hBI2UwCwveWpE/?=
 =?us-ascii?Q?0oB2L7GXNXIyQlKTrLHtYVBoMzuTcY4hgZG62Z0yH7KqNG/z9qFm8s3rruMT?=
 =?us-ascii?Q?LrLWd9jZJhdlu9sF8y/7uV5swt0v8pKZs4oaKjYW3OLrUBSqaeN7awIGizW+?=
 =?us-ascii?Q?hmlkMrW0Mu45BKZdSR90au4hkXgNabQBzPkY+RJlo76Z6xDZy+epI1nE49v6?=
 =?us-ascii?Q?S6f4thjGjOuCXoqqowjjfZ7UlMpc5j2m+Qen6Li/CVzfP7kDhmBAIPJ92TPi?=
 =?us-ascii?Q?BB9qkPBRnCeP4nmxAMRuiKqDp5IBvIfXcofjJVEi1k6iu8lgZYaf2Cu8xq43?=
 =?us-ascii?Q?+1lHtVzykW+JA523qLmIDqmYziYnSFshyiSVJlZJ8YfI8NABn00mVApp5Wp/?=
 =?us-ascii?Q?uGYEX8Yae9ExKqU7jzR5G3Kf899uOM+K+pmwXOow4808OOhWOaQJvAm11M//?=
 =?us-ascii?Q?iiyCwljg7DDL1LkkdYU8YkUsx/UBIhZ/Dr0R33rh64NSMwaeIpkgWIjkWNlp?=
 =?us-ascii?Q?heJU+W+DJXnOoBjiMj0mjqitJTq18Q3HCZWZF9l8QXrJWGFtflemgdLGBIS8?=
 =?us-ascii?Q?rfFpoa7beVDpCUz0LZCcFL45qyMDKMSC+VTFqhO+WkFbgwSbopgxgl3YCnYi?=
 =?us-ascii?Q?TRierJIO9VrCBBVudgwTF3m+xXGhMWJ/uzWihkVUGZMtykGkBV9+Kx8gICgw?=
 =?us-ascii?Q?dZuUPoWiJkE56oCYLGv19bwieJuV7jIhmf2WsB9C0mRAplRqcVZ59Z2P/uiz?=
 =?us-ascii?Q?b1OTc7Ii1oFthb2J2d6Xppw3S63i0hDI7V5jQlqrXhk7fLajNDpb0MG4fasw?=
 =?us-ascii?Q?TCjUzC/9ZEkNHwCA+cp0V9EIFHQ/Xm0zSO2P10b8KzFxa3lQR8RPlOPJcW1S?=
 =?us-ascii?Q?aaxu0J9C4RJEF248gvOYZgYYqGW0OAPGF6rSkOGXFeY2OeEV2kcwmqsl/PH5?=
 =?us-ascii?Q?LPkD06ywaHmRbVROU2T9Q5SK/Vi91/1C5+0i7FTa8ofEzZ1XbjQ8UbEGnbTj?=
 =?us-ascii?Q?Bm1+en5PvVA9R3NaloQDwe0Dur71b+ecD06a0ySTa6MKPu57BjPxEpRLMGT9?=
 =?us-ascii?Q?gigik4ZNImBsfle6cctuDxbdAfm7+M5vpwb0lQpXTodNcpbzdXd8cT304D/n?=
 =?us-ascii?Q?wC4qF6PYhLExWl0lKbELeULF2mZedAk0RRHb5tet?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7275.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c14d6194-c943-4290-ba3f-08db10b91d2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 07:32:24.6921 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jSnsxJ1Wyks0i19blz5uf+oOcn4OnpZ6M6xDuVCgPfH1LF4srrcQvZ3jzFRq3IU2fqhvh5Z8/+yxEEVbLdqvLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8210
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Ankur Dwivedi,

This patch has been merged into the DPDK23.03.  At present, we have failed =
to test the fuzz case error display global-buffer-overflow.
Could you please hava a look at it , also submitted a Bugzilla ticket: http=
s://bugs.dpdk.org/show_bug.cgi?id=3D1162.

Regards,
Li, Weiyuan

> -----Original Message-----
> From: Ankur Dwivedi <adwivedi@marvell.com>
> Sent: Thursday, February 9, 2023 1:12 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; david.marchand@redhat.com; mdr@ashroe.eu;
> orika@nvidia.com; ferruh.yigit@amd.com; chas3@att.com;
> humin29@huawei.com; linville@tuxdriver.com; Loftus, Ciara
> <ciara.loftus@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com;
> evgenys@amazon.com; igorch@amazon.com; chandu@amd.com;
> irusskikh@marvell.com; Shepard Siegel <shepard.siegel@atomicrules.com>;
> Czeck, Ed <ed.czeck@atomicrules.com>; john.miller@atomicrules.com;
> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com;
> jerinj@marvell.com; mczekaj@marvell.com; sthotton@marvell.com;
> srinivasan@marvell.com; hkalra@marvell.com; rahul.lakkireddy@chelsio.com;
> Daley, John <johndale@cisco.com>; hyonkim@cisco.com;
> liudongdong3@huawei.com; yisen.zhuang@huawei.com;
> xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com;
> zhouguoyang@huawei.com; Su, Simei <simei.su@intel.com>; Wu, Wenjun1
> <wenjun1.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Wang, Xiao W <xiao.w.wang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Xu,
> Rosen <rosen.xu@intel.com>; ndabilpuram@marvell.com;
> kirankumark@marvell.com; skori@marvell.com; skoteshwar@marvell.com;
> lironh@marvell.com; zr@semihalf.com; radhac@marvell.com;
> vburru@marvell.com; sedara@marvell.com; matan@nvidia.com;
> viacheslavo@nvidia.com; longli@microsoft.com; spinler@cesnet.cz;
> chaoyong.he@corigine.com; niklas.soderlund@corigine.com;
> hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; g.singh@nxp.com;
> apeksha.gupta@nxp.com; sachin.saxena@nxp.com; aboyer@pensando.io;
> rmody@marvell.com; shshaikh@marvell.com; dsinghrawat@marvell.com;
> andrew.rybchenko@oktetlabs.ru; jiawenwu@trustnetic.com;
> jianwang@trustnetic.com; Behrens, Jochen <jbehrens@vmware.com>;
> maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> Webster, Steven <steven.webster@windriver.com>; Peters, Matt
> <matt.peters@windriver.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; mtetsuyah@gmail.com; grive@u256.net;
> Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; jgrajcia@cisco.com;
> mb@smartsharesystems.com; Ankur Dwivedi <adwivedi@marvell.com>
> Subject: [PATCH v11 2/6] ethdev: add trace points for ethdev (part one)
>=20
> Adds trace points for ethdev functions.
>=20
> The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as
> an internal header. ethdev_trace.h contains internal slow path and
> fast path tracepoints. The public fast path tracepoints are present in
> rte_ethdev_trace_fp.h header.
>=20
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> Acked-by: Sunil Kumar Kori <skori@marvell.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
>  lib/ethdev/ethdev_private.c      |   7 +
>  lib/ethdev/ethdev_trace.h        | 635
> +++++++++++++++++++++++++++++++
>  lib/ethdev/ethdev_trace_points.c | 195 +++++++++-
>  lib/ethdev/meson.build           |   2 +-
>  lib/ethdev/rte_ethdev.c          | 387 ++++++++++++++++---
>  lib/ethdev/rte_ethdev_trace.h    |  95 -----
>  lib/ethdev/rte_ethdev_trace_fp.h |  36 ++
>  7 files changed, 1200 insertions(+), 157 deletions(-)
>  create mode 100644 lib/ethdev/ethdev_trace.h
>  delete mode 100644 lib/ethdev/rte_ethdev_trace.h
>=20
> diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c
> index 48090c879a..14ec8c6ccf 100644
> --- a/lib/ethdev/ethdev_private.c
> +++ b/lib/ethdev/ethdev_private.c
> @@ -5,6 +5,7 @@
>  #include <rte_debug.h>
>=20
>  #include "rte_ethdev.h"
> +#include "rte_ethdev_trace_fp.h"
>  #include "ethdev_driver.h"
>  #include "ethdev_private.h"
>=20
> @@ -297,6 +298,9 @@ rte_eth_call_rx_callbacks(uint16_t port_id, uint16_t
> queue_id,
>  		cb =3D cb->next;
>  	}
>=20
> +	rte_eth_trace_call_rx_callbacks(port_id, queue_id, (void **)rx_pkts,
> +					nb_rx, nb_pkts);
> +
>  	return nb_rx;
>  }
>=20
> @@ -312,6 +316,9 @@ rte_eth_call_tx_callbacks(uint16_t port_id, uint16_t
> queue_id,
>  		cb =3D cb->next;
>  	}
>=20
> +	rte_eth_trace_call_tx_callbacks(port_id, queue_id, (void **)tx_pkts,
> +					nb_pkts);
> +
>  	return nb_pkts;
>  }
>=20
> diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h
> new file mode 100644
> index 0000000000..d88ad60ec8
> --- /dev/null
> +++ b/lib/ethdev/ethdev_trace.h
> @@ -0,0 +1,635 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Marvell International Ltd.
> + */
> +
> +#ifndef _RTE_ETHDEV_TRACE_H_
> +#define _RTE_ETHDEV_TRACE_H_
> +
> +/**
> + * @file
> + *
> + * API for ethdev trace support
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include <dev_driver.h>
> +#include <rte_trace_point.h>
> +
> +#include "rte_ethdev.h"
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_configure,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t nb_rx_q,
> +		uint16_t nb_tx_q, const struct rte_eth_conf *dev_conf, int
> rc),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(nb_rx_q);
> +	rte_trace_point_emit_u16(nb_tx_q);
> +	rte_trace_point_emit_u32(dev_conf->link_speeds);
> +	rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode);
> +	rte_trace_point_emit_u32(dev_conf->rxmode.mtu);
> +	rte_trace_point_emit_u64(dev_conf->rxmode.offloads);
> +	rte_trace_point_emit_u32(dev_conf->txmode.mq_mode);
> +	rte_trace_point_emit_u64(dev_conf->txmode.offloads);
> +	rte_trace_point_emit_u32(dev_conf->lpbk_mode);
> +	rte_trace_point_emit_int(rc);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_rxq_setup,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> +		uint16_t nb_rx_desc, void *mp,
> +		const struct rte_eth_rxconf *rx_conf, int rc),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(rx_queue_id);
> +	rte_trace_point_emit_u16(nb_rx_desc);
> +	rte_trace_point_emit_ptr(mp);
> +	rte_trace_point_emit_u8(rx_conf->rx_thresh.pthresh);
> +	rte_trace_point_emit_u8(rx_conf->rx_thresh.hthresh);
> +	rte_trace_point_emit_u8(rx_conf->rx_thresh.wthresh);
> +	rte_trace_point_emit_u8(rx_conf->rx_drop_en);
> +	rte_trace_point_emit_u8(rx_conf->rx_deferred_start);
> +	rte_trace_point_emit_u64(rx_conf->offloads);
> +	rte_trace_point_emit_int(rc);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_txq_setup,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> +		uint16_t nb_tx_desc, const struct rte_eth_txconf *tx_conf),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(tx_queue_id);
> +	rte_trace_point_emit_u16(nb_tx_desc);
> +	rte_trace_point_emit_u8(tx_conf->tx_thresh.pthresh);
> +	rte_trace_point_emit_u8(tx_conf->tx_thresh.hthresh);
> +	rte_trace_point_emit_u8(tx_conf->tx_thresh.wthresh);
> +	rte_trace_point_emit_u8(tx_conf->tx_deferred_start);
> +	rte_trace_point_emit_u16(tx_conf->tx_free_thresh);
> +	rte_trace_point_emit_u64(tx_conf->offloads);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_start,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> +	rte_trace_point_emit_u16(port_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_stop,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_close,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> +	rte_trace_point_emit_u16(port_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_iterator_init,
> +	RTE_TRACE_POINT_ARGS(const char *devargs),
> +	rte_trace_point_emit_string(devargs);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_iterator_next,
> +	RTE_TRACE_POINT_ARGS(const struct rte_dev_iterator *iter,
> uint16_t id),
> +	rte_trace_point_emit_string(iter->bus_str);
> +	rte_trace_point_emit_string(iter->cls_str);
> +	rte_trace_point_emit_u16(id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_iterator_cleanup,
> +	RTE_TRACE_POINT_ARGS(const struct rte_dev_iterator *iter),
> +	rte_trace_point_emit_string(iter->bus_str);
> +	rte_trace_point_emit_string(iter->cls_str);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_owner_new,
> +	RTE_TRACE_POINT_ARGS(uint64_t owner_id),
> +	rte_trace_point_emit_u64(owner_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_owner_set,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id,
> +		const struct rte_eth_dev_owner *owner, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(owner->id);
> +	rte_trace_point_emit_string(owner->name);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_owner_unset,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint64_t owner_id, int
> ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(owner_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_owner_delete,
> +	RTE_TRACE_POINT_ARGS(uint64_t owner_id, int ret),
> +	rte_trace_point_emit_u64(owner_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_socket_id,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int socket_id),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(socket_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_rx_queue_start,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(rx_queue_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_rx_queue_stop,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(rx_queue_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_tx_queue_start,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(tx_queue_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_tx_queue_stop,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(tx_queue_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_speed_bitflag,
> +	RTE_TRACE_POINT_ARGS(uint32_t speed, int duplex, uint32_t ret),
> +	rte_trace_point_emit_u32(speed);
> +	rte_trace_point_emit_int(duplex);
> +	rte_trace_point_emit_u32(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_rx_offload_name,
> +	RTE_TRACE_POINT_ARGS(uint64_t offload, const char *name),
> +	rte_trace_point_emit_u64(offload);
> +	rte_trace_point_emit_string(name);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_tx_offload_name,
> +	RTE_TRACE_POINT_ARGS(uint64_t offload, const char *name),
> +	rte_trace_point_emit_u64(offload);
> +	rte_trace_point_emit_string(name);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_capability_name,
> +	RTE_TRACE_POINT_ARGS(uint64_t capability, const char *name),
> +	rte_trace_point_emit_u64(capability);
> +	rte_trace_point_emit_string(name);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_set_link_up,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_set_link_down,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_reset,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_rx_hairpin_queue_setup,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> +		uint16_t nb_rx_desc, const struct rte_eth_hairpin_conf
> *conf,
> +		int ret),
> +	uint16_t peer_count =3D conf->peer_count;
> +	uint8_t tx_explicit =3D conf->tx_explicit;
> +	uint8_t manual_bind =3D conf->manual_bind;
> +	uint8_t use_locked_device_memory =3D conf-
> >use_locked_device_memory;
> +	uint8_t use_rte_memory =3D conf->use_rte_memory;
> +	uint8_t force_memory =3D conf->force_memory;
> +
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(rx_queue_id);
> +	rte_trace_point_emit_u16(nb_rx_desc);
> +	rte_trace_point_emit_u16(peer_count);
> +	rte_trace_point_emit_u8(tx_explicit);
> +	rte_trace_point_emit_u8(manual_bind);
> +	rte_trace_point_emit_u8(use_locked_device_memory);
> +	rte_trace_point_emit_u8(use_rte_memory);
> +	rte_trace_point_emit_u8(force_memory);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_tx_hairpin_queue_setup,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> +		uint16_t nb_tx_desc, const struct rte_eth_hairpin_conf
> *conf,
> +		int ret),
> +	uint16_t peer_count =3D conf->peer_count;
> +	uint8_t tx_explicit =3D conf->tx_explicit;
> +	uint8_t manual_bind =3D conf->manual_bind;
> +	uint8_t use_locked_device_memory =3D conf-
> >use_locked_device_memory;
> +	uint8_t use_rte_memory =3D conf->use_rte_memory;
> +	uint8_t force_memory =3D conf->force_memory;
> +
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(tx_queue_id);
> +	rte_trace_point_emit_u16(nb_tx_desc);
> +	rte_trace_point_emit_u16(peer_count);
> +	rte_trace_point_emit_u8(tx_explicit);
> +	rte_trace_point_emit_u8(manual_bind);
> +	rte_trace_point_emit_u8(use_locked_device_memory);
> +	rte_trace_point_emit_u8(use_rte_memory);
> +	rte_trace_point_emit_u8(force_memory);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_hairpin_bind,
> +	RTE_TRACE_POINT_ARGS(uint16_t tx_port, uint16_t rx_port, int ret),
> +	rte_trace_point_emit_u16(tx_port);
> +	rte_trace_point_emit_u16(rx_port);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_hairpin_unbind,
> +	RTE_TRACE_POINT_ARGS(uint16_t tx_port, uint16_t rx_port, int ret),
> +	rte_trace_point_emit_u16(tx_port);
> +	rte_trace_point_emit_u16(rx_port);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_tx_buffer_set_err_callback,
> +	RTE_TRACE_POINT_ARGS(const struct rte_eth_dev_tx_buffer
> *buffer),
> +	rte_trace_point_emit_ptr(buffer->error_callback);
> +	rte_trace_point_emit_ptr(buffer->error_userdata);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_promiscuous_enable,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int promiscuous, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(promiscuous);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_promiscuous_disable,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int promiscuous, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(promiscuous);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_allmulticast_enable,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int all_multicast, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(all_multicast);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_allmulticast_disable,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int all_multicast, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(all_multicast);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_set_rx_queue_stats_mapping,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> +		uint8_t stat_idx, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(rx_queue_id);
> +	rte_trace_point_emit_u8(stat_idx);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_set_tx_queue_stats_mapping,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> +		uint8_t stat_idx, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(tx_queue_id);
> +	rte_trace_point_emit_u8(stat_idx);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_fw_version_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const char *fw_version,
> +		size_t fw_size, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_string(fw_version);
> +	rte_trace_point_emit_size_t(fw_size);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_find_next,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> +	rte_trace_point_emit_u16(port_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_find_next_of,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct rte_device
> *parent),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_string(parent->name);
> +	rte_trace_point_emit_string(parent->bus_info);
> +	rte_trace_point_emit_int(parent->numa_node);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_find_next_sibling,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id_start, uint16_t
> ref_port_id,
> +		uint16_t ret),
> +	rte_trace_point_emit_u16(port_id_start);
> +	rte_trace_point_emit_u16(ref_port_id);
> +	rte_trace_point_emit_u16(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_is_valid_port,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int is_valid),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(is_valid);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_find_next_owned_by,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint64_t owner_id),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(owner_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_owner_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id,
> +		const struct rte_eth_dev_owner *owner),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(owner->id);
> +	rte_trace_point_emit_string(owner->name);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_get_sec_ctx,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const void *ctx),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_ptr(ctx);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_count_avail,
> +	RTE_TRACE_POINT_ARGS(uint16_t count),
> +	rte_trace_point_emit_u16(count);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_count_total,
> +	RTE_TRACE_POINT_ARGS(uint16_t count),
> +	rte_trace_point_emit_u16(count);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_get_name_by_port,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const char *name),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_string(name);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_get_port_by_name,
> +	RTE_TRACE_POINT_ARGS(const char *name, uint16_t port_id),
> +	rte_trace_point_emit_string(name);
> +	rte_trace_point_emit_u16(port_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_ethdev_trace_is_removed,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_hairpin_get_peer_ports,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const uint16_t
> *peer_ports,
> +		size_t len, uint32_t direction, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_ptr(peer_ports);
> +	rte_trace_point_emit_size_t(len);
> +	rte_trace_point_emit_u32(direction);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_tx_buffer_init,
> +	RTE_TRACE_POINT_ARGS(const struct rte_eth_dev_tx_buffer
> *buffer,
> +		uint16_t size, int ret),
> +	rte_trace_point_emit_ptr(buffer);
> +	rte_trace_point_emit_u16(size);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_tx_done_cleanup,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t queue_id,
> +		uint32_t free_cnt, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(queue_id);
> +	rte_trace_point_emit_u32(free_cnt);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_promiscuous_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int promiscuous),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(promiscuous);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_allmulticast_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int all_multicast),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(all_multicast);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_link_get_nowait,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct rte_eth_link
> *link),
> +	uint8_t link_duplex =3D link->link_duplex;
> +	uint8_t link_autoneg =3D link->link_autoneg;
> +	uint8_t link_status =3D link->link_status;
> +
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u32(link->link_speed);
> +	rte_trace_point_emit_u8(link_duplex);
> +	rte_trace_point_emit_u8(link_autoneg);
> +	rte_trace_point_emit_u8(link_status);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_link_to_str,
> +	RTE_TRACE_POINT_ARGS(size_t len, const struct rte_eth_link *link,
> +		char *str, int ret),
> +	uint8_t link_duplex =3D link->link_duplex;
> +	uint8_t link_autoneg =3D link->link_autoneg;
> +	uint8_t link_status =3D link->link_status;
> +
> +	rte_trace_point_emit_size_t(len);
> +	rte_trace_point_emit_u32(link->link_speed);
> +	rte_trace_point_emit_u8(link_duplex);
> +	rte_trace_point_emit_u8(link_autoneg);
> +	rte_trace_point_emit_u8(link_status);
> +	rte_trace_point_emit_string(str);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_stats_reset,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> +	rte_trace_point_emit_u16(port_id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_get_id_by_name,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const char *xstat_name,
> +		uint64_t id),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_string(xstat_name);
> +	rte_trace_point_emit_u64(id);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_get_names_by_id,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id,
> +		const struct rte_eth_xstat_name *xstats_names, uint64_t
> ids),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_string(xstats_names->name);
> +	rte_trace_point_emit_u64(ids);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_get_names,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int i,
> +		struct rte_eth_xstat_name xstats_names,
> +		unsigned int size, int cnt_used_entries),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(i);
> +	rte_trace_point_emit_string(xstats_names.name);
> +	rte_trace_point_emit_u32(size);
> +	rte_trace_point_emit_int(cnt_used_entries);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_get_by_id,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const uint64_t *ids,
> +		const uint64_t *values, unsigned int size),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_ptr(ids);
> +	rte_trace_point_emit_ptr(values);
> +	rte_trace_point_emit_u32(size);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, struct rte_eth_xstat
> xstats),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(xstats.id);
> +	rte_trace_point_emit_u64(xstats.value);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_eth_trace_xstats_reset,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +/* Fast path trace points */
> +
> +/* Called in loop in examples/qos_sched and examples/distributor */
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_stats_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id,
> +		const struct rte_eth_stats *stats, int ret),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u64(stats->rx_nombuf);
> +	rte_trace_point_emit_u64(stats->ipackets);
> +	rte_trace_point_emit_u64(stats->opackets);
> +	rte_trace_point_emit_u64(stats->ibytes);
> +	rte_trace_point_emit_u64(stats->obytes);
> +	rte_trace_point_emit_u64(stats->imissed);
> +	rte_trace_point_emit_u64(stats->ierrors);
> +	rte_trace_point_emit_u64(stats->oerrors);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +/* Called in loop in examples/ip_pipeline */
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_link_get,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct rte_eth_link
> *link),
> +	uint8_t link_duplex =3D link->link_duplex;
> +	uint8_t link_autoneg =3D link->link_autoneg;
> +	uint8_t link_status =3D link->link_status;
> +
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u32(link->link_speed);
> +	rte_trace_point_emit_u8(link_duplex);
> +	rte_trace_point_emit_u8(link_autoneg);
> +	rte_trace_point_emit_u8(link_status);
> +)
> +
> +/* Called in loop in examples/ip_pipeline */
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_link_speed_to_str,
> +	RTE_TRACE_POINT_ARGS(uint32_t link_speed, const char *ret),
> +	rte_trace_point_emit_u32(link_speed);
> +	rte_trace_point_emit_string(ret);
> +)
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_ETHDEV_TRACE_H_ */
> diff --git a/lib/ethdev/ethdev_trace_points.c
> b/lib/ethdev/ethdev_trace_points.c
> index 2919409a15..3e58c679c3 100644
> --- a/lib/ethdev/ethdev_trace_points.c
> +++ b/lib/ethdev/ethdev_trace_points.c
> @@ -4,7 +4,8 @@
>=20
>  #include <rte_trace_point_register.h>
>=20
> -#include <rte_ethdev_trace.h>
> +#include <ethdev_trace.h>
> +#include <rte_ethdev_trace_fp.h>
>=20
>  RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_configure,
>  	lib.ethdev.configure)
> @@ -29,3 +30,195 @@
> RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_rx_burst,
>=20
>  RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_tx_burst,
>  	lib.ethdev.tx.burst)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_call_rx_callbacks,
> +	lib.ethdev.call_rx_callbacks)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_call_tx_callbacks,
> +	lib.ethdev.call_tx_callbacks)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_iterator_init,
> +	lib.ethdev.iterator_init)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_iterator_next,
> +	lib.ethdev.iterator_next)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_iterator_cleanup,
> +	lib.ethdev.iterator_cleanup)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_find_next,
> +	lib.ethdev.find_next)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_find_next_of,
> +	lib.ethdev.find_next_of)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_find_next_sibling,
> +	lib.ethdev.find_next_sibling)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_is_valid_port,
> +	lib.ethdev.is_valid_port)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_find_next_owned_by,
> +	lib.ethdev.find_next_owned_by)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_owner_new,
> +	lib.ethdev.owner_new)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_owner_set,
> +	lib.ethdev.owner_set)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_owner_unset,
> +	lib.ethdev.owner_unset)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_owner_delete,
> +	lib.ethdev.owner_delete)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_owner_get,
> +	lib.ethdev.owner_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_socket_id,
> +	lib.ethdev.socket_id)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_get_sec_ctx,
> +	lib.ethdev.get_sec_ctx)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_count_avail,
> +	lib.ethdev.count_avail)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_count_total,
> +	lib.ethdev.count_total)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_get_name_by_port,
> +	lib.ethdev.get_name_by_port)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_get_port_by_name,
> +	lib.ethdev.get_port_by_name)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_rx_queue_start,
> +	lib.ethdev.rx_queue_start)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_rx_queue_stop,
> +	lib.ethdev.rx_queue_stop)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_tx_queue_start,
> +	lib.ethdev.tx_queue_start)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_tx_queue_stop,
> +	lib.ethdev.tx_queue_stop)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_speed_bitflag,
> +	lib.ethdev.speed_bitflag)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_rx_offload_name,
> +	lib.ethdev.rx_offload_name)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_tx_offload_name,
> +	lib.ethdev.tx_offload_name)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_capability_name,
> +	lib.ethdev.capability_name)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_set_link_up,
> +	lib.ethdev.set_link_up)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_set_link_down,
> +	lib.ethdev.set_link_down)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_reset,
> +	lib.ethdev.reset)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_is_removed,
> +	lib.ethdev.is_removed)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_rx_hairpin_queue_setup,
> +	lib.ethdev.rx_hairpin_queue_setup)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_hairpin_queue_setup,
> +	lib.ethdev.tx_hairpin_queue_setup)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_hairpin_bind,
> +	lib.ethdev.hairpin_bind)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_hairpin_unbind,
> +	lib.ethdev.hairpin_unbind)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_hairpin_get_peer_ports,
> +	lib.ethdev.hairpin_get_peer_ports)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_buffer_drop_callback,
> +	lib.ethdev.tx_buffer_drop_callback)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_buffer_count_callback,
> +	lib.ethdev.tx_buffer_count_callback)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_buffer_set_err_callback,
> +	lib.ethdev.tx_buffer_set_err_callback)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_buffer_init,
> +	lib.ethdev.tx_buffer_init)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_tx_done_cleanup,
> +	lib.ethdev.tx_done_cleanup)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_promiscuous_enable,
> +	lib.ethdev.promiscuous_enable)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_promiscuous_disable,
> +	lib.ethdev.promiscuous_disable)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_promiscuous_get,
> +	lib.ethdev.promiscuous_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_allmulticast_enable,
> +	lib.ethdev.allmulticast_enable)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_allmulticast_disable,
> +	lib.ethdev.allmulticast_disable)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_allmulticast_get,
> +	lib.ethdev.allmulticast_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_link_get,
> +	lib.ethdev.link_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_link_get_nowait,
> +	lib.ethdev.link_get_nowait)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_link_speed_to_str,
> +	lib.ethdev.link_speed_to_str)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_link_to_str,
> +	lib.ethdev.link_to_str)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_stats_get,
> +	lib.ethdev.stats_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_stats_reset,
> +	lib.ethdev.stats_reset)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_get_id_by_name,
> +	lib.ethdev.xstats_get_id_by_name)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_get_names_by_id,
> +	lib.ethdev.xstats_get_names_by_id)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_get_names,
> +	lib.ethdev.xstats_get_names)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_get_by_id,
> +	lib.ethdev.xstats_get_by_id)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_get,
> +	lib.ethdev.xstats_get)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_xstats_reset,
> +	lib.ethdev.xstats_reset)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_set_tx_queue_stats_ma
> pping,
> +	lib.ethdev.set_tx_queue_stats_mapping)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_set_rx_queue_stats_ma
> pping,
> +	lib.ethdev.set_rx_queue_stats_mapping)
> +
> +RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_fw_version_get,
> +	lib.ethdev.fw_version_get)
> diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build
> index 39250b5da1..7835c96601 100644
> --- a/lib/ethdev/meson.build
> +++ b/lib/ethdev/meson.build
> @@ -22,7 +22,6 @@ sources =3D files(
>  headers =3D files(
>          'rte_cman.h',
>          'rte_ethdev.h',
> -        'rte_ethdev_trace.h',
>          'rte_ethdev_trace_fp.h',
>          'rte_dev_info.h',
>          'rte_flow.h',
> @@ -41,6 +40,7 @@ indirect_headers +=3D files(
>  driver_sdk_headers +=3D files(
>          'ethdev_driver.h',
>          'ethdev_pci.h',
> +        'ethdev_trace.h',
>          'ethdev_vdev.h',
>  )
>=20
> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
> index d25db35f7f..6aaae66b83 100644
> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -27,11 +27,12 @@
>  #include <rte_ether.h>
>  #include <rte_telemetry.h>
>=20
> -#include "rte_ethdev_trace.h"
>  #include "rte_ethdev.h"
> +#include "rte_ethdev_trace_fp.h"
>  #include "ethdev_driver.h"
>  #include "ethdev_profile.h"
>  #include "ethdev_private.h"
> +#include "ethdev_trace.h"
>  #include "sff_telemetry.h"
>=20
>  struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
> @@ -259,6 +260,9 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter,
> const char *devargs_str)
>  end:
>  	iter->cls =3D rte_class_find_by_name("eth");
>  	rte_devargs_reset(&devargs);
> +
> +	rte_eth_trace_iterator_init(devargs_str);
> +
>  	return 0;
>=20
>  error:
> @@ -297,8 +301,13 @@ rte_eth_iterator_next(struct rte_dev_iterator *iter)
>  		/* A device is matching bus part, need to check ethdev part.
> */
>  		iter->class_device =3D iter->cls->dev_iterate(
>  				iter->class_device, iter->cls_str, iter);
> -		if (iter->class_device !=3D NULL)
> -			return eth_dev_to_id(iter->class_device); /* match
> */
> +		if (iter->class_device !=3D NULL) {
> +			uint16_t id =3D eth_dev_to_id(iter->class_device);
> +
> +			rte_eth_trace_iterator_next(iter, id);
> +
> +			return id; /* match */
> +		}
>  	} while (iter->bus !=3D NULL); /* need to try next rte_device */
>=20
>  	/* No more ethdev port to iterate. */
> @@ -316,6 +325,9 @@ rte_eth_iterator_cleanup(struct rte_dev_iterator
> *iter)
>=20
>  	if (iter->bus_str =3D=3D NULL)
>  		return; /* nothing to free in pure class filter */
> +
> +	rte_eth_trace_iterator_cleanup(iter);
> +
>  	free(RTE_CAST_FIELD(iter, bus_str, char *)); /* workaround const */
>  	free(RTE_CAST_FIELD(iter, cls_str, char *)); /* workaround const */
>  	memset(iter, 0, sizeof(*iter));
> @@ -331,6 +343,8 @@ rte_eth_find_next(uint16_t port_id)
>  	if (port_id >=3D RTE_MAX_ETHPORTS)
>  		return RTE_MAX_ETHPORTS;
>=20
> +	rte_eth_trace_find_next(port_id);
> +
>  	return port_id;
>  }
>=20
> @@ -351,15 +365,23 @@ rte_eth_find_next_of(uint16_t port_id, const
> struct rte_device *parent)
>  			rte_eth_devices[port_id].device !=3D parent)
>  		port_id =3D rte_eth_find_next(port_id + 1);
>=20
> +	rte_eth_trace_find_next_of(port_id, parent);
> +
>  	return port_id;
>  }
>=20
>  uint16_t
>  rte_eth_find_next_sibling(uint16_t port_id, uint16_t ref_port_id)
>  {
> +	uint16_t ret;
> +
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(ref_port_id,
> RTE_MAX_ETHPORTS);
> -	return rte_eth_find_next_of(port_id,
> +	ret =3D rte_eth_find_next_of(port_id,
>  			rte_eth_devices[ref_port_id].device);
> +
> +	rte_eth_trace_find_next_sibling(port_id, ref_port_id, ret);
> +
> +	return ret;
>  }
>=20
>  static bool
> @@ -371,11 +393,17 @@ eth_dev_is_allocated(const struct rte_eth_dev
> *ethdev)
>  int
>  rte_eth_dev_is_valid_port(uint16_t port_id)
>  {
> +	int is_valid;
> +
>  	if (port_id >=3D RTE_MAX_ETHPORTS ||
>  	    (rte_eth_devices[port_id].state =3D=3D RTE_ETH_DEV_UNUSED))
> -		return 0;
> +		is_valid =3D 0;
>  	else
> -		return 1;
> +		is_valid =3D 1;
> +
> +	rte_ethdev_trace_is_valid_port(port_id, is_valid);
> +
> +	return is_valid;
>  }
>=20
>  static int
> @@ -395,6 +423,8 @@ rte_eth_find_next_owned_by(uint16_t port_id,
> const uint64_t owner_id)
>  			rte_eth_devices[port_id].data->owner.id !=3D
> owner_id)
>  		port_id =3D rte_eth_find_next(port_id + 1);
>=20
> +	rte_eth_trace_find_next_owned_by(port_id, owner_id);
> +
>  	return port_id;
>  }
>=20
> @@ -413,6 +443,9 @@ rte_eth_dev_owner_new(uint64_t *owner_id)
>  	*owner_id =3D eth_dev_shared_data->next_owner_id++;
>=20
>  	rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
> +
> +	rte_ethdev_trace_owner_new(*owner_id);
> +
>  	return 0;
>  }
>=20
> @@ -476,6 +509,9 @@ rte_eth_dev_owner_set(const uint16_t port_id,
>  	ret =3D eth_dev_owner_set(port_id, RTE_ETH_DEV_NO_OWNER,
> owner);
>=20
>  	rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
> +
> +	rte_ethdev_trace_owner_set(port_id, owner, ret);
> +
>  	return ret;
>  }
>=20
> @@ -493,6 +529,9 @@ rte_eth_dev_owner_unset(const uint16_t port_id,
> const uint64_t owner_id)
>  	ret =3D eth_dev_owner_set(port_id, owner_id, &new_owner);
>=20
>  	rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
> +
> +	rte_ethdev_trace_owner_unset(port_id, owner_id, ret);
> +
>  	return ret;
>  }
>=20
> @@ -526,6 +565,8 @@ rte_eth_dev_owner_delete(const uint64_t owner_id)
>=20
>  	rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
>=20
> +	rte_ethdev_trace_owner_delete(owner_id, ret);
> +
>  	return ret;
>  }
>=20
> @@ -555,6 +596,8 @@ rte_eth_dev_owner_get(const uint16_t port_id,
> struct rte_eth_dev_owner *owner)
>  	rte_memcpy(owner, &ethdev->data->owner, sizeof(*owner));
>  	rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
>=20
> +	rte_ethdev_trace_owner_get(port_id, owner);
> +
>  	return 0;
>  }
>=20
> @@ -570,14 +613,23 @@ rte_eth_dev_socket_id(uint16_t port_id)
>  		if (socket_id =3D=3D SOCKET_ID_ANY)
>  			rte_errno =3D 0;
>  	}
> +
> +	rte_ethdev_trace_socket_id(port_id, socket_id);
> +
>  	return socket_id;
>  }
>=20
>  void *
>  rte_eth_dev_get_sec_ctx(uint16_t port_id)
>  {
> +	void *ctx;
> +
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL);
> -	return rte_eth_devices[port_id].security_ctx;
> +	ctx =3D rte_eth_devices[port_id].security_ctx;
> +
> +	rte_ethdev_trace_get_sec_ctx(port_id, ctx);
> +
> +	return ctx;
>  }
>=20
>  uint16_t
> @@ -591,6 +643,8 @@ rte_eth_dev_count_avail(void)
>  	RTE_ETH_FOREACH_DEV(p)
>  		count++;
>=20
> +	rte_ethdev_trace_count_avail(count);
> +
>  	return count;
>  }
>=20
> @@ -602,6 +656,8 @@ rte_eth_dev_count_total(void)
>  	RTE_ETH_FOREACH_VALID_DEV(port)
>  		count++;
>=20
> +	rte_ethdev_trace_count_total(count);
> +
>  	return count;
>  }
>=20
> @@ -622,6 +678,9 @@ rte_eth_dev_get_name_by_port(uint16_t port_id,
> char *name)
>  	 * because it might be overwritten by VDEV PMD */
>  	tmp =3D eth_dev_shared_data->data[port_id].name;
>  	strcpy(name, tmp);
> +
> +	rte_ethdev_trace_get_name_by_port(port_id, name);
> +
>  	return 0;
>  }
>=20
> @@ -644,6 +703,9 @@ rte_eth_dev_get_port_by_name(const char *name,
> uint16_t *port_id)
>  	RTE_ETH_FOREACH_VALID_DEV(pid)
>  		if (!strcmp(name, eth_dev_shared_data->data[pid].name)) {
>  			*port_id =3D pid;
> +
> +			rte_ethdev_trace_get_port_by_name(name,
> *port_id);
> +
>  			return 0;
>  		}
>=20
> @@ -745,7 +807,11 @@ rte_eth_dev_rx_queue_start(uint16_t port_id,
> uint16_t rx_queue_id)
>  		return 0;
>  	}
>=20
> -	return eth_err(port_id, dev->dev_ops->rx_queue_start(dev,
> rx_queue_id));
> +	ret =3D eth_err(port_id, dev->dev_ops->rx_queue_start(dev,
> rx_queue_id));
> +
> +	rte_ethdev_trace_rx_queue_start(port_id, rx_queue_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -778,7 +844,11 @@ rte_eth_dev_rx_queue_stop(uint16_t port_id,
> uint16_t rx_queue_id)
>  		return 0;
>  	}
>=20
> -	return eth_err(port_id, dev->dev_ops->rx_queue_stop(dev,
> rx_queue_id));
> +	ret =3D eth_err(port_id, dev->dev_ops->rx_queue_stop(dev,
> rx_queue_id));
> +
> +	rte_ethdev_trace_rx_queue_stop(port_id, rx_queue_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -818,7 +888,11 @@ rte_eth_dev_tx_queue_start(uint16_t port_id,
> uint16_t tx_queue_id)
>  		return 0;
>  	}
>=20
> -	return eth_err(port_id, dev->dev_ops->tx_queue_start(dev,
> tx_queue_id));
> +	ret =3D eth_err(port_id, dev->dev_ops->tx_queue_start(dev,
> tx_queue_id));
> +
> +	rte_ethdev_trace_tx_queue_start(port_id, tx_queue_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -851,42 +925,65 @@ rte_eth_dev_tx_queue_stop(uint16_t port_id,
> uint16_t tx_queue_id)
>  		return 0;
>  	}
>=20
> -	return eth_err(port_id, dev->dev_ops->tx_queue_stop(dev,
> tx_queue_id));
> +	ret =3D eth_err(port_id, dev->dev_ops->tx_queue_stop(dev,
> tx_queue_id));
> +
> +	rte_ethdev_trace_tx_queue_stop(port_id, tx_queue_id, ret);
> +
> +	return ret;
>  }
>=20
>  uint32_t
>  rte_eth_speed_bitflag(uint32_t speed, int duplex)
>  {
> +	uint32_t ret;
> +
>  	switch (speed) {
>  	case RTE_ETH_SPEED_NUM_10M:
> -		return duplex ? RTE_ETH_LINK_SPEED_10M :
> RTE_ETH_LINK_SPEED_10M_HD;
> +		ret =3D duplex ? RTE_ETH_LINK_SPEED_10M :
> RTE_ETH_LINK_SPEED_10M_HD;
> +		break;
>  	case RTE_ETH_SPEED_NUM_100M:
> -		return duplex ? RTE_ETH_LINK_SPEED_100M :
> RTE_ETH_LINK_SPEED_100M_HD;
> +		ret =3D duplex ? RTE_ETH_LINK_SPEED_100M :
> RTE_ETH_LINK_SPEED_100M_HD;
> +		break;
>  	case RTE_ETH_SPEED_NUM_1G:
> -		return RTE_ETH_LINK_SPEED_1G;
> +		ret =3D RTE_ETH_LINK_SPEED_1G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_2_5G:
> -		return RTE_ETH_LINK_SPEED_2_5G;
> +		ret =3D RTE_ETH_LINK_SPEED_2_5G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_5G:
> -		return RTE_ETH_LINK_SPEED_5G;
> +		ret =3D RTE_ETH_LINK_SPEED_5G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_10G:
> -		return RTE_ETH_LINK_SPEED_10G;
> +		ret =3D RTE_ETH_LINK_SPEED_10G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_20G:
> -		return RTE_ETH_LINK_SPEED_20G;
> +		ret =3D RTE_ETH_LINK_SPEED_20G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_25G:
> -		return RTE_ETH_LINK_SPEED_25G;
> +		ret =3D RTE_ETH_LINK_SPEED_25G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_40G:
> -		return RTE_ETH_LINK_SPEED_40G;
> +		ret =3D RTE_ETH_LINK_SPEED_40G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_50G:
> -		return RTE_ETH_LINK_SPEED_50G;
> +		ret =3D RTE_ETH_LINK_SPEED_50G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_56G:
> -		return RTE_ETH_LINK_SPEED_56G;
> +		ret =3D RTE_ETH_LINK_SPEED_56G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_100G:
> -		return RTE_ETH_LINK_SPEED_100G;
> +		ret =3D RTE_ETH_LINK_SPEED_100G;
> +		break;
>  	case RTE_ETH_SPEED_NUM_200G:
> -		return RTE_ETH_LINK_SPEED_200G;
> +		ret =3D RTE_ETH_LINK_SPEED_200G;
> +		break;
>  	default:
> -		return 0;
> +		ret =3D 0;
>  	}
> +
> +	rte_eth_trace_speed_bitflag(speed, duplex, ret);
> +
> +	return ret;
>  }
>=20
>  const char *
> @@ -902,6 +999,8 @@ rte_eth_dev_rx_offload_name(uint64_t offload)
>  		}
>  	}
>=20
> +	rte_ethdev_trace_rx_offload_name(offload, name);
> +
>  	return name;
>  }
>=20
> @@ -918,6 +1017,8 @@ rte_eth_dev_tx_offload_name(uint64_t offload)
>  		}
>  	}
>=20
> +	rte_ethdev_trace_tx_offload_name(offload, name);
> +
>  	return name;
>  }
>=20
> @@ -934,6 +1035,8 @@ rte_eth_dev_capability_name(uint64_t capability)
>  		}
>  	}
>=20
> +	rte_ethdev_trace_capability_name(capability, name);
> +
>  	return name;
>  }
>=20
> @@ -1554,26 +1657,36 @@ int
>  rte_eth_dev_set_link_up(uint16_t port_id)
>  {
>  	struct rte_eth_dev *dev;
> +	int ret;
>=20
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
>=20
>  	if (*dev->dev_ops->dev_set_link_up =3D=3D NULL)
>  		return -ENOTSUP;
> -	return eth_err(port_id, (*dev->dev_ops->dev_set_link_up)(dev));
> +	ret =3D eth_err(port_id, (*dev->dev_ops->dev_set_link_up)(dev));
> +
> +	rte_ethdev_trace_set_link_up(port_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
>  rte_eth_dev_set_link_down(uint16_t port_id)
>  {
>  	struct rte_eth_dev *dev;
> +	int ret;
>=20
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
>=20
>  	if (*dev->dev_ops->dev_set_link_down =3D=3D NULL)
>  		return -ENOTSUP;
> -	return eth_err(port_id, (*dev->dev_ops-
> >dev_set_link_down)(dev));
> +	ret =3D eth_err(port_id, (*dev->dev_ops->dev_set_link_down)(dev));
> +
> +	rte_ethdev_trace_set_link_down(port_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -1628,9 +1741,11 @@ rte_eth_dev_reset(uint16_t port_id)
>  			"Failed to stop device (port %u) before reset: %s -
> ignore\n",
>  			port_id, rte_strerror(-ret));
>  	}
> -	ret =3D dev->dev_ops->dev_reset(dev);
> +	ret =3D eth_err(port_id, dev->dev_ops->dev_reset(dev));
>=20
> -	return eth_err(port_id, ret);
> +	rte_ethdev_trace_reset(port_id, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -1653,6 +1768,8 @@ rte_eth_dev_is_removed(uint16_t port_id)
>  		/* Device is physically removed. */
>  		dev->state =3D RTE_ETH_DEV_REMOVED;
>=20
> +	rte_ethdev_trace_is_removed(port_id, ret);
> +
>  	return ret;
>  }
>=20
> @@ -2151,7 +2268,12 @@ rte_eth_rx_hairpin_queue_setup(uint16_t
> port_id, uint16_t rx_queue_id,
>  	if (ret =3D=3D 0)
>  		dev->data->rx_queue_state[rx_queue_id] =3D
>  			RTE_ETH_QUEUE_STATE_HAIRPIN;
> -	return eth_err(port_id, ret);
> +	ret =3D eth_err(port_id, ret);
> +
> +	rte_eth_trace_rx_hairpin_queue_setup(port_id, rx_queue_id,
> nb_rx_desc,
> +					     conf, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -2340,7 +2462,12 @@ rte_eth_tx_hairpin_queue_setup(uint16_t
> port_id, uint16_t tx_queue_id,
>  	if (ret =3D=3D 0)
>  		dev->data->tx_queue_state[tx_queue_id] =3D
>  			RTE_ETH_QUEUE_STATE_HAIRPIN;
> -	return eth_err(port_id, ret);
> +	ret =3D eth_err(port_id, ret);
> +
> +	rte_eth_trace_tx_hairpin_queue_setup(port_id, tx_queue_id,
> nb_tx_desc,
> +					     conf, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -2365,6 +2492,8 @@ rte_eth_hairpin_bind(uint16_t tx_port, uint16_t
> rx_port)
>  			       " to Rx %d (%d - all ports)\n",
>  			       tx_port, rx_port, RTE_MAX_ETHPORTS);
>=20
> +	rte_eth_trace_hairpin_bind(tx_port, rx_port, ret);
> +
>  	return ret;
>  }
>=20
> @@ -2390,6 +2519,8 @@ rte_eth_hairpin_unbind(uint16_t tx_port, uint16_t
> rx_port)
>  			       " from Rx %d (%d - all ports)\n",
>  			       tx_port, rx_port, RTE_MAX_ETHPORTS);
>=20
> +	rte_eth_trace_hairpin_unbind(tx_port, rx_port, ret);
> +
>  	return ret;
>  }
>=20
> @@ -2426,6 +2557,9 @@ rte_eth_hairpin_get_peer_ports(uint16_t port_id,
> uint16_t *peer_ports,
>  		RTE_ETHDEV_LOG(ERR, "Failed to get %d hairpin peer %s
> ports\n",
>  			       port_id, direction ? "Rx" : "Tx");
>=20
> +	rte_eth_trace_hairpin_get_peer_ports(port_id, peer_ports, len,
> +					     direction, ret);
> +
>  	return ret;
>  }
>=20
> @@ -2434,6 +2568,8 @@ rte_eth_tx_buffer_drop_callback(struct rte_mbuf
> **pkts, uint16_t unsent,
>  		void *userdata __rte_unused)
>  {
>  	rte_pktmbuf_free_bulk(pkts, unsent);
> +
> +	rte_eth_trace_tx_buffer_drop_callback((void **)pkts, unsent);
>  }
>=20
>  void
> @@ -2444,6 +2580,8 @@ rte_eth_tx_buffer_count_callback(struct rte_mbuf
> **pkts, uint16_t unsent,
>=20
>  	rte_pktmbuf_free_bulk(pkts, unsent);
>  	*count +=3D unsent;
> +
> +	rte_eth_trace_tx_buffer_count_callback((void **)pkts, unsent,
> *count);
>  }
>=20
>  int
> @@ -2458,6 +2596,9 @@ rte_eth_tx_buffer_set_err_callback(struct
> rte_eth_dev_tx_buffer *buffer,
>=20
>  	buffer->error_callback =3D cbfn;
>  	buffer->error_userdata =3D userdata;
> +
> +	rte_eth_trace_tx_buffer_set_err_callback(buffer);
> +
>  	return 0;
>  }
>=20
> @@ -2477,6 +2618,8 @@ rte_eth_tx_buffer_init(struct
> rte_eth_dev_tx_buffer *buffer, uint16_t size)
>  			buffer, rte_eth_tx_buffer_drop_callback, NULL);
>  	}
>=20
> +	rte_eth_trace_tx_buffer_init(buffer, size, ret);
> +
>  	return ret;
>  }
>=20
> @@ -2495,7 +2638,11 @@ rte_eth_tx_done_cleanup(uint16_t port_id,
> uint16_t queue_id, uint32_t free_cnt)
>  	/* Call driver to free pending mbufs. */
>  	ret =3D (*dev->dev_ops->tx_done_cleanup)(dev->data-
> >tx_queues[queue_id],
>  					       free_cnt);
> -	return eth_err(port_id, ret);
> +	ret =3D eth_err(port_id, ret);
> +
> +	rte_eth_trace_tx_done_cleanup(port_id, queue_id, free_cnt, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -2516,7 +2663,12 @@ rte_eth_promiscuous_enable(uint16_t port_id)
>  	diag =3D (*dev->dev_ops->promiscuous_enable)(dev);
>  	dev->data->promiscuous =3D (diag =3D=3D 0) ? 1 : 0;
>=20
> -	return eth_err(port_id, diag);
> +	diag =3D eth_err(port_id, diag);
> +
> +	rte_eth_trace_promiscuous_enable(port_id, dev->data-
> >promiscuous,
> +					 diag);
> +
> +	return diag;
>  }
>=20
>  int
> @@ -2539,7 +2691,12 @@ rte_eth_promiscuous_disable(uint16_t port_id)
>  	if (diag !=3D 0)
>  		dev->data->promiscuous =3D 1;
>=20
> -	return eth_err(port_id, diag);
> +	diag =3D eth_err(port_id, diag);
> +
> +	rte_eth_trace_promiscuous_disable(port_id, dev->data-
> >promiscuous,
> +					  diag);
> +
> +	return diag;
>  }
>=20
>  int
> @@ -2550,6 +2707,8 @@ rte_eth_promiscuous_get(uint16_t port_id)
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
>=20
> +	rte_eth_trace_promiscuous_get(port_id, dev->data->promiscuous);
> +
>  	return dev->data->promiscuous;
>  }
>=20
> @@ -2570,7 +2729,12 @@ rte_eth_allmulticast_enable(uint16_t port_id)
>  	diag =3D (*dev->dev_ops->allmulticast_enable)(dev);
>  	dev->data->all_multicast =3D (diag =3D=3D 0) ? 1 : 0;
>=20
> -	return eth_err(port_id, diag);
> +	diag =3D eth_err(port_id, diag);
> +
> +	rte_eth_trace_allmulticast_enable(port_id, dev->data->all_multicast,
> +					  diag);
> +
> +	return diag;
>  }
>=20
>  int
> @@ -2592,7 +2756,12 @@ rte_eth_allmulticast_disable(uint16_t port_id)
>  	if (diag !=3D 0)
>  		dev->data->all_multicast =3D 1;
>=20
> -	return eth_err(port_id, diag);
> +	diag =3D eth_err(port_id, diag);
> +
> +	rte_eth_trace_allmulticast_disable(port_id, dev->data->all_multicast,
> +					   diag);
> +
> +	return diag;
>  }
>=20
>  int
> @@ -2603,6 +2772,8 @@ rte_eth_allmulticast_get(uint16_t port_id)
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
>=20
> +	rte_eth_trace_allmulticast_get(port_id, dev->data->all_multicast);
> +
>  	return dev->data->all_multicast;
>  }
>=20
> @@ -2629,6 +2800,8 @@ rte_eth_link_get(uint16_t port_id, struct
> rte_eth_link *eth_link)
>  		*eth_link =3D dev->data->dev_link;
>  	}
>=20
> +	rte_eth_trace_link_get(port_id, eth_link);
> +
>  	return 0;
>  }
>=20
> @@ -2655,35 +2828,76 @@ rte_eth_link_get_nowait(uint16_t port_id, struct
> rte_eth_link *eth_link)
>  		*eth_link =3D dev->data->dev_link;
>  	}
>=20
> +	rte_eth_trace_link_get_nowait(port_id, eth_link);
> +
>  	return 0;
>  }
>=20
>  const char *
>  rte_eth_link_speed_to_str(uint32_t link_speed)
>  {
> +	const char *ret;
> +
>  	switch (link_speed) {
> -	case RTE_ETH_SPEED_NUM_NONE: return "None";
> -	case RTE_ETH_SPEED_NUM_10M:  return "10 Mbps";
> -	case RTE_ETH_SPEED_NUM_100M: return "100 Mbps";
> -	case RTE_ETH_SPEED_NUM_1G:   return "1 Gbps";
> -	case RTE_ETH_SPEED_NUM_2_5G: return "2.5 Gbps";
> -	case RTE_ETH_SPEED_NUM_5G:   return "5 Gbps";
> -	case RTE_ETH_SPEED_NUM_10G:  return "10 Gbps";
> -	case RTE_ETH_SPEED_NUM_20G:  return "20 Gbps";
> -	case RTE_ETH_SPEED_NUM_25G:  return "25 Gbps";
> -	case RTE_ETH_SPEED_NUM_40G:  return "40 Gbps";
> -	case RTE_ETH_SPEED_NUM_50G:  return "50 Gbps";
> -	case RTE_ETH_SPEED_NUM_56G:  return "56 Gbps";
> -	case RTE_ETH_SPEED_NUM_100G: return "100 Gbps";
> -	case RTE_ETH_SPEED_NUM_200G: return "200 Gbps";
> -	case RTE_ETH_SPEED_NUM_UNKNOWN: return "Unknown";
> -	default: return "Invalid";
> +	case RTE_ETH_SPEED_NUM_NONE:
> +		ret =3D "None";
> +		break;
> +	case RTE_ETH_SPEED_NUM_10M:
> +		ret =3D "10 Mbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_100M:
> +		ret =3D "100 Mbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_1G:
> +		ret =3D "1 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_2_5G:
> +		ret =3D "2.5 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_5G:
> +		ret =3D "5 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_10G:
> +		ret =3D "10 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_20G:
> +		ret =3D "20 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_25G:
> +		ret =3D "25 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_40G:
> +		ret =3D "40 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_50G:
> +		ret =3D "50 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_56G:
> +		ret =3D "56 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_100G:
> +		ret =3D "100 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_200G:
> +		ret =3D "200 Gbps";
> +		break;
> +	case RTE_ETH_SPEED_NUM_UNKNOWN:
> +		ret =3D "Unknown";
> +		break;
> +	default:
> +		ret =3D "Invalid";
>  	}
> +
> +	rte_eth_trace_link_speed_to_str(link_speed, ret);
> +
> +	return ret;
>  }
>=20
>  int
>  rte_eth_link_to_str(char *str, size_t len, const struct rte_eth_link *et=
h_link)
>  {
> +	int ret;
> +
>  	if (str =3D=3D NULL) {
>  		RTE_ETHDEV_LOG(ERR, "Cannot convert link to NULL
> string\n");
>  		return -EINVAL;
> @@ -2701,20 +2915,25 @@ rte_eth_link_to_str(char *str, size_t len, const
> struct rte_eth_link *eth_link)
>  	}
>=20
>  	if (eth_link->link_status =3D=3D RTE_ETH_LINK_DOWN)
> -		return snprintf(str, len, "Link down");
> +		ret =3D snprintf(str, len, "Link down");
>  	else
> -		return snprintf(str, len, "Link up at %s %s %s",
> +		ret =3D snprintf(str, len, "Link up at %s %s %s",
>  			rte_eth_link_speed_to_str(eth_link->link_speed),
>  			(eth_link->link_duplex =3D=3D
> RTE_ETH_LINK_FULL_DUPLEX) ?
>  			"FDX" : "HDX",
>  			(eth_link->link_autoneg =3D=3D
> RTE_ETH_LINK_AUTONEG) ?
>  			"Autoneg" : "Fixed");
> +
> +	rte_eth_trace_link_to_str(len, eth_link, str, ret);
> +
> +	return ret;
>  }
>=20
>  int
>  rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats)
>  {
>  	struct rte_eth_dev *dev;
> +	int ret;
>=20
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
> @@ -2730,7 +2949,11 @@ rte_eth_stats_get(uint16_t port_id, struct
> rte_eth_stats *stats)
>  	if (*dev->dev_ops->stats_get =3D=3D NULL)
>  		return -ENOTSUP;
>  	stats->rx_nombuf =3D dev->data->rx_mbuf_alloc_failed;
> -	return eth_err(port_id, (*dev->dev_ops->stats_get)(dev, stats));
> +	ret =3D eth_err(port_id, (*dev->dev_ops->stats_get)(dev, stats));
> +
> +	rte_eth_trace_stats_get(port_id, stats, ret);
> +
> +	return ret;
>  }
>=20
>  int
> @@ -2750,6 +2973,8 @@ rte_eth_stats_reset(uint16_t port_id)
>=20
>  	dev->data->rx_mbuf_alloc_failed =3D 0;
>=20
> +	rte_eth_trace_stats_reset(port_id);
> +
>  	return 0;
>  }
>=20
> @@ -2833,6 +3058,10 @@ rte_eth_xstats_get_id_by_name(uint16_t port_id,
> const char *xstat_name,
>  	for (idx_xstat =3D 0; idx_xstat < cnt_xstats; idx_xstat++) {
>  		if (!strcmp(xstats_names[idx_xstat].name, xstat_name)) {
>  			*id =3D idx_xstat;
> +
> +			rte_eth_trace_xstats_get_id_by_name(port_id,
> +							    xstat_name, *id);
> +
>  			return 0;
>  		};
>  	}
> @@ -2986,6 +3215,9 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
>  			return -1;
>  		}
>  		xstats_names[i] =3D xstats_names_copy[ids[i]];
> +
> +		rte_eth_trace_xstats_get_names_by_id(port_id,
> &xstats_names[i],
> +						     ids[i]);
>  	}
>=20
>  	free(xstats_names_copy);
> @@ -3001,6 +3233,7 @@ rte_eth_xstats_get_names(uint16_t port_id,
>  	int cnt_used_entries;
>  	int cnt_expected_entries;
>  	int cnt_driver_entries;
> +	int i;
>=20
>  	cnt_expected_entries =3D eth_dev_get_xstats_count(port_id);
>  	if (xstats_names =3D=3D NULL || cnt_expected_entries < 0 ||
> @@ -3025,6 +3258,10 @@ rte_eth_xstats_get_names(uint16_t port_id,
>  		cnt_used_entries +=3D cnt_driver_entries;
>  	}
>=20
> +	for (i =3D 0; i < cnt_used_entries; i++)
> +		rte_eth_trace_xstats_get_names(port_id, i, xstats_names[i],
> +					       size, cnt_used_entries);
> +
>  	return cnt_used_entries;
>  }
>=20
> @@ -3174,6 +3411,9 @@ rte_eth_xstats_get_by_id(uint16_t port_id, const
> uint64_t *ids,
>  		}
>  		values[i] =3D xstats[ids[i]].value;
>  	}
> +
> +	rte_eth_trace_xstats_get_by_id(port_id, ids, values, size);
> +
>  	return size;
>  }
>=20
> @@ -3221,6 +3461,9 @@ rte_eth_xstats_get(uint16_t port_id, struct
> rte_eth_xstat *xstats,
>  	for ( ; i < count + xcount; i++)
>  		xstats[i].id +=3D count;
>=20
> +	for (i =3D 0; i < n; i++)
> +		rte_eth_trace_xstats_get(port_id, xstats[i]);
> +
>  	return count + xcount;
>  }
>=20
> @@ -3234,8 +3477,13 @@ rte_eth_xstats_reset(uint16_t port_id)
>  	dev =3D &rte_eth_devices[port_id];
>=20
>  	/* implemented by the driver */
> -	if (dev->dev_ops->xstats_reset !=3D NULL)
> -		return eth_err(port_id, (*dev->dev_ops-
> >xstats_reset)(dev));
> +	if (dev->dev_ops->xstats_reset !=3D NULL) {
> +		int ret =3D eth_err(port_id, (*dev->dev_ops-
> >xstats_reset)(dev));
> +
> +		rte_eth_trace_xstats_reset(port_id, ret);
> +
> +		return ret;
> +	}
>=20
>  	/* fallback to default */
>  	return rte_eth_stats_reset(port_id);
> @@ -3268,24 +3516,39 @@ int
>  rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, uint16_t
> tx_queue_id,
>  		uint8_t stat_idx)
>  {
> -	return eth_err(port_id, eth_dev_set_queue_stats_mapping(port_id,
> +	int ret;
> +
> +	ret =3D eth_err(port_id, eth_dev_set_queue_stats_mapping(port_id,
>  						tx_queue_id,
>  						stat_idx, STAT_QMAP_TX));
> +
> +	rte_ethdev_trace_set_tx_queue_stats_mapping(port_id,
> tx_queue_id,
> +						    stat_idx, ret);
> +
> +	return ret;
>  }
>=20
>  int
>  rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, uint16_t
> rx_queue_id,
>  		uint8_t stat_idx)
>  {
> -	return eth_err(port_id, eth_dev_set_queue_stats_mapping(port_id,
> +	int ret;
> +
> +	ret =3D eth_err(port_id, eth_dev_set_queue_stats_mapping(port_id,
>  						rx_queue_id,
>  						stat_idx, STAT_QMAP_RX));
> +
> +	rte_ethdev_trace_set_rx_queue_stats_mapping(port_id,
> rx_queue_id,
> +						    stat_idx, ret);
> +
> +	return ret;
>  }
>=20
>  int
>  rte_eth_dev_fw_version_get(uint16_t port_id, char *fw_version, size_t
> fw_size)
>  {
>  	struct rte_eth_dev *dev;
> +	int ret;
>=20
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev =3D &rte_eth_devices[port_id];
> @@ -3299,8 +3562,12 @@ rte_eth_dev_fw_version_get(uint16_t port_id,
> char *fw_version, size_t fw_size)
>=20
>  	if (*dev->dev_ops->fw_version_get =3D=3D NULL)
>  		return -ENOTSUP;
> -	return eth_err(port_id, (*dev->dev_ops->fw_version_get)(dev,
> +	ret =3D eth_err(port_id, (*dev->dev_ops->fw_version_get)(dev,
>  							fw_version, fw_size));
> +
> +	rte_ethdev_trace_fw_version_get(port_id, fw_version, fw_size,
> ret);
> +
> +	return ret;
>  }
>=20
>  int
> diff --git a/lib/ethdev/rte_ethdev_trace.h b/lib/ethdev/rte_ethdev_trace.=
h
> deleted file mode 100644
> index 1491c815c3..0000000000
> --- a/lib/ethdev/rte_ethdev_trace.h
> +++ /dev/null
> @@ -1,95 +0,0 @@
> -/* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright(C) 2020 Marvell International Ltd.
> - */
> -
> -#ifndef _RTE_ETHDEV_TRACE_H_
> -#define _RTE_ETHDEV_TRACE_H_
> -
> -/**
> - * @file
> - *
> - * API for ethdev trace support
> - */
> -
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
> -#include <rte_trace_point.h>
> -
> -#include "rte_ethdev.h"
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_configure,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t nb_rx_q,
> -		uint16_t nb_tx_q, const struct rte_eth_conf *dev_conf, int
> rc),
> -	rte_trace_point_emit_u16(port_id);
> -	rte_trace_point_emit_u16(nb_rx_q);
> -	rte_trace_point_emit_u16(nb_tx_q);
> -	rte_trace_point_emit_u32(dev_conf->link_speeds);
> -	rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode);
> -	rte_trace_point_emit_u32(dev_conf->rxmode.mtu);
> -	rte_trace_point_emit_u64(dev_conf->rxmode.offloads);
> -	rte_trace_point_emit_u32(dev_conf->txmode.mq_mode);
> -	rte_trace_point_emit_u64(dev_conf->txmode.offloads);
> -	rte_trace_point_emit_u32(dev_conf->lpbk_mode);
> -	rte_trace_point_emit_int(rc);
> -)
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_rxq_setup,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t rx_queue_id,
> -		uint16_t nb_rx_desc, void *mp,
> -		const struct rte_eth_rxconf *rx_conf, int rc),
> -	rte_trace_point_emit_u16(port_id);
> -	rte_trace_point_emit_u16(rx_queue_id);
> -	rte_trace_point_emit_u16(nb_rx_desc);
> -	rte_trace_point_emit_ptr(mp);
> -	rte_trace_point_emit_u8(rx_conf->rx_thresh.pthresh);
> -	rte_trace_point_emit_u8(rx_conf->rx_thresh.hthresh);
> -	rte_trace_point_emit_u8(rx_conf->rx_thresh.wthresh);
> -	rte_trace_point_emit_u8(rx_conf->rx_drop_en);
> -	rte_trace_point_emit_u8(rx_conf->rx_deferred_start);
> -	rte_trace_point_emit_u64(rx_conf->offloads);
> -	rte_trace_point_emit_int(rc);
> -)
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_txq_setup,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t tx_queue_id,
> -		uint16_t nb_tx_desc, const struct rte_eth_txconf *tx_conf),
> -	rte_trace_point_emit_u16(port_id);
> -	rte_trace_point_emit_u16(tx_queue_id);
> -	rte_trace_point_emit_u16(nb_tx_desc);
> -	rte_trace_point_emit_u8(tx_conf->tx_thresh.pthresh);
> -	rte_trace_point_emit_u8(tx_conf->tx_thresh.hthresh);
> -	rte_trace_point_emit_u8(tx_conf->tx_thresh.wthresh);
> -	rte_trace_point_emit_u8(tx_conf->tx_deferred_start);
> -	rte_trace_point_emit_u16(tx_conf->tx_free_thresh);
> -	rte_trace_point_emit_u64(tx_conf->offloads);
> -)
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_start,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> -	rte_trace_point_emit_u16(port_id);
> -)
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_stop,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id, int ret),
> -	rte_trace_point_emit_u16(port_id);
> -	rte_trace_point_emit_int(ret);
> -)
> -
> -RTE_TRACE_POINT(
> -	rte_ethdev_trace_close,
> -	RTE_TRACE_POINT_ARGS(uint16_t port_id),
> -	rte_trace_point_emit_u16(port_id);
> -)
> -
> -#ifdef __cplusplus
> -}
> -#endif
> -
> -#endif /* _RTE_ETHDEV_TRACE_H_ */
> diff --git a/lib/ethdev/rte_ethdev_trace_fp.h
> b/lib/ethdev/rte_ethdev_trace_fp.h
> index 40084d1929..186271c9ff 100644
> --- a/lib/ethdev/rte_ethdev_trace_fp.h
> +++ b/lib/ethdev/rte_ethdev_trace_fp.h
> @@ -37,6 +37,42 @@ RTE_TRACE_POINT_FP(
>  	rte_trace_point_emit_u16(nb_pkts);
>  )
>=20
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_call_rx_callbacks,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t queue_id,
> +		void **rx_pkts, uint16_t nb_rx, uint16_t nb_pkts),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(queue_id);
> +	rte_trace_point_emit_ptr(rx_pkts);
> +	rte_trace_point_emit_u16(nb_rx);
> +	rte_trace_point_emit_u16(nb_pkts);
> +)
> +
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_call_tx_callbacks,
> +	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint16_t queue_id,
> +		void **tx_pkts, uint16_t nb_pkts),
> +	rte_trace_point_emit_u16(port_id);
> +	rte_trace_point_emit_u16(queue_id);
> +	rte_trace_point_emit_ptr(tx_pkts);
> +	rte_trace_point_emit_u16(nb_pkts);
> +)
> +
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_tx_buffer_drop_callback,
> +	RTE_TRACE_POINT_ARGS(void **pkts, uint16_t unsent),
> +	rte_trace_point_emit_ptr(pkts);
> +	rte_trace_point_emit_u16(unsent);
> +)
> +
> +RTE_TRACE_POINT_FP(
> +	rte_eth_trace_tx_buffer_count_callback,
> +	RTE_TRACE_POINT_ARGS(void **pkts, uint16_t unsent, uint64_t
> count),
> +	rte_trace_point_emit_ptr(pkts);
> +	rte_trace_point_emit_u16(unsent);
> +	rte_trace_point_emit_u64(count);
> +)
> +
>  #ifdef __cplusplus
>  }
>  #endif
> --
> 2.25.1