From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEAE1A0A02; Thu, 20 Oct 2022 07:32:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A528142C78; Thu, 20 Oct 2022 07:32:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B86AE42C31 for ; Thu, 20 Oct 2022 07:32:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666243933; x=1697779933; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/FV08z9PpikOmdOMnfl2FDKLGWBodMx5d2m7lxXczO8=; b=ZEJ5tZckCcL9ArG5XegiXnV6L/44SdwLG5QjfWolt9pbllkgkxqrsMsM eWj4GD9VKxH4pBoGFlTzbo3Y3DLUyZqbLzUDcqxlBxeFybDbTv6Cgbg4v KjeFGvRlUJRCvKhYB15UOAEB1dhSv0SWLA0uT1J0axSXFwaAVkLSPWYfx Yw2jFGs39sUUvGAvwPS03TfbQ70SV9LiUh2K0oYQRNwhXo/KeHD/5j8DK 0LciXywdeLtkh5AM4Vy9L+mzVxmLkZpqW0UY0DQaod+1ABGY6BtEGEAfa WcUOmDWs4Q29gX19y1GB0WlCLSi25d/syfu8rbcjHGwLFiNDQxveqwKYt g==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="392912626" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="392912626" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 22:32:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="698440522" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="698440522" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 19 Oct 2022 22:32:11 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 22:32:07 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 22:32:07 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 22:32:07 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 22:32:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8ReK/wxG869747ahFZQpNKuSdRqS3gyT3iQr2l202KI6oWK3W24ArbSIC6z67Wdm9dQJ+c33ckJ/LC7EYxeAhZLRdklEGz21YNWmh02aXL7MNApkaAZZhpzmMVH7mup2lb+xYBlh1XLm8ydsGzsKFxsJ3Zs6GaN0H7mKZtu4EvPczdZQfcfbWEccebUg1IZdmGjFiASub2tz/XJ0Pl9pp8CvDSkM6AzeZyrNPi7ZAHXmdfM3vFfZg/8QdJTou3dVbqIva0BrfJaZkUcM++e073Pf/yEeLBLj5S8W8VjmSmRV7fA/e2EAjlj9OVYHJ/OG8bowfreN6RUev+qXmtfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/FV08z9PpikOmdOMnfl2FDKLGWBodMx5d2m7lxXczO8=; b=DQGT/8KqiYHEAl5uQEHsvOZosTL0NfwfaaY8hSK0FS0R2Wu4br+NkO57eHQnheEsmNCMba4vb3UnbsvRC/LBLcZllLYwo79TijG5nJMTeU33k3iC8KrNOCqqNf5A0fxfuvAhRvATm0Cb4TWMX7H4r3wRvQBtKg+BSjmzm9Y2XIaHFxPL0MoPOycQ79i9jxGJsuSd618/R7ja1GrXYC9FSdGNN3lhmSd1f/UR1xRaOpopnVB0kz0LUxrGYbwdoZhhK1qhGU2CPj52ZTgXgDV61DsASuzrPRGDbtD69Kko1oSEfpVhPNm5bvoRMOnJ/w9wYo9wufahAPYAq428lOWk7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7275.namprd11.prod.outlook.com (2603:10b6:610:14c::20) by DM4PR11MB6430.namprd11.prod.outlook.com (2603:10b6:8:b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Thu, 20 Oct 2022 05:32:00 +0000 Received: from CH3PR11MB7275.namprd11.prod.outlook.com ([fe80::2d8e:e7f6:fb43:c175]) by CH3PR11MB7275.namprd11.prod.outlook.com ([fe80::2d8e:e7f6:fb43:c175%3]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 05:31:59 +0000 From: "Li, WeiyuanX" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "Laatz, Kevin" , =?iso-8859-1?Q?Morten_Br=F8rup?= , "Richardson, Bruce" Subject: RE: [PATCH v2] bus: fix memleak during pci device cleanup Thread-Topic: [PATCH v2] bus: fix memleak during pci device cleanup Thread-Index: AQHY47dNfZr4n+O16UKFjM9WxUJt7a4Wwg7Q Date: Thu, 20 Oct 2022 05:31:59 +0000 Message-ID: References: <20221019104923.1240394-1-kevin.laatz@intel.com> <20221019123743.1282969-1-kevin.laatz@intel.com> In-Reply-To: <20221019123743.1282969-1-kevin.laatz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7275:EE_|DM4PR11MB6430:EE_ x-ms-office365-filtering-correlation-id: a04de46c-38a6-41a1-9705-08dab25c6913 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bkFu9L1fwk+uF7yibYAD1LzKbo9+b87uywGWT1+1VTfSU3jQoBDBLg3CIvlzgxajpWjttbGAQVJr9W5LeGB2bZJ7kOZSPMH2VO1rULfuA2dTrkoHDuEsHAf6HbID2Uwlm7iJ5ou2ExWcmUgD5u6zKWi9KYbkHTxTkrtw0v63zJljuLPKQhvcxg7/UVr5cekU4uW40zqo6VnfdMY65ob5KWr/LZLthSmGEVoNhdpuG9H329BazD6wlBM2yn1XgJdOJYByBbNw+m/JfTuh+oFwbRYV+uKCUya1uFPIT+sgGTpKRXdqxiMu/avJ7iqAJMyKxEXnJLPwh/n/rpdzxpCzZk/BDUUKlsxLWgHf9p/rVCjpy23iHK+CjHnPv3W1bMQct+oqUXCcH+OVYaEiH7BYir+g8p3rOVsOQCyzlJBj2xg3ciqZ+tkvSd3N7gnlRJWhqxJ3p8IqSsldoH0nZ07wZyPF8BGV9oCif4bDem/CTpc5aB+e/VFKlsTDPqQrx6ozNcIgJCcREulOc/wGkE7hkuLTSf76NalsIctsdwAsx2CY8Z18RpG02H+PmdF/6I9D+YLJII39DUhVaENcKG9jOfgdHC6ytqybM/q41Ord9CgtE7rMz6y50IWhy4pfiIKGZ10JyS33Yjrgz9Tg8Pj6Mfyn6XUQm5/1PbRi7gpYBeKzacdGUr8cssyFTdwhGGMbb32a4xWKgaAzCcESa+tAbNlqv1vYI8USfvXSbjBjaUqALIKXdaXpMNIq0NXxX1T2cbhudzehL1ZC9hr0+x37fA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB7275.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199015)(38100700002)(66476007)(54906003)(110136005)(66556008)(64756008)(6506007)(7696005)(4326008)(66446008)(38070700005)(8676002)(26005)(83380400001)(122000001)(66946007)(76116006)(9686003)(55016003)(316002)(2906002)(41300700001)(86362001)(53546011)(107886003)(4744005)(71200400001)(5660300002)(478600001)(52536014)(186003)(8936002)(82960400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2DdYPCeUAb+lzcbqWsck0JB1aEnbxRXLDV84Y5Me6pTFJ/w5ElQy+wvk3H?= =?iso-8859-1?Q?kKQlgTXlgGbuck18SbXhiWzzFpmQY46BSkUsJS9qqBdYVsZMdptNEdaKbi?= =?iso-8859-1?Q?kUCAIDyFrbCmvbWeKJz1hOPpAYavDwlJa1zrUue+MLdjjBcSrAikj+fHiX?= =?iso-8859-1?Q?vQX3SvmckfX/VL+jliLH95as2XvK5bgwvWH+vWqNRJjkp3bbcJbDIONsxI?= =?iso-8859-1?Q?BZIcAVn0j7empTjmUs7cv7gBgL31e+sAemozxnenjwW/0BYi3yXMlo7Ddf?= =?iso-8859-1?Q?k3rvSU/5KRFHS6suEHZ6OxV+yVP3s0s7YMYPY82CPg6c2HpFx8BM2lcxZ3?= =?iso-8859-1?Q?rfd4gyQqK8Xfz0FqZyEqN+YDcpZT9dQm2ZclWoi6MD4dl0slpcpDIuTPS4?= =?iso-8859-1?Q?TeuId18le4E9nJh7mpTYiutyM5lrodkS0XCi0ubV7+wXd0DvfXwGClnedV?= =?iso-8859-1?Q?PSrEs1vAx2/rlB95lpiTvzIy3s7UnOlmuEG8wbGGqaaVEd/GY5cF9i3wep?= =?iso-8859-1?Q?YjDOxhB3IXajQ1gmNfP+IDsHXYxirIli40m2UoPCEO1iQUjVyKQkwekklV?= =?iso-8859-1?Q?GSJ6by+0PabmvgHf8GmhjzqEBsMo6G859UTZnHxZ5IXFQUYj3ed3g8EhRF?= =?iso-8859-1?Q?nNzI6YVr9ul7bYWRA+KcQXHG2UUvv1G21ME68lJCweRNoZsTVpB3aTwkP5?= =?iso-8859-1?Q?E7unr9KpAADkd2Bsi0lshgtRGsC3SFd1dh633eZBZMCPChpKVQN3edNArp?= =?iso-8859-1?Q?AGIWOQ9U55yD9bo9sEBDT2gx3pIlbRsK+KvMrGPYq6pK9dSNbojMwGS58g?= =?iso-8859-1?Q?fC2bt+MG1BhWYBHdJI+b18u3UO43YOuCAckcmgvoNM4ovYEuRWJMUh+XhS?= =?iso-8859-1?Q?rtok4ck8ZRCpTL+lBdNQNMMutdIsgPwjuQVVLrZQ8tu0CVVBOz9939PZr8?= =?iso-8859-1?Q?Ct4eaZzF/DwgFkyJKyetcDw7oJYlAzZVKpBCV8Q3DF8POSmbzUwc9V6+OW?= =?iso-8859-1?Q?hWxzZSyo1Iq98u1v+EO58G/DeTVNCrACEkY6x4lx8UNEJPGfN5fRcTwIap?= =?iso-8859-1?Q?cmewBZ1PD8Q9sNakZMhhBA/joGUYn9p6Mm5yM2hQR9seAqvMDODPdpJdqq?= =?iso-8859-1?Q?1n0ScDy1AmoF/pa5sJQZERHbMvunrOTqSU8CxDhlQYxAFKJZ402RH9EH3a?= =?iso-8859-1?Q?JV3clTiRp/09jWJD/OjaLS8qBQxBXS2a2BwezBqCFQhqJODMaihxBXi/y/?= =?iso-8859-1?Q?0POdgZzIFOWEjwD3+UeVL43XoscW216E40gkw5nvioY3lS0VD1l4kdUxNs?= =?iso-8859-1?Q?2rCHZscxSoA7O34GZeQvI/A+GLyDnBJfoeRM3IwM+SDCBi04Zgc3R6Zg5G?= =?iso-8859-1?Q?nf7zymux4QGO/FwQ2u4YMU5MG7IrsL1nfomQgTjKP5hVnDNEjzBS0EQEz7?= =?iso-8859-1?Q?BOQi2z33Rb41DmD4724Eq67p5vGlyEcx+WQCV5IIRapV6DTG5AErYDgCeM?= =?iso-8859-1?Q?SquDI+LlPHKWoHWfFrIHrs3TH5ZJyg19ptThtGVxChDQ6IPHJPSbHoN75M?= =?iso-8859-1?Q?VQ8pbFdHUf3k/vqbReMuGzGcD5VUuCNRWGuPDToRsq7BgX7CKCWSzQguj3?= =?iso-8859-1?Q?K70U7BcF36wKduSqiaqBqIU82tHRwvnoIa?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7275.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a04de46c-38a6-41a1-9705-08dab25c6913 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 05:31:59.5660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5amugKz6AXdHdk3U7QoteMOkgmXKpiXj0LdWy0LhwwazisGLfep7Kkh/SrrlmNbDYFqlOaFhmF8483ikpflexg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6430 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kevin Laatz > Sent: Wednesday, October 19, 2022 8:38 PM > To: dev@dpdk.org > Cc: Laatz, Kevin ; Morten Br=F8rup > ; Richardson, Bruce > > Subject: [PATCH v2] bus: fix memleak during pci device cleanup >=20 > During PCI bus device cleanup some interrupt handle pointers and the > bus_info pointer are not being free'd, leading to memory leaks. > This patch fixes the memory leaks by ensuring they are free'd during devi= ce > cleanup on exit. >=20 > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") >=20 > Signed-off-by: Kevin Laatz >=20 > --- Tested-by: Weiyuan Li