From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0F9344158;
	Wed,  5 Jun 2024 03:16:28 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5208F402CE;
	Wed,  5 Jun 2024 03:16:28 +0200 (CEST)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2042.outbound.protection.outlook.com [40.107.237.42])
 by mails.dpdk.org (Postfix) with ESMTP id A8C59402A9
 for <dev@dpdk.org>; Wed,  5 Jun 2024 03:16:26 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LX344S3+XoieSgGQa/OCQYLhG2uT+746QAeSSaS5Muoan/nqhNcT90vyGiBHnvfuU0NdnnFwxLxlo6aYU2pdtlzLPWWvMbcH5DAbgI3FEZuEIr/8VgFHQwzBZ6j9qYwlTaGHBhL/bg13rxXAALHsh9ygwTYyKa/l8smPv1btdROZ2UqmbDqk1/uSNrxKgdSCWvrOJ0SaAwOoH6OjAa+oS+e61UT+NDzOduieEjuVSDMS3DV+vlJrqM0dGpoRMpeuq+NnTDLi0OCYUaWzd0RuDeF0JQLLtKdlPnn1FeWFgFpJFl+Ox29J5dnCMBVsxn31mi05ZYfBqzfZEfI6vcEssw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZTwR1MQIQACuUHGCWGthNguYYcaWGi2A3GLX7/s7wa4=;
 b=D2B/anMq9kZoqJbBbO2U1DAS60XtJwdiMOCLjRg0usT3VuQH9bdOivVGViI4DDgO3/eSMxmyk1yQU/kGxhBXsaom5Qi2uihJo+XejqVvQfB7Bg4xxR/IYYiG/AvIKE9P5Q/CHtaTvpxgRILL37u6ZDWUaB4rBL+jWH5YW1aNA//EVDey3J+adwOnfipdHr6BdMU5wc/NjXQPSSTbEuzTZA72mqAIIn2vuE1aafrbDrJrMVvlApcb863+eRgVh1lin/taFdIM9EU0TaexgTNs9j5/DZRKqJx+bB4m+xZAE0S7RcPJ4v9y7Ip7Kct6FSBrkX7qiAdubYgEL8DJHzfcpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZTwR1MQIQACuUHGCWGthNguYYcaWGi2A3GLX7/s7wa4=;
 b=HV9QPfH6yLfGqO6GTeWH4pu43Xt5s5gAKeiuNkPWmpoZp6QsoEB3ma9Hlg3qoVrCmYwpi7auVTAXYd4XlUiqKhvh1mZNK2+5ynKhKKffwp9cLCyBCzkBqWbs/ixj6GGchWMNfBCVVvYdhsZqzPzvzcTMwysUtC3Eav/ZG8219QzuBE+RY+yjTh1sCS6M3jVu0e6WQo8VLfn+O4GYKVBR5NrHfDdMoUNNkcGLsaN3OzcOwKSmXy2SQBS520JZekpyYfmnOw5tyknD2ep8UCVT3Vgh1XCCNsYDTd83xHFvkBbxiKDMmxEX5nJ4pwwmGoESidIrake82Kq/Zqy4Ly+TBQ==
Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18)
 by DS7PR12MB8276.namprd12.prod.outlook.com (2603:10b6:8:da::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Wed, 5 Jun
 2024 01:16:23 +0000
Received: from CH3PR12MB8209.namprd12.prod.outlook.com
 ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com
 ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024
 01:16:23 +0000
From: rongwei liu <rongweil@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>, Dariusz
 Sosnowski <dsosnowski@nvidia.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>, Slava
 Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou
 <suanmingm@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew
 Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field
Thread-Topic: [PATCH v4 2/3] ethdev: add VXLAN last reserved field
Thread-Index: AQHatnxK7usmfC8pJUuRgvKy0YbyIbG3s94AgAAWyJmAAARWgIAAIHCAgAButFo=
Date: Wed, 5 Jun 2024 01:16:23 +0000
Message-ID: <CH3PR12MB82094DC38A35BD12C7FFD2EBABF92@CH3PR12MB8209.namprd12.prod.outlook.com>
References: <14937324.O6BkTfRZtg@thomas>
 <CH3PR12MB8209FC4C9706B0CBAD894C8DABF82@CH3PR12MB8209.namprd12.prod.outlook.com>
 <PH0PR12MB8800ECD345A322AFC4F5DC5CA4F82@PH0PR12MB8800.namprd12.prod.outlook.com>
 <5068960.a9HWlOh95j@thomas>
In-Reply-To: <5068960.a9HWlOh95j@thomas>
Accept-Language: en-US, zh-CN
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
msip_labels: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|DS7PR12MB8276:EE_
x-ms-office365-filtering-correlation-id: 7c23d644-72cf-4e1f-5f87-08dc84fd1d4e
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009;
x-microsoft-antispam-message-info: =?iso-8859-1?Q?3zSF8Mko3TiXPSczw+bM/+2/0VFwzl8Dw60ax9KmDEc+UOkrx6kd89adys?=
 =?iso-8859-1?Q?ZdwrOoP4uVgKXchaRU8dlm525DfLFVtkXrhqPJsyKa7rya+kUdivsm0eSA?=
 =?iso-8859-1?Q?+JomUjngiV0V+a0JbWCCjPzWajHRLJU2sKftJLnKgkec6IiQxtLguYZBei?=
 =?iso-8859-1?Q?K+Dn5qUYqt/LbgmtHrqUT2P937dHsZD1CUx5nJbQ/iSaHF5MrV9DK38dmi?=
 =?iso-8859-1?Q?BQZVzsrcrax5w9lw73kPynBYQlgJpW80BGEAT7Ub/Ep9c3ya/R9EHBULDg?=
 =?iso-8859-1?Q?nCU+5s9u6aHD6NeA4ZmMi1cpl+/LE4Moq/LdIPhIwNM6IyDcKswzfTuFC6?=
 =?iso-8859-1?Q?9kWmCZRk2IaCIvUXmps0Mm8YXUwxP/6qNg18BZgYxWwAQSSSLCmLLoMLyo?=
 =?iso-8859-1?Q?QaF5Dx65UWQr91ts8JOl2dP4F5NeeD15Vn7z4O7pTnPr8Q4qG0S3lGcmCg?=
 =?iso-8859-1?Q?jr9kela0UVK4EsHDnmA9lrJhvYIDHHMgsMxf5JSmx+KhQETb6u+N2B4foj?=
 =?iso-8859-1?Q?VIDCcr7hDzH3g3H3gKjSztyLvdg+ut6sS5+FyL3odUHrTXXRFzHMn5eOS3?=
 =?iso-8859-1?Q?PyVDKXXvCFw8lcXNKWhB8NAFhOWDjTObGc6QGFRoc+ddl0L9IRKixgafiV?=
 =?iso-8859-1?Q?lvkoUyK9hlbElv3pIFMOyD0cYZ7VYeG2CTEPmoBw2lZYrifhVEkov9DjzK?=
 =?iso-8859-1?Q?sJR87BOOWqE018AwpFBiKWe5d8XYqzPEHNtxcQHjMdivjNtHYUaMPk+LaK?=
 =?iso-8859-1?Q?KAfQ355Jhq1qJTHWujekeriPLrO2ZuZxDwsYAMiaT1yDofo6dyckv6gVXc?=
 =?iso-8859-1?Q?ihceQqfTh32kGJcjCclNAQShMWWM5xyQzCQafnH1YfHlZrfcMQcH05c68E?=
 =?iso-8859-1?Q?n5SmC14cJhJ/Zu4gdEXmirO0/1jzWm0jqgUtKErgz1ADfowq0OFaQpDVk0?=
 =?iso-8859-1?Q?WioHNRMK9dIypl4QQXgHILJmS8CioJPWpVpwWCz/G95z6G8Bp1097yA5vZ?=
 =?iso-8859-1?Q?muvMlDJ1NmTwqxSFQACMs/PQc2vqqQz5Nf9jcf/O+QggE0JqQLZKtdlC7o?=
 =?iso-8859-1?Q?fhrRVPiLuR7uRjGLeqG2SljwuRu3ddceVsldDlKc4vy3ZAlSPFlXZkqdsU?=
 =?iso-8859-1?Q?3SYIGCx9KMbeaUjU0ivyqiiGU9tGR3ipdXsqlhVYuvV4AQj1OwzPSJ0X83?=
 =?iso-8859-1?Q?4yQSNzNkFpj/nowfiyqkg0Jm/HF3Ji4tpuXd3vkp4AwFNctcnR9omUExwQ?=
 =?iso-8859-1?Q?16WZKY/GwdL0MvEFBYQ6cZo3fLe60AUQBnQQEOCOV+O4oDtBfx5fkUPlxd?=
 =?iso-8859-1?Q?+Cn+rFM7DW5Pi5RSyk1CqLttu1F3we15XIwsziIvi53UftlfVt3Io1iRsK?=
 =?iso-8859-1?Q?hp+vmT1A/Qq79dSSWz8/mnwVHPaewFDQGkVpfl/X7tj/RTh+sq/VQ=3D?=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?XheeYwBdemvWzN/rPKcOpb3MOrr/eOyFSDbh2RmRJ4KqMImTOXqLGeE/Iw?=
 =?iso-8859-1?Q?j6gs5yzWuaZrkdoegcdFb7ENXGI4DJAPm8z5E8laPuFbagM8pg9iGMLqjb?=
 =?iso-8859-1?Q?l9+23GiJVHOPNneAoPQr3Uyl+QO/bfLThmeSSwRdI8LbX8epCAMYyQA31T?=
 =?iso-8859-1?Q?f66n5oR+i73ufP6nkBzCj5dw+AW0IFqNyghWiee2uT/Gr/aROB8QsspzfP?=
 =?iso-8859-1?Q?6tF28eftq27qbXCptSqgrOxwXCdmQVeZtWTrptexvaMBNqT6sJ2CtherwX?=
 =?iso-8859-1?Q?wKArFI9hUaXKsmqR1nN6sIYy1BFopm7jhfMfEMiVJHR/pEuO04wKc1bh/Y?=
 =?iso-8859-1?Q?iYHamuWV5Oct3RtXI/3BBc++Nfpg7UJIxozMML2OAo7UfOwEN63lPs+kRq?=
 =?iso-8859-1?Q?Ti82Gl0pqfn4ssI5C4un6liYjGpeO9SrLKke65yGmXB3+qQEbQk532E4T4?=
 =?iso-8859-1?Q?GiVmVqAMU6QxZ6rr8A0ohURKMsjVqWfQR3BQh5YZAkmz2HPt92zsfWTA1J?=
 =?iso-8859-1?Q?JfuHAlJs376CmOKExAM0WDzsd9te5SkYAbqqbOHrh2mxEyzijvL9apd4pn?=
 =?iso-8859-1?Q?60LNyNhPlhotS3o5XbQWnNA/wHxIN9ZmmES86BnJArzilPNP0O1WcA+dVX?=
 =?iso-8859-1?Q?KHvLPFtQKyQP7CZqTksGacH8tXZ6UXeG52o9fWl6KRA2QsNMB5ZmaHFfyk?=
 =?iso-8859-1?Q?cfQq5dfdeCoHJgiNPv2QeAQ61wGjv5S/3rui3LiHPkJOi1OX67KYskiLPA?=
 =?iso-8859-1?Q?oOQgg2u1AP+kB27dSSeP1iT2iH4c9uys2hQJj2dX2xCa19hxwY3xkVnrIX?=
 =?iso-8859-1?Q?MuNnx/RrBSnOowLS/jJpUDUqcA0c/OaqASgqz19pr1jh9tHxLW0I2l9CBg?=
 =?iso-8859-1?Q?4CF2NRUbATBME7yNTp6oY5Ov78Gm5Ju4s5MVv9tNY1Sv7YNqqyHaKvePEM?=
 =?iso-8859-1?Q?lu3dkb/DTxYz4vzgcW6P/ppcLhC5o1ktOlMRX98/oeVLQAiXO7IPYEKwZx?=
 =?iso-8859-1?Q?4aSjeJkeOr5fFFRXEkyslawbv7A+IWI0IatgU63SF0hLN/o5jbLIvVZjXS?=
 =?iso-8859-1?Q?ogC1zaH683P75YFxiohh/msxUql3SahBWOe6k8kMzsRzKtczmABUR1pDcB?=
 =?iso-8859-1?Q?L3NgjuQIvRkHjZTz8YTO4HfrXf0tr3z9f7HBFgrLPS3FZW1C9nnVFiUaar?=
 =?iso-8859-1?Q?8pFnaTyA9Ta2oYKucqV7AABRo2aC1pIeLg52lv8oO4HoWXZCMSj6/DHMD0?=
 =?iso-8859-1?Q?nf83ff9jMp00akeBDYkIN9+Nsc8XNg687Bno4RKH2Pqra90cg+02zzRC4y?=
 =?iso-8859-1?Q?ZL3YzESWZ8+Wb5kBNFhbMo4qg8HHMlG8tLAXmHHfKzcskTRNAii+fq/cCI?=
 =?iso-8859-1?Q?2Xd0RluNdhEOjNSUeDDHVZHmkcP17nbcf4CFOxbqzkW9+fZs/l0Tl7gllB?=
 =?iso-8859-1?Q?xAOs2nzs9sRETXhmdX6Ar51ifjwYOqWMcKubfV+UguYiJNrmszNSzCWKYN?=
 =?iso-8859-1?Q?GxixAFDTwkZe2TJNudWXvbRyjSBxpddZ865oIgiH0Dn32QF9LCtRxEyYQu?=
 =?iso-8859-1?Q?dDEeolsp2Mh2HN25dABmW1CVmXjy9yh4kqOgXOzyT8LyG4f15DYbpQ7JS4?=
 =?iso-8859-1?Q?OFCCNrrPbQJLP7JlkcslHdM8HF+t+WpCQV?=
Content-Type: multipart/alternative;
 boundary="_000_CH3PR12MB82094DC38A35BD12C7FFD2EBABF92CH3PR12MB8209namp_"
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c23d644-72cf-4e1f-5f87-08dc84fd1d4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 01:16:23.2854 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: veIdElloyLiDmiGULPlWnAQeeEIrdewI2H1pRPY5wlwuFZhTmOJXqoMYSUc4jv0+NbBOCG+yVC/U/QuqQOuhIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8276
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--_000_CH3PR12MB82094DC38A35BD12C7FFD2EBABF92CH3PR12MB8209namp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable



BR

Rongwei



________________________________
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Wednesday, June 5, 2024 2:37
To: rongwei liu <rongweil@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia=
.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsi=
ienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <s=
uanmingm@nvidia.com>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang =
<yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Andrew Rybch=
enko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

External email: Use caution opening links or attachments


04/06/2024 18:40, Dariusz Sosnowski:
> > > 04/06/2024 14:38, Rongwei Liu:
> > > > --- a/app/test-pmd/cmdline_flow.c
> > > > +++ b/app/test-pmd/cmdline_flow.c
> > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] =3D=
 {
> > > >       "ipv6_flow_label", "ipv6_traffic_class",
> > > >       "esp_spi", "esp_seq_num", "esp_proto",
> > > >       "random",
> > > > +     "vxlan_last_rsvd",
> > > >       NULL
> > > >  };
> > >
> > > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpm=
d?
> > > Just because it is the same order?
>
> Yes, it's because of the order.
> We should refactor this to use array designators.
>
> > > > --- a/lib/ethdev/rte_flow.h
> > > > +++ b/lib/ethdev/rte_flow.h
> > > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {
> > > >       RTE_FLOW_FIELD_ESP_SEQ_NUM,     /**< ESP Sequence Number. */
> > > >       RTE_FLOW_FIELD_ESP_PROTO,       /**< ESP next protocol value.=
 */
> > > >       RTE_FLOW_FIELD_RANDOM,          /**< Random value. */
> > > > +     RTE_FLOW_FIELD_VXLAN_RSVD1,     /**< VXLAN last reserved byte=
. */
> > > >  };
> > >
> > > I think we should use the same naming as in testpmd.
> > > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?
> > To be honest, no strong objection per my personal thought.  Considering=
 the API "vxlan_hdr" names this field as "uint8_t rsvd1", maybe RTE_FLOW_FI=
ELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping?
>
> +1 on using RSVD1 so it matches rte_vxlan_hdr definition.
>
> In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches existi=
ng "last_rsvd" field in VXLAN item.
> If we choose to use "rsvd1", we should probably rename all other instance=
s of "last_rsvd" to match.

I prefer "vxlan_last_rsvd" for 2 reasons:
        - it is more meaningful
        - we are adding first, second and third reserved fields to match th=
e 3 bytes of rsvd0 (patch to come)

Sound clear and reasonable. I would like to propose the alignment between r=
te_flow_field_id and rte_vxlan_hdr:

  1.
RTE_FLOW_FIELD_VXLAN_RSVD1  ---> RTE_FLOW_FIELD_VXLAN_LAST_RSVD
  2.
"uint8_t rsvd1"  ---->  "uint8_t last_rsvd"




--_000_CH3PR12MB82094DC38A35BD12C7FFD2EBABF92CH3PR12MB8209namp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div id=3D"Signature">
<p>BR</p>
<p>Rongwei</p>
<p>&nbsp;</p>
</div>
<div id=3D"appendonsend"></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style=3D"display: inline-block; width: 98%;">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><span style=3D"font-family: Calibri, =
sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b>&nbsp;Thomas=
 Monjalon &lt;thomas@monjalon.net&gt;<br>
<b>Sent:</b>&nbsp;Wednesday, June 5, 2024 2:37<br>
<b>To:</b>&nbsp;rongwei liu &lt;rongweil@nvidia.com&gt;; Dariusz Sosnowski =
&lt;dsosnowski@nvidia.com&gt;<br>
<b>Cc:</b>&nbsp;dev@dpdk.org &lt;dev@dpdk.org&gt;; Matan Azrad &lt;matan@nv=
idia.com&gt;; Slava Ovsiienko &lt;viacheslavo@nvidia.com&gt;; Ori Kam &lt;o=
rika@nvidia.com&gt;; Suanming Mou &lt;suanmingm@nvidia.com&gt;; Aman Singh =
&lt;aman.deep.singh@intel.com&gt;; Yuying Zhang &lt;yuying.zhang@intel.com&=
gt;;
 Ferruh Yigit &lt;ferruh.yigit@amd.com&gt;; Andrew Rybchenko &lt;andrew.ryb=
chenko@oktetlabs.ru&gt;<br>
<b>Subject:</b>&nbsp;Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved fie=
ld</span>
<div>&nbsp;</div>
</div>
<div class=3D"elementToProof" style=3D"font-size: 11pt;">External email: Us=
e caution opening links or attachments<br>
<br>
<br>
04/06/2024 18:40, Dariusz Sosnowski:<br>
&gt; &gt; &gt; 04/06/2024 14:38, Rongwei Liu:<br>
&gt; &gt; &gt; &gt; --- a/app/test-pmd/cmdline_flow.c<br>
&gt; &gt; &gt; &gt; +++ b/app/test-pmd/cmdline_flow.c<br>
&gt; &gt; &gt; &gt; @@ -1006,6 +1006,7 @@ static const char *const flow_fie=
ld_ids[] =3D {<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &quot;ipv6_flow_lab=
el&quot;, &quot;ipv6_traffic_class&quot;,<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &quot;esp_spi&quot;=
, &quot;esp_seq_num&quot;, &quot;esp_proto&quot;,<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &quot;random&quot;,=
<br>
&gt; &gt; &gt; &gt; +&nbsp;&nbsp;&nbsp;&nbsp; &quot;vxlan_last_rsvd&quot;,<=
br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; NULL<br>
&gt; &gt; &gt; &gt;&nbsp; };<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 =
in testpmd?<br>
&gt; &gt; &gt; Just because it is the same order?<br>
&gt;<br>
&gt; Yes, it's because of the order.<br>
&gt; We should refactor this to use array designators.<br>
&gt;<br>
&gt; &gt; &gt; &gt; --- a/lib/ethdev/rte_flow.h<br>
&gt; &gt; &gt; &gt; +++ b/lib/ethdev/rte_flow.h<br>
&gt; &gt; &gt; &gt; @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; RTE_FLOW_FIELD_ESP_=
SEQ_NUM,&nbsp;&nbsp;&nbsp;&nbsp; /**&lt; ESP Sequence Number. */<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; RTE_FLOW_FIELD_ESP_=
PROTO,&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /**&lt; ESP next protocol value.=
 */<br>
&gt; &gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; RTE_FLOW_FIELD_RAND=
OM,&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /**&lt; Random va=
lue. */<br>
&gt; &gt; &gt; &gt; +&nbsp;&nbsp;&nbsp;&nbsp; RTE_FLOW_FIELD_VXLAN_RSVD1,&n=
bsp;&nbsp;&nbsp;&nbsp; /**&lt; VXLAN last reserved byte. */<br>
&gt; &gt; &gt; &gt;&nbsp; };<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; I think we should use the same naming as in testpmd.<br>
&gt; &gt; &gt; What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?<br>
&gt; &gt; To be honest, no strong objection per my personal thought.&nbsp; =
Considering the API &quot;vxlan_hdr&quot; names this field as &quot;uint8_t=
 rsvd1&quot;, maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as =
1 vs 1 mapping?<br>
&gt;<br>
&gt; +1 on using RSVD1 so it matches rte_vxlan_hdr definition.<br>
&gt;<br>
&gt; In this patch, &quot;vxlan_last_rsvd&quot; is used in testpmd, so it m=
atches existing &quot;last_rsvd&quot; field in VXLAN item.<br>
&gt; If we choose to use &quot;rsvd1&quot;, we should probably rename all o=
ther instances of &quot;last_rsvd&quot; to match.<br>
<br>
I prefer &quot;vxlan_last_rsvd&quot; for 2 reasons:<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - it is more meaningful<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - we are adding first, second an=
d third reserved fields to match the 3 bytes of rsvd0 (patch to come)</div>
<div class=3D"elementToProof" style=3D"font-size: 11pt;"><br>
</div>
<div class=3D"elementToProof" style=3D"font-size: 11pt;">Sound clear and re=
asonable. I would like to propose the alignment between rte_flow_field_id a=
nd rte_vxlan_hdr:</div>
<ol start=3D"1" data-editing-info=3D"{&quot;orderedStyleType&quot;:1,&quot;=
unorderedStyleType&quot;:1}" data-listchain=3D"__List_Chain_23" style=3D"ma=
rgin-top: 0px; margin-bottom: 0px; list-style-type: decimal;">
<li style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, C=
alibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
RTE_FLOW_FIELD_VXLAN_RSVD1&nbsp; ---&gt; RTE_FLOW_FIELD_VXLAN_LAST_RSVD</di=
v>
</li><li style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontServi=
ce, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
&quot;uint8_t rsvd1&quot;&nbsp; ----&gt;&nbsp; &quot;uint8_t last_rsvd&quot=
;&nbsp;</div>
</li></ol>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-size: 11pt;"><br>
</div>
<div class=3D"elementToProof" style=3D"font-size: 11pt;"><br>
</div>
</body>
</html>

--_000_CH3PR12MB82094DC38A35BD12C7FFD2EBABF92CH3PR12MB8209namp_--