From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10C6D43B6A; Thu, 22 Feb 2024 04:06:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A95B3402DA; Thu, 22 Feb 2024 04:06:37 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2040.outbound.protection.outlook.com [40.107.93.40]) by mails.dpdk.org (Postfix) with ESMTP id 3F6BA40281; Thu, 22 Feb 2024 04:06:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3GvqWZF6d6PAFPhsfJFyoZIx5d3JXy+1qEvvoKYBYZwtOyZh9gKq4UjKZgozMOnqIyz+WrgS0OP/nqryKlnHFmnHOpSFSSB7jnfgBvDwGwQqaB2KqROeSuvqXOfC3keNGiF+BCPVYmKb5cfN//hif/wB+QzgxgD19DBlCtQUj9vh1cTu78sJcdF31T/5U10tly0m3i/gDdCFRTYoRf2PpmzfS6T6j7sIcK1tb5e0exP2H5JjbIX6y1Sr/z+D48+i+sDBXjpljRfqL+ZjXbe5KHJVG2emCiu3mohPGyiWiSeialsZJG2pIqSPJUY74KY3TyYs9Xcpy6eMaSubypeXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LLlKzNINtJjhcPM5NxBtwbk5swlsu8P64HPCRt26xc=; b=TpazApQnlmjtrM4SKqGUpNoUihVlGHfGJ4zYOWij8WaxPCUTRXzC4/6VTIAxAHMJ2a2RICRI6jqAxVBAKn2YwW0HE9IUtjA7DtPix0YkfpWY7vNI63mswVSMxsynzb720XP92NOwYDBQmtoH75jn8p3OupbLFjrc1Dv/7hNf7K1Ai57w4jvh7jy4c4aJ9hdtU1D4t7/jXITO6PaxP1LBGjbgw5ywsYflR98xxNUloYwy8NkkHP+F/3+tcmWjdU2gbobA94LiE+9o3on6vjexFjN8WueBVPvQ4N0X6w5wP6GU3ftQcQBJ39IFERLPFBvDshS5OOGYk597+DNEbl2GzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4LLlKzNINtJjhcPM5NxBtwbk5swlsu8P64HPCRt26xc=; b=tKLNlrCBcAhBJBYx5wye3kaT/AYIDT9rvj7gi+twzkbEKF/TZC7w7GNCXj+2wfgw6Ob96jI41q1gLbUJcJJ1w1n3LIZKrMxc/ry7dfnGo/nXAL0EE8hJu0EoPOT5lYRTnawHEk84E3UkQBhJT4njRn7eiGwTbCTvyyaHiemkyCOUvJM9HGtQKftGZw4lv15tbr8ygFRxHDvpFHa84RLfHTzxRuGCAELkBsQV6qLf1jnkX68GgEXBWXY7b8x3IDYDv4CwzJsUIalhqJB6W9gt64Jx8HLmpFrnM/HeLXV/FHGbS++D6e9ji1aZ6wRAP0Ee4ZN0xEQMKFIi5d0dMRRnsA== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by DM4PR12MB6591.namprd12.prod.outlook.com (2603:10b6:8:8e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Thu, 22 Feb 2024 03:06:33 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::3d1b:b474:1b55:63fe]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::3d1b:b474:1b55:63fe%6]) with mapi id 15.20.7316.018; Thu, 22 Feb 2024 03:06:33 +0000 From: rongwei liu To: Ferruh Yigit , "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Raslan Darawsheh CC: Michael Baum , "stable@dpdk.org" , Dariusz Sosnowski , Aman Singh , Yuying Zhang Subject: Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo Thread-Topic: [PATCH v1 1/2] app/testpmd: fix modify tag typo Thread-Index: AQHaZJU4EwC0qY9rXEWnfwtFsxVXFbEU/l2AgAACSICAAK1urA== Date: Thu, 22 Feb 2024 03:06:33 +0000 Message-ID: References: <20240221071043.3309205-1-rongweil@nvidia.com> <20240221071043.3309205-2-rongweil@nvidia.com> <8cec38d8-b7e6-4288-ae32-1ac3732d159e@amd.com> <787e4cc7-8687-482e-b59e-4826e6ae87d3@amd.com> In-Reply-To: <787e4cc7-8687-482e-b59e-4826e6ae87d3@amd.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-Mentions: rasland@nvidia.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|DM4PR12MB6591:EE_ x-ms-office365-filtering-correlation-id: a2eb12a3-39ab-4f10-235f-08dc3353464e x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rinsIB8dNXKuY5onEuZzK6eVZDVUzhS/jdktS0QU8cViX80njREPWCZUkXenMULi3rgjBRPMvrZtOOuixTfmMLxdK/hdgZgZM4cOQIdJWbTAFBRf+FqVNB7n7UHOzZfbbta5w5lacYbkb9092sag+4cyqT1QjihfQktIsDEvXqveTOZQjvvtu5/0Xae4tOabxJnLhf41F34/Uyal0SLHEbLKKnycy3inx5yr+EC+rSBJ0lXw+rsiOPnJWX35CzQ0A6238CdxLtf/GSDX6t5f6MMXhPivRD3zq2FTzEtplEve0GAOxFZGtqdlA/wyQ45AeDIlMBXJ7NVuFNKRdl8P2NxDIUqBeR1Ih5iFA/gRZ9O/mfNvRYbKC8itUDIpjjU9N+sANZ7JwxFc/DNqxWdIT6pUnlxcXvN5cUc7sYTkUVFwZVAbnHkxnfvrVPsTSjqn9WpwyK10nhh2zW9/ArjMafaS9As+DJtDwVoZxYF5RFXnSWiV3xtEV3y+2WsiOBqoanotIc0z42fe+fH81946ANhZcWJs6CREErTZO/mcPlX5oulOCJH7q9wrpjwYP1FF2DJtP8sVLC59ht2Xnnxbjcjs7UyxvuN+9nfiLUcp/6Q51kicNZU0NUhSrQqLe6gP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(230273577357003)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gnh3GTNBBxcVcq3M8GJ5QXpaK3nDgrJFPi8Mo/bFTHnrBtKS+yKepHntNJzO?= =?us-ascii?Q?4aedo1OcjGwL8954eCfDYl1/BxozxsrBFC2N/qngp80EcCuxmi3/RJhjBJFZ?= =?us-ascii?Q?jul7QpjgAbDYvbkRNOmFwFQpAhBkx1W7YBJbGv7Gd2TL3FRx/oj19SBZootb?= =?us-ascii?Q?krWf0Ri+KrBH7EH4XhEuQif94hDz+SVOwm+M6TF+FmYW2AvyL33ZLHt58ST+?= =?us-ascii?Q?ctYMubJDY9uzUaC9r3OL+JJrhK92EyQS9qicO0REfo2DFusKHFvYw75fadE8?= =?us-ascii?Q?nc4n/d2FVxWTXTtFYUaRL7ptnkmfk6HdBHunNF39NKJ9ctgVpU0DkIDo7Wzr?= =?us-ascii?Q?7TdOtWsxaE27JTjC3bp+6tQy4HX67iXbw8kwoh1t/XbAT+e/2Bf/ANArx55j?= =?us-ascii?Q?7rmsDkN7nsic4O5vHjC1UE3n6tSwiY8t4pKHWXJ1/0DiMRkNXMSWQIWrOpbF?= =?us-ascii?Q?ZJiv08rY4Kx1MlJ8IXeAhGq+x3fWXGZT5mn8WSaWSpAof5gCeRbl0kVAtekj?= =?us-ascii?Q?ImCLFDoxUCFNtZ9t2C8pD/GP+3faT6Xq1hdZswTDr5+lYpM1yrEaVgCadh3R?= =?us-ascii?Q?RCbENVK07qzcZHO1aCeQAFcLE5DhEBtCJ8uwUR1DR/j/e72tFfvoOhOODr3Y?= =?us-ascii?Q?t4RVSJrTvW0jUkQPucMgo9d9tM21lcd5Fvi7dnCOeCScu8+AwaRU+72Kb1gS?= =?us-ascii?Q?crBSF0xs7aLrD+HIAIEiRiksZDm5nyCp0f1718GSJevw2pJHhhAsQjO0pwhf?= =?us-ascii?Q?gLQjAIGE5KymOkFg4H79bGPHRP6U0o0mb4/I5X5a6JjjavWM838IxCgLzMBh?= =?us-ascii?Q?trBYSLHJGuzbTA5bUPjH0kCuhEAqRycDSINpvEuXlgofIrpG07ADYehN3bbZ?= =?us-ascii?Q?mAKlPM+h+3WyRfv9JRfmLNmKfdz4agjGPCchCGaZzDaeAm98gxAO+bQsae5E?= =?us-ascii?Q?M43r9MmYgNEGDTGtM/U9KhiUpObruJery7s/L1FUaYgNpCLfFZJA8pz+w6UX?= =?us-ascii?Q?OKH5kcrFoYNC0MFPbD0EXF82UNLRCbqXJAQAZzvGUUoI1uf7gBmaM1rjRzlh?= =?us-ascii?Q?BX4ZJVfTA3ba11X0VJmnRUuELyCmARHvP8M5NtaZc+AFeTdWax7+4xDQ9xqC?= =?us-ascii?Q?KbqRPuaIeoDhbTbftA1n9WJKG4jlUdPTvxJ8MAYKunod8OpwaQT7NNU0nvgX?= =?us-ascii?Q?rrETpTSe3NPtAHVXuDWTttsgmU+ry+wuRtqAlbNnIFPp0Y3Su/zuns4ZBtOW?= =?us-ascii?Q?zHgHS9uLqOn8eurg5rqoxe+SPZdu15hCK0xJCkoDbaOqF7FbR3zyPXj55dcG?= =?us-ascii?Q?E4xGC9wzxg8CZD58dyM6zbaPvQ5cJlKMw2GI4zTFQBUq98hytfmd3xp/BhnO?= =?us-ascii?Q?tS4fBG5X9iACx0AT812dzvpJRVX0XWA3Y2fy6KPxpBp6zLt0+Kv3HISRytQy?= =?us-ascii?Q?COEvpsXbYor68kppf6tjxiEmSEJtgJ6JsvoQDM1Vb/ry64tBHvP7TNRuTzjy?= =?us-ascii?Q?1bD5OW7bk/adjROJaQ5m2tvjpze94RcaXiL1Z/vaIvZr9Rn/lKT8b3o1h4Uv?= =?us-ascii?Q?nJfVXL6Z4zlPRB+gP8spbM68UY4CAcrQ4FhQhFJC?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8209D421B8529F37C9352E17AB562CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2eb12a3-39ab-4f10-235f-08dc3353464e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 03:06:33.4548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5OkL22TyIdNtuE0Xhgj0sst/J2WpUaU5BPLO9nfAY0Cv0WifhjDe6nkwtzV+SeY27M0ndp3RCY+Or9rYFrNgMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6591 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB8209D421B8529F37C9352E17AB562CH3PR12MB8209namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am using the master-net-mlx branch as base to verify. And cross-checked the main and master-net-mlx branch diverage now. Patch 1 was good and patch 2 failed to apply on the main branch. [rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 1.patch patching file app/test-pmd/cmdline_flow.c Hunk #1 succeeded at 7283 (offset -186 lines). [rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 2.patch patching file drivers/net/mlx5/mlx5_flow.c Hunk #1 succeeded at 2384 with fuzz 1 (offset 15 lines). patching file drivers/net/mlx5/mlx5_flow_hw.c Hunk #1 FAILED at 6104. Hunk #2 FAILED at 6129. 2 out of 2 hunks FAILED -- saving rejects to file drivers/net/mlx5/mlx5_flo= w_hw.c.rej @Raslan DarawshehDo I need to switch to main bra= nch when sending patches to community? BR Rongwei ________________________________ From: Ferruh Yigit Sent: Thursday, February 22, 2024 0:42 To: rongwei liu ; dev@dpdk.org ; Matan A= zrad ; Slava Ovsiienko ; Ori Kam = ; Suanming Mou ; NBU-Contact-Thomas= Monjalon (EXTERNAL) Cc: Michael Baum ; stable@dpdk.org ;= Dariusz Sosnowski ; Aman Singh ; Yuying Zhang Subject: Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo External email: Use caution opening links or attachments On 2/21/2024 4:33 PM, Ferruh Yigit wrote: > On 2/21/2024 7:10 AM, Rongwei Liu wrote: >> Update the name to the right one: "src_tag_index" >> >> Fixes: 7ea38955b ("ethdev: update MPLS header modification API") >> Cc: stable@dpdk.org >> >> Signed-off-by: Rongwei Liu >> Acked-by: Dariusz Sosnowski > > > Acked-by: Ferruh Yigit > btw, fixes commit is wrong, it should be [1], I guess this is related to the tree you are using as other patch has similar issue. [1] Fixes: c23626f27b09 ("ethdev: add MPLS header modification") --_000_CH3PR12MB8209D421B8529F37C9352E17AB562CH3PR12MB8209namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I am using the master-net-mlx branch as base to verify.
And cross-checked the main and master-net-mlx branch diverage now. 
Patch 1 was good and patch 2 failed to apply on the main branch.

[rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ = -p 1 < 1.patch
2 out of 2 hunks FAILED -- saving rejects to fil= e drivers/net/mlx5/mlx5_flow_hw.c.rej

@Raslan DarawshehDo I need to switch to main branch when sending patches to co= mmunity?

= BR

= Rongwei

=  

From: Ferruh Yigit <ferr= uh.yigit@amd.com>
Sent: Thursday, February 22, 2024 0:42
To: rongwei liu <rongweil@nvidia.com>; dev@dpdk.org <dev@dp= dk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viach= eslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <s= uanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@= monjalon.net>
Cc: Michael Baum <michaelba@nvidia.com>; stable@dpdk.org <s= table@dpdk.org>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Aman S= ingh <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel= .com>
Subject: Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo
 
External email: Use caution opening links or attac= hments


On 2/21/2024 4:33 PM, Ferruh Yigit wrote:
> On 2/21/2024 7:10 AM, Rongwei Liu wrote:
>> Update the name to the right one: "src_tag_index"
>>
>> Fixes: 7ea38955b ("ethdev: update MPLS header modification AP= I")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
>> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>

btw, fixes commit is wrong, it should be [1], I guess this is related to the tree you are using as other patch has similar issue.


[1]
Fixes: c23626f27b09 ("ethdev: add MPLS header modification")
--_000_CH3PR12MB8209D421B8529F37C9352E17AB562CH3PR12MB8209namp_--