[PATCH 0/2] use flags from user if it is set

[PATCH 0/2] use flags from user if it is set

[Minggang Li(Gavin)]

This patch series also fixed mlx5 release notes on VXLAN limitations.

Minggang Li (Gavin) (2):
  doc: fix mlx5 VXLAN matching limitations
  app/testpmd: use flags from user if it is set

 app/test-pmd/cmdline_flow.c | 3 ++-
 doc/guides/nics/mlx5.rst    | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH 1/2] doc: fix mlx5 VXLAN matching limitations

[Minggang Li(Gavin)]

P bit of VXLAN-GPE and G bit of VXLAN-GBP should be set when matching the
protocols.

Fixes: 49765b78c81b ("net/mlx5/hws: match all VXLAN fields")
Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 690b46a974..caf711ce67 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -339,6 +339,10 @@ Limitations
   - For ConnectX-5, the UDP destination port must be the standard one (4789).
   - Default UDP destination is 4789 if not explicitly specified.
   - Group zero's behavior may differ which depends on FW.
+  - User should set different flags when matching on VXLAN-GPE/GBP:
+
+   - for VXLAN-GPE - P flag
+   - for VXLAN-GBP - G flag
 
 - Matching on VXLAN-GPE header fields:
 
-- 
2.34.1

RE: [PATCH 1/2] doc: fix mlx5 VXLAN matching limitations

[Dariusz Sosnowski]

> -----Original Message-----
> From: Minggang(Gavin) Li <gavinl@nvidia.com>
> Sent: Tuesday, February 18, 2025 11:33
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon (EXTERNAL) <thomas@monjalon.net>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; Alex Vesker <valex@nvidia.com>; rongwei liu
> <rongweil@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH 1/2] doc: fix mlx5 VXLAN matching limitations
> 
> P bit of VXLAN-GPE and G bit of VXLAN-GBP should be set when matching the
> protocols.
> 
> Fixes: 49765b78c81b ("net/mlx5/hws: match all VXLAN fields")
> Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski

[PATCH 2/2] app/testpmd: use flags from user if it is set

[Minggang Li(Gavin)]

It's user's responsibility to set correct flags, especially the G bit, to
distinguish the protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.

It will be set to 0x8 if user does not specify the flags.

Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field")
Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index e1720e54d7..3947304b63 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -13598,7 +13598,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN:
 		vxlan = (struct rte_vxlan_hdr *)buf;
-		vxlan->vx_flags = 0x08;
+		if (!vxlan->flags)
+			vxlan->flags = 0x08;
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN_GPE:
 		gpe = (struct rte_vxlan_gpe_hdr *)buf;
-- 
2.34.1

RE: [PATCH 2/2] app/testpmd: use flags from user if it is set

[Dariusz Sosnowski]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]



> -----Original Message-----
> From: Minggang Li(Gavin) <gavinl@nvidia.com>
> Sent: Tuesday, February 18, 2025 11:33
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon (EXTERNAL) <thomas@monjalon.net>; Aman Singh
> <aman.deep.singh@intel.com>; Minggang(Gavin) Li <gavinl@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH 2/2] app/testpmd: use flags from user if it is set
> 
> External email: Use caution opening links or attachments
> 
> 
> It's user's responsibility to set correct flags, especially the G bit, to distinguish the
> protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.
> 
> It will be set to 0x8 if user does not specify the flags.
> 
> Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field")
> Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 17370 bytes --]

Re: [PATCH 0/2] use flags from user if it is set

[Stephen Hemminger]

On Tue, 18 Feb 2025 12:33:20 +0200
"Minggang Li(Gavin)" <gavinl@nvidia.com> wrote:

> This patch series also fixed mlx5 release notes on VXLAN limitations.
> 
> Minggang Li (Gavin) (2):
>   doc: fix mlx5 VXLAN matching limitations
>   app/testpmd: use flags from user if it is set
> 
>  app/test-pmd/cmdline_flow.c | 3 ++-
>  doc/guides/nics/mlx5.rst    | 4 ++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 


Applied to next-net.
Checkpatches gives warnings because the entry in mailmap has a space before the
parenthesis part and the Signed-off-by does not. I resolved it by putting space
in the Signed-off-by but probably want to fix your mail settings to match.

Also added cc to stable on both