RE: [PATCH] doc/guides: Mention needed kernel option for mlx5 multiport e-switch

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

Hi,

Thank you very much for the patch.

Could you please regenerate the patch and resend?
CI job for checking patches fails, because it seems that patch is corrupted: http://mails.dpdk.org/archives/test-report/2025-January/844526.html
It appears that spaces are missing at the beginning of diff lines.
Also name in "From" does not match the "Signed-off-by" tag.

> From: Plague <4plague@gmail.com> 
> Sent: Monday, January 20, 2025 3:15 PM
> To: dev@dpdk.org
> Subject: [PATCH] doc/guides: Mention needed kernel option for mlx5 multiport e-switch
> 
> External email: Use caution opening links or attachments 
> 
> On some kernels (Debian 6.6, 6.9 and 6.10 tested), 
> there is a missing option for "TC recirculation" 
> that prevents MLX5 driver to include CONFIG_MLX5_CLS_ACT 
> in the compilation, thus preventing PF1 
> from properly working in multiport-eswitch mode. 

Could you please add the following line here?

Fixes: 11c73de9ef63 ("net/mlx5: probe multi-port E-Switch device")

This would allow us to pick up this patch for next LTS releases.

> 
> Signed-off-by: Jaromír Smrček <mailto:4plague@gmail.com> 
> --- 
> doc/guides/nics/mlx5.rst | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst 
> index 30c40f767b..5e327be673 100644 
> --- a/doc/guides/nics/mlx5.rst 
> +++ b/doc/guides/nics/mlx5.rst 
> @@ -1713,7 +1713,7 @@ Supported HCAs: 
>  
> Supported mlx5 kernel modules versions: 
>  
> -- Upstream Linux - from version 6.3. 
> +- Upstream Linux - from version 6.3. with CONFIG_NET_TC_SKB_EXT enabled 

Could you also include CONFIG_MLX5_CLS_ACT option in this line?

> - Modules packaged in MLNX_OFED - from version v23.04-0.5.3.3. 
>  
> Configuration 
> --  
> 2.39.2

Best regards,
Dariusz Sosnowski