RE: [PATCH] ethdev: convert string initialization

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Friday, October 4, 2024 09:27
> To: Ferruh Yigit <ferruh.yigit@amd.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>; Ori Kam <orika@nvidia.com>; Aman Singh
> <aman.deep.singh@intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Reshma Pattan <reshma.pattan@intel.com>;
> Stephen Hemminger <stephen@networkplumber.org>; Akhil Goyal
> <gakhil@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Potnuri Bharat
> Teja <bharat@chelsio.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Sachin Saxena <sachin.saxena@nxp.com>; Matan Azrad <matan@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; Chaoyong He <chaoyong.he@corigine.com>
> Cc: dev@dpdk.org; Morten Brørup <mb@smartsharesystems.com>; Bruce
> Richardson <bruce.richardson@intel.com>
> Subject: Re: [PATCH] ethdev: convert string initialization
> 
> External email: Use caution opening links or attachments
> 
> 
> On 10/4/24 07:13, Ferruh Yigit wrote:
> > gcc 15 experimental [1], with -Wextra flag, gives warning in variable
> > initialization as string [2].
> >
> > The warning has a point when initialized variable is intended to use
> > as string, since assignment is missing the required null terminator
> > for this case. But warning is useless for our usecase.
> >
> > In this patch only updated a few instance to show the issue, there are
> > many instances to fix, if we prefer to go this way.
> > Other option is to disable warning but it can be useful for actual
> > string usecases, so I prefer to keep it.
> >
> > Converted string initialization to array initialization.
> >
> > [1]
> > gcc (GCC) 15.0.0 20241003 (experimental)
> >
> > [2]
> > ../lib/ethdev/rte_flow.h:906:36:
> >    error: initializer-string for array of ‘unsigned char’ is too long
> >          [-Werror=unterminated-string-initialization]
> > 906 |         .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
> >      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ../lib/ethdev/rte_flow.h:907:36:
> >    error: initializer-string for array of ‘unsigned char’ is too long
> >           [-Werror=unterminated-string-initialization]
> > 907 |         .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
> >      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ../lib/ethdev/rte_flow.h:1009:25:
> >    error: initializer-string for array of ‘unsigned char’ is too long
> >           [-Werror=unterminated-string-initialization]
> > 1009 |                         "\xff\xff\xff\xff\xff\xff\xff\xff"
> >       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ../lib/ethdev/rte_flow.h:1012:25:
> >    error: initializer-string for array of ‘unsigned char’ is too long
> >           [-Werror=unterminated-string-initialization]
> > 1012 |                         "\xff\xff\xff\xff\xff\xff\xff\xff"
> >       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ../lib/ethdev/rte_flow.h:1135:20:
> >    error: initializer-string for array of ‘unsigned char’ is too long
> >           [-Werror=unterminated-string-initialization]
> > 1135 |         .hdr.vni = "\xff\xff\xff",
> >       |                    ^~~~~~~~~~~~~~
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski