From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A02B445A2A; Wed, 25 Sep 2024 17:00:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BEA74025D; Wed, 25 Sep 2024 17:00:19 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060.outbound.protection.outlook.com [40.107.220.60]) by mails.dpdk.org (Postfix) with ESMTP id 3388D400EF for ; Wed, 25 Sep 2024 17:00:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dNfpo/T31q4L3B6/VLUKZ+kb4NAoNdsexYtQHjqRhz3xe80PXJXMKItQfjuL7IrcubYDWWhsCC7w0VbGSQmm1HjBb3Ytuu9W7ZVSImQPFijzB6fvP7MhsSIuT+f92Aen/GtXIKV2lplJQOa9Gz/o1YQ87e9WrXQWKxrwbTBS9l2vgCtMqZH9DdEk7YMe2ul3YOpukZZIjFkItNFUa4bKN0BDt/HAo/8mJMNntICXbIna0pI4OuJwnpecA8C/JR+R/Z8qPSpId3tomjDgYplvOEmi17Stf6yjMl2ptTKSOcW2eKsZfpDf+IAYcr4ViY6g7p60K831Np+c5K77bXlSvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Am9B/1+aZQfylX4t8XGtHtISBDJIU9KFhkIcQYk7Uo=; b=IFM04PNmqPM90fdLPdW6nv+N4zvRbzm4AShBqiWY5DIsIM3Tyh2RGZuc9+SLIJJXMJjqHbkOrc33VRRiF/W2MdXNzTf1utOwLvcgult+sCwdb6zCzIU/iXaFOVrooJSxJPdb8Dg7xWjHAPzS411BMKzvC8remprpQa+I7HXS1nmCSht4dA5N4n3yIPCyyUiBiE/bcNhazGybBqWu/Cdmevl7axoBdrsjP/IDOwAb4xNAzlvTnLZbfAP8Z6zsppq3yo/MuXqY1rJD425qlQbcPgrCDNrFziLYyW3SJ4WJwQyTq7Lyksn78ZVZe7bGUS2yZmDh0dwozC7iMSTsd3CqBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Am9B/1+aZQfylX4t8XGtHtISBDJIU9KFhkIcQYk7Uo=; b=V9es7aOu5oxe65tXSmMVoni//ZRFSLU/wUt21dAud/7ZwB91Dn2Zfra8rbc8u27LdzZoqJ6m+H/oq70ZnEr/zJPWB6eKJvMBnigRiQJUgiF+UEK4AGF9APlJjyn4WOyl6i9mxD61OY/0TUxWiOdNpwxxDN4LyxgVvvOCYXv+3ujJ9jukfGI3rfTZQq2dh7vRH+GzovmtznBP68NY/OceYMkZVP7j/rRqBy2Rsjm8dbeQBd5cGnDfsPqK0zcRmSVRAgvXp40suW9RmrhrCp3om1Dx7GSNXOpyfvXtDnP4WqwuHd+MvwyRFhsLj8eC/rMUD+om11AKE2uoHaTOXDdYXA== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by PH7PR12MB6717.namprd12.prod.outlook.com (2603:10b6:510:1b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.26; Wed, 25 Sep 2024 15:00:13 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%4]) with mapi id 15.20.7982.022; Wed, 25 Sep 2024 15:00:13 +0000 From: Dariusz Sosnowski To: Alexander Kozyrev , "dev@dpdk.org" CC: Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Matan Azrad , "ferruh.yigit@amd.com" , "stephen@networkplumber.org" Subject: RE: [PATCH 3/6] ethdev: add flow rule insertion by index with pattern Thread-Topic: [PATCH 3/6] ethdev: add flow rule insertion by index with pattern Thread-Index: AQHbCi21Mov6qeUXGUiaffKKCkDy9LJoncnQ Date: Wed, 25 Sep 2024 15:00:13 +0000 Message-ID: References: <20240919004813.3158356-1-akozyrev@nvidia.com> <20240919004813.3158356-4-akozyrev@nvidia.com> In-Reply-To: <20240919004813.3158356-4-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|PH7PR12MB6717:EE_ x-ms-office365-filtering-correlation-id: bc54f2f5-ea95-499a-aaf0-08dcdd72c1fe x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?SURzUFIKcQ7uX/zmSlm9xFTmF4XkOOQi0MR4bjMtTaxU4OCYLkMhKRGuc+YV?= =?us-ascii?Q?uNzImu6o2QbeqCDDH0g/z52U9gE1bU9DD5i+Da/PaBgBUIoqXi+rqYWYrGZg?= =?us-ascii?Q?W9gb/ygaheM1u6lK2d1KBdNwJxsyUtmvX9Q0/ymk/fbOn0g+dCWHR4AP50Im?= =?us-ascii?Q?oc/qElCmKcNEsn6k6O1+Jwoau2dIgE5DBnyNO2qUawTX1LkHgoT5KaOKKb7+?= =?us-ascii?Q?qbIv3+fDtAqzF8GIYRoLCYYIZkST55AaMJ9V6PhpUmiUuQpcTAAQYHblxlvw?= =?us-ascii?Q?e48g00LoM7t1k7GslWGQ6pt3t7hJtNxPn/7BozMJalvgtygvymrfdtMSbDZ0?= =?us-ascii?Q?VJ+8TVlvMCZ9jpCWZ7mmx+/4Sul0cM64p/AkGKp6yifgPSU1fWXIfzRiiz5T?= =?us-ascii?Q?A1wq8tiqH2b0gsFFLV++6d+qfD/uEiHyBm+h0QeFrIvPf5lXotZCk7v7+bFB?= =?us-ascii?Q?1BmDgriKqrQhrogxr8AQ9anmcT5dCdRZLbOfvWvY+DjQvslw1OoKBE45OTn1?= =?us-ascii?Q?25+iv5L8SDeycu7V5srYHsO9WK9xsMA2RMWwZdTI5FxqGDKT4FRmCYBhafqy?= =?us-ascii?Q?4UB1SGjimNRv+9QK75BKtjNhik8jy//s3W0aSwKqz51EzfNmqgVIkIVJavvF?= =?us-ascii?Q?bhlqEciObLy+qIKpauV93C8KLfNNwz22vIYiZ1BstxHx4226IFFTZPkPVM++?= =?us-ascii?Q?/80h2wFaDwCQpFVycpBzVCeEdmKUmigxdq3iqE+Bt44/n3XUtensTzenyIOb?= =?us-ascii?Q?99UP5Udlev2/D0nb8qYTCypyhSDhC+6ZfkzHr+wB1jHIOtVK6+5ofGSYSDEf?= =?us-ascii?Q?q3IhhWRNKRXWNbEFNZSAnDWTB5j35xag7Kzm74nue7FdJvU1zsSs/M1xGmhd?= =?us-ascii?Q?tNNsrbU/+BN10UEx2jYDF2tEdzdxRuuwIo/jdwBmwufyjr4lJ6HgN2H0B656?= =?us-ascii?Q?lEpcAxvwH7byW47bxgvz8uGN56f5PKV00aoHoY/l9SNncOD4tRic+dpw8un6?= =?us-ascii?Q?kDV+keKo5o2LZoutFSAC5jK2SutmYiwOIc3Qjdicr+6FTSyFN7Cj2yTYWQhc?= =?us-ascii?Q?GL9Bx7LyUG1J08xB1C4uP/LxTg9rwlspHiv5nbrLiniuO8KCk3hVJQnxCcmY?= =?us-ascii?Q?hzuUhTSlOL31b9LK8xa8JnPG/Z2ra8C08pjcKJ0hm3yigMn3M/gWE3RBROq+?= =?us-ascii?Q?Asq32C61h5f3hP07ZhjypYiyjt7wDUVYj4kOWVFUa2ajzi91NoS/v6+E05VD?= =?us-ascii?Q?e/pqd3uo7vj951ff8VNw3qEmOESdX+kAhlQcUdAm8LlT5f6Mj2mjdVVbH5lE?= =?us-ascii?Q?vb75kHWECP2e9ndXQ3Q228LXpbB2YaW03S+uIGCeo//G+f0+pYRqdghwAYye?= =?us-ascii?Q?W4H1KFzx+o8UUnvX8Kwi9Y1Roj+d44WG8IHARe3P6FLj22xwRA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?low5p+4YD+tNmbSUgv6wI931Whn9u4IiEd8VfbGWaUWVio74laHF7jNUgojO?= =?us-ascii?Q?XJ8UlzgSJo2e5rGVMqAQccKWMOlvS+Sjl7ZFyI06oAgvZ9r/aK1IW/vG8kw5?= =?us-ascii?Q?THF3MlAd1mvuMVminm+OEQ1fCUHqffkP81Z1aK9wxXT5CbqSm6hnik+XI1+n?= =?us-ascii?Q?6DUXWcmu6EKmULk83AKbHrrO7/xAcd8Cc8Iv7O1hMcgTQ3nb9LHOZS7Ij82C?= =?us-ascii?Q?sb3OLYDrD7mY1hI6qHmW1BpeVQTJ2A9iXjjVz9U7LrFbmeGOyigC1IjPbz75?= =?us-ascii?Q?JKZVLYhcwVZuj7yppM9wjgiQREbzcgOHHa+V0ilW5vfimBQJ4mQAzBnbBSIB?= =?us-ascii?Q?1faVwhNVDBOnfBvndMMemzANdoXcbgnICiaFuF7zz9oIK5UMqtUKWvJdlhSP?= =?us-ascii?Q?Rmt2qARnZ0LAMxtjnTPBY9P/cOb66Aa39jitWNoXB1p3LSc5BsHYD5hRFiH3?= =?us-ascii?Q?rndSmbBotx1LXrppmscb/4eTOBO5oRbcyScrDQCfopdxyZeZ/JhFVJ08m/p8?= =?us-ascii?Q?5wrVXJxmSo3FMDwDCZBWwuAQT5VONIoHS0kSIB+elpQSDGOWYZYqvAqv0Fn4?= =?us-ascii?Q?Fam9XrtlQnMytAgN/rRRkdtdF/hUQoB4aVfxw8OCsrauoaJhTm0tW6j3zyNV?= =?us-ascii?Q?f7JUfNCAWrnpq11UpRMqtcv8HuSugaw50MB24ftO87acUBZ6mBU1VmzwQLvk?= =?us-ascii?Q?VuWQ+OjBuNNRTLcWFE8Fslkjrm1gPessgyzHj0OUhJN13ZtLWXHOiRSeffFM?= =?us-ascii?Q?DxKUIqeStMllXIaPVsTS258NL4VzywgNesCPrWdz61SydZzHrdCUH43nJJK/?= =?us-ascii?Q?/iqe282fstxp1ah8jBhebX55WnRhIqwyJz/5b1aKiEgdw0DuhEwZHea3YEUv?= =?us-ascii?Q?zWX4cfivAXq9SsYJ9HXVHBjIdpbJTqZE1arWVH5wVE5vHE5FHkzaOoRkKXl5?= =?us-ascii?Q?oi949cADr5Zvoh1VKh19y3+kVKl15jRibK2AKXUmiwmX3J+RYQvDYIABnHE3?= =?us-ascii?Q?U4Bpxq/T7oqvJ4EPwWbWfuxM9iQmeD7xDzUIeJUPSWFmDYLNe7xeB5VfmC4v?= =?us-ascii?Q?j0TMQXsNfqBQaJdAsM823MvP17YcbSi//b3Q6E5QwrKnqiwmIz0tE5FdCt4D?= =?us-ascii?Q?EQiHaQIrJgjI7FK9Ndu3CSm6SiegcKzoBNAzjSifxtY5JW1Jj9MrmAVJqIGT?= =?us-ascii?Q?V8dsXrW9ZG7MK3DKkjcedbPmpSKpibV8EvkjlnKzX1qi/+8ppSycOXEra7Mu?= =?us-ascii?Q?Aq3ae5UwJOg+dem0TK1/dGwh0Q9P8bOwVZhYFYMmTyoxNIY7ofhWHk+X1Nq/?= =?us-ascii?Q?WXL95DeC/eKiettUt8wowvTIVA3aXQ4r8iUo6vd3L/PRkXcRisNABKAC34Y0?= =?us-ascii?Q?d07aNGcKaJuhRVYUza8/s1GbiXajTEroxrWfdsieQ1k31/8F3Fj0Mxb6EzkO?= =?us-ascii?Q?t06AnkCADpVIxoBbeZwwkGNILge1JPRGRnrl1/g6yqNbtxXoOlKvmSzPyUwo?= =?us-ascii?Q?Z7A+MOsBsTLOlpv9LJvAb3h6McL4jg0zOC208+ONG2q2W2O9aZmMn7LJYpLw?= =?us-ascii?Q?5wtKzojExl9us2AYTmWqjxS3tNifpmS2zwxzFl8/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc54f2f5-ea95-499a-aaf0-08dcdd72c1fe X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2024 15:00:13.0416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fxsCSlmSXkPaQ0lHX8VvuQoztAJjJx5t8+hEc93WPzPAJYXcc3dNthTOrgIVBQPEdW5tRlHFuLuPvbyy/dTpNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6717 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Alexander Kozyrev > Sent: Thursday, September 19, 2024 02:48 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Ori Kam > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Matan Azrad ; > ferruh.yigit@amd.com; stephen@networkplumber.org > Subject: [PATCH 3/6] ethdev: add flow rule insertion by index with patter= n >=20 > Add a new API to enqueue flow rule creation by index with pattern. > The new template table rules insertion type, index-based insertion with > pattern, requires a new flow rule creation function with both rule index = and > pattern provided. > Packets will match on the provided pattern at the provided index. >=20 > Signed-off-by: Alexander Kozyrev [snip] > +RTE_TRACE_POINT_FP( > + rte_flow_trace_async_create_by_index, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > + const struct rte_flow_op_attr *op_attr, > + const struct rte_flow_template_table *template_table, > + uint32_t rule_index, > + const struct rte_flow_action *actions, > + uint8_t actions_template_index, > + const void *user_data, const struct rte_flow *flow), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_ptr(op_attr); > + rte_trace_point_emit_ptr(template_table); > + rte_trace_point_emit_u32(rule_index); > + rte_trace_point_emit_ptr(actions); > + rte_trace_point_emit_u8(actions_template_index); > + rte_trace_point_emit_ptr(user_data); > + rte_trace_point_emit_ptr(flow); > +) This tracepoint is not used anywhere and is not related to the addition of = rte_flow_trace_async_create_by_index_with_pattern. Maybe this tracepoint should be added in a separate commit? > +RTE_TRACE_POINT_FP( > + rte_flow_trace_async_create_by_index_with_pattern, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > + const struct rte_flow_op_attr *op_attr, > + const struct rte_flow_template_table *template_table, > + uint32_t rule_index, > + const struct rte_flow_item *pattern, > + uint8_t pattern_template_index, > + const struct rte_flow_action *actions, > + uint8_t actions_template_index, > + const void *user_data, const struct rte_flow *flow), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_ptr(op_attr); > + rte_trace_point_emit_ptr(template_table); > + rte_trace_point_emit_u32(rule_index); > + rte_trace_point_emit_ptr(pattern); > + rte_trace_point_emit_u8(pattern_template_index); > + rte_trace_point_emit_ptr(actions); > + rte_trace_point_emit_u8(actions_template_index); > + rte_trace_point_emit_ptr(user_data); > + rte_trace_point_emit_ptr(flow); > +) This tracepoint is not used in this commit. Could you please add the usage? Best regards, Dariusz Sosnowski