RE: [PATCH] net/mlx5/hws: change error flow on matcher disconnect

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Sunday, February 9, 2025 2:48 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Maayan Kashani
> <mkashani@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Itamar
> Gozlan <igozlan@nvidia.com>
> Subject: [PATCH] net/mlx5/hws: change error flow on matcher disconnect
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Itamar Gozlan <igozlan@nvidia.com>
> 
> Currently, when a firmware (FW) failure occurs during matcher error flow, the
> system attempts to reconnect the matcher, leading to a segmentation fault. This
> happens because the matcher is freed but remains in the list.
> 
> Example scenario:
> Given matchers M1->M2->M3, if a FW failure occurs:
> 1. System tries to destroy M1 and fails
> 2. M1 remains in the list but is freed
> 3. When destroying M2, it attempts to remove itself and create M1->M3 4. This
> results in a segmentation fault as M1 is already freed
> 
> Signed-off-by: Itamar Gozlan <igozlan@nvidia.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski