From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A1A445C15; Wed, 30 Oct 2024 15:19:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CB24433DA; Wed, 30 Oct 2024 15:19:40 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74]) by mails.dpdk.org (Postfix) with ESMTP id 43DAF402EE for <dev@dpdk.org>; Wed, 30 Oct 2024 15:19:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H5SCbAr5Un4pdk+o3rMp6+AegjP0RP4+qayik8mqIHtd0j9nUsnAr0vmTer67oxXzHe6p6CThU2dBXFbaBfiqHdCAvYTtRs9qY4siWdlF2guR7E4qMKxdwBVnS7Dp6PdrFa0NMEPIpk527icb46+dBBY2Kl6sG+cjG22tsK0gwnNCD64ieAZKPzssoFVADiR+rNbeUSFLBiyu5dxqUxsKwvdRe1Nd9E1rGYqiPOc3fKuwbawlLRhOXMy2pHdMa8QYTxuQ+Y8YQlTIc8MJxm0gjK5xNodg6e6shvqXOVRaQ2KO8jcm4jSUEHv9ef3pJtQEYwtXG+clz5FPIb9tSPYXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u0q2p769DKVuAjAqIHjPUTrXUi0O3OGUTEjDQmvY3uw=; b=okSiYvhQdX/BJfR7rk4FKW+EAN25ypxdadIhMTRXskWHy2j0pSK99wcmyWX+TxgPrliM0G+U5iSHFrAeRCRMdj4z2B1ra3Et4iAtbDZtoJEf/v2+bZO5qaVh0/jJlu4XxEf24KGNql1lzJ4qH8rXEF0OcRX1LRUK5JH/y39IQ99qjH9k27Qx1YdER5a5tfSY19rnXI21Mj0Yl6jSp2ySQr6QddkaWTjgkawIjpRTwOfOMRPxrQiyd6cF9Rg5wlc1XA3lRJyVn8A9pCNmYi6T+pE2CNsHg1eG2+CIJc3f2E9Bubvifgz54gUJkbJ+F6QltXErNtLrQ+SgOmS7/MHAig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0q2p769DKVuAjAqIHjPUTrXUi0O3OGUTEjDQmvY3uw=; b=W22v4LBq/UXjXsLgDYbOHridM52aD3R7JcGRkoFo7QCdfKcsCHhgxWJHrSoB1dWIAtF49Xm6X4cBfDHHLv7neIRZB5mdjP8mcrv6VCRxFStqJPnqv81iwDRd/ABJNXEPsAp0sULjn0u1UqozrXfp+U5twgzmGHSXTkvHbhmS9SRSY1gyXStOQ9cpLiYRSxX5URkvQKZLXRHy/lyXOZ8tKN+rEaktITlbwBcqPep6uWs/J1z0GJUvHWNuCotpcxnwwPhxXLFgO/jSiNE9KppYdr7ZBCefTwTN0I5JNoQBX7Y2oecu1Mf4V/NnAacByYtglOQla7Xdc8x9vo2uwT7jtQ== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by SJ1PR12MB6195.namprd12.prod.outlook.com (2603:10b6:a03:457::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.28; Wed, 30 Oct 2024 14:19:35 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%4]) with mapi id 15.20.8114.015; Wed, 30 Oct 2024 14:19:35 +0000 From: Raslan Darawsheh <rasland@nvidia.com> To: Igor Gutorov <igootorov@gmail.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Thread-Topic: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Thread-Index: AQHa6QqmmIYLdOpAoEOwBl565NMqNLKf21K5 Date: Wed, 30 Oct 2024 14:19:35 +0000 Message-ID: <CH3PR12MB8460C7B420D0DD81063FA990CF542@CH3PR12MB8460.namprd12.prod.outlook.com> References: <IA1PR12MB807824F2008B2D750A4CCCC4DFCB2@IA1PR12MB8078.namprd12.prod.outlook.com> <20240807204406.700332-1-igootorov@gmail.com> In-Reply-To: <20240807204406.700332-1-igootorov@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|SJ1PR12MB6195:EE_ x-ms-office365-filtering-correlation-id: 8e5ee76b-2124-4ac2-809e-08dcf8ede199 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?StQkR7l+xbtLia2fnYA2LonCR+soFIzDG8zCjEezGFXLYV59dbR28NuGsL?= =?iso-8859-1?Q?GtKO6jYBsoQDv6NIQsjOOToQiKEDNDtiQIPoIkdM5BOz0yo+CnG8mVqx2V?= =?iso-8859-1?Q?R6IZZ0GQtn86BUFMmzELlKt46MiMM/ENQ6wQcLlRsSUKAny2ybifb4PV1G?= =?iso-8859-1?Q?uZaRREbG7+MvzYHGfnSR/G8TM8UDRSB+TCKf2259vgASrxOlN+BFsMLwqt?= =?iso-8859-1?Q?CXddW3TdRbxo4IRQFspgs/zQbS2KWxYlHCvrC//jI8na8rqbsVUEpRE4Q5?= =?iso-8859-1?Q?4tV1iJOuPl+0o1vGKTgxJ8zCDUounEYprcTfofqk2ttOAzsoQ8UlevBKX0?= =?iso-8859-1?Q?JcmfedTPeoQI97e4Axejx2j4N66SEuVDw9Yb8J5QwV0jef+r7zqk+A3fWv?= =?iso-8859-1?Q?P/pD/ch7uyrsRolPaVmkh7RszCACdzfhwBvrBmcL/ankxCQURJSigH2pkz?= =?iso-8859-1?Q?qXeLYZjj3zqt/VGnneS9WqCY6MjqsVp83aF6+rj8Mmh9kUkF5ctWCRfe7T?= =?iso-8859-1?Q?XCVsj5rSRZMQ5uSf4z4CIGnY6dTXJBwm18/cctVJ583BFEVoHhu2v7lRbM?= =?iso-8859-1?Q?hZ3GSalBhlohMnVQ8vllKcjp4DiOjLe2P8QuboHVA9jn3nMus2iuERWO1/?= =?iso-8859-1?Q?PBEFQ42v55hp5XkGl4V5cumUqdW4eXBv1IpmJI5CxvKypdIOBgpi6IJANk?= =?iso-8859-1?Q?MJpvFb7Ri1AoaIsZRFZEYmIxfBFabgVWl/3zxuyWCA5ipnZG52AJzk7PAW?= =?iso-8859-1?Q?7Ss5CUJKqTFS3NcNsbzF1DaSAQ5ZEfSdd/YxpHmXWQIMjLEl+ChcupGKxb?= =?iso-8859-1?Q?kdv8+NfvdnRXqbfzWAhA/f3AgkRm4o9HNzsZi9CrDCDdQMn1L28ZMUo5eR?= =?iso-8859-1?Q?hUW0bBfUChsiu22O63wzTWFPmVAsiq+7SIkRj7g0DIy0TWE1kRb7xrdvkb?= =?iso-8859-1?Q?hx6HKobAYaJ1ICV5yK+2z9hwopwYQAapOBJGpCxOh6eem3mRPojGnQAKRK?= =?iso-8859-1?Q?IjahqVvf8R8hXotr15onZAgeciJmEXoS/G2zpfOX/nMvh8IE1ZrdFM01Rf?= =?iso-8859-1?Q?tVvZM5HAYz/zqasPGOSVXflMvT2gruG61964+6vi8d3dBbfdgdLVVxpg2Z?= =?iso-8859-1?Q?tLxpWV50UNsmlp4A6tUTqjfhOA0xEa4C/bul8bl45MKCC8DNsbIA4qwGLt?= =?iso-8859-1?Q?w8N+4jU/hIoSqlK7oOwzXbPwiHa9IVOts17m27qnr90t/ZkIBwkzNlfBtg?= =?iso-8859-1?Q?98+0gEUp23mCSuOhtSWhre4eHINKx4RjJLkEtVaqy3LHVdJ+udaouVhtA2?= =?iso-8859-1?Q?tm/BrMCJ3DlxLIX/n3eJFo/A9j55dQKRsiQHO7AJjUSkmU+mTVj5U8VjjW?= =?iso-8859-1?Q?bkYkw7gVIbQ0TS649rLkG4y7Cpk5YKRaprMLoBdEEuVchvJC/Gehdr5WA8?= =?iso-8859-1?Q?MJYvKS3pqpq/4Nfs?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?NzIFOYCYIXIepTePpDKspTyZYoDoG4aPo7XmiFYqoyPR3BT5FhbYNmmKzx?= =?iso-8859-1?Q?SlkJULvRgSKrCnsIEu1EXUA47omJF/TJOPUv9kRvQiPHmcw0ys4bpc/ED0?= =?iso-8859-1?Q?wkyf4gK9XvckXu4gBwHwywfio/68vE0PTI0t/eSuP4d2lf0/L/1qxZHyox?= =?iso-8859-1?Q?+LQejEEba22cxNjQO+sycyaFqvgoaZH6CSb+I2dCem4LMbO8C7gVw3zFdd?= =?iso-8859-1?Q?73aVHzaua3ByOrpWgXZsy5vuB6oH8x1CJ8skg2CVwUMCaansVy5tKpeiGD?= =?iso-8859-1?Q?ICwTfCyc24rp3Mi4HuYzfI7IPwQq2+4l3wyz778hKgM3N2eH/ogTvsSS7f?= =?iso-8859-1?Q?DhJlhBw5sYrph6+Fp9WvbgSiM39wWJ6qD6IN4YSyn2j0qUVXYaIX/8rKzF?= =?iso-8859-1?Q?aXp8g1iTO9/zU51hHznhdHg48qgwxKd+eu7Ij1iP+5rphV2fKpHqX2QlzP?= =?iso-8859-1?Q?KBEG0ONlm6UdpBwGwyq3TEGTg8mYtfrqXVQ73VziAu13TXyG5UnqFGD2b4?= =?iso-8859-1?Q?/G0RJOMQYUgyQTcFQzpbOqYr6ZjutQN3hungCaJj9WQf8JS/mtmkQcryvc?= =?iso-8859-1?Q?6AdiAwhuFI8NQs2TPd4WOnt0gNsEmAGfaVX5RyH/74Mg6JFBRv44COpuWp?= =?iso-8859-1?Q?RL2F0SlsXmo3390YIOqkPbx5HgxO1MwGzwZ6rGDNq36h1lWBpl3lsW5R/Y?= =?iso-8859-1?Q?reUtdnR7fSh8LjuQ5o2Bmai/3xmqH9qjcf12M+fdzp/0nmanPZM6FuVUXY?= =?iso-8859-1?Q?bwN0fKryO6FzaS9+p8Sgm6iIVUD06lnp1Zohfrn2GYr06ljlyKGeTL0ivZ?= =?iso-8859-1?Q?uQMlt7veqEP4gz3Up60bcn+qNajP45LWuz88usHZ39HkqAsgOTIpjTEYRA?= =?iso-8859-1?Q?E6LAeAzczj96QeGM6RxZ4sj6FQKrqF83d7INZA2cfGMzgw3rkhcUD2c8Zi?= =?iso-8859-1?Q?8YydcBrb1pJCkuAAszxASBYTbq3yQAOkxfhuvSemkdFENYsCSdkrNp9t5T?= =?iso-8859-1?Q?8FnWQpm+o5MUlWVvWj2JHd8BcTmbU5h82lasOPZACGB7gkk4xmwjUgq3Vl?= =?iso-8859-1?Q?c2Rf3fQqnm8EDXEZasSc4Qgh4InVxgD4wreGemdG/7SKTZ4whasQ1VJCfD?= =?iso-8859-1?Q?0FgXF+NGZtIcglYUhrQSdNKDw3YptLE/V/4Yj69irDgnxNjPO0hz9pOA3i?= =?iso-8859-1?Q?b399dJ/ajDDNTla6KScYjuWTwU+pcwO6Zpx1qisQZi2jAKuZTa8+G3P/fp?= =?iso-8859-1?Q?T2eahMl3GnPZ73oAufMXfPNur2K3mNjvQkcwCLTTWA0CJlKxGYBxD8eKEg?= =?iso-8859-1?Q?eMALE9qE8DI0yYC5YUk5h/5x9LWZ01Ftprnbz4D7ZZtXVqQCKwVx6r0Ib/?= =?iso-8859-1?Q?tjIsCL6JLfKCZSQbrPWJbgo830d06NUwZWVBLcUKdNJrFKLB+1+/TWo0kI?= =?iso-8859-1?Q?eApNFlE32aygxyg/Zdr86adY/JeQ+wWMXh8HYuLb1ER8DAoyp/TL7+d724?= =?iso-8859-1?Q?ItdxsSm14coU1YEcO4OuXZXOQXLAC5PbfHb92Ln++Wp9r9zww1WQAVNf4c?= =?iso-8859-1?Q?H7nDQ/V3Fpp0McEIpi0oUgXv+1DLB5Z9fCjEnt3uIjZ1QXnQTmmDL/wq05?= =?iso-8859-1?Q?arjLIHtV0qOWk=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5ee76b-2124-4ac2-809e-08dcf8ede199 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2024 14:19:35.5465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c9ys9wokxFKsqqGGjskzsl0WWqv+mwkXUSt756kh2qJyAuRQiFuJYwD0jj2wtunjLunV5laiv7C/6jbdVewUWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6195 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi,=0A= =0A= From: Igor Gutorov <igootorov@gmail.com>=0A= Sent: Wednesday, August 7, 2024 11:44 PM=0A= To: dev@dpdk.org=0A= Cc: Igor Gutorov=0A= Subject: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits=0A= =0A= Hi, Slava=0A= =0A= > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t`=0A= > > is sufficient, but I've left it an `int` for consistency with the=0A= > > other `log_max_*` values.=0A= >=0A= > Right, uint8_t looks to be enough. No objection to optimize others to=0A= > uint8_t.=0A= =0A= Changed log_max_wq_sz to uint8_t in the main patch. The others are=0A= changed in a separate patch. Let me know if it'd be preferrable to=0A= squash the patches.=0A= =0A= > >=0A= > > > 4. Please, format your patch according to the "fix" template.=0A= > >=0A= > > I've reworded the commit message a little bit. But I don't see these=0A= > > issues on Bugzilla, I've stumbled upon them independently. If you'd=0A= > > like the bug reports to be created, let me know.=0A= >=0A= > I meant this: https://doc.dpdk.org/guides/contributing/patches.html=0A= > Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc:=0A= > stable@dpdk.org".=0A= =0A= It is a bit difficult for me to reference a commit for the "Fixes",=0A= since it's a bit hard to call this a regression specifically. I set this=0A= tag to the commit that first introduced configuring the device. Is that=0A= appropriate?=0A= =0A= >=0A= > Also, please run checking script: /devtools/check-git-log.sh' -1 to=0A= > verify commit message compliance.=0A= =0A= Thanks! No warnings now, except for "Wrong headline prefix" for the=0A= first patch because it modifies both common/mlx5 and net/mlx5. I can=0A= split the patch into two if needed.=0A= =0A= =0A= v3:=0A= * Added uint8_t optimization=0A= * Fixed commit messages=0A= =0A= v2:=0A= * Patch reworked to query HCA attributes=0A= =0A= Igor Gutorov (2):=0A= net/mlx5: fix reported Rx/Tx desc limits=0A= common/mlx5: reduce HCA attribute type sizes=0A= =0A= drivers/common/mlx5/mlx5_devx_cmds.c | 1 +=0A= drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++----=0A= drivers/net/mlx5/mlx5_ethdev.c | 4 ++++=0A= drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++=0A= drivers/net/mlx5/mlx5_txq.c | 8 ++++++++=0A= 5 files changed, 26 insertions(+), 4 deletions(-)=0A= =0A= --=0A= 2.45.2=0A= =0A= Series applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A= =0A= =0A=